180108 2017-11-28 13:48:13 -0800 CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more efficient 2017-11-29 20:50:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 165909 1 fpizlo fpizlo ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1375511 0 fpizlo 2017-11-28 13:48:13 -0800 Patch forthcoming. 1375514 1 327784 fpizlo 2017-11-28 13:58:47 -0800 Created attachment 327784 the patch 1375521 2 327784 saam 2017-11-28 14:06:08 -0800 Comment on attachment 327784 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=327784&action=review r=me > Source/JavaScriptCore/heap/CodeBlockSet.cpp:31 > +#include "SuperSampler.h" You're not using this AFAICT > Source/JavaScriptCore/heap/CodeBlockSet.cpp:87 > + // FIXME: make CodeBlock::~CodeBlock a lot faster. It seems insane for that to take 1us or more. Indeed. That's crazy 1376199 3 fpizlo 2017-11-29 20:49:13 -0800 Landed in https://trac.webkit.org/changeset/225315/webkit 1376200 4 webkit-bug-importer 2017-11-29 20:50:35 -0800 <rdar://problem/35765296> 327784 2017-11-28 13:58:47 -0800 2017-11-28 14:06:08 -0800 the patch blah.patch text/plain 3122 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI1MjM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE3LTExLTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q29kZUJsb2NrU2V0OjpkZWxldGVVbm1hcmtlZEFuZFVucmVmZXJlbmNlZCBjYW4gYmUgYSBsaXR0 bGUgbW9yZSBlZmZpY2llbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4MDEwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor ICAgICAgICAKKyAgICAgICAgVGhpcyB3YXMgY3JlYXRpbmcgYSB2ZWN0b3Igb2YgdGhpbmdzIHRv IHJlbW92ZSBhbmQgdGhlbiByZW1vdmluZyB0aGVtLiBJIHRoaW5rIEkgcmVtZW1iZXIgd3JpdGlu ZworICAgICAgICB0aGlzIGNvZGUsIGFuZCBJIGRpZCB0aGF0IGJlY2F1c2UgYXQgdGhlIHRpbWUg d2UgZGlkIG5vdCBoYXZlIHJlbW92ZUFsbE1hdGNoaW5nLCB3aGljaCBpcworICAgICAgICBkZWZp bml0ZWx5IGJldHRlci4gVGhpcyBpcyBhIG1pbnVzY3VsZSBvcHRpbWl6YXRpb24gZm9yIFNwZWVk b21ldGVyLiBJIHdhbnRlZCB0byBsYW5kIHRoaXMKKyAgICAgICAgb2J2aW91cyBpbXByb3ZlbWVu dCBiZWZvcmUgSSBkaWQgbW9yZSBmdW5kYW1lbnRhbCB0aGluZ3MgdG8gdGhpcyBjb2RlLgorCisg ICAgICAgICogaGVhcC9Db2RlQmxvY2tTZXQuY3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2tT ZXQ6OmRlbGV0ZVVubWFya2VkQW5kVW5yZWZlcmVuY2VkKToKKwogMjAxNy0xMS0xNCAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgTW92ZSBKU09O VmFsdWVzIHRvIFdURiBhbmQgY29udmVydCB1c2VzIG9mIEluc3BlY3RvclZhbHVlcy5oIHRvIEpT T05WYWx1ZXMuaApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29kZUJsb2NrU2V0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db2RlQmxvY2tT ZXQuY3BwCShyZXZpc2lvbiAyMjUxNzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9D b2RlQmxvY2tTZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpbmNs dWRlICJDb2RlQmxvY2suaCIKICNpbmNsdWRlICJKU0NJbmxpbmVzLmgiCisjaW5jbHVkZSAiU3Vw ZXJTYW1wbGVyLmgiCiAjaW5jbHVkZSA8d3RmL0NvbW1hUHJpbnRlci5oPgogCiBuYW1lc3BhY2Ug SlNDIHsKQEAgLTc0LDE5ICs3NSwyNiBAQCB2b2lkIENvZGVCbG9ja1NldDo6bGFzdENoYW5jZVRv RmluYWxpemUoCiB2b2lkIENvZGVCbG9ja1NldDo6ZGVsZXRlVW5tYXJrZWRBbmRVbnJlZmVyZW5j ZWQoVk0mIHZtLCBDb2xsZWN0aW9uU2NvcGUgc2NvcGUpCiB7CiAgICAgTG9ja0hvbGRlciBsb2Nr ZXIoJm1fbG9jayk7Ci0gICAgVmVjdG9yPENvZGVCbG9jayo+IHVubWFya2VkOworICAgIAorICAg IC8vIERlc3Ryb3lpbmcgYSBDb2RlQmxvY2sgdGFrZXMgYWJvdXQgMXVzIG9uIGF2ZXJhZ2UgaW4g U3BlZWRvbWV0ZXIuIEZ1bGwgY29sbGVjdGlvbnMgaW4gU3BlZWRvbWV0ZXIKKyAgICAvLyB1c3Vh bGx5IGhhdmUgfjIwMDAgQ29kZUJsb2NrcyB0byBwcm9jZXNzLiBUaGUgdGltZSBpdCB0YWtlcyB0 byBwcm9jZXNzIHRoZSB3aG9sZSBsaXN0IHZhcmllcyBhCisgICAgLy8gbG90LiBJbiBvbmUgZXh0 cmVtZSBjYXNlIEkgc2F3IDE4bXMgKG9uIG15IGZhc3QgTUJQKS4KKyAgICAvLworICAgIC8vIEZJ WE1FOiB1c2UgU3Vic3BhY2UgaW5zdGVhZCBvZiBIYXNoU2V0IGFuZCBhZG9wdCBTdWJzcGFjZS1i YXNlZCBjb25zdHJhaW50IHNvbHZpbmcuIFRoaXMgbWF5CisgICAgLy8gcmVtb3ZlIHRoZSBuZWVk IHRvIGVhZ2VybHkgZGVzdHJ1Y3QgQ29kZUJsb2Nrcy4KKyAgICAvLyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMDg5CisgICAgLy8KKyAgICAvLyBGSVhNRTogbWFr ZSBDb2RlQmxvY2s6On5Db2RlQmxvY2sgYSBsb3QgZmFzdGVyLiBJdCBzZWVtcyBpbnNhbmUgZm9y IHRoYXQgdG8gdGFrZSAxdXMgb3IgbW9yZS4KKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMTA5CiAgICAgCiAgICAgYXV0byBjb25zaWRlciA9IFsmXSAo SGFzaFNldDxDb2RlQmxvY2sqPiYgc2V0KSB7Ci0gICAgICAgIGZvciAoQ29kZUJsb2NrKiBjb2Rl QmxvY2sgOiBzZXQpIHsKLSAgICAgICAgICAgIGlmIChIZWFwOjppc01hcmtlZChjb2RlQmxvY2sp KQotICAgICAgICAgICAgICAgIGNvbnRpbnVlOzsKLSAgICAgICAgICAgIHVubWFya2VkLmFwcGVu ZChjb2RlQmxvY2spOwotICAgICAgICB9Ci0gICAgICAgIGZvciAoQ29kZUJsb2NrKiBjb2RlQmxv Y2sgOiB1bm1hcmtlZCkgewotICAgICAgICAgICAgY29kZUJsb2NrLT5zdHJ1Y3R1cmUodm0pLT5j bGFzc0luZm8oKS0+bWV0aG9kVGFibGUuZGVzdHJveShjb2RlQmxvY2spOwotICAgICAgICAgICAg c2V0LnJlbW92ZShjb2RlQmxvY2spOwotICAgICAgICB9Ci0gICAgICAgIHVubWFya2VkLnNocmlu aygwKTsKKyAgICAgICAgc2V0LnJlbW92ZUlmKAorICAgICAgICAgICAgWyZdIChDb2RlQmxvY2sq IGNvZGVCbG9jaykgLT4gYm9vbCB7CisgICAgICAgICAgICAgICAgaWYgKEhlYXA6OmlzTWFya2Vk KGNvZGVCbG9jaykpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAg ICAgICAgICBjb2RlQmxvY2stPnN0cnVjdHVyZSh2bSktPmNsYXNzSW5mbygpLT5tZXRob2RUYWJs ZS5kZXN0cm95KGNvZGVCbG9jayk7CisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAg ICAgICAgICB9KTsKICAgICB9OwogCiAgICAgc3dpdGNoIChzY29wZSkgewo=