180107 2017-11-28 13:47:18 -0800 Clean up spanners before creating nested column context 2017-11-28 20:13:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1375510 0 zalan 2017-11-28 13:47:18 -0800 rdar://problem/35686655 1375524 1 327785 zalan 2017-11-28 14:08:18 -0800 Created attachment 327785 Patch 1375604 2 327785 koivisto 2017-11-28 16:55:01 -0800 Comment on attachment 327785 Patch Can we also delete some existing code dealing with spanner moving with this? 1375666 3 zalan 2017-11-28 19:53:08 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 327785 [details] > Patch > > Can we also delete some existing code dealing with spanner moving with this? Unfortunately RenderTreeUpdater::MultiColumn::destroyFragmentedFlow still relies on that code for cleaning up nested multicols. I am fixing destroyFragmentedFlow now 1375671 4 327785 commit-queue 2017-11-28 20:12:36 -0800 Comment on attachment 327785 Patch Clearing flags on attachment: 327785 Committed r225255: <https://trac.webkit.org/changeset/225255> 1375672 5 commit-queue 2017-11-28 20:12:37 -0800 All reviewed patches have been landed. Closing bug. 1375673 6 webkit-bug-importer 2017-11-28 20:13:20 -0800 <rdar://problem/35740188> 327785 2017-11-28 14:08:18 -0800 2017-11-28 20:12:36 -0800 Patch bug-180107-20171128140818.patch text/plain 7017 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmU3OTMyNmVmYTAxMzBi ZjhkMGY5OGE3OTFkYjMzMTNjYTA3ZjJjNC4uYzAzOTQ0MmE1MDkxZWI2ZDU5MDlhZmNiODE4NzRj ZDU0ZGYwMzk3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE3LTExLTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgc3Bhbm5lcnMg YmVmb3JlIGNyZWF0aW5nIG5lc3RlZCBjb2x1bW4gY29udGV4dAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMTA3CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zNTY4NjY1NT4KKyAgICAgICAgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4gYW4gZXhpc3Rpbmcgc3Bhbm5lciBwbGFjZWhvbGRlciBpcyBt b3ZlZCBpbnRvIGEgbmV3bHkgY29uc3RydWN0ZWQgKGFuZCBuZXN0ZWQpCisgICAgICAgIG11bHRp Y29sdW1uIGNvbnRleHQsIHdlIGZpZ3VyZSBpdCdzIG5vdCB2YWxpZCBhbnltb3JlIGFuZCBlbmQg dXAgZGVzdHJveWluZyBpdAorICAgICAgICAoc2VlIFJlbmRlck11bHRpQ29sdW1uRmxvdzo6ZnJh Z21lbnRlZEZsb3dEZXNjZW5kYW50SW5zZXJ0ZWQpLgorICAgICAgICBUaGlzIGlzIHZlcnkgdW5m b3J0dW5hdGUgc2luY2UgYXMgd2UgY2xpbWIgYmFjayBvbiB0aGUgc3RhY2ssIHdlIGNvdWxkIGhp dCB0aGlzIHJlbmRlcmVyIGFzCisgICAgICAgIHRoZSBuZXdseSBpbnNlcnRlZCBjaGlsZC4gCisK KyAgICAgICAgVGhpcyBwYXRjaCBwcm9hY3RpdmVseSByZW1vdmVzIHRoZSBpbnZhbGlkIHBsYWNl aG9sZGVycyBhbmQgbW92ZXMgdGhlIGFzc29jaWF0ZWQgc3Bhbm5lcnMgYmFjayB0byB0aGVpcgor ICAgICAgICBvcmlnaW5hbCBwb3NpdGlvbi4gCisKKyAgICAgICAgVGVzdDogZmFzdC9tdWx0aWNv bC9jcmFzaC13aGVuLWNvbnN0cnVjdGluZy1uZXN0ZWQtY29sdW1ucy5odG1sCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5GbG93Lmg6CisgICAgICAgICogc3R5bGUvUmVu ZGVyVHJlZVVwZGF0ZXJNdWx0aUNvbHVtbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJU cmVlVXBkYXRlcjo6TXVsdGlDb2x1bW46OmNyZWF0ZUZyYWdtZW50ZWRGbG93KTogCisgICAgICAg IFJlbmRlclRyZWVVcGRhdGVyOjpNdWx0aUNvbHVtbjo6ZGVzdHJveUZyYWdtZW50ZWRGbG93IHN0 aWxsIHJlbGllcyBvbiB0aGUgcGxhY2Vob2xkZXIgcmVtb3ZhbAorICAgICAgICBsb2dpYyBpbiBS ZW5kZXJNdWx0aUNvbHVtbkZsb3c6OmZyYWdtZW50ZWRGbG93RGVzY2VuZGFudEluc2VydGVkLgor CiAyMDE2LTA4LTA1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggc29tZSBtaW5vciBwcm9ibGVtcyBpbiB0aGUgU3RyaW5nSW1wbCBoZWFkZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3cuaCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3cuaAppbmRleCAyMGU4 MWYxOGU0MDVhZTlhMzJmNTM2Njc0N2QyMzJmZWEzMzIyODAzLi4yM2M5NjA5YzVmN2M5MDk5NDc4 NmFhOWJhNTk0OTIxOGM3NDE5N2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTXVsdGlDb2x1bW5GbG93LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck11bHRpQ29sdW1uRmxvdy5oCkBAIC05Niw2ICs5Niw3IEBAIHB1YmxpYzoKICAgICBi b29sIHNob3VsZENoZWNrQ29sdW1uQnJlYWtzKCkgY29uc3Qgb3ZlcnJpZGU7CiAKICAgICB0eXBl ZGVmIEhhc2hNYXA8UmVuZGVyQm94KiwgV2Vha1B0cjxSZW5kZXJNdWx0aUNvbHVtblNwYW5uZXJQ bGFjZWhvbGRlcj4+IFNwYW5uZXJNYXA7CisgICAgU3Bhbm5lck1hcCYgc3Bhbm5lck1hcCgpIHsg cmV0dXJuICptX3NwYW5uZXJNYXA7IH0KICAgICBzdGQ6OnVuaXF1ZV9wdHI8U3Bhbm5lck1hcD4g dGFrZVNwYW5uZXJNYXAoKSB7IHJldHVybiBXVEZNb3ZlKG1fc3Bhbm5lck1hcCk7IH0KIAogcHJp dmF0ZToKQEAgLTExOSw4ICsxMjAsNiBAQCBwcml2YXRlOgogICAgIHZvaWQgaGFuZGxlU3Bhbm5l clJlbW92YWwoUmVuZGVyT2JqZWN0JiBzcGFubmVyKTsKICAgICBSZW5kZXJPYmplY3QqIHByb2Nl c3NQb3NzaWJsZVNwYW5uZXJEZXNjZW5kYW50KFJlbmRlck9iamVjdComIHN1YnRyZWVSb290LCBS ZW5kZXJPYmplY3QmIGRlc2NlbmRhbnQpOwogCi0gICAgU3Bhbm5lck1hcCYgc3Bhbm5lck1hcCgp IHsgcmV0dXJuICptX3NwYW5uZXJNYXA7IH0KLSAgICAKIHByaXZhdGU6CiAgICAgc3RkOjp1bmlx dWVfcHRyPFNwYW5uZXJNYXA+IG1fc3Bhbm5lck1hcDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvc3R5bGUvUmVuZGVyVHJlZVVwZGF0ZXJNdWx0aUNvbHVtbi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9zdHlsZS9SZW5kZXJUcmVlVXBkYXRlck11bHRpQ29sdW1uLmNwcAppbmRleCAxYmU3NjBm OWJlZWFlMzAyZTM4YTI2NTY3MWU2YmE0NDBiNWJjZDA2Li4xYzFmZWI0NmU4ZjFiM2JjOTg2ZjZh ZmM5NTE5ZTdiOTlhYTQxMzIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9SZW5k ZXJUcmVlVXBkYXRlck11bHRpQ29sdW1uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9S ZW5kZXJUcmVlVXBkYXRlck11bHRpQ29sdW1uLmNwcApAQCAtNDksMTAgKzQ5LDM2IEBAIHZvaWQg UmVuZGVyVHJlZVVwZGF0ZXI6Ok11bHRpQ29sdW1uOjp1cGRhdGUoUmVuZGVyQmxvY2tGbG93JiBm bG93KQogCiB2b2lkIFJlbmRlclRyZWVVcGRhdGVyOjpNdWx0aUNvbHVtbjo6Y3JlYXRlRnJhZ21l bnRlZEZsb3coUmVuZGVyQmxvY2tGbG93JiBmbG93KQogewotICAgIGF1dG8gbmV3RnJhZ21lbnRl ZEZsb3cgPSBXZWJDb3JlOjpjcmVhdGVSZW5kZXJlcjxSZW5kZXJNdWx0aUNvbHVtbkZsb3c+KGZs b3cuZG9jdW1lbnQoKSwgUmVuZGVyU3R5bGU6OmNyZWF0ZUFub255bW91c1N0eWxlV2l0aERpc3Bs YXkoZmxvdy5zdHlsZSgpLCBCTE9DSykpOwotICAgIG5ld0ZyYWdtZW50ZWRGbG93LT5pbml0aWFs aXplU3R5bGUoKTsKICAgICBmbG93LnNldENoaWxkcmVuSW5saW5lKGZhbHNlKTsgLy8gRG8gdGhp cyB0byBhdm9pZCB3cmFwcGluZyBpbmxpbmUgY2hpbGRyZW4gdGhhdCBhcmUganVzdCBnb2luZyB0 byBtb3ZlIGludG8gdGhlIGZsb3cgdGhyZWFkLgogICAgIGZsb3cuZGVsZXRlTGluZXMoKTsKKyAg ICAvLyBJZiB0aGlzIHNvb24tdG8tYmUgbXVsdGljb2x1bW4gZmxvdyBpcyBhbHJlYWR5IHBhcnQg b2YgYSBtdWx0aWNvbHVtbiBjb250ZXh0LCB3ZSBuZWVkIHRvIG1vdmUgYmFjayB0aGUgZGVzY2Vu ZGFudCBzcGFubmVycworICAgIC8vIHRvIHRoZWlyIG9yaWdpbmFsIHBvc2l0aW9uIGJlZm9yZSBt b3Zpbmcgc3VidHJlZXMgYXJvdW5kLgorICAgIGF1dG8qIGVuY2xvc2luZ2Zsb3cgPSBmbG93LmVu Y2xvc2luZ0ZyYWdtZW50ZWRGbG93KCk7CisgICAgaWYgKGlzPFJlbmRlck11bHRpQ29sdW1uRmxv dz4oZW5jbG9zaW5nZmxvdykpIHsKKyAgICAgICAgYXV0byYgc3Bhbm5lcnMgPSBkb3duY2FzdDxS ZW5kZXJNdWx0aUNvbHVtbkZsb3c+KGVuY2xvc2luZ2Zsb3cpLT5zcGFubmVyTWFwKCk7CisgICAg ICAgIFZlY3RvcjxSZW5kZXJNdWx0aUNvbHVtblNwYW5uZXJQbGFjZWhvbGRlcio+IHBsYWNlaG9s ZGVyc1RvRGVsZXRlOworICAgICAgICBmb3IgKGF1dG8mIHNwYW5uZXJBbmRQbGFjZWhvbGRlciA6 IHNwYW5uZXJzKSB7CisgICAgICAgICAgICBhdXRvJiBwbGFjZWhvbGRlciA9ICpzcGFubmVyQW5k UGxhY2Vob2xkZXIudmFsdWU7CisgICAgICAgICAgICBpZiAoIXBsYWNlaG9sZGVyLmlzRGVzY2Vu ZGFudE9mKCZmbG93KSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIHBs YWNlaG9sZGVyc1RvRGVsZXRlLmFwcGVuZCgmcGxhY2Vob2xkZXIpOworICAgICAgICB9CisgICAg ICAgIGZvciAoYXV0byogcGxhY2Vob2xkZXIgOiBwbGFjZWhvbGRlcnNUb0RlbGV0ZSkgeworICAg ICAgICAgICAgYXV0byogc3Bhbm5lciA9IHBsYWNlaG9sZGVyLT5zcGFubmVyKCk7CisgICAgICAg ICAgICBpZiAoIXNwYW5uZXIpIHsKKyAgICAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAg IC8vIE1vdmUgdGhlIHNwYW5uZXIgYmFjayB0byBpdHMgb3JpZ2luYWwgcG9zaXRpb24uCisgICAg ICAgICAgICBhdXRvJiBzcGFubmVyT3JpZ2luYWxQYXJlbnQgPSAqcGxhY2Vob2xkZXItPnBhcmVu dCgpOworICAgICAgICAgICAgLy8gRGV0YWNoaW5nIHRoZSBzcGFubmVyIHRha2VzIGNhcmUgb2Yg cmVtb3ZpbmcgdGhlIHBsYWNlaG9sZGVyIChhbmQgbWVyZ2VzIHRoZSBSZW5kZXJNdWx0aUNvbHVt blNldHMpLgorICAgICAgICAgICAgYXV0byBzcGFubmVyVG9SZUluc2VydCA9IHNwYW5uZXItPnBh cmVudCgpLT50YWtlQ2hpbGQoKnNwYW5uZXIpOworICAgICAgICAgICAgc3Bhbm5lck9yaWdpbmFs UGFyZW50LmFkZENoaWxkKFdURk1vdmUoc3Bhbm5lclRvUmVJbnNlcnQpKTsKKyAgICAgICAgfQor ICAgIH0KKworICAgIGF1dG8gbmV3RnJhZ21lbnRlZEZsb3cgPSBXZWJDb3JlOjpjcmVhdGVSZW5k ZXJlcjxSZW5kZXJNdWx0aUNvbHVtbkZsb3c+KGZsb3cuZG9jdW1lbnQoKSwgUmVuZGVyU3R5bGU6 OmNyZWF0ZUFub255bW91c1N0eWxlV2l0aERpc3BsYXkoZmxvdy5zdHlsZSgpLCBCTE9DSykpOwor ICAgIG5ld0ZyYWdtZW50ZWRGbG93LT5pbml0aWFsaXplU3R5bGUoKTsKICAgICBhdXRvJiBmcmFn bWVudGVkRmxvdyA9ICpuZXdGcmFnbWVudGVkRmxvdzsKICAgICBmbG93LlJlbmRlckJsb2NrOjph ZGRDaGlsZChXVEZNb3ZlKG5ld0ZyYWdtZW50ZWRGbG93KSk7CiAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5ZGE0ZmJmMDRl YjQ1MTFjNzUwNWMwOTYyZTNmN2M5Y2MxZTdhMzRjLi5iNTMxNzQ4ZGNkNDQ1ODgwYWExNGE0YzYy Yzg5NDhkNTdhM2Q4MTEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTEtMjggIFphbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBzcGFubmVycyBi ZWZvcmUgY3JlYXRpbmcgbmVzdGVkIGNvbHVtbiBjb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAxMDcKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM1Njg2NjU1PgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L211bHRpY29sL2NyYXNoLXdoZW4tY29uc3RydWN0aW5nLW5l c3RlZC1jb2x1bW5zLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9tdWx0aWNv bC9jcmFzaC13aGVuLWNvbnN0cnVjdGluZy1uZXN0ZWQtY29sdW1ucy5odG1sOiBBZGRlZC4KKwog MjAxNy0xMS0yNCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAg U3R5bGUgcmVzb2x1dGlvbiBzcGluIGR1ZSB0byBjYWxjKCkgdmFsdWVzIGFsd2F5cyBjb21wYXJp bmcgaW5lcXVhbCAoc2VlbiBvbiBhcnN0ZWNobmljYS5jb20pCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L211bHRpY29sL2NyYXNoLXdoZW4tY29uc3RydWN0aW5nLW5lc3RlZC1jb2x1bW5z LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvY3Jhc2gtd2hlbi1jb25z dHJ1Y3RpbmctbmVzdGVkLWNvbHVtbnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjczNDA5YWVh OGRmYWQzOTNlN2UyNzU2NzczM2QyOTU4N2U4MDEyMTgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L211bHRpY29sL2NyYXNoLXdoZW4tY29uc3RydWN0aW5nLW5lc3RlZC1jb2x1 bW5zLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1BBU1MgaWYgbm8gY3Jhc2guCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvY3Jhc2gtd2hlbi1jb25zdHJ1Y3Rp bmctbmVzdGVkLWNvbHVtbnMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvY3Jhc2gt d2hlbi1jb25zdHJ1Y3RpbmctbmVzdGVkLWNvbHVtbnMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45YjNmMTU5 NTM4Mjg3ODUwOTE4MDQ3NWU1NzU1OWQ4MzcwZmM5ZGYyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9jcmFzaC13aGVuLWNvbnN0cnVjdGluZy1uZXN0ZWQtY29s dW1ucy5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9k eT4KK1BBU1MgaWYgbm8gY3Jhc2guCis8ZGl2IHN0eWxlPSJjb2x1bW5zOiAyOyI+PGRpdiBpZD1u ZXN0ZWRDb2x1bW4+PGRpdiBzdHlsZT0iY29sdW1uLXNwYW46YWxsOyI+PC9kaXY+PC9kaXY+PC9k aXY+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7CituZXN0ZWRDb2x1bW4uc3R5bGUu Y29sdW1ucyA9ICIyIjsKKzwvc2NyaXB0PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUK