180079 2017-11-28 06:09:16 -0800 Remove dead debugging code in modern media controls 2017-11-28 07:14:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1375327 0 graouts 2017-11-28 06:09:16 -0800 Remove dead debugging code in modern media controls 1375328 1 327748 graouts 2017-11-28 06:09:51 -0800 Created attachment 327748 Patch 1375339 2 327748 commit-queue 2017-11-28 07:13:27 -0800 Comment on attachment 327748 Patch Clearing flags on attachment: 327748 Committed r225217: <https://trac.webkit.org/changeset/225217> 1375340 3 commit-queue 2017-11-28 07:13:28 -0800 All reviewed patches have been landed. Closing bug. 1375341 4 webkit-bug-importer 2017-11-28 07:14:28 -0800 <rdar://problem/35722161> 327748 2017-11-28 06:09:51 -0800 2017-11-28 07:13:27 -0800 Patch bug-180079-20171128150950.patch text/plain 4191 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQzZDdiNzEzMGRhMWFm M2I5ODc2ODdkYzcyYjU0OGZmNzg3OTI1NS4uN2U0N2VmOTZhMTI0ZGVhNzMxYjdiOTE1MTg4YTdh MTZiODJkZjBhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTExLTI4ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGRlYWQgZGVi dWdnaW5nIGNvZGUgaW4gbW9kZXJuIG1lZGlhIGNvbnRyb2xzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAwNzkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGRlYnVnIHV0aWxpdHkgaXMgbm8gbG9u Z2VyIG5lY2Vzc2FyeSBhbmQgaXMganVzdCBkZWFkIGNvZGUuCisKKyAgICAgICAgKiBNb2R1bGVz L21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9zY2hlZHVsZXIuanM6CisgICAgICAgIChj b25zdC5zY2hlZHVsZXIubmV3LnByb3RvdHlwZS5zY2hlZHVsZUxheW91dCk6CisgICAgICAgIChj b25zdC5zY2hlZHVsZXIubmV3LnByb3RvdHlwZS51bnNjaGVkdWxlTGF5b3V0KToKKyAgICAgICAg KGNvbnN0LnNjaGVkdWxlci5uZXcucHJvdG90eXBlLl9yZXF1ZXN0RnJhbWVJZk5lZWRlZCk6Cisg ICAgICAgIChjb25zdC5zY2hlZHVsZXIubmV3LnByb3RvdHlwZS5fZnJhbWVEaWRGaXJlKToKKyAg ICAgICAgKGNvbnN0LnNjaGVkdWxlci5uZXcucHJvdG90eXBlLl9sYXlvdXQpOgorCiAyMDE3LTEx LTI4ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgUHJlc3Np bmcgdGhlIHNwYWNlIGJhciB3aGlsZSB3YXRjaGluZyBhIGZ1bGxzY3JlZW4gdmlkZW8gZG9lc24n dCBwbGF5IG9yIHBhdXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVy bi1tZWRpYS1jb250cm9scy9jb250cm9scy9zY2hlZHVsZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9zY2hlZHVsZXIuanMKaW5kZXgg Yjg4ZGE4OTc4YWY5M2Q0N2YzZjVlNjQ2MTY1MjRkZmU0ZWJjNzE1MS4uMjVhY2E0NWY3OWQzMTc1 OTZlNTJlYjk5N2JjYjUzMmY0YWJkNTUyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvc2NoZWR1bGVyLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL3NjaGVk dWxlci5qcwpAQCAtNiw3ICs2LDYgQEAgY29uc3Qgc2NoZWR1bGVyID0gbmV3IGNsYXNzCiAgICAg ewogICAgICAgICB0aGlzLl9mcmFtZUlEID0gLTE7CiAgICAgICAgIHRoaXMuX2xheW91dENhbGxi YWNrcyA9IG5ldyBTZXQ7Ci0gICAgICAgIHRoaXMuZGVidWcgPSBuZXcgRnVuY3Rpb247CiAgICAg fQogCiAgICAgLy8gUHVibGljCkBAIC0xOCwyOSArMTcsMTkgQEAgY29uc3Qgc2NoZWR1bGVyID0g bmV3IGNsYXNzCiAKICAgICBzY2hlZHVsZUxheW91dChjYWxsYmFjaykKICAgICB7Ci0gICAgICAg IHRoaXMuZGVidWcoInNjaGVkdWxlTGF5b3V0KCkgLSBzdGFydCIpOwotICAgICAgICBpZiAodHlw ZW9mIGNhbGxiYWNrICE9PSAiZnVuY3Rpb24iKSB7Ci0gICAgICAgICAgICB0aGlzLmRlYnVnKCJz Y2hlZHVsZUxheW91dCgpIC0gZW5kIC0gY2FsbGJhY2sgd2FzIG5vdCBhIGZ1bmN0aW9uIik7Cisg ICAgICAgIGlmICh0eXBlb2YgY2FsbGJhY2sgIT09ICJmdW5jdGlvbiIpCiAgICAgICAgICAgICBy ZXR1cm47Ci0gICAgICAgIH0KIAogICAgICAgICB0aGlzLl9sYXlvdXRDYWxsYmFja3MuYWRkKGNh bGxiYWNrKTsKICAgICAgICAgdGhpcy5fcmVxdWVzdEZyYW1lSWZOZWVkZWQoKTsKLSAgICAgICAg dGhpcy5kZWJ1Zyhgc2NoZWR1bGVMYXlvdXQoKSAtIF9sYXlvdXRDYWxsYmFja3Muc2l6ZSA9ICR7 dGhpcy5fbGF5b3V0Q2FsbGJhY2tzLnNpemV9YCk7Ci0gICAgICAgIHRoaXMuZGVidWcoInNjaGVk dWxlTGF5b3V0KCkgLSBlbmQiKTsKICAgICB9CiAKICAgICB1bnNjaGVkdWxlTGF5b3V0KGNhbGxi YWNrKQogICAgIHsKLSAgICAgICAgdGhpcy5kZWJ1ZygidW5zY2hlZHVsZUxheW91dCgpIC0gc3Rh cnQiKTsKLSAgICAgICAgaWYgKHR5cGVvZiBjYWxsYmFjayAhPT0gImZ1bmN0aW9uIikgewotICAg ICAgICAgICAgdGhpcy5kZWJ1ZygidW5zY2hlZHVsZUxheW91dCgpIC0gZW5kIC0gY2FsbGJhY2sg d2FzIG5vdCBhIGZ1bmN0aW9uIik7CisgICAgICAgIGlmICh0eXBlb2YgY2FsbGJhY2sgIT09ICJm dW5jdGlvbiIpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KIAogICAgICAgICB0aGlz Ll9sYXlvdXRDYWxsYmFja3MuZGVsZXRlKGNhbGxiYWNrKTsKLSAgICAgICAgdGhpcy5kZWJ1Zyhg dW5zY2hlZHVsZUxheW91dCgpIC0gdGhpcy5fbGF5b3V0Q2FsbGJhY2tzLnNpemUgPSAke3RoaXMu X2xheW91dENhbGxiYWNrcy5zaXplfWApOwotICAgICAgICB0aGlzLmRlYnVnKCJ1bnNjaGVkdWxl TGF5b3V0KCkgLSBlbmQiKTsKICAgICB9CiAKICAgICBmbHVzaFNjaGVkdWxlZExheW91dENhbGxi YWNrcygpCkBAIC01MiwxNyArNDEsMTIgQEAgY29uc3Qgc2NoZWR1bGVyID0gbmV3IGNsYXNzCiAK ICAgICBfcmVxdWVzdEZyYW1lSWZOZWVkZWQoKQogICAgIHsKLSAgICAgICAgdGhpcy5kZWJ1Zygi X3JlcXVlc3RGcmFtZUlmTmVlZGVkKCkiKTsKLSAgICAgICAgaWYgKHRoaXMuX2ZyYW1lSUQgPT09 IC0xICYmIHRoaXMuX2xheW91dENhbGxiYWNrcy5zaXplID4gMCkgeworICAgICAgICBpZiAodGhp cy5fZnJhbWVJRCA9PT0gLTEgJiYgdGhpcy5fbGF5b3V0Q2FsbGJhY2tzLnNpemUgPiAwKQogICAg ICAgICAgICAgdGhpcy5fZnJhbWVJRCA9IHdpbmRvdy5yZXF1ZXN0QW5pbWF0aW9uRnJhbWUodGhp cy5fZnJhbWVEaWRGaXJlLmJpbmQodGhpcykpOwotICAgICAgICAgICAgdGhpcy5kZWJ1ZyhgX3Jl cXVlc3RGcmFtZUlmTmVlZGVkKCkgLSByZWdpc3RlcmVkIHJBRiwgX2ZyYW1lSUQgPSAke3RoaXMu X2ZyYW1lSUR9YCk7Ci0gICAgICAgIH0gZWxzZQotICAgICAgICAgICAgdGhpcy5kZWJ1ZyhgX3Jl cXVlc3RGcmFtZUlmTmVlZGVkKCkgLSBmYWlsZWQgdG8gcmVnaXN0ZXIgckFGIGNhbGwsIF9mcmFt ZUlEID0gJHt0aGlzLl9mcmFtZUlEfSwgX2xheW91dENhbGxiYWNrcy5zaXplID0gJHt0aGlzLl9s YXlvdXRDYWxsYmFja3Muc2l6ZX1gKTsKICAgICB9CiAKICAgICBfZnJhbWVEaWRGaXJlKCkKICAg ICB7Ci0gICAgICAgIHRoaXMuZGVidWcoIl9mcmFtZURpZEZpcmUoKSAtIHN0YXJ0Iik7CiAgICAg ICAgIGlmICh0eXBlb2Ygc2NoZWR1bGVyLmZyYW1lV2lsbEZpcmUgPT09ICJmdW5jdGlvbiIpCiAg ICAgICAgICAgICBzY2hlZHVsZXIuZnJhbWVXaWxsRmlyZSgpOwogCkBAIC03MiwyMSArNTYsMTYg QEAgY29uc3Qgc2NoZWR1bGVyID0gbmV3IGNsYXNzCiAKICAgICAgICAgaWYgKHR5cGVvZiBzY2hl ZHVsZXIuZnJhbWVEaWRGaXJlID09PSAiZnVuY3Rpb24iKQogICAgICAgICAgICAgc2NoZWR1bGVy LmZyYW1lRGlkRmlyZSgpOwotICAgICAgICB0aGlzLmRlYnVnKCJfZnJhbWVEaWRGaXJlKCkgLSBl bmQiKTsKICAgICB9CiAKICAgICBfbGF5b3V0KCkKICAgICB7Ci0gICAgICAgIHRoaXMuZGVidWco Il9sYXlvdXQoKSAtIHN0YXJ0Iik7CiAgICAgICAgIC8vIExheW91dHMgYXJlIG5vdCByZS1lbnRy YW50LgogICAgICAgICBjb25zdCBsYXlvdXRDYWxsYmFja3MgPSB0aGlzLl9sYXlvdXRDYWxsYmFj a3M7CiAgICAgICAgIHRoaXMuX2xheW91dENhbGxiYWNrcyA9IG5ldyBTZXQ7CiAKLSAgICAgICAg dGhpcy5kZWJ1ZyhgX2xheW91dCgpIC0gbGF5b3V0Q2FsbGJhY2tzLnNpemUgPSAke2xheW91dENh bGxiYWNrcy5zaXplfWApOwotCiAgICAgICAgIGZvciAobGV0IGNhbGxiYWNrIG9mIGxheW91dENh bGxiYWNrcykKICAgICAgICAgICAgIGNhbGxiYWNrKCk7Ci0gICAgICAgIHRoaXMuZGVidWcoIl9s YXlvdXQoKSAtIGVuZCIpOwogICAgIH0KIAogfTsK