180069 2017-11-28 00:32:12 -0800 REGRESSION (r225199): webkitpy: PlatformInfo raises AssertionError "assert self.os_version is not None" in Cygwin since Bug 179621 2017-11-28 06:45:23 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 179621 1 fujii fujii commit-queue dbates ews-watchlist glenn lforschler pvollan webkit-bug-importer oldest_to_newest 1375273 0 fujii 2017-11-28 00:32:12 -0800 > $ ./Tools/Scripts/check-webkit-style > Traceback (most recent call last): > File "./Tools/Scripts/check-webkit-style", line 44, in <module> > from webkitpy.style.main import CheckWebKitStyle > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/main.py", line 27, in <module> > import webkitpy.style.checker as checker > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checker.py", line 54, in <module> > from checkers.test_expectations import TestExpectationsChecker > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 46, in <module> > class TestExpectationsChecker(object): > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 124, in TestExpectationsChecker > def lint_test_expectations(files, configuration, cwd, increment_error_count=lambda: 0, line_numbers=None, host=Host()): > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/host.py", line 48, in __init__ > SystemHost.__init__(self) > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/systemhost.py", line 40, in __init__ > self.user = user.User() > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/user.py", line 61, in __init__ > self._platforminfo = platforminfo or PlatformInfo(sys, platform, Executive()) > File "/cygdrive/c/webkit/ga/Tools/Scripts/webkitpy/common/system/platforminfo.py", line 74, in __init__ > assert self.os_version is not None > AssertionError > 1375278 1 fujii 2017-11-28 00:36:53 -0800 The output of ver command looks like this: > C:\>ver > > Microsoft Windows [Version 10.0.16299.64] > 1375281 2 327735 fujii 2017-11-28 00:42:37 -0800 Created attachment 327735 Patch 1375331 3 327735 commit-queue 2017-11-28 06:43:34 -0800 Comment on attachment 327735 Patch Clearing flags on attachment: 327735 Committed r225215: <https://trac.webkit.org/changeset/225215> 1375332 4 commit-queue 2017-11-28 06:43:36 -0800 All reviewed patches have been landed. Closing bug. 1375333 5 webkit-bug-importer 2017-11-28 06:45:23 -0800 <rdar://problem/35721810> 327735 2017-11-28 00:42:37 -0800 2017-11-28 06:43:34 -0800 Patch bug-180069-20171128174236.patch text/plain 1775 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MjA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmRkZGJlYjk2OTUzYTNlMWM2OTBhOTNhMTYzYzM1ZDAx NjE0MDdkOS4uNjRmZTg2ZjIwYjRiYTA1MTQxZTRhNmQyNGQyMmE0NGY1ODVlYTRlNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE3LTExLTI4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHdlYmtpdHB5OiBQbGF0Zm9ybUluZm8gcmFpc2VzIEFzc2VydGlvbkVycm9y ICJhc3NlcnQgc2VsZi5vc192ZXJzaW9uIGlzIG5vdCBOb25lIiBpbiBDeWd3aW4gc2luY2UgQnVn IDE3OTYyMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTgwMDY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg IlZlcnNpb24gMTAuMC4xNjI5OSIgd2FzIGludGVycHJldGVkIGFzIDAuMC4xNjI5OS4gRml4IHRo ZSB3cm9uZworICAgICAgICByZWdleHAgZm9yICd2ZXInIGNvbW1hbmQuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5OgorICAgICAgICAo UGxhdGZvcm1JbmZvLl93aW5fdmVyc2lvbl9mcm9tX2NtZCk6IFJlcGxhY2UgXGQgd2l0aCBcZCsu CisKIDIwMTctMTEtMjcgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIERvIG5vdCBydW4gd2Via2l0cHkgdGVzdHMgb24gbXVsdGlwbGUgRVdTZXMKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8u cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5 CmluZGV4IDAxYTdiMzdmMTQxNWRjMDAyYzc1ZTk2YmZiZGFjNGVmYTNjZGEzNTIuLjhkODZhOGFk N2JhZmRlNDE5MDU4ZGFkZjg1M2VmNWE5YmIxY2U5ZGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQpAQCAtMTg0LDYgKzE4 NCw2IEBAIGNsYXNzIFBsYXRmb3JtSW5mbyhvYmplY3QpOgogICAgIGRlZiBfd2luX3ZlcnNpb25f ZnJvbV9jbWQoc2VsZik6CiAgICAgICAgICMgTm90ZSB0aGF0IHRoaXMgc2hvdWxkIG9ubHkgZXZl ciBiZSBjYWxsZWQgb24gd2luZG93cywgc28gdGhpcyBzaG91bGQgYWx3YXlzIHdvcmsuCiAgICAg ICAgIHZlcl9vdXRwdXQgPSBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQoWydjbWQnLCAnL2Mn LCAndmVyJ10sIGRlY29kZV9vdXRwdXQ9RmFsc2UpCi0gICAgICAgIG1hdGNoX29iamVjdCA9IHJl LnNlYXJjaChyJyg/UDxtYWpvcj5cZClcLig/UDxtaW5vcj5cZClcLig/UDxidWlsZD5cZCspJywg dmVyX291dHB1dCkKKyAgICAgICAgbWF0Y2hfb2JqZWN0ID0gcmUuc2VhcmNoKHInKD9QPG1ham9y PlxkKylcLig/UDxtaW5vcj5cZCspXC4oP1A8YnVpbGQ+XGQrKScsIHZlcl9vdXRwdXQpCiAgICAg ICAgIGFzc2VydCBtYXRjaF9vYmplY3QsICdjbWQgcmV0dXJuZWQgYW4gdW5leHBlY3RlZCB2ZXJz aW9uIHN0cmluZzogJyArIHZlcl9vdXRwdXQKICAgICAgICAgcmV0dXJuIG1hdGNoX29iamVjdC5n cm91cHMoKQo=