180059 2017-11-27 15:47:45 -0800 NavigatorBase::serviceWorker() should return a reference instead of a raw pointer 2017-11-27 16:23:25 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue dbates esprehn+autocc ews-watchlist ggaren kangil.han webkit-bug-importer youennf oldest_to_newest 1375187 0 cdumez 2017-11-27 15:47:45 -0800 NavigatorBase::serviceWorker() should return a reference instead of a raw pointer, as it can never return null. 1375188 1 327704 cdumez 2017-11-27 15:48:42 -0800 Created attachment 327704 Patch 1375191 2 327704 ggaren 2017-11-27 15:49:22 -0800 Comment on attachment 327704 Patch r=me 1375206 3 327704 commit-queue 2017-11-27 16:22:17 -0800 Comment on attachment 327704 Patch Clearing flags on attachment: 327704 Committed r225203: <https://trac.webkit.org/changeset/225203> 1375207 4 commit-queue 2017-11-27 16:22:19 -0800 All reviewed patches have been landed. Closing bug. 1375209 5 webkit-bug-importer 2017-11-27 16:23:25 -0800 <rdar://problem/35711144> 327704 2017-11-27 15:48:42 -0800 2017-11-27 16:22:17 -0800 Patch bug-180059-20171127154841.patch text/plain 3490 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzc4ZjRmNzM2N2Y0OTcz ZmY2MmU0NWRkNWQyZjE2MTNlZjEzNTJmOC4uZjcyNDE4NDkxNWU5MGMwOWVkZjEwMTc0ZDRjYjQ3 Njc5ZmYzMWIwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTExLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTmF2aWdhdG9yQmFzZTo6c2Vy dmljZVdvcmtlcigpIHNob3VsZCByZXR1cm4gYSByZWZlcmVuY2UgaW5zdGVhZCBvZiBhIHJhdyBw b2ludGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODAwNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO YXZpZ2F0b3JCYXNlOjpzZXJ2aWNlV29ya2VyKCkgc2hvdWxkIHJldHVybiBhIHJlZmVyZW5jZSBp bnN0ZWFkIG9mIGEgcmF3IHBvaW50ZXIKKyAgICAgICAgYXMgaXQgY2FuIG5ldmVyIHJldHVybiBu dWxsLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNOYXZpZ2F0b3JDdXN0b20uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SlNOYXZpZ2F0b3I6OnZpc2l0QWRkaXRpb25hbENoaWxkcmVuKToKKyAg ICAgICAgKiBkb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpzZXJ2aWNlV29ya2VyQ29udGFpbmVyKToKKyAgICAg ICAgKiBwYWdlL05hdmlnYXRvckJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmF2aWdhdG9y QmFzZTo6c2VydmljZVdvcmtlcik6CisgICAgICAgICogcGFnZS9OYXZpZ2F0b3JCYXNlLmg6CisK IDIwMTctMTEtMjcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBB U1NFUlRJT04gRkFJTEVEOiBhZGRSZXN1bHQuaXNOZXdFbnRyeSBXZWJDb3JlOjpTV1NlcnZlclJl Z2lzdHJhdGlvbjo6YWRkQ2xpZW50VXNpbmdSZWdpc3RyYXRpb24oV2ViQ29yZTo6U2VydmljZVdv cmtlckNsaWVudElkZW50aWZpZXIgY29uc3QmKSArIDE0MQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNOYXZpZ2F0b3JDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNOYXZpZ2F0b3JDdXN0b20uY3BwCmluZGV4IGFkYTNhMzc3NjE1MTFhMDll MDk4ZGJjMDQ3ODlmZTgwNmE1MzM3NTQuLjQ5Y2RhMDY0ZGM2NmYyYmIzODkwMWEyZTNlNmUzMTk1 NzM5YzBmODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTmF2aWdh dG9yQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU05hdmlnYXRv ckN1c3RvbS5jcHAKQEAgLTMxLDcgKzMxLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogdm9pZCBK U05hdmlnYXRvcjo6dmlzaXRBZGRpdGlvbmFsQ2hpbGRyZW4oU2xvdFZpc2l0b3ImIHZpc2l0b3Ip CiB7CiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQotICAgIHZpc2l0b3IuYWRkT3BhcXVlUm9v dCh3cmFwcGVkKCkuc2VydmljZVdvcmtlcigpKTsKKyAgICB2aXNpdG9yLmFkZE9wYXF1ZVJvb3Qo JndyYXBwZWQoKS5zZXJ2aWNlV29ya2VyKCkpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0odmlz aXRvcik7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVj dXRpb25Db250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRFeGVjdXRpb25Db250 ZXh0LmNwcAppbmRleCA0OTU1MjVmNDI3NTczMzFmNjIxMzBhODdkNTk2NjhjNTYxMDBmYmEzLi5i OWVlYzkzOGQ0ZTg5MzM1OWU3Y2YwNTVkYmJlMDQ0MmM2ZTZhYzVlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQuY3BwCkBAIC01NjksNyArNTY5LDcgQEAg U2VydmljZVdvcmtlckNvbnRhaW5lciogU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6c2VydmljZVdv cmtlckNvbnRhaW5lcigpCiAgICAgfSBlbHNlCiAgICAgICAgIG5hdmlnYXRvciA9IGRvd25jYXN0 PFdvcmtlckdsb2JhbFNjb3BlPigqdGhpcykub3B0aW9uYWxOYXZpZ2F0b3IoKTsKIAotICAgIHJl dHVybiBuYXZpZ2F0b3IgPyBuYXZpZ2F0b3ItPnNlcnZpY2VXb3JrZXIoKSA6IG51bGxwdHI7Cisg ICAgcmV0dXJuIG5hdmlnYXRvciA/ICZuYXZpZ2F0b3ItPnNlcnZpY2VXb3JrZXIoKSA6IG51bGxw dHI7CiB9CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0 b3JCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yQmFzZS5jcHAKaW5kZXgg NjZiNmFkMWY0ZDYzNWFlNGU1NDMxNTQ5Mjc5ZmMzZGYyNzUyYTU0Ni4uOTc5ZWVhNWJhMWQ4NmMy YzJkYzI5MTI0ODQ2YTQwMjIyNmZjMzZlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9OYXZpZ2F0b3JCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvckJh c2UuY3BwCkBAIC0xNDksOSArMTQ5LDkgQEAgVmVjdG9yPFN0cmluZz4gTmF2aWdhdG9yQmFzZTo6 bGFuZ3VhZ2VzKCkKIH0KIAogI2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKLVNlcnZpY2VXb3Jr ZXJDb250YWluZXIqIE5hdmlnYXRvckJhc2U6OnNlcnZpY2VXb3JrZXIoKQorU2VydmljZVdvcmtl ckNvbnRhaW5lciYgTmF2aWdhdG9yQmFzZTo6c2VydmljZVdvcmtlcigpCiB7Ci0gICAgcmV0dXJu ICZtX3NlcnZpY2VXb3JrZXJDb250YWluZXI7CisgICAgcmV0dXJuIG1fc2VydmljZVdvcmtlckNv bnRhaW5lcjsKIH0KICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL05h dmlnYXRvckJhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yQmFzZS5oCmluZGV4 IGVjNmNlNjM3OTU3YjE3MzNjYmRkMjJjZDBjNTQ2NzExMDg1N2ViZjAuLjg0YjQ2NGQ2MjgxNWQw ZWFjZWExY2YxMWEyZDIwMDc4ZTY2NzlkZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvTmF2aWdhdG9yQmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yQmFz ZS5oCkBAIC02MCw3ICs2MCw3IEBAIHByb3RlY3RlZDoKIAogI2lmIEVOQUJMRShTRVJWSUNFX1dP UktFUikKIHB1YmxpYzoKLSAgICBTZXJ2aWNlV29ya2VyQ29udGFpbmVyKiBzZXJ2aWNlV29ya2Vy KCk7CisgICAgU2VydmljZVdvcmtlckNvbnRhaW5lciYgc2VydmljZVdvcmtlcigpOwogCiBwcml2 YXRlOgogICAgIFVuaXF1ZVJlZjxTZXJ2aWNlV29ya2VyQ29udGFpbmVyPiBtX3NlcnZpY2VXb3Jr ZXJDb250YWluZXI7Cg==