180032 2017-11-27 05:50:47 -0800 [WPE][GTK] Improve contents of pkg-config .pc files 2017-11-27 06:17:25 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez cgarcia clopez commit-queue lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1374891 0 aperez 2017-11-27 05:50:47 -0800 The .pc files for the WPE and GTK+ ports could use some love: - Missing “URL” fields. - The “Name” field could be nicer, e.g. it reads just “WebKit2” for the GTK+ port, when it probably should be “WebKitGTK+”. 1374892 1 327631 aperez 2017-11-27 05:54:09 -0800 Created attachment 327631 Patch 1374893 2 aperez 2017-11-27 05:56:17 -0800 (In reply to Adrian Perez from comment #0) > The .pc files for the WPE and GTK+ ports could use some love: > > - Missing “URL” fields. > - The “Name” field could be nicer, e.g. it reads just “WebKit2” for > the GTK+ port, when it probably should be “WebKitGTK+”. Also, both WPE and GTK+ ports had the value “WebKit2” in their “Name” fields. It seems better to have different names ;-) 1374896 3 327631 commit-queue 2017-11-27 06:16:56 -0800 Comment on attachment 327631 Patch Clearing flags on attachment: 327631 Committed r225167: <https://trac.webkit.org/changeset/225167> 1374897 4 commit-queue 2017-11-27 06:16:57 -0800 All reviewed patches have been landed. Closing bug. 1374898 5 webkit-bug-importer 2017-11-27 06:17:25 -0800 <rdar://problem/35696892> 327631 2017-11-27 05:54:09 -0800 2017-11-27 06:16:56 -0800 Patch bug-180032-20171127155408.patch text/plain 2843 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU4NzJiMjMxMDllYzdjNWQ3 OTc2MDQ5MDRjYzRlZjQ5ZThjZWYwOGEuLjczMGI4NDNlNTA3M2Y2NjJlNTdjNDI4MWUxOTkwYWM2 NTIwZTRlZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTEtMjcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtd IEltcHJvdmUgY29udGVudHMgb2YgcGtnLWNvbmZpZyAucGMgZmlsZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDAzMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL3dlYmtpdDJndGstd2ViLWV4 dGVuc2lvbi5wYy5pbjogQWRkIFVSTCwgZWRpdCBOYW1lIGFuZCBEZXNjcmlwdGlvbi4KKyAgICAg ICAgKiBndGsvd2Via2l0Mmd0ay5wYy5pbjogQWRkIFVSTCwgZWRpdCBOYW1lLgorICAgICAgICAq IHdwZS93cGUtd2Via2l0LnBjLmluOiBBZGQgVVJMLCBlZGl0IE5hbWUgYW5kIERlc2NyaXB0aW9u LgorCiAyMDE3LTExLTIzICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXggZGljdGlvbmFyeSBsZWFrIGluIGxvb2t1cCwgY29udmVydCBGaW5kT3B0aW9ucyB0byBP cHRpb25TZXQsIHR3ZWFrIGNvZGUgc3R5bGUgbmVhcmJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2d0ay93ZWJraXQyZ3RrLXdlYi1leHRlbnNpb24ucGMuaW4gYi9Tb3VyY2UvV2ViS2l0L2d0 ay93ZWJraXQyZ3RrLXdlYi1leHRlbnNpb24ucGMuaW4KaW5kZXggZWM0MTk5YTI3MDhlMTY4ZDUx OGVhZWU4N2RjOTdmZmQ0NjQ1OTI2Yy4uYWFlZjA3OTg3N2JlMWQyMmE4NWQ4MTkyNThjNjFhMzk3 MTgwMjk4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0Mmd0ay13ZWItZXh0 ZW5zaW9uLnBjLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdDJndGstd2ViLWV4dGVu c2lvbi5wYy5pbgpAQCAtMyw4ICszLDkgQEAgZXhlY19wcmVmaXg9JHtwcmVmaXh9CiBsaWJkaXI9 QExJQl9JTlNUQUxMX0RJUkAKIGluY2x1ZGVkaXI9JHtwcmVmaXh9L2luY2x1ZGUKIAotTmFtZTog V2ViS2l0MldlYkV4dGVuc2lvbgotRGVzY3JpcHRpb246IFdlYktpdCB3ZWIgcHJvY2VzcyBleHRl bnNpb25zCitOYW1lOiBXZWJLaXRHVEsrIFdlYiBwcm9jZXNzIGV4dGVuc2lvbnMKK0Rlc2NyaXB0 aW9uOiBXZWIgY29udGVudCBlbmdpbmUgZm9yIEdUSysgLSBXZWIgcHJvY2VzcyBleHRlbnNpb25z CitVUkw6IGh0dHBzOi8vd2Via2l0Z3RrLm9yZwogVmVyc2lvbjogQFBST0pFQ1RfVkVSU0lPTkAK IFJlcXVpcmVzOiBnbGliLTIuMCBndGsrLTMuMCBsaWJzb3VwLTIuNCBqYXZhc2NyaXB0Y29yZWd0 ay1AV0VCS0lUR1RLX0FQSV9WRVJTSU9OQAogTGliczogLUwke2xpYmRpcn0gLWx3ZWJraXQyZ3Rr LUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05ACmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93 ZWJraXQyZ3RrLnBjLmluIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0Mmd0ay5wYy5pbgppbmRl eCBkMzVkNTlmYzFmNGY5NjMyYjAzOGI0MDkyMTQzNDAwMWY2ZTAzYzRkLi41YTE1YmJmMzZmMmI5 ZmIxMzJjZjY2OTU2NDcyNzNjMTI3OWNiYjc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0 ay93ZWJraXQyZ3RrLnBjLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdDJndGsucGMu aW4KQEAgLTMsOCArMyw5IEBAIGV4ZWNfcHJlZml4PSR7cHJlZml4fQogbGliZGlyPUBMSUJfSU5T VEFMTF9ESVJACiBpbmNsdWRlZGlyPSR7cHJlZml4fS9pbmNsdWRlCiAKLU5hbWU6IFdlYktpdDIK K05hbWU6IFdlYktpdEdUSysKIERlc2NyaXB0aW9uOiBXZWIgY29udGVudCBlbmdpbmUgZm9yIEdU SysKK1VSTDogaHR0cHM6Ly93ZWJraXRndGsub3JnCiBWZXJzaW9uOiBAUFJPSkVDVF9WRVJTSU9O QAogUmVxdWlyZXM6IGdsaWItMi4wIGd0aystMy4wIGxpYnNvdXAtMi40IGphdmFzY3JpcHRjb3Jl Z3RrLUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05ACiBMaWJzOiAtTCR7bGliZGlyfSAtbHdlYmtpdDJn dGstQFdFQktJVEdUS19BUElfVkVSU0lPTkAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvd3Bl L3dwZS13ZWJraXQucGMuaW4gYi9Tb3VyY2UvV2ViS2l0L3dwZS93cGUtd2Via2l0LnBjLmluCmlu ZGV4IDRlZWU3MmVhMGYzY2VhNGExYzdmY2M3OGY0NzUzMWU0YWE4NGFhN2QuLmE1NzY4ZDZhZGU4 ZDU5MjgyYWM2M2U5NzMzMDk3ZWM5ZjBiZmE2YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv d3BlL3dwZS13ZWJraXQucGMuaW4KKysrIGIvU291cmNlL1dlYktpdC93cGUvd3BlLXdlYmtpdC5w Yy5pbgpAQCAtMyw4ICszLDkgQEAgZXhlY19wcmVmaXg9JHtwcmVmaXh9CiBsaWJkaXI9QExJQl9J TlNUQUxMX0RJUkAKIGluY2x1ZGVkaXI9JHtwcmVmaXh9L2luY2x1ZGUKIAotTmFtZTogV2ViS2l0 MgotRGVzY3JpcHRpb246IFdQRS1mbGF2b3JlZCBXZWIgZW5naW5lCitOYW1lOiBXUEUgV2ViS2l0 CitEZXNjcmlwdGlvbjogRW1iZWRkYWJsZSBXZWIgY29udGVudCBlbmdpbmUKK1VSTDogaHR0cHM6 Ly93cGV3ZWJraXQub3JnCiBWZXJzaW9uOiBAUFJPSkVDVF9WRVJTSU9OQAogUmVxdWlyZXM6IGds aWItMi4wIGxpYnNvdXAtMi40CiBMaWJzOiAtTCR7bGliZGlyfSAtbFdQRVdlYktpdAo=