180031 2017-11-27 05:16:58 -0800 REGRESSION(r223073): disk cache directory is no longer copied in ProcessPoolConfiguration::copy() 2017-11-27 08:32:18 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar, Regression P2 Normal --- 1 cgarcia webkit-unassigned achristensen bugs-noreply webkit-bug-importer youennf oldest_to_newest 1374888 0 cgarcia 2017-11-27 05:16:58 -0800 This has caused GTK/WPE test /webkit2/WebKitWebsiteData/configuration to fail, and the wrong directory is used by the network process. I think it was removed by mistake in r223073. TEST: ./Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestWebsiteData... (pid=5917) /webkit2/WebKitWebsiteData/configuration: ** ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:168:void testWebsiteDataConfiguration(WebsiteDataTest*, gconstpointer): assertion failed: (g_file_test(diskCacheDirectory.get(), G_FILE_TEST_IS_DIR)) FAIL 1374889 1 327630 cgarcia 2017-11-27 05:19:10 -0800 Created attachment 327630 Patch 1374935 2 cgarcia 2017-11-27 08:31:07 -0800 Committed r225171: <https://trac.webkit.org/changeset/225171> 1374937 3 webkit-bug-importer 2017-11-27 08:32:18 -0800 <rdar://problem/35698329> 327630 2017-11-27 05:19:10 -0800 2017-11-27 07:42:33 -0800 Patch wk2-disk-cache-dir.diff text/plain 1802 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZTg3MmIyMzEwOWUuLjY1MTc3MTQyMjU3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE3LTExLTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMjMwNzMpOiBkaXNrIGNhY2hlIGRpcmVjdG9y eSBpcyBubyBsb25nZXIgY29waWVkIGluIFByb2Nlc3NQb29sQ29uZmlndXJhdGlvbjo6Y29weSgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAwMzEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhh cyBjYXVzZWQgR1RLL1dQRSB0ZXN0IC93ZWJraXQyL1dlYktpdFdlYnNpdGVEYXRhL2NvbmZpZ3Vy YXRpb24gdG8gZmFpbCwgYW5kIHRoZSB3cm9uZyBkaXJlY3RvcnkgaXMgdXNlZAorICAgICAgICBi eSB0aGUgbmV0d29yayBwcm9jZXNzLiBJIHRoaW5rIGl0IHdhcyByZW1vdmVkIGJ5IG1pc3Rha2Ug aW4gcjIyMzA3My4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQVBJUHJvY2Vzc1Bvb2xDb25m aWd1cmF0aW9uLmNwcDoKKyAgICAgICAgKEFQSTo6UHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uOjpj b3B5KTogQ29weSBtX2Rpc2tDYWNoZURpcmVjdG9yeSB0b28uCisKIDIwMTctMTEtMjMgIERhcmlu IEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBkaWN0aW9uYXJ5IGxlYWsg aW4gbG9va3VwLCBjb252ZXJ0IEZpbmRPcHRpb25zIHRvIE9wdGlvblNldCwgdHdlYWsgY29kZSBz dHlsZSBuZWFyYnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElQ cm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0FQSVByb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5jcHAKaW5kZXggZjlkMDJjOTIyOTUuLmU5Njk0 MDZiN2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJUHJvY2Vz c1Bvb2xDb25maWd1cmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv QVBJUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uLmNwcApAQCAtOTksNiArOTksNyBAQCBSZWY8UHJv Y2Vzc1Bvb2xDb25maWd1cmF0aW9uPiBQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb246OmNvcHkoKQog ICAgIGNvcHktPm1fc2hvdWxkSGF2ZUxlZ2FjeURhdGFTdG9yZSA9IHRoaXMtPm1fc2hvdWxkSGF2 ZUxlZ2FjeURhdGFTdG9yZTsKICAgICBjb3B5LT5tX21heGltdW1Qcm9jZXNzQ291bnQgPSB0aGlz LT5tX21heGltdW1Qcm9jZXNzQ291bnQ7CiAgICAgY29weS0+bV9jYWNoZU1vZGVsID0gdGhpcy0+ bV9jYWNoZU1vZGVsOworICAgIGNvcHktPm1fZGlza0NhY2hlRGlyZWN0b3J5ID0gdGhpcy0+bV9k aXNrQ2FjaGVEaXJlY3Rvcnk7CiAgICAgY29weS0+bV9kaXNrQ2FjaGVTcGVjdWxhdGl2ZVZhbGlk YXRpb25FbmFibGVkID0gdGhpcy0+bV9kaXNrQ2FjaGVTcGVjdWxhdGl2ZVZhbGlkYXRpb25FbmFi bGVkOwogICAgIGNvcHktPm1fZGlza0NhY2hlU2l6ZU92ZXJyaWRlID0gdGhpcy0+bV9kaXNrQ2Fj aGVTaXplT3ZlcnJpZGU7CiAgICAgY29weS0+bV9hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5ID0g dGhpcy0+bV9hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5Owo=