180024 2017-11-26 17:43:48 -0800 WorkQueue::concurrentApply() and ParallelJobs do the same thing 2017-11-27 08:19:48 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 simon.fraser webkit-unassigned sam simon.fraser thorton oldest_to_newest 1374793 0 simon.fraser 2017-11-26 17:43:48 -0800 I don't know why we need both WorkQueue::concurrentApply() and ParallelJobs::execute(), which seems to do the same thing. For Cocoa at least, both do: dispatch_apply(iterations, dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ...) 1374816 1 sam 2017-11-26 19:49:43 -0800 My preference is to remove ParallelJobs and keep WorkQueue::concurrentApply(). 1374928 2 simon.fraser 2017-11-27 08:19:48 -0800 Sam says: > > Source/WebCore/platform/graphics/filters/FEMorphology.cpp:195 > > ParallelJobs<PlatformApplyParameters> parallelJobs(&WebCore::FEMorphology::platformApplyWorker, optimalThreadNumber); > > No strictly related to this patch, but I checked what we were using for > ParallelJobs, saw that ParallelJobsLibdispatch (which I assume we are using) > uses dispatch_apply with a global queue. I believe using DISPATCH_APPLY_AUTO > for the queue will work better. so that's worth testing.