180013 2017-11-25 07:13:34 -0800 WPT tests for MathML lengths fail 2019-03-01 05:52:26 -0800 1 1 1 Unclassified WebKit MathML WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=85730 P2 Normal --- 179110 1 fred.wang webkit-unassigned dbarton ews-watchlist rbuis oldest_to_newest 1374691 0 fred.wang 2017-11-25 07:13:34 -0800 * http://www.w3c-test.org/mathml/relations/css-styling/lengths-1.html * http://www.w3c-test.org/mathml/relations/css-styling/lengths-3.html The "unitless" tests fail because mathsize="5" and mathsize="20.0" is not interpreted as "500%" and "2000%". See https://www.w3.org/TR/MathML/chapter2.html#fund.units * http://www.w3c-test.org/mathml/relations/css-styling/lengths-2.html This test fails because of limitation the mpadded element ( https://bugs.webkit.org/show_bug.cgi?id=85730 ), probably the lack of support for pseudo units and for negative lengths. See https://www.w3.org/TR/MathML/chapter3.html#presm.mpadded 1508922 1 362701 rbuis 2019-02-22 00:16:09 -0800 Created attachment 362701 Patch 1508928 2 362701 fred.wang 2019-02-22 00:46:07 -0800 Comment on attachment 362701 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362701&action=review > Source/WebCore/ChangeLog:3 > + WPT tests for MathML lengths fail This actually fixes the mathsize unitless and tests length-1 and length-3. I guess it could be in a different bug with better title/desc. At least we should have a bug open to track the remaining length-2 failure. (Note: I wonder if the support for (nonzero) unitless values should be removed from MathML) > Source/WebCore/ChangeLog:8 > + Covert unitless lengths to percentage values to correct the computed convert 1508949 3 rbuis 2019-02-22 01:42:01 -0800 (In reply to Frédéric Wang (:fredw) from comment #2) > Comment on attachment 362701 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362701&action=review > > > Source/WebCore/ChangeLog:3 > > + WPT tests for MathML lengths fail > > This actually fixes the mathsize unitless and tests length-1 and length-3. I > guess it could be in a different bug with better title/desc. At least we > should have a bug open to track the remaining length-2 failure. Sure, I opened https://bugs.webkit.org/show_bug.cgi?id=194940 instead and removed the review flag for this one. > (Note: I wonder if the support for (nonzero) unitless values should be > removed from MathML) > > > Source/WebCore/ChangeLog:8 > > + Covert unitless lengths to percentage values to correct the computed > > convert Fixed. 1511387 4 rbuis 2019-03-01 05:52:26 -0800 Not working on this ATM, but only failure left: * http://www.w3c-test.org/mathml/relations/css-styling/lengths-2.html This test fails because of limitation the mpadded element ( https://bugs.webkit.org/show_bug.cgi?id=85730 ), probably the lack of support for pseudo units and for negative lengths. See https://www.w3.org/TR/MathML/chapter3.html#presm.mpadded 362701 2019-02-22 00:16:09 -0800 2019-02-22 01:39:43 -0800 Patch bug-180013-20190222091607.patch text/plain 4026 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZkYTUzZmU4ZTA0YWQ3 OWRkMDZjMTE3YzQxMGEwNDBiMmI5N2U3Ni4uNTcxN2YxYTBiNDM0NDRhNmNhMWIwNDIwMTYzNmQy ODZlYTQzOWMxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAyLTIxICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgV1BUIHRlc3RzIGZvciBNYXRoTUwg bGVuZ3RocyBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODAwMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDb3ZlcnQgdW5pdGxlc3MgbGVuZ3RocyB0byBwZXJjZW50YWdlIHZhbHVlcyB0byBjb3Jy ZWN0IHRoZSBjb21wdXRlZAorICAgICAgICBmb250IHNpemUuCisKKyAgICAgICAgKiBtYXRobWwv TWF0aE1MRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb252ZXJ0VG9QZXJjZW50YWdl SWZOZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6TWF0aE1MRWxlbWVudDo6Y29sbGVjdFN0eWxl Rm9yUHJlc2VudGF0aW9uQXR0cmlidXRlKToKKwogMjAxOS0wMi0xOSAgQ29tbWl0IFF1ZXVlICA8 Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjI0MTcyMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxFbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxFbGVtZW50LmNwcAppbmRleCA1 ZmZhMjNmMjQxZTAwYWQ0MDNmZWM2NzgxZDE3NjM4MTAzNjI4ZDdkLi5kOGNiMWM0ZGFiM2Q1Nzhh Y2RkNTUxNGRjZjQyMDMwMzk4OTJlZGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9tYXRo bWwvTWF0aE1MRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbWF0aG1sL01hdGhNTEVs ZW1lbnQuY3BwCkBAIC05Nyw2ICs5NywxNSBAQCBib29sIE1hdGhNTEVsZW1lbnQ6OmlzUHJlc2Vu dGF0aW9uQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUpIGNvbnN0CiAgICAgcmV0 dXJuIFN0eWxlZEVsZW1lbnQ6OmlzUHJlc2VudGF0aW9uQXR0cmlidXRlKG5hbWUpOwogfQogCitz dGF0aWMgU3RyaW5nIGNvbnZlcnRUb1BlcmNlbnRhZ2VJZk5lZWRlZChjb25zdCBBdG9taWNTdHJp bmcmIHZhbHVlKQoreworICAgIGJvb2wgb2sgPSBmYWxzZTsKKyAgICBmbG9hdCB1bml0bGVzc1Zh bHVlID0gdmFsdWUudG9GbG9hdCgmb2spOworICAgIGlmIChvaykKKyAgICAgICAgcmV0dXJuIFN0 cmluZzo6Zm9ybWF0KCIlLjNmJSUiLCB1bml0bGVzc1ZhbHVlICogMTAwLjApOworICAgIHJldHVy biB2YWx1ZTsKK30KKwogdm9pZCBNYXRoTUxFbGVtZW50Ojpjb2xsZWN0U3R5bGVGb3JQcmVzZW50 YXRpb25BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbWljU3Ry aW5nJiB2YWx1ZSwgTXV0YWJsZVN0eWxlUHJvcGVydGllcyYgc3R5bGUpCiB7CiAgICAgaWYgKG5h bWUgPT0gbWF0aGJhY2tncm91bmRBdHRyKQpAQCAtMTA0LDcgKzExMyw3IEBAIHZvaWQgTWF0aE1M RWxlbWVudDo6Y29sbGVjdFN0eWxlRm9yUHJlc2VudGF0aW9uQXR0cmlidXRlKGNvbnN0IFF1YWxp ZmllZE5hbWUmIG5hCiAgICAgZWxzZSBpZiAobmFtZSA9PSBtYXRoc2l6ZUF0dHIpIHsKICAgICAg ICAgLy8gVGhlIGZvbGxvd2luZyB0aHJlZSB2YWx1ZXMgb2YgbWF0aHNpemUgYXJlIGhhbmRsZWQg aW4gV2ViQ29yZS9jc3MvbWF0aG1sLmNzcwogICAgICAgICBpZiAodmFsdWUgIT0gIm5vcm1hbCIg JiYgdmFsdWUgIT0gInNtYWxsIiAmJiB2YWx1ZSAhPSAiYmlnIikKLSAgICAgICAgICAgIGFkZFBy b3BlcnR5VG9QcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZShzdHlsZSwgQ1NTUHJvcGVydHlGb250 U2l6ZSwgdmFsdWUpOworICAgICAgICAgICAgYWRkUHJvcGVydHlUb1ByZXNlbnRhdGlvbkF0dHJp YnV0ZVN0eWxlKHN0eWxlLCBDU1NQcm9wZXJ0eUZvbnRTaXplLCBjb252ZXJ0VG9QZXJjZW50YWdl SWZOZWVkZWQodmFsdWUpKTsKICAgICB9IGVsc2UgaWYgKG5hbWUgPT0gbWF0aGNvbG9yQXR0cikK ICAgICAgICAgYWRkUHJvcGVydHlUb1ByZXNlbnRhdGlvbkF0dHJpYnV0ZVN0eWxlKHN0eWxlLCBD U1NQcm9wZXJ0eUNvbG9yLCB2YWx1ZSk7CiAgICAgLy8gRklYTUU6IGRlcHJlY2F0ZWQgYXR0cmli dXRlcyB0aGF0IHNob3VsZCBsb29zZSBpbiBhIGNvbmZsaWN0IHdpdGggYSBub24gZGVwcmVjYXRl ZCBhdHRyaWJ1dGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCBlMjZlYWY2ZTk4NDkwNGFjNDM5OGUxNTgzMzJjMmM2ODllMjA5 NTAwLi44OTQ4Nzc1ZTRjNGE3NGVlYWYyOGYyYTAzNTdmYWYzNTQyNzg3MjBlIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTktMDItMjEgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KKwor ICAgICAgICBXUFQgdGVzdHMgZm9yIE1hdGhNTCBsZW5ndGhzIGZhaWwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MDAxMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgVGVzdHMgbGVuZ3Rocy0xLmh0bWwgYW5k IGxlbmd0aC0zLmh0bWwgbm93IHBhc3MuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOgor CiAyMDE5LTAyLTE5ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQxNzIyLgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMK aW5kZXggYzJjMTlmYjExNTNlYTY1OTUzMGRmODYxMDhiZDVmZmY3ZDljYjI2YS4uNjEwMTVmY2My Zjk2YzdkZWNkZjJjN2Y4ZjU4MDc5MjczMmRjZjcxZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC03 MTksOSArNzE5LDcgQEAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2Jyb3dz ZXJzL3dpbmRvd3MvbmVzdGVkLWJyb3dzaW5nLWNvbnRleHRzL2YKIGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvaHRtbC9icm93c2Vycy93aW5kb3dzL3RhcmdldGluZy1jcm9zcy1vcmln aW4tbmVzdGVkLWJyb3dzaW5nLWNvbnRleHRzLnN1Yi5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAog IyBUaGVzZSBNYXRoTUwgV1BUIHRlc3RzIGZhaWwuCi13ZWJraXQub3JnL2IvMTgwMDEzIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvbWF0aG1sL3JlbGF0aW9ucy9jc3Mtc3R5bGluZy9s ZW5ndGhzLTEuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE4MDAxMyBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21hdGhtbC9yZWxhdGlvbnMvY3NzLXN0eWxp bmcvbGVuZ3Rocy0yLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xODAw MTMgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tYXRobWwvcmVsYXRpb25zL2Nzcy1z dHlsaW5nL2xlbmd0aHMtMy5odG1sIFsgRmFpbHVyZSBdCiAKICMgVGhlc2Ugd2VibWVzc2FnaW5n IFdQVCB0ZXN0cyB0aW1lIG91dC4KIHdlYmtpdC5vcmcvYi8xODcwMzQgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy93ZWJtZXNzYWdpbmcvTWVzc2FnZUV2ZW50X29ubWVzc2FnZV9wb3N0 TWVzc2FnZV9pbmZpbml0ZV9sb29wLmh0bWwgWyBTa2lwIF0K