180012 2017-11-25 01:43:27 -0800 [GTK] WebDriver: stop making mandatory to provide a browser path if webkitgtk:browserOptions is present in capabilities 2018-06-04 05:32:46 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186264 Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply calvaris clopez webkit-bug-importer oldest_to_newest 1374686 0 cgarcia 2017-11-25 01:43:27 -0800 Everything should be optional. We might want to disable overlay scrollbars, but still using the default browser, for example, as I'm doing when running the selenium tests. We might also want to provide additional browser arguments, but using the default browser. 1374687 1 327574 cgarcia 2017-11-25 01:47:21 -0800 Created attachment 327574 Patch 1375307 2 cgarcia 2017-11-28 04:44:07 -0800 Committed r225210: <https://trac.webkit.org/changeset/225210> 1375308 3 webkit-bug-importer 2017-11-28 04:45:30 -0800 <rdar://problem/35720708> 327574 2017-11-25 01:47:21 -0800 2017-11-28 04:03:21 -0800 Patch wd-wkgtk-options.diff text/plain 5128 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggNWMwZTZlN2JjNmQuLjYxNzAyNDIwMTc4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTExLTI1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBXZWJEcml2ZXI6IHN0b3AgbWFraW5n IG1hbmRhdG9yeSB0byBwcm92aWRlIGEgYnJvd3NlciBwYXRoIGlmIHdlYmtpdGd0azpicm93c2Vy T3B0aW9ucyBpcyBwcmVzZW50IGluIGNhcGFiaWxpdGllcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXZlcnl0aGluZyBzaG91bGQgYmUgb3B0aW9uYWwu IFdlIG1pZ2h0IHdhbnQgdG8gZGlzYWJsZSBvdmVybGF5IHNjcm9sbGJhcnMsIGJ1dCBzdGlsbCB1 c2luZyB0aGUgZGVmYXVsdCBicm93c2VyLAorICAgICAgICBmb3IgZXhhbXBsZSwgYXMgSSdtIGRv aW5nIHdoZW4gcnVubmluZyB0aGUgc2VsZW5pdW0gdGVzdHMuIFdlIG1pZ2h0IGFsc28gd2FudCB0 byBwcm92aWRlIGFkZGl0aW9uYWwgYnJvd3NlcgorICAgICAgICBhcmd1bWVudHMsIGJ1dCB1c2lu ZyB0aGUgZGVmYXVsdCBicm93c2VyLgorCisgICAgICAgICogZ3RrL1dlYkRyaXZlclNlcnZpY2VH dGsuY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpXZWJEcml2ZXJTZXJ2aWNlOjpwbGF0Zm9ybVZh bGlkYXRlQ2FwYWJpbGl0eSBjb25zdCk6IERvIG5vdCBjb25zaWRlciBpbnZhbGlkIHRvIG5vdCBw cm92aWRlIGEKKyAgICAgICAgYnJvd3NlciBiaW5hcnkgd2hlbiB3ZWJraXRndGs6YnJvd3Nlck9w dGlvbnMgaXMgcHJlc2VudC4KKyAgICAgICAgKFdlYkRyaXZlcjo6V2ViRHJpdmVyU2VydmljZTo6 cGxhdGZvcm1QYXJzZUNhcGFiaWxpdGllcyBjb25zdCk6IE92ZXJyaWRlIGRlZmF1bHQgY2FwYWJp bGl0aWVzIHdpdGggdGhlIG9uZXMKKyAgICAgICAgcHJvdmlkZWQuCisKIDIwMTctMTEtMjQgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFdlYkRy aXZlcjogSW1wbGVtZW50IGdldCBhY3RpdmUgZWxlbWVudCBjb21tYW5kCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViRHJpdmVyL2d0ay9XZWJEcml2ZXJTZXJ2aWNlR3RrLmNwcCBiL1NvdXJjZS9XZWJE cml2ZXIvZ3RrL1dlYkRyaXZlclNlcnZpY2VHdGsuY3BwCmluZGV4IDFkNDgyNzVhNjNlLi45YjM5 Mjk3MTJiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9ndGsvV2ViRHJpdmVyU2Vydmlj ZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9ndGsvV2ViRHJpdmVyU2VydmljZUd0ay5j cHAKQEAgLTU0LDkgKzU0LDkgQEAgYm9vbCBXZWJEcml2ZXJTZXJ2aWNlOjpwbGF0Zm9ybVZhbGlk YXRlQ2FwYWJpbGl0eShjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFJlZlAKICAgICBpZiAoYnJv d3Nlck9wdGlvbnMtPmlzTnVsbCgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIC8vIElm IGJyb3dzZXIgb3B0aW9ucyBhcmUgcHJvdmlkZWQsIGJpbmFyeSBpcyByZXF1aXJlZC4KKyAgICBS ZWZQdHI8SW5zcGVjdG9yVmFsdWU+IGJpbmFyeVZhbHVlOwogICAgIFN0cmluZyBiaW5hcnk7Ci0g ICAgaWYgKCFicm93c2VyT3B0aW9ucy0+Z2V0U3RyaW5nKEFTQ0lJTGl0ZXJhbCgiYmluYXJ5Iiks IGJpbmFyeSkpCisgICAgaWYgKGJyb3dzZXJPcHRpb25zLT5nZXRWYWx1ZShBU0NJSUxpdGVyYWwo ImJpbmFyeSIpLCBiaW5hcnlWYWx1ZSkgJiYgIWJpbmFyeVZhbHVlLT5hc1N0cmluZyhiaW5hcnkp KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBSZWZQdHI8SW5zcGVjdG9yVmFsdWU+IHVz ZU92ZXJsYXlTY3JvbGxiYXJzVmFsdWU7CkBAIC02NiwxNSArNjYsMTcgQEAgYm9vbCBXZWJEcml2 ZXJTZXJ2aWNlOjpwbGF0Zm9ybVZhbGlkYXRlQ2FwYWJpbGl0eShjb25zdCBTdHJpbmcmIG5hbWUs IGNvbnN0IFJlZlAKIAogICAgIFJlZlB0cjxJbnNwZWN0b3JWYWx1ZT4gYnJvd3NlckFyZ3VtZW50 c1ZhbHVlOwogICAgIFJlZlB0cjxJbnNwZWN0b3JBcnJheT4gYnJvd3NlckFyZ3VtZW50czsKLSAg ICBpZiAoYnJvd3Nlck9wdGlvbnMtPmdldFZhbHVlKEFTQ0lJTGl0ZXJhbCgiYXJncyIpLCBicm93 c2VyQXJndW1lbnRzVmFsdWUpICYmICFicm93c2VyQXJndW1lbnRzVmFsdWUtPmFzQXJyYXkoYnJv d3NlckFyZ3VtZW50cykpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIHVuc2lnbmVkIGJy b3dzZXJBcmd1bWVudHNMZW5ndGggPSBicm93c2VyQXJndW1lbnRzLT5sZW5ndGgoKTsKLSAgICBm b3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYnJvd3NlckFyZ3VtZW50c0xlbmd0aDsgKytpKSB7Ci0g ICAgICAgIFJlZlB0cjxJbnNwZWN0b3JWYWx1ZT4gdmFsdWUgPSBicm93c2VyQXJndW1lbnRzLT5n ZXQoaSk7Ci0gICAgICAgIFN0cmluZyBhcmd1bWVudDsKLSAgICAgICAgaWYgKCF2YWx1ZS0+YXNT dHJpbmcoYXJndW1lbnQpKQorICAgIGlmIChicm93c2VyT3B0aW9ucy0+Z2V0VmFsdWUoQVNDSUlM aXRlcmFsKCJhcmdzIiksIGJyb3dzZXJBcmd1bWVudHNWYWx1ZSkpIHsKKyAgICAgICAgaWYgKCFi cm93c2VyQXJndW1lbnRzVmFsdWUtPmFzQXJyYXkoYnJvd3NlckFyZ3VtZW50cykpCiAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgdW5zaWduZWQgYnJvd3NlckFyZ3VtZW50c0xl bmd0aCA9IGJyb3dzZXJBcmd1bWVudHMtPmxlbmd0aCgpOworICAgICAgICBmb3IgKHVuc2lnbmVk IGkgPSAwOyBpIDwgYnJvd3NlckFyZ3VtZW50c0xlbmd0aDsgKytpKSB7CisgICAgICAgICAgICBS ZWZQdHI8SW5zcGVjdG9yVmFsdWU+IHZhbHVlID0gYnJvd3NlckFyZ3VtZW50cy0+Z2V0KGkpOwor ICAgICAgICAgICAgU3RyaW5nIGFyZ3VtZW50OworICAgICAgICAgICAgaWYgKCF2YWx1ZS0+YXNT dHJpbmcoYXJndW1lbnQpKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAg fQogICAgIH0KIAogICAgIHJldHVybiB0cnVlOwpAQCAtODcsMjMgKzg5LDIyIEBAIHN0ZDo6b3B0 aW9uYWw8U3RyaW5nPiBXZWJEcml2ZXJTZXJ2aWNlOjpwbGF0Zm9ybU1hdGNoQ2FwYWJpbGl0eShj b25zdCBTdHJpbmcmLCBjCiAKIHZvaWQgV2ViRHJpdmVyU2VydmljZTo6cGxhdGZvcm1QYXJzZUNh cGFiaWxpdGllcyhjb25zdCBJbnNwZWN0b3JPYmplY3QmIG1hdGNoZWRDYXBhYmlsaXRpZXMsIENh cGFiaWxpdGllcyYgY2FwYWJpbGl0aWVzKSBjb25zdAogeworICAgIGNhcGFiaWxpdGllcy5icm93 c2VyQmluYXJ5ID0gU3RyaW5nKExJQkVYRUNESVIgIi93ZWJraXQyZ3RrLSIgV0VCS0lUR1RLX0FQ SV9WRVJTSU9OX1NUUklORyAiL01pbmlCcm93c2VyIik7CisgICAgY2FwYWJpbGl0aWVzLmJyb3dz ZXJBcmd1bWVudHMgPSBWZWN0b3I8U3RyaW5nPiB7IEFTQ0lJTGl0ZXJhbCgiLS1hdXRvbWF0aW9u IikgfTsKKyAgICBjYXBhYmlsaXRpZXMudXNlT3ZlcmxheVNjcm9sbGJhcnMgPSB0cnVlOworCiAg ICAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gYnJvd3Nlck9wdGlvbnM7Ci0gICAgaWYgKCFtYXRj aGVkQ2FwYWJpbGl0aWVzLmdldE9iamVjdChBU0NJSUxpdGVyYWwoIndlYmtpdGd0azpicm93c2Vy T3B0aW9ucyIpLCBicm93c2VyT3B0aW9ucykpIHsKLSAgICAgICAgY2FwYWJpbGl0aWVzLmJyb3dz ZXJCaW5hcnkgPSBTdHJpbmcoTElCRVhFQ0RJUiAiL3dlYmtpdDJndGstIiBXRUJLSVRHVEtfQVBJ X1ZFUlNJT05fU1RSSU5HICIvTWluaUJyb3dzZXIiKTsKLSAgICAgICAgY2FwYWJpbGl0aWVzLmJy b3dzZXJBcmd1bWVudHMgPSBWZWN0b3I8U3RyaW5nPiB7IEFTQ0lJTGl0ZXJhbCgiLS1hdXRvbWF0 aW9uIikgfTsKLSAgICAgICAgY2FwYWJpbGl0aWVzLnVzZU92ZXJsYXlTY3JvbGxiYXJzID0gdHJ1 ZTsKKyAgICBpZiAoIW1hdGNoZWRDYXBhYmlsaXRpZXMuZ2V0T2JqZWN0KEFTQ0lJTGl0ZXJhbCgi d2Via2l0Z3RrOmJyb3dzZXJPcHRpb25zIiksIGJyb3dzZXJPcHRpb25zKSkKICAgICAgICAgcmV0 dXJuOwotICAgIH0KIAogICAgIFN0cmluZyBicm93c2VyQmluYXJ5OwotICAgIGJyb3dzZXJPcHRp b25zLT5nZXRTdHJpbmcoQVNDSUlMaXRlcmFsKCJiaW5hcnkiKSwgYnJvd3NlckJpbmFyeSk7Ci0g ICAgQVNTRVJUKCFicm93c2VyQmluYXJ5LmlzTnVsbCgpKTsKLSAgICBjYXBhYmlsaXRpZXMuYnJv d3NlckJpbmFyeSA9IGJyb3dzZXJCaW5hcnk7CisgICAgaWYgKGJyb3dzZXJPcHRpb25zLT5nZXRT dHJpbmcoQVNDSUlMaXRlcmFsKCJiaW5hcnkiKSwgYnJvd3NlckJpbmFyeSkpCisgICAgICAgIGNh cGFiaWxpdGllcy5icm93c2VyQmluYXJ5ID0gYnJvd3NlckJpbmFyeTsKIAotICAgIGNhcGFiaWxp dGllcy5icm93c2VyQXJndW1lbnRzID0gVmVjdG9yPFN0cmluZz4oKTsKICAgICBSZWZQdHI8SW5z cGVjdG9yQXJyYXk+IGJyb3dzZXJBcmd1bWVudHM7Ci0gICAgaWYgKGJyb3dzZXJPcHRpb25zLT5n ZXRBcnJheShBU0NJSUxpdGVyYWwoImFyZ3MiKSwgYnJvd3NlckFyZ3VtZW50cykpIHsKKyAgICBp ZiAoYnJvd3Nlck9wdGlvbnMtPmdldEFycmF5KEFTQ0lJTGl0ZXJhbCgiYXJncyIpLCBicm93c2Vy QXJndW1lbnRzKSAmJiBicm93c2VyQXJndW1lbnRzLT5sZW5ndGgoKSkgewogICAgICAgICB1bnNp Z25lZCBicm93c2VyQXJndW1lbnRzTGVuZ3RoID0gYnJvd3NlckFyZ3VtZW50cy0+bGVuZ3RoKCk7 CisgICAgICAgIGNhcGFiaWxpdGllcy5icm93c2VyQXJndW1lbnRzID0gVmVjdG9yPFN0cmluZz4o KTsKICAgICAgICAgY2FwYWJpbGl0aWVzLmJyb3dzZXJBcmd1bWVudHMtPnJlc2VydmVJbml0aWFs Q2FwYWNpdHkoYnJvd3NlckFyZ3VtZW50c0xlbmd0aCk7CiAgICAgICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBicm93c2VyQXJndW1lbnRzTGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgIFJl ZlB0cjxJbnNwZWN0b3JWYWx1ZT4gdmFsdWUgPSBicm93c2VyQXJndW1lbnRzLT5nZXQoaSk7Cg==