179982 2017-11-23 13:08:48 -0800 Style resolution spin due to calc() values in animations always comparing inequal (seen on arstechnica.com) 2017-12-14 01:58:30 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue darin dino graouts malendariel simon.fraser webkit-bug-importer oldest_to_newest 1374466 0 koivisto 2017-11-23 13:08:48 -0800 Reduction attached. 1374467 1 327513 koivisto 2017-11-23 13:09:36 -0800 Created attachment 327513 reduction 1374468 2 webkit-bug-importer 2017-11-23 13:10:07 -0800 <rdar://problem/35677991> 1374469 3 327514 koivisto 2017-11-23 13:27:09 -0800 Created attachment 327514 reduction 1374470 4 koivisto 2017-11-23 13:36:47 -0800 Basically something like calc(100% - 10px) compares inequal to itself. This causes the implicit animation engine think that there is a new value after style recalc and restart the transition. Starting the transition triggers style recalc on zero duration timer which restarts the transition and so on. 1374561 5 327538 koivisto 2017-11-24 03:49:21 -0800 Created attachment 327538 patch 1374622 6 327538 darin 2017-11-24 11:22:30 -0800 Comment on attachment 327538 patch View in context: https://bugs.webkit.org/attachment.cgi?id=327538&action=review > Source/WebCore/platform/CalculationValue.cpp:130 > + // Maybe Vectors of unique_ptrs should always do deep compare? VectorTypeOperations exists so that we can do that kind of thing. It looks like we never specialized VectorTypeOperations, though, so I’m not entirely sure why we have it! > Source/WebCore/platform/CalculationValue.cpp:134 > + if (!(*a.children()[i] == *b.children()[i])) Could use a != b instead of !(a == b) 1374631 7 koivisto 2017-11-24 12:56:08 -0800 > VectorTypeOperations exists so that we can do that kind of thing. It looks > like we never specialized VectorTypeOperations, though, so I’m not entirely > sure why we have it! This more in the realm of VectorComparer. We could easily add a deep compare vector trait if we think that is a good idea. I can't really see any cases where pointer-comparing unique_ptr vectors would be correct. On the other hand it might be surprising that ptr vector and unique_ptr vector behave differently in default comparisons. > Could use a != b instead of !(a == b) Yes, after adding it. I'll keep this patch minimal for easy integration. 1374635 8 327538 commit-queue 2017-11-24 13:15:58 -0800 Comment on attachment 327538 patch Clearing flags on attachment: 327538 Committed r225141: <https://trac.webkit.org/changeset/225141> 1374636 9 commit-queue 2017-11-24 13:15:59 -0800 All reviewed patches have been landed. Closing bug. 1381546 10 koivisto 2017-12-14 01:58:30 -0800 *** Bug 180733 has been marked as a duplicate of this bug. *** 327513 2017-11-23 13:09:36 -0800 2017-11-23 13:27:09 -0800 reduction animation-with-calc-spin.html text/html 249 koivisto PHN0eWxlPgojdGVzdGRpdiB7CiAgICB3aWR0aDogY2FsYygxMDAlIC0gMTBweCk7CiAgICBiYWNr Z3JvdW5kLWNvbG9yOiBpbmhlcml0Owp9Ci50ZXN0IHsKICAgIHRyYW5zaXRpb246IDFzOwogICAg d2lkdGg6IGNhbGMoMTAwJSAtIDEwcHgpOwp9Cjwvc3R5bGU+CjxkaXY+CjxkaXYgaWQ9dGVzdGRp dj48L2Rpdj4KPGJ1dHRvbiBvbmNsaWNrPSJ0ZXN0ZGl2LmNsYXNzTGlzdC5hZGQoJ3Rlc3QnKSI+ VGVzdDwvYnV0dG9uPgo8L2Rpdj4K 327514 2017-11-23 13:27:09 -0800 2017-11-23 13:27:09 -0800 reduction animation-with-calc-spin.html text/html 363 koivisto PHN0eWxlPgojdGVzdGRpdiB7CiAgICB3aWR0aDogY2FsYygxMDAlIC0gMTBweCk7CiAgICBiYWNr Z3JvdW5kLWNvbG9yOiBpbmhlcml0OyAvKiBuZWVkZWQgdG8gZG9kZ2UgdGhlIG1hdGNoZWQgcHJv cGVydGllcyBjYWNoZSAqLwp9Ci50ZXN0IHsKICAgIHRyYW5zaXRpb246IDFzOwogICAgd2lkdGg6 IGNhbGMoMTAwJSAtIDEwcHgpOyAvKiBjYWxjIGNvbXBhcmVzIGluZXF1YWwgd2l0aCB0aGUgc2Ft ZSBleGFjdCBjYWxjIHZhbHVlICovCn0KPC9zdHlsZT4KPGRpdj4KPGRpdiBpZD10ZXN0ZGl2Pjwv ZGl2Pgo8YnV0dG9uIG9uY2xpY2s9InRlc3RkaXYuY2xhc3NMaXN0LmFkZCgndGVzdCcpIj5DUFUg c3BpbjwvYnV0dG9uPgo8L2Rpdj4K 327538 2017-11-24 03:49:21 -0800 2017-11-24 13:15:58 -0800 patch transition-calc-spin.patch text/plain 5382 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNTEzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE3LTExLTI0ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBTdHlsZSByZXNvbHV0aW9uIHNw aW4gZHVlIHRvIGNhbGMoKSB2YWx1ZXMgYWx3YXlzIGNvbXBhcmluZyBpbmVxdWFsIChzZWVuIG9u IGFyc3RlY2huaWNhLmNvbSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3OTk4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU2Nzc5OTE+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogdHJhbnNp dGlvbnMvdHJhbnNpdGlvbi13aXRoLWNhbGMtc3Bpbi5odG1sCisKKyAgICAgICAgU29tZXRoaW5n IGxpa2UgY2FsYygxMDAlIC0gMTBweCkgd291bGQgY29tcGFyZSBpbmVxdWFsIHRvIGl0c2VsZi4g VGhpcyBjYXVzZXMgdGhlIGltcGxpY2l0IGFuaW1hdGlvbiBlbmdpbmUgdGhpbmsgdGhhdAorICAg ICAgICB0aGVyZSBpcyBhIG5ldyB0YXJnZXQgdmFsdWUgYWZ0ZXIgc3R5bGUgcmVzb2x1dGlvbiBh bmQgcmVzdGFydCB0aGUgdHJhbnNpdGlvbi4gU3RhcnRpbmcgdGhlIHRyYW5zaXRpb24gdHJpZ2dl cnMgYW5vdGhlciBzdHlsZQorICAgICAgICByZXNvbHV0aW9uIG9uIHplcm8gZHVyYXRpb24gdGlt ZXIgYW5kIHNvIG9uLgorCisgICAgICAgICogcGxhdGZvcm0vQ2FsY3VsYXRpb25WYWx1ZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpvcGVyYXRvcj09KToKKyAgICAgICAgKiBwbGF0Zm9ybS9DYWxj dWxhdGlvblZhbHVlLmg6CisKKyAgICAgICAgRGVlcCBjb21wYXJlIHRoZSBjaGlsZCB2ZWN0b3Jz LgorCiAyMDE3LTExLTIzICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAg ICAgICAgW1dlYiBBbmltYXRpb25zXSBQZXJmb3JtIGFjY2VsZXJhdGVkIGFuaW1hdGlvbnMgd2hl biBwb3NzaWJsZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ2FsY3VsYXRpb25WYWx1 ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ2FsY3VsYXRpb25W YWx1ZS5jcHAJKHJldmlzaW9uIDIyNTA3OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Nh bGN1bGF0aW9uVmFsdWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjMsNiArMTIzLDIwIEBAIGJv b2wgQ2FsY0V4cHJlc3Npb25PcGVyYXRpb246Om9wZXJhdG9yPT0KICAgICByZXR1cm4gb3RoZXIu dHlwZSgpID09IENhbGNFeHByZXNzaW9uTm9kZU9wZXJhdGlvbiAmJiAqdGhpcyA9PSB0b0NhbGNF eHByZXNzaW9uT3BlcmF0aW9uKG90aGVyKTsKIH0KIAorYm9vbCBvcGVyYXRvcj09KGNvbnN0IENh bGNFeHByZXNzaW9uT3BlcmF0aW9uJiBhLCBjb25zdCBDYWxjRXhwcmVzc2lvbk9wZXJhdGlvbiYg YikKK3sKKyAgICBpZiAoYS5nZXRPcGVyYXRvcigpICE9IGIuZ2V0T3BlcmF0b3IoKSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgIC8vIE1heWJlIFZlY3RvcnMgb2YgdW5pcXVlX3B0cnMgc2hv dWxkIGFsd2F5cyBkbyBkZWVwIGNvbXBhcmU/CisgICAgaWYgKGEuY2hpbGRyZW4oKS5zaXplKCkg IT0gYi5jaGlsZHJlbigpLnNpemUoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGZvciAo dW5zaWduZWQgaSA9IDA7IGkgPCBhLmNoaWxkcmVuKCkuc2l6ZSgpOyArK2kpIHsKKyAgICAgICAg aWYgKCEoKmEuY2hpbGRyZW4oKVtpXSA9PSAqYi5jaGlsZHJlbigpW2ldKSkKKyAgICAgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICB9CisgICAgcmV0dXJuIHRydWU7Cit9CisKIHZvaWQgQ2FsY0V4 cHJlc3Npb25PcGVyYXRpb246OmR1bXAoVGV4dFN0cmVhbSYgdHMpIGNvbnN0CiB7CiAgICAgaWYg KG1fb3BlcmF0b3IgPT0gQ2FsY01pbiB8fCBtX29wZXJhdG9yID09IENhbGNNYXgpIHsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0NhbGN1bGF0aW9uVmFsdWUuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9DYWxjdWxhdGlvblZhbHVlLmgJKHJldmlzaW9uIDIy NTA3OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0NhbGN1bGF0aW9uVmFsdWUuaAkod29y a2luZyBjb3B5KQpAQCAtMjExLDEwICsyMTEsNyBAQCBpbmxpbmUgQ2FsY0V4cHJlc3Npb25PcGVy YXRpb246OkNhbGNFeHByCiB7CiB9CiAKLWlubGluZSBib29sIG9wZXJhdG9yPT0oY29uc3QgQ2Fs Y0V4cHJlc3Npb25PcGVyYXRpb24mIGEsIGNvbnN0IENhbGNFeHByZXNzaW9uT3BlcmF0aW9uJiBi KQotewotICAgIHJldHVybiBhLmdldE9wZXJhdG9yKCkgPT0gYi5nZXRPcGVyYXRvcigpICYmIGEu Y2hpbGRyZW4oKSA9PSBiLmNoaWxkcmVuKCk7Ci19Citib29sIG9wZXJhdG9yPT0oY29uc3QgQ2Fs Y0V4cHJlc3Npb25PcGVyYXRpb24mLCBjb25zdCBDYWxjRXhwcmVzc2lvbk9wZXJhdGlvbiYpOwog CiBpbmxpbmUgY29uc3QgQ2FsY0V4cHJlc3Npb25PcGVyYXRpb24mIHRvQ2FsY0V4cHJlc3Npb25P cGVyYXRpb24oY29uc3QgQ2FsY0V4cHJlc3Npb25Ob2RlJiB2YWx1ZSkKIHsKSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNTA3OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE3LTExLTI0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxl LmNvbT4KKworICAgICAgICBTdHlsZSByZXNvbHV0aW9uIHNwaW4gZHVlIHRvIGNhbGMoKSB2YWx1 ZXMgYWx3YXlzIGNvbXBhcmluZyBpbmVxdWFsIChzZWVuIG9uIGFyc3RlY2huaWNhLmNvbSkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTk4MgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzU2Nzc5OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0cmFuc2l0aW9ucy90cmFuc2l0aW9uLXdpdGgtY2Fs Yy1zcGluLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogdHJhbnNpdGlvbnMvdHJhbnNp dGlvbi13aXRoLWNhbGMtc3Bpbi5odG1sOiBBZGRlZC4KKwogMjAxNy0xMS0yMSAgRnJlZGVyaWMg V2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIW5l ZWRzTGF5b3V0KCkgaW4gV2ViQ29yZTo6UmVuZGVyTWF0aE1MU2NyaXB0czo6Zmlyc3RMaW5lQmFz ZWxpbmUKSW5kZXg6IExheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24td2l0aC1jYWxj LXNwaW4tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3RyYW5zaXRpb25z L3RyYW5zaXRpb24td2l0aC1jYWxjLXNwaW4tZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysr IExheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24td2l0aC1jYWxjLXNwaW4tZXhwZWN0 ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMyBAQAorVGVzdCB0aGF0IGNhbGMgdmFs dWVzIGluIHRyYW5zaXRpb25zIGRvbid0IGxlYWQgdG8gYSBzdHlsZSByZXNvbHV0aW9uIHNwaW4u CitQQVNTCisKSW5kZXg6IExheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24td2l0aC1j YWxjLXNwaW4uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy90cmFuc2l0aW9ucy90cmFu c2l0aW9uLXdpdGgtY2FsYy1zcGluLmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMv dHJhbnNpdGlvbnMvdHJhbnNpdGlvbi13aXRoLWNhbGMtc3Bpbi5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC0wLDAgKzEsMzkgQEAKKzxzdHlsZT4KKyN0ZXN0ZGl2IHsKKyAgICBiYWNrZ3JvdW5kLWNv bG9yOiBpbmhlcml0OyAvKiBuZWVkZWQgdG8gZG9kZ2UgdGhlIG1hdGNoZWQgcHJvcGVydGllcyBj YWNoZSAqLworfQorLnRlc3QgeworICAgIHRyYW5zaXRpb246IDFzOworICAgIHdpZHRoOiBjYWxj KDEwMCUgLSAxMHB4KTsgLyogY2FsYyBjb21wYXJlcyBpbmVxdWFsIHdpdGggdGhlIHNhbWUgZXhh Y3QgY2FsYyB2YWx1ZSAqLworfQorPC9zdHlsZT4KKzxib2R5IG9ubG9hZD0idGVzdCgpIj4KK1Rl c3QgdGhhdCBjYWxjIHZhbHVlcyBpbiB0cmFuc2l0aW9ucyBkb24ndCBsZWFkIHRvIGEgc3R5bGUg cmVzb2x1dGlvbiBzcGluLgorPGRpdiBpZD1sb2c+PC9kaXY+Cis8ZGl2IGlkPXRlc3RkaXY+PC9k aXY+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci53 YWl0VW50aWxEb25lKCk7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cit9CisKK2Z1bmN0 aW9uIHRlc3QoKSB7CisgICAgZG9jdW1lbnQuYm9keS5vZmZzZXRXaWR0aDsKKworICAgIGNvbnN0 IHN0YXJ0U3R5bGVSZWNhbGNDb3VudCA9IHdpbmRvdy5pbnRlcm5hbHMgPyBpbnRlcm5hbHMuc3R5 bGVSZWNhbGNDb3VudCgpIDogMDsKKworICAgIHRlc3RkaXYuY2xhc3NMaXN0LmFkZCgndGVzdCcp OworCisgICAgaWYgKCF3aW5kb3cuaW50ZXJuYWxzKQorICAgICAgICByZXR1cm47CisgICAgc2V0 VGltZW91dCgoKSA9PiB7CisgICAgICAgY29uc3Qgc3R5bGVSZWNhbGNDb3VudCA9IGludGVybmFs cy5zdHlsZVJlY2FsY0NvdW50KCkgLSBzdGFydFN0eWxlUmVjYWxjQ291bnQ7CisgICAgICAgaWYg KHN0eWxlUmVjYWxjQ291bnQgPD0gMykKKyAgICAgICAgICAgbG9nLmlubmVySFRNTCA9ICJQQVNT IgorICAgICAgIGVsc2UKKyAgICAgICAgICAgbG9nLmlubmVySFRNTCA9IGBGQUlMOiBzdHlsZVJl Y2FsY0NvdW50OiAkeyBpbnRlcm5hbHMuc3R5bGVSZWNhbGNDb3VudCgpIC0gc3RhcnRTdHlsZVJl Y2FsY0NvdW50fWA7CisgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgfSwgMTAp OworfQorPC9zY3JpcHQ+Cis8L2Rpdj4K