179971 2017-11-23 02:23:26 -0800 [CMake] Values of CMAKE_BUILD_TYPE from toolchain file are ignored 2017-11-27 07:35:25 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez bburg cgarcia clopez commit-queue jfbastien lforschler mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1374365 0 aperez 2017-11-23 02:23:26 -0800 I have noticed this one while working with Buildroot. For CMake-based packages it generates a “Toolchain file” [1] which defines the paths to the cross-compilation tools, build options, and so on. This toolchain file also specifies the build type with: # Build type from the Buildroot configuration set(CMAKE_BUILD_TYPE Release CACHE STRING "Buildroot build configuration") Nevertheless, when WebKit is configured with the above setting, it will notify that “RelWithDebInfo” is being used instead (output re-formatted by me for clarity) — the value from the toolchain file is ignored: >>> wpewebkit custom Configuring (mkdir -p /home/aperez/devel/wpe/buildroot-wpe-overlay/buildroot-2017.08.1/output/build/wpewebkit-custom/ && \ cd /home/aperez/devel/wpe/buildroot-wpe-overlay/buildroot-2017.08.1/output/build/wpewebkit-custom/ && \ rm -f CMakeCache.txt && \ PATH="/home/aperez/devel/wpe/buildroot-wpe-overlay/buildroot-2017.08.1/output/host/bin:/home/aperez/devel/wpe/buildroot-wpe-overlay/buildroot-2017.08.1/output/host/sbin:/usr/local/bin:/usr/local/sbin" \ /usr/bin/cmake /home/aperez/devel/wpe/buildroot-wpe-overlay/buildroot-2017.08.1/output/build/wpewebkit-custom/ \ -DCMAKE_TOOLCHAIN_FILE="/home/aperez/devel/wpe/buildroot-wpe-overlay/buildroot-2017.08.1/output/host/share/buildroot/toolchainfile.cmake" \ -DCMAKE_INSTALL_PREFIX="/usr" \ -DCMAKE_COLOR_MAKEFILE=OFF \ -DBUILD_DOC=OFF \ -DBUILD_DOCS=OFF \ -DBUILD_EXAMPLE=OFF \ -DBUILD_EXAMPLES=OFF \ -DBUILD_TEST=OFF \ -DBUILD_TESTS=OFF \ -DBUILD_TESTING=OFF \ -DBUILD_SHARED_LIBS=ON \ -DENABLE_API_TESTS=OFF \ -DENABLE_GEOLOCATION=OFF \ -DENABLE_GTKDOC=OFF \ -DENABLE_INTROSPECTION=OFF \ -DENABLE_MINIBROWSER=OFF \ -DENABLE_SPELLCHECK=OFF \ -DPORT=WPE \ -DENABLE_JIT=ON \ -DENABLE_VIDEO=OFF \ -DENABLE_WEB_AUDIO=OFF \ -DENABLE_MEDIA_STREAM=OFF \ -DENABLE_WEB_CRYPTO=OFF \ -DENABLE_WEBDRIVER=OFF \ -DENABLE_XSLT=OFF ) CMake Warning at CMakeLists.txt:7 (message): No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo. Probably this has to do with how we are trying to detect whether “CMAKE_BUILD_TYPE” was set (or not) in the command line. In this case it is not coming directly from the command line, and it is being reset to “RelWithDebInfo”. This is definitely having an impact on the build results: If I patch the Buildroot recipe to pass “-DCMAKE_BUILD_TYPE=Release” in the command line, instead of letting the default “RelWithDebInfo” overwrite the setting from the toolchain file, then the resulting binaries take ~17 MiB less of disk space. --- [1] https://cmake.org/cmake/help/v3.3/variable/CMAKE_TOOLCHAIN_FILE.html 1374366 1 327489 aperez 2017-11-23 02:24:53 -0800 Created attachment 327489 Example toolchainfile.cmake generated by Buildroot 1374424 2 mcatanzaro 2017-11-23 07:58:14 -0800 The code at the top of our toplevel CMakeLists.txt is this: if (NOT CMAKE_BUILD_TYPE) message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.") set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE) else () message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}") endif () So... that's fairly straightforward. Are the other variables in the toolchain file already set before that point? 1374431 3 aperez 2017-11-23 08:48:19 -0800 (In reply to Michael Catanzaro from comment #2) > The code at the top of our toplevel CMakeLists.txt is this: > > if (NOT CMAKE_BUILD_TYPE) > message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to > RelWithDebInfo.") > set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of > build." FORCE) > else () > message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}") > endif () > > So... that's fairly straightforward. It is, indeed! It's puzzling, and I have no idea why CMake is so bizarre. I suspect that the toolchain file is NOT loaded directly on startup, but included by some file from “/usrshare/cmake/*”, and those get pulled in by one of the top-level commands used to configure. > Are the other variables in the toolchain file already set before that point? Will check. Probably not if my hypothesis as outlined above is correct. 1374514 4 327524 aperez 2017-11-23 21:23:41 -0800 Created attachment 327524 Patch 1374515 5 aperez 2017-11-23 21:25:10 -0800 (In reply to Adrian Perez from comment #3) > (In reply to Michael Catanzaro from comment #2) > > The code at the top of our toplevel CMakeLists.txt is this: > > > > if (NOT CMAKE_BUILD_TYPE) > > message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to > > RelWithDebInfo.") > > set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of > > build." FORCE) > > else () > > message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}") > > endif () > > > > So... that's fairly straightforward. > > It is, indeed! It's puzzling, and I have no idea why CMake is so > bizarre. I suspect that the toolchain file is NOT loaded directly > on startup, but included by some file from “/usrshare/cmake/*”, > and those get pulled in by one of the top-level commands used to > configure. It turns out that the call to “project()” in the top-level CMakeLists.txt is what checks “CMAKE_TOOLCHAIN_FILE” and loads it. Therefore we need to call “project()” first before checking anything. 1374529 6 327524 clopez 2017-11-24 01:19:01 -0800 Comment on attachment 327524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327524&action=review wow, this is certainly tricky. > CMakeLists.txt:10 > > +project(WebKit) > + > if (NOT CMAKE_BUILD_TYPE) > message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.") > set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE) I think this deserves a comment line saying that calling project first is needed to automatically define CMAKE_BUILD_TYPE from the toolchain file 1374886 7 aperez 2017-11-27 04:56:40 -0800 (In reply to Carlos Alberto Lopez Perez from comment #6) > Comment on attachment 327524 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=327524&action=review > > wow, this is certainly tricky. > > > CMakeLists.txt:10 > > > > +project(WebKit) > > + > > if (NOT CMAKE_BUILD_TYPE) > > message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.") > > set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE) > > I think this deserves a comment line saying that calling project first is > needed to automatically define CMAKE_BUILD_TYPE from the toolchain file I'll add the comment before landing the change, with a link to https://cmake.org/cmake/help/v3.3/command/project.html where it says that “project()” must be the first command (it does not explain very well why, but then again not being particularly clear is something the CMake documentation tends to do). 1374887 8 327629 aperez 2017-11-27 05:02:58 -0800 Created attachment 327629 Patch for landing 1374909 9 327629 commit-queue 2017-11-27 07:34:52 -0800 Comment on attachment 327629 Patch for landing Clearing flags on attachment: 327629 Committed r225168: <https://trac.webkit.org/changeset/225168> 1374910 10 commit-queue 2017-11-27 07:34:54 -0800 All reviewed patches have been landed. Closing bug. 1374911 11 webkit-bug-importer 2017-11-27 07:35:25 -0800 <rdar://problem/35697658> 327489 2017-11-23 02:24:53 -0800 2017-11-23 02:24:53 -0800 Example toolchainfile.cmake generated by Buildroot toolchainfile.cmake text/plain 3582 aperez IwojIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGVkIGZpbGU7IERPIE5PVCBFRElULgojIENNYWtlIHRv b2xjaGFpbiBmaWxlIGZvciBCdWlsZHJvb3QKIwoKIyBJbiBvcmRlciB0byBhbGxvdyB0aGUgdG9v bGNoYWluIHRvIGJlIHJlbG9jYXRlZCwgd2UgY2FsY3VsYXRlIHRoZQojIEhPU1RfRElSIGJhc2Vk IG9uIHRoaXMgZmlsZSdzIGxvY2F0aW9uOiAkKEhPU1RfRElSKS9zaGFyZS9idWlsZHJvb3QKIyBh bmQgc3RvcmUgaXQgaW4gUkVMT0NBVEVEX0hPU1RfRElSLgojIEFsbCB0aGUgb3RoZXIgdmFyaWFi bGVzIHRoYXQgbmVlZCB0byByZWZlciB0byBIT1NUX0RJUiB3aWxsIHVzZSB0aGUKIyBSRUxPQ0FU RURfSE9TVF9ESVIgdmFyaWFibGUuCnN0cmluZyhSRVBMQUNFICIvc2hhcmUvYnVpbGRyb290IiAi IiBSRUxPQ0FURURfSE9TVF9ESVIgJHtDTUFLRV9DVVJSRU5UX0xJU1RfRElSfSkKCiMgUG9pbnQg Y21ha2UgdG8gdGhlIGxvY2F0aW9uIHdoZXJlIHdlIGhhdmUgb3VyIGN1c3RvbSBtb2R1bGVzLAoj IHNvIHRoYXQgaXQgY2FuIGZpbmQgb3VyIGN1c3RvbSBwbGF0Zm9ybSBkZXNjcmlwdGlvbi4KbGlz dChBUFBFTkQgQ01BS0VfTU9EVUxFX1BBVEggJHtDTUFLRV9DVVJSRU5UX0xJU1RfRElSfSkKCnNl dChDTUFLRV9TWVNURU1fTkFNRSBCdWlsZHJvb3QpCnNldChDTUFLRV9TWVNURU1fUFJPQ0VTU09S IGFybXY4bCkKCiMgU2V0IHRoZSB7QyxDWFh9RkxBR1MgYXBwZW5kZWQgYnkgQ01ha2UgZGVwZW5k aW5nIG9uIHRoZSBidWlsZCB0eXBlCiMgZGVmaW5lZCBieSBCdWlsZHJvb3QuIENNYWtlIGRlZmF1 bHRzIHRoZXNlIHZhcmlhYmxlcyB3aXRoIC1nIGFuZC9vcgojIC1PIG9wdGlvbnMsIGFuZCB0aGV5 IGFyZSBhcHBlbmRlZCBhdCB0aGUgZW5kIG9mIHRoZSBhcmd1bWVudCBsaXN0LAojIHNvIHRoZSBC dWlsZHJvb3Qgb3B0aW9ucyBhcmUgb3ZlcnJpZGRlbi4gVGhlcmVmb3JlIHRoZXNlIHZhcmlhYmxl cwojIGhhdmUgdG8gYmUgY2xlYXJlZCwgc28gdGhhdCB0aGUgb3B0aW9ucyBwYXNzZWQgaW4gQ01B S0VfQ19GTEFHUyBkbwojIGFwcGx5LgojCiMgTm90ZToKIyAgIGlmIHRoZSBwcm9qZWN0IGZvcmNl cyBzb21lIG9mIHRoZXNlIGZsYWcgdmFyaWFibGVzLCBCdWlsZHJvb3QgaXMKIyAgIHNjcmV3ZWQg dXAgYW5kIHRoZXJlIGlzIG5vdGhpbmcgQnVpbGRyb290IGNhbiBkbyBhYm91dCB0aGF0IDooCnNl dChDTUFLRV9DX0ZMQUdTX0RFQlVHICIiIENBQ0hFIFNUUklORyAiRGVidWcgQ0ZMQUdTIikKc2V0 KENNQUtFX0NYWF9GTEFHU19ERUJVRyAiIiBDQUNIRSBTVFJJTkcgIkRlYnVnIENYWEZMQUdTIikK c2V0KENNQUtFX0NfRkxBR1NfUkVMRUFTRSAiIC1ETkRFQlVHIiBDQUNIRSBTVFJJTkcgIlJlbGVh c2UgQ0ZMQUdTIikKc2V0KENNQUtFX0NYWF9GTEFHU19SRUxFQVNFICIgLUROREVCVUciIENBQ0hF IFNUUklORyAiUmVsZWFzZSBDWFhGTEFHUyIpCgojIEJ1aWxkIHR5cGUgZnJvbSB0aGUgQnVpbGRy b290IGNvbmZpZ3VyYXRpb24Kc2V0KENNQUtFX0JVSUxEX1RZUEUgUmVsZWFzZSBDQUNIRSBTVFJJ TkcgIkJ1aWxkcm9vdCBidWlsZCBjb25maWd1cmF0aW9uIikKCiMgQnVpbGRyb290IGRlZmF1bHRz IGZsYWdzLgojIElmIHlvdSBhcmUgdXNpbmcgdGhpcyB0b29sY2hhaW5maWxlLmNtYWtlIGZpbGUg b3V0c2lkZSBvZiBCdWlsZHJvb3QgYW5kCiMgd2FudCB0byBjdXN0b21pemUgdGhlIGNvbXBpbGVy L2xpbmtlciBmbGFncywgdGhlbjoKIyAqIHNldCB0aGVtIGFsbCBvbiB0aGUgY21ha2UgY29tbWFu ZCBsaW5lLCBlLmcuOgojICAgICBjbWFrZSAtRENNQUtFX0NfRkxBR1M9Ii1EX0xBUkdFRklMRV9T T1VSQ0UgLURfTEFSR0VGSUxFNjRfU09VUkNFIC1EX0ZJTEVfT0ZGU0VUX0JJVFM9NjQgLU8yIC1m c3RhY2stcHJvdGVjdG9yLXN0cm9uZyAtRHNvbWVfY3VzdG9tX2ZsYWciIC4uLgojICogYW5kIG1h a2Ugc3VyZSB0aGUgcHJvamVjdCdzIENNYWtlIGNvZGUgZXh0ZW5kcyB0aGVtIGxpa2UgdGhpcyBp ZiBuZWVkZWQ6CiMgICAgIHNldChDTUFLRV9DX0ZMQUdTICIke0NNQUtFX0NfRkxBR1N9IC1Ec29t ZV9kZWZpbml0aW9ucyIpCnNldChDTUFLRV9DX0ZMQUdTICItRF9MQVJHRUZJTEVfU09VUkNFIC1E X0xBUkdFRklMRTY0X1NPVVJDRSAtRF9GSUxFX09GRlNFVF9CSVRTPTY0IC1PMiAtZnN0YWNrLXBy b3RlY3Rvci1zdHJvbmciIENBQ0hFIFNUUklORyAiQnVpbGRyb290IENGTEFHUyIpCnNldChDTUFL RV9DWFhfRkxBR1MgIi1EX0xBUkdFRklMRV9TT1VSQ0UgLURfTEFSR0VGSUxFNjRfU09VUkNFIC1E X0ZJTEVfT0ZGU0VUX0JJVFM9NjQgLU8yIC1mc3RhY2stcHJvdGVjdG9yLXN0cm9uZyAtZnN0YWNr LXByb3RlY3Rvci1zdHJvbmciIENBQ0hFIFNUUklORyAiQnVpbGRyb290IENYWEZMQUdTIikKc2V0 KENNQUtFX0VYRV9MSU5LRVJfRkxBR1MgIiIgQ0FDSEUgU1RSSU5HICJCdWlsZHJvb3QgTERGTEFH UyBmb3IgZXhlY3V0YWJsZXMiKQoKc2V0KENNQUtFX0lOU1RBTExfU09fTk9fRVhFIDApCgpzZXQo Q01BS0VfUFJPR1JBTV9QQVRIICIke1JFTE9DQVRFRF9IT1NUX0RJUn0vYmluIikKc2V0KENNQUtF X1NZU1JPT1QgIiR7UkVMT0NBVEVEX0hPU1RfRElSfS9hcm0tYnVpbGRyb290LWxpbnV4LWdudWVh Ymkvc3lzcm9vdCIpCnNldChDTUFLRV9GSU5EX1JPT1RfUEFUSCAiJHtSRUxPQ0FURURfSE9TVF9E SVJ9L2FybS1idWlsZHJvb3QtbGludXgtZ251ZWFiaS9zeXNyb290IikKc2V0KENNQUtFX0ZJTkRf Uk9PVF9QQVRIX01PREVfUFJPR1JBTSBORVZFUikKc2V0KENNQUtFX0ZJTkRfUk9PVF9QQVRIX01P REVfUEFDS0FHRSBPTkxZKQpzZXQoQ01BS0VfRklORF9ST09UX1BBVEhfTU9ERV9MSUJSQVJZIE9O TFkpCnNldChDTUFLRV9GSU5EX1JPT1RfUEFUSF9NT0RFX0lOQ0xVREUgT05MWSkKc2V0KEVOVntQ S0dfQ09ORklHX1NZU1JPT1RfRElSfSAiJHtSRUxPQ0FURURfSE9TVF9ESVJ9L2FybS1idWlsZHJv b3QtbGludXgtZ251ZWFiaS9zeXNyb290IikKCiMgVGhpcyB0b29sY2hhaW4gZmlsZSBjYW4gYmUg dXNlZCBib3RoIGluc2lkZSBhbmQgb3V0c2lkZSBCdWlsZHJvb3QuCnNldChDTUFLRV9DX0NPTVBJ TEVSICIke1JFTE9DQVRFRF9IT1NUX0RJUn0vYmluL2FybS1idWlsZHJvb3QtbGludXgtZ251ZWFi aS1nY2MiKQpzZXQoQ01BS0VfQ1hYX0NPTVBJTEVSICIke1JFTE9DQVRFRF9IT1NUX0RJUn0vYmlu L2FybS1idWlsZHJvb3QtbGludXgtZ251ZWFiaS1nKysiKQppZigwKQogIHNldChDTUFLRV9Gb3J0 cmFuX0ZMQUdTX0RFQlVHICIiIENBQ0hFIFNUUklORyAiRGVidWcgRm9ydHJhbiBGTEFHUyIpCiAg c2V0KENNQUtFX0ZvcnRyYW5fRkxBR1NfUkVMRUFTRSAiIC1ETkRFQlVHIiBDQUNIRSBTVFJJTkcg IlJlbGVhc2UgRm9ydHJhbiBGTEFHUyIpCiAgc2V0KENNQUtFX0ZvcnRyYW5fRkxBR1MgIi1PMiAt ZnN0YWNrLXByb3RlY3Rvci1zdHJvbmciIENBQ0hFIFNUUklORyAiQnVpbGRyb290IEZDRkxBR1Mi KQogIHNldChDTUFLRV9Gb3J0cmFuX0NPTVBJTEVSICIke1JFTE9DQVRFRF9IT1NUX0RJUn0vYmlu L2FybS1idWlsZHJvb3QtbGludXgtZ251ZWFiaS1nZm9ydHJhbiIpCmVuZGlmKCkK 327524 2017-11-23 21:23:41 -0800 2017-11-27 05:02:54 -0800 Patch bug-179971-20171124072339.patch text/plain 1470 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MDcwCmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IDcwNmUxYjMyYWJiZjI4ZTUwN2Q2YjVmMzQzZjQ2MjgyMDc2 YTg4MWEuLjI0YjM3MjQxOWI3ZWNkMDZjZWRjNjM3YzY3ODk4N2YyOWViYzczODQgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0zLDYgKzMsOCBAQAog IyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogY21ha2VfbWluaW11bV9yZXF1aXJlZChWRVJTSU9OIDMu MykKIAorcHJvamVjdChXZWJLaXQpCisKIGlmIChOT1QgQ01BS0VfQlVJTERfVFlQRSkKICAgICBt ZXNzYWdlKFdBUk5JTkcgIk5vIENNQUtFX0JVSUxEX1RZUEUgdmFsdWUgc3BlY2lmaWVkLCBkZWZh dWx0aW5nIHRvIFJlbFdpdGhEZWJJbmZvLiIpCiAgICAgc2V0KENNQUtFX0JVSUxEX1RZUEUgIlJl bFdpdGhEZWJJbmZvIiBDQUNIRSBTVFJJTkcgIkNob29zZSB0aGUgdHlwZSBvZiBidWlsZC4iIEZP UkNFKQpAQCAtMTAsOCArMTIsNiBAQCBlbHNlICgpCiAgICAgbWVzc2FnZShTVEFUVVMgIlRoZSBD TWFrZSBidWlsZCB0eXBlIGlzOiAke0NNQUtFX0JVSUxEX1RZUEV9IikKIGVuZGlmICgpCiAKLXBy b2plY3QoV2ViS2l0KQotCiBzZXQoQ01BS0VfTU9EVUxFX1BBVEggIiR7Q01BS0VfU09VUkNFX0RJ Un0vU291cmNlL2NtYWtlIikKIAogc2V0KEVOQUJMRV9XRUJDT1JFIE9OKQpkaWZmIC0tZ2l0IGEv Q2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDA0ZmEzMWM3YzZlNzZlNzk0YzJiNmI0NmNmOTZm NTQwZmRkYWNiNzcuLjk4MWI4YzcwNmE4N2Y0MmU5N2Q1M2IxZTRmNTdkNWJjZjc4NDYzNDggMTAw NjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAx Ny0xMS0yMyAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtDTWFrZV0gVmFsdWVzIG9mIENNQUtFX0JVSUxEX1RZUEUgZnJvbSB0b29sY2hhaW4g ZmlsZSBhcmUgaWdub3JlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc5OTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogQ2FsbCBwcm9qZWN0KCkgZmlyc3QsIGFzIGl0IGxv YWRzIHRoZSB0b29sY2hhaW4KKyAgICAgICAgZmlsZSwgc28gdGhhdCdzIGRvbmUgYmVmb3JlIGNo ZWNraW5nIENNQUtFX0JVSUxEX1RZUEUuCisKIDIwMTctMTEtMjAgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBP cHRpb25zR1RLLmNtYWtlIGFuZCBORVdTIGZvciAyLjE5LjIgcmVsZWFzZS4K 327629 2017-11-27 05:02:58 -0800 2017-11-27 07:34:52 -0800 Patch for landing bug-179971-20171127150257.patch text/plain 1908 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MTY1CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IDcwNmUxYjMyYWJiZjI4ZTUwN2Q2YjVmMzQzZjQ2MjgyMDc2 YTg4MWEuLjA1YjA1NzllYjNjOTM1YzJiNjZiNDRmN2ZmZWYyNzUwM2I5OTBiZjMgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0xLDggKzEsMTcgQEAK ICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgRGV0ZXJtaW5lIENNYWtlIHZlcnNpb24gYW5kIGJ1 aWxkIHR5cGUuCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisjCisjIE5PVEU6IGNtYWtlX21pbmlt dW1fcmVxdWlyZWQoKSBhbmQgcHJvamVjdCgpICpNVVNUKiBiZSB0aGUgdHdvIGZpc3QgY29tbWFu ZHMKKyMgdXNlZCwgc2VlIGh0dHBzOi8vY21ha2Uub3JnL2NtYWtlL2hlbHAvdjMuMy9jb21tYW5k L3Byb2plY3QuaHRtbCAtLSB0aGUKKyMgbGF0dGVyIGluIHBhcnRpY3VsYXIgaGFuZGxlcyBsb2Fk aW5nIGEgYnVuY2ggb2Ygc2hhcmVkIENNYWtlIGRlZmluaXRpb25zCisjIGFuZCBsb2FkaW5nIHRo ZSBjcm9zcy1jb21waWxhdGlvbiBzZXR0aW5ncyBmcm9tIENNQUtFX1RPT0xDSEFJTl9GSUxFLgor IworCiBjbWFrZV9taW5pbXVtX3JlcXVpcmVkKFZFUlNJT04gMy4zKQogCitwcm9qZWN0KFdlYktp dCkKKwogaWYgKE5PVCBDTUFLRV9CVUlMRF9UWVBFKQogICAgIG1lc3NhZ2UoV0FSTklORyAiTm8g Q01BS0VfQlVJTERfVFlQRSB2YWx1ZSBzcGVjaWZpZWQsIGRlZmF1bHRpbmcgdG8gUmVsV2l0aERl YkluZm8uIikKICAgICBzZXQoQ01BS0VfQlVJTERfVFlQRSAiUmVsV2l0aERlYkluZm8iIENBQ0hF IFNUUklORyAiQ2hvb3NlIHRoZSB0eXBlIG9mIGJ1aWxkLiIgRk9SQ0UpCkBAIC0xMCw4ICsxOSw2 IEBAIGVsc2UgKCkKICAgICBtZXNzYWdlKFNUQVRVUyAiVGhlIENNYWtlIGJ1aWxkIHR5cGUgaXM6 ICR7Q01BS0VfQlVJTERfVFlQRX0iKQogZW5kaWYgKCkKIAotcHJvamVjdChXZWJLaXQpCi0KIHNl dChDTUFLRV9NT0RVTEVfUEFUSCAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvY21ha2UiKQog CiBzZXQoRU5BQkxFX1dFQkNPUkUgT04pCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VM b2cKaW5kZXggYWZjOWU4YzFmYzk1ZDJjZTNjODc3YWNlYWQxMjRlY2MwNDI4MDhmZC4uNGEwMWQ3 Yzk4NDU4MjQ1OTQwMTE1ODA5MDIyNDQ3ZTVhZjFiMWZjYyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9n CisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTExLTIzICBBZHJpYW4gUGVy ZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBWYWx1 ZXMgb2YgQ01BS0VfQlVJTERfVFlQRSBmcm9tIHRvb2xjaGFpbiBmaWxlIGFyZSBpZ25vcmVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk5NzEKKwor ICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJlei4KKworICAgICAg ICAqIENNYWtlTGlzdHMudHh0OiBDYWxsIHByb2plY3QoKSBmaXJzdCwgYXMgaXQgbG9hZHMgdGhl IHRvb2xjaGFpbgorICAgICAgICBmaWxlLCBzbyB0aGF0J3MgZG9uZSBiZWZvcmUgY2hlY2tpbmcg Q01BS0VfQlVJTERfVFlQRS4KKwogMjAxNy0xMS0yMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0 YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgU2FuaXR5LWNoZWNrIGZlYXR1cmUgZGVmYXVs dHMgaW4gV2ViS2l0RmVhdHVyZXMuY21ha2UK