179966 2017-11-22 23:26:55 -0800 Minor ArrayBufferView cleanup 2017-11-23 14:24:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue darin ews-watchlist keith_miller mark.lam msaboff saam simon.fraser webkit-bug-importer oldest_to_newest 1374345 0 simon.fraser 2017-11-22 23:26:55 -0800 Minor ArrayBufferView cleanup 1374346 1 327484 simon.fraser 2017-11-22 23:29:14 -0800 Created attachment 327484 Patch 1374474 2 327484 darin 2017-11-23 14:04:07 -0800 Comment on attachment 327484 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327484&action=review > Source/JavaScriptCore/runtime/ArrayBufferView.h:194 > + // Do not replace with RELEASE_ASSERT; we want to avoid the virtual byteLength() function call in release. This shows that using the style checker to suggest replacing every last ASSERT_WITH_SECURITY_IMPLICATION with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION might not be the right thing to do. 1374479 3 327484 commit-queue 2017-11-23 14:23:18 -0800 Comment on attachment 327484 Patch Clearing flags on attachment: 327484 Committed r225123: <https://trac.webkit.org/changeset/225123> 1374480 4 commit-queue 2017-11-23 14:23:20 -0800 All reviewed patches have been landed. Closing bug. 1374482 5 webkit-bug-importer 2017-11-23 14:24:25 -0800 <rdar://problem/35678187> 327484 2017-11-22 23:29:14 -0800 2017-11-23 14:23:18 -0800 Patch bug-179966-20171122232913.patch text/plain 4813 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZjJmMWFjMzFiNGI5MjVlZTcwYTEwM2E1YTRkZmM1ZDFkOGFhNmU2Li40MjBmNDllOTk5YzNkYmU4 Yjk3MDc5YjkwMzEwYThkZGMyM2Y3MmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNyBAQAogMjAxNy0xMS0yMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAorICAgICAgICBNaW5vciBBcnJheUJ1ZmZlclZpZXcgY2xlYW51cAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5OTY2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBVc2Ugdm9pZCog Zm9yIGRhdGEgcG9pbnRlcnMgd2hlbiB3ZSBkb24ndCBuZWVkIHRvIGRvIG9mZnNldCBtYXRoLiBV c2UgY29uc3QgZm9yCisgICAgICAgIHNvdXJjZSBwb2ludGVycy4KKyAgICAgICAgCisgICAgICAg IFByZWZlciB1aW50OF90KiB0byBjaGFyKi4KKyAgICAgICAgCisgICAgICAgIEFkZCBjb21tZW50 cyBub3RpbmcgdGhhdCB0aGUgYXNzZXJ0aW9ucyBzaG91bGQgbm90IGJlIG1hZGUgcmVsZWFzZSBh c3NlcnRpb25zCisgICAgICAgIGFzIHJlY29tbWVuZGVkIGJ5IHRoZSBzdHlsZSBjaGVja2VyLCBz aW5jZSB0aGUgcG9pbnQgaXMgdG8gYXZvaWQgdGhlIHZpcnR1YWwgYnl0ZUxlbmd0aCgpCisgICAg ICAgIGNhbGwgaW4gcmVsZWFzZS4KKworICAgICAgICAqIHJ1bnRpbWUvQXJyYXlCdWZmZXJWaWV3 Lmg6CisgICAgICAgIChKU0M6OkFycmF5QnVmZmVyVmlldzo6c2V0SW1wbCk6CisgICAgICAgIChK U0M6OkFycmF5QnVmZmVyVmlldzo6c2V0UmFuZ2VJbXBsKToKKyAgICAgICAgKEpTQzo6QXJyYXlC dWZmZXJWaWV3OjpnZXRSYW5nZUltcGwpOgorICAgICAgICAoSlNDOjpBcnJheUJ1ZmZlclZpZXc6 Onplcm9SYW5nZUltcGwpOgorCisyMDE3LTExLTIyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIEZvbGxvd3VwIGFmdGVyIHIyMjUwODQ6IGlmIGFueW9u ZSBjYWxsZWQgR2VuZXJpY1R5cGVkQXJyYXlWaWV3KCkgaXQgZGlkbid0IGNvbXBpbGUsCiAgICAg ICAgIGJlY2F1c2Ugb2YgYSBnZXRSYW5nZVVuY2hlY2tlZC9nZXRSYW5nZUltcGwgbmFtZSBtaXNt YXRjaDsgZml4ZWQgdG8gdXNlIGdldFJhbmdlSW1wbCgpLgogICAgICAgICAKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5QnVmZmVyVmlldy5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlCdWZmZXJWaWV3LmgKaW5kZXggZGFmOWQ4NmU4 NjUxNDYyZTI2NjlmMDk1NDI1MDRmMWZmMmViZjg4MS4uNzAzYmM2MjcyYWNmZTdmMzRkMmE4OTk0 NjRhY2QzYTk5OGVkNGUwMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvQXJyYXlCdWZmZXJWaWV3LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv QXJyYXlCdWZmZXJWaWV3LmgKQEAgLTExOCw4ICsxMTgsOCBAQCBwcm90ZWN0ZWQ6CiAgICAgaW5s aW5lIGJvb2wgc2V0SW1wbChBcnJheUJ1ZmZlclZpZXcqLCB1bnNpZ25lZCBieXRlT2Zmc2V0KTsK IAogICAgIC8vIENhbGxlciBwYXNzZXMgaW4gYnVmZmVyQnl0ZUxlbmd0aCB0byBhdm9pZCBhIHZp cnR1YWwgZnVuY3Rpb24gY2FsbC4KLSAgICBpbmxpbmUgYm9vbCBzZXRSYW5nZUltcGwoY29uc3Qg Y2hhciogZGF0YSwgc2l6ZV90IGRhdGFCeXRlTGVuZ3RoLCB1bnNpZ25lZCBieXRlT2Zmc2V0LCB1 bnNpZ25lZCBidWZmZXJCeXRlTGVuZ3RoKTsKLSAgICBpbmxpbmUgYm9vbCBnZXRSYW5nZUltcGwo Y2hhciogZGVzdGluYXRpb24sIHNpemVfdCBkYXRhQnl0ZUxlbmd0aCwgdW5zaWduZWQgYnl0ZU9m ZnNldCwgdW5zaWduZWQgYnVmZmVyQnl0ZUxlbmd0aCk7CisgICAgaW5saW5lIGJvb2wgc2V0UmFu Z2VJbXBsKGNvbnN0IHZvaWQqIGRhdGEsIHNpemVfdCBkYXRhQnl0ZUxlbmd0aCwgdW5zaWduZWQg Ynl0ZU9mZnNldCwgdW5zaWduZWQgYnVmZmVyQnl0ZUxlbmd0aCk7CisgICAgaW5saW5lIGJvb2wg Z2V0UmFuZ2VJbXBsKHZvaWQqIGRlc3RpbmF0aW9uLCBzaXplX3QgZGF0YUJ5dGVMZW5ndGgsIHVu c2lnbmVkIGJ5dGVPZmZzZXQsIHVuc2lnbmVkIGJ1ZmZlckJ5dGVMZW5ndGgpOwogCiAgICAgaW5s aW5lIGJvb2wgemVyb1JhbmdlSW1wbCh1bnNpZ25lZCBieXRlT2Zmc2V0LCBzaXplX3QgcmFuZ2VC eXRlTGVuZ3RoKTsKIApAQCAtMTY4LDEzICsxNjgsMTQgQEAgYm9vbCBBcnJheUJ1ZmZlclZpZXc6 OnNldEltcGwoQXJyYXlCdWZmZXJWaWV3KiBhcnJheSwgdW5zaWduZWQgYnl0ZU9mZnNldCkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KICAgICAKLSAgICBjaGFyKiBiYXNlID0gc3RhdGlj X2Nhc3Q8Y2hhcio+KGJhc2VBZGRyZXNzKCkpOworICAgIHVpbnQ4X3QqIGJhc2UgPSBzdGF0aWNf Y2FzdDx1aW50OF90Kj4oYmFzZUFkZHJlc3MoKSk7CiAgICAgbWVtbW92ZShiYXNlICsgYnl0ZU9m ZnNldCwgYXJyYXktPmJhc2VBZGRyZXNzKCksIGFycmF5LT5ieXRlTGVuZ3RoKCkpOwogICAgIHJl dHVybiB0cnVlOwogfQogCi1ib29sIEFycmF5QnVmZmVyVmlldzo6c2V0UmFuZ2VJbXBsKGNvbnN0 IGNoYXIqIGRhdGEsIHNpemVfdCBkYXRhQnl0ZUxlbmd0aCwgdW5zaWduZWQgYnl0ZU9mZnNldCwg dW5zaWduZWQgYnVmZmVyQnl0ZUxlbmd0aCkKK2Jvb2wgQXJyYXlCdWZmZXJWaWV3OjpzZXRSYW5n ZUltcGwoY29uc3Qgdm9pZCogZGF0YSwgc2l6ZV90IGRhdGFCeXRlTGVuZ3RoLCB1bnNpZ25lZCBi eXRlT2Zmc2V0LCB1bnNpZ25lZCBidWZmZXJCeXRlTGVuZ3RoKQogeworICAgIC8vIERvIG5vdCBy ZXBsYWNlIHdpdGggUkVMRUFTRV9BU1NFUlQ7IHdlIHdhbnQgdG8gYXZvaWQgdGhlIHZpcnR1YWwg Ynl0ZUxlbmd0aCgpIGZ1bmN0aW9uIGNhbGwgaW4gcmVsZWFzZS4KICAgICBBU1NFUlRfV0lUSF9T RUNVUklUWV9JTVBMSUNBVElPTihidWZmZXJCeXRlTGVuZ3RoID09IGJ5dGVMZW5ndGgoKSk7CiAg ICAgaWYgKGJ5dGVPZmZzZXQgPiBidWZmZXJCeXRlTGVuZ3RoCiAgICAgICAgIHx8IGJ5dGVPZmZz ZXQgKyBkYXRhQnl0ZUxlbmd0aCA+IGJ1ZmZlckJ5dGVMZW5ndGgKQEAgLTE4MywxMyArMTg0LDE0 IEBAIGJvb2wgQXJyYXlCdWZmZXJWaWV3OjpzZXRSYW5nZUltcGwoY29uc3QgY2hhciogZGF0YSwg c2l6ZV90IGRhdGFCeXRlTGVuZ3RoLCB1bnNpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9 CiAKLSAgICBjaGFyKiBiYXNlID0gc3RhdGljX2Nhc3Q8Y2hhcio+KGJhc2VBZGRyZXNzKCkpOwor ICAgIHVpbnQ4X3QqIGJhc2UgPSBzdGF0aWNfY2FzdDx1aW50OF90Kj4oYmFzZUFkZHJlc3MoKSk7 CiAgICAgbWVtbW92ZShiYXNlICsgYnl0ZU9mZnNldCwgZGF0YSwgZGF0YUJ5dGVMZW5ndGgpOwog ICAgIHJldHVybiB0cnVlOwogfQogCi1ib29sIEFycmF5QnVmZmVyVmlldzo6Z2V0UmFuZ2VJbXBs KGNoYXIqIGRlc3RpbmF0aW9uLCBzaXplX3QgZGF0YUJ5dGVMZW5ndGgsIHVuc2lnbmVkIGJ5dGVP ZmZzZXQsIHVuc2lnbmVkIGJ1ZmZlckJ5dGVMZW5ndGgpCitib29sIEFycmF5QnVmZmVyVmlldzo6 Z2V0UmFuZ2VJbXBsKHZvaWQqIGRlc3RpbmF0aW9uLCBzaXplX3QgZGF0YUJ5dGVMZW5ndGgsIHVu c2lnbmVkIGJ5dGVPZmZzZXQsIHVuc2lnbmVkIGJ1ZmZlckJ5dGVMZW5ndGgpCiB7CisgICAgLy8g RG8gbm90IHJlcGxhY2Ugd2l0aCBSRUxFQVNFX0FTU0VSVDsgd2Ugd2FudCB0byBhdm9pZCB0aGUg dmlydHVhbCBieXRlTGVuZ3RoKCkgZnVuY3Rpb24gY2FsbCBpbiByZWxlYXNlLgogICAgIEFTU0VS VF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGJ1ZmZlckJ5dGVMZW5ndGggPT0gYnl0ZUxlbmd0 aCgpKTsKICAgICBpZiAoYnl0ZU9mZnNldCA+IGJ1ZmZlckJ5dGVMZW5ndGgKICAgICAgICAgfHwg Ynl0ZU9mZnNldCArIGRhdGFCeXRlTGVuZ3RoID4gYnVmZmVyQnl0ZUxlbmd0aApAQCAtMTk4LDcg KzIwMCw3IEBAIGJvb2wgQXJyYXlCdWZmZXJWaWV3OjpnZXRSYW5nZUltcGwoY2hhciogZGVzdGlu YXRpb24sIHNpemVfdCBkYXRhQnl0ZUxlbmd0aCwgdW5zCiAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICB9CiAKLSAgICBjaGFyKiBiYXNlID0gc3RhdGljX2Nhc3Q8Y2hhcio+KGJhc2VBZGRyZXNz KCkpOworICAgIGNvbnN0IHVpbnQ4X3QqIGJhc2UgPSBzdGF0aWNfY2FzdDxjb25zdCB1aW50OF90 Kj4oYmFzZUFkZHJlc3MoKSk7CiAgICAgbWVtbW92ZShkZXN0aW5hdGlvbiwgYmFzZSArIGJ5dGVP ZmZzZXQsIGRhdGFCeXRlTGVuZ3RoKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KQEAgLTIxMiw3ICsy MTQsNyBAQCBib29sIEFycmF5QnVmZmVyVmlldzo6emVyb1JhbmdlSW1wbCh1bnNpZ25lZCBieXRl T2Zmc2V0LCBzaXplX3QgcmFuZ2VCeXRlTGVuZ3RoKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgfQogICAgIAotICAgIGNoYXIqIGJhc2UgPSBzdGF0aWNfY2FzdDxjaGFyKj4oYmFzZUFkZHJl c3MoKSk7CisgICAgdWludDhfdCogYmFzZSA9IHN0YXRpY19jYXN0PHVpbnQ4X3QqPihiYXNlQWRk cmVzcygpKTsKICAgICBtZW1zZXQoYmFzZSArIGJ5dGVPZmZzZXQsIDAsIHJhbmdlQnl0ZUxlbmd0 aCk7CiAgICAgcmV0dXJuIHRydWU7CiB9Cg==