179960 2017-11-22 17:15:46 -0800 [WinCairo] WebPreferences IDL not regenerating 2017-11-24 11:53:26 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173352 InRadar P2 Normal --- 1 don.olmstead fujii commit-queue darin fujii lforschler webkit-bug-importer oldest_to_newest 1374315 0 don.olmstead 2017-11-22 17:15:46 -0800 There were issues when landing https://bugs.webkit.org/show_bug.cgi?id=179385 which point to the generated WebPreferences getting stale. This should be resolved to allow WinCairo to build after changes to the preferences. ..\..\Source\WebKitLegacy\win\WebView.cpp(5246): error C2039: 'visualViewportAPIEnabled': is not a member of 'IWebPreferencesPrivate6' See https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/8578/steps/compile-webkit/logs/stdio 1374322 1 fujii 2017-11-22 18:05:37 -0800 Looks like a similar issue with: Bug 173352 – [Win] WebKit shouldn't include the forwarding header of WebKit itself 1374502 2 327518 fujii 2017-11-23 18:52:21 -0800 Created attachment 327518 Patch 1374627 3 327518 commit-queue 2017-11-24 11:52:58 -0800 Comment on attachment 327518 Patch Clearing flags on attachment: 327518 Committed r225139: <https://trac.webkit.org/changeset/225139> 1374628 4 commit-queue 2017-11-24 11:53:00 -0800 All reviewed patches have been landed. Closing bug. 1374629 5 webkit-bug-importer 2017-11-24 11:53:26 -0800 <rdar://problem/35684422> 327518 2017-11-23 18:52:21 -0800 2017-11-24 11:52:58 -0800 Patch bug-179960-20171124115220.patch text/plain 1565 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCmluZGV4IGEzZjE4 YmRjNDJjYTY1YThkNGFjZTRjYjJhMmQyYzQ0OTVkOGI1NGUuLjA2MDdjMGVmMWI2OWVkMDU4NDEx ODVhMWM2MzBhODI3OTQyMTdlMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTctMTEtMjMgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+ CisKKyAgICAgICAgW1dpbkNhaXJvXSBXZWJQcmVmZXJlbmNlcyBJREwgbm90IHJlZ2VuZXJhdGlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5OTYw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0 TGVnYWN5IHNob3VsZG4ndCBpbmNsdWRlIHRoZSBmb3J3YXJkaW5nIGhlYWRlciBvZgorICAgICAg ICBXZWJLaXRMZWdhY3kgaXRzZWxmLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IEFkZCAk e0ZPUldBUkRJTkdfSEVBREVSU19ESVJ9IGFuZCByZW1vdmUKKyAgICAgICAgJHtGT1JXQVJESU5H X0hFQURFUlNfRElSfS9KYXZhU2NyaXB0Q29yZSBhbmQKKyAgICAgICAgJHtGT1JXQVJESU5HX0hF QURFUlNfRElSfS9XZWJLaXRMZWdhY3kgZnJvbQorICAgICAgICBXZWJLaXRMZWdhY3lfSU5DTFVE RV9ESVJFQ1RPUklFUy4KKwogMjAxNy0xMS0xNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBDb2NvYSBDRlVSTENvbm5lY3Rpb24g bG9hZGluZyBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L0NNYWtlTGlzdHMu dHh0IGIvU291cmNlL1dlYktpdExlZ2FjeS9DTWFrZUxpc3RzLnR4dAppbmRleCAzM2QwYTRkMWIy NDgyNDZiODE2ZmJkNzc0YmE3ZGQzOGNiMGM5MDE5Li4zNDY1NTkzYTI2Mjk4NDU4YmY1OWNhMzYw NzhhZTVhZDI0NGYwN2MzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L0NNYWtlTGlz dHMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ01ha2VMaXN0cy50eHQKQEAgLTIwLDkg KzIwLDggQEAgc2V0KFdlYktpdExlZ2FjeV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7Q01B S0VfQklOQVJZX0RJUn0iCiAgICAgIiR7V0VCS0lUTEVHQUNZX0RJUn0vU3RvcmFnZSIKICAgICAi JHtXRUJLSVRMRUdBQ1lfRElSfS9XZWJDb3JlU3VwcG9ydCIKLSAgICAiJHtGT1JXQVJESU5HX0hF QURFUlNfRElSfS9KYXZhU2NyaXB0Q29yZSIKKyAgICAiJHtGT1JXQVJESU5HX0hFQURFUlNfRElS fSIKICAgICAiJHtGT1JXQVJESU5HX0hFQURFUlNfRElSfS9XZWJDb3JlIgotICAgICIke0ZPUldB UkRJTkdfSEVBREVSU19ESVJ9L1dlYktpdExlZ2FjeSIKICkKIAogc2V0KFdlYktpdExlZ2FjeV9T WVNURU1fSU5DTFVERV9ESVJFQ1RPUklFUwo=