179951 2017-11-22 09:19:23 -0800 [WPE] Stop building Wayland in JHBuild moduleset 2017-11-30 07:01:58 -0800 1 1 1 Unclassified WebKit WPE WebKit Other PC Linux RESOLVED FIXED P2 Normal --- 178894 178896 1 mcatanzaro mcatanzaro bugs-noreply cgarcia clopez commit-queue mcatanzaro zan oldest_to_newest 1374206 0 mcatanzaro 2017-11-22 09:19:23 -0800 Upgrade Wayland in JHBuild moduleset. This is needed for EGLGetDisplay() to work on my computer. 1374207 1 cgarcia 2017-11-22 09:25:33 -0800 If I'm not wrong wayland is not needed at all to run the tests, becase we use the headless backend, so wayland is just a dep of dyz, and we don't need to build it ourselves, so I would just remove it from the jhbuild moduleset. Unless I'm missing something. . . 1374208 2 mcatanzaro 2017-11-22 09:29:17 -0800 Yes,since Wayland is not used for running tests, and since it does not seem to depend on anything in the JHBuild moduleset, I think we can remove it safely without having to worry that the system version of Wayland might use libraries in the jhbuild environment (which would be unsafe). 1374209 3 mcatanzaro 2017-11-22 09:29:39 -0800 It's also a dep of wpe-mesa, but that does not matter. It would only be a problem if the dependency was reversed. 1374210 4 327457 mcatanzaro 2017-11-22 09:35:04 -0800 Created attachment 327457 Patch 1374261 5 mcatanzaro 2017-11-22 11:55:14 -0800 Zan thinks Wayland can affect OpenGL tests, even using headless mode, so I'll upgrade it instead. 1374264 6 327468 mcatanzaro 2017-11-22 12:04:35 -0800 Created attachment 327468 Patch 1374294 7 327468 mcatanzaro 2017-11-22 15:01:23 -0800 Comment on attachment 327468 Patch Unsetting r? because Carlos Lopez thinks this is a bad idea. 1374295 8 327457 mcatanzaro 2017-11-22 15:05:54 -0800 Comment on attachment 327457 Patch Setting r? on this one, since I suspect this is the one we'll have to go with... even if it means we don't get consistent results for WebGL tests. (But I'm still not clear as to why Wayland would affect headless mode results.) 1374305 9 clopez 2017-11-22 16:24:02 -0800 (In reply to Michael Catanzaro from comment #5) > Zan thinks Wayland can affect OpenGL tests, even using headless mode, so > I'll upgrade it instead. mmmm... how this can happen? 1374307 10 mcatanzaro 2017-11-22 16:33:39 -0800 I don't know. 1375053 11 mcatanzaro 2017-11-27 12:22:45 -0800 (In reply to Carlos Alberto Lopez Perez from comment #9) > (In reply to Michael Catanzaro from comment #5) > > Zan thinks Wayland can affect OpenGL tests, even using headless mode, so > > I'll upgrade it instead. > > mmmm... how this can happen? Zan, any comment on this? If Wayland version can still somehow affect layout tests even though we now have headless mode, then I suggest we build Weston inside the JHBuild environment, and expect developers using the JHBuild environment to use that version of Weston. Otherwise, I think we should commit my patch to drop Wayland from the JHBuild environment. 1376115 12 mcatanzaro 2017-11-29 16:49:18 -0800 OK, I was supposed to ensure this didn't get stalled... r? 1376229 13 zan 2017-11-29 23:39:29 -0800 (In reply to Michael Catanzaro from comment #11) > (In reply to Carlos Alberto Lopez Perez from comment #9) > > (In reply to Michael Catanzaro from comment #5) > > > Zan thinks Wayland can affect OpenGL tests, even using headless mode, so > > > I'll upgrade it instead. > > > > mmmm... how this can happen? > > Zan, any comment on this? > It apparently never happened. False memories on my side. 1376305 14 327457 commit-queue 2017-11-30 07:01:56 -0800 Comment on attachment 327457 Patch Clearing flags on attachment: 327457 Committed r225327: <https://trac.webkit.org/changeset/225327> 1376306 15 commit-queue 2017-11-30 07:01:58 -0800 All reviewed patches have been landed. Closing bug. 327457 2017-11-22 09:35:04 -0800 2017-11-30 07:01:56 -0800 Patch bug-179951-20171122113503.patch text/plain 3867 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MDk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGQyYTIzYjViOWNlNzBmOTE2MjA1MTVkZjY3NDg1N2U5 YmI0NDU2My4uN2UxZjM1ZmViZmJmOTBjNWMyMDk3ZjMxNWFiNjNhY2Q3ZDdiNmZhZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE3LTExLTIyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXSBTdG9wIGJ1aWxkaW5nIFdheWxhbmQgaW4gSkhCdWlsZCBtb2R1 bGVzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTk1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNp bmNlIFdheWxhbmQgaXMgbm90IHVzZWQgZm9yIHJ1bm5pbmcgdGVzdHMsIGFuZCBzaW5jZSBpdCBk b2VzIG5vdCBzZWVtIHRvIGRlcGVuZCBvbgorICAgICAgICBhbnl0aGluZyBpbiB0aGUgSkhCdWls ZCBtb2R1bGVzZXQsIEkgdGhpbmsgd2UgY2FuIHJlbW92ZSBpdCBzYWZlbHkgd2l0aG91dCBoYXZp bmcgdG8gd29ycnkKKyAgICAgICAgdGhhdCB0aGUgc3lzdGVtIHZlcnNpb24gb2YgV2F5bGFuZCBt aWdodCB1c2UgbGlicmFyaWVzIGluIHRoZSBKSEJ1aWxkIGVudmlyb25tZW50ICh3aGljaAorICAg ICAgICB3b3VsZCBiZSB1bnNhZmUpLgorCisgICAgICAgICogd3BlL2luc3RhbGwtZGVwZW5kZW5j aWVzOiBJbnN0YWxsIFdheWxhbmQuCisgICAgICAgICogd3BlL2poYnVpbGQubW9kdWxlczogU3Rv cCBidWlsZGluZyBXYXlsYW5kLgorCiAyMDE3LTExLTIyICBDb21taXQgUXVldWUgIDxjb21taXQt cXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjI1 MDkzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzIGIvVG9vbHMv d3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzCmluZGV4IGU2Yzg3ODg3MmQ5MGU3OTUwYjc5NDc4MmI2 MzU4ODMyNmEyZjE0OWMuLmRiODE1YjkwOTFiN2Y4ZmIyOTVkODgwNTQ1ZGE0ODQyYjM5MTEyYjIg MTAwNzU1Ci0tLSBhL1Rvb2xzL3dwZS9pbnN0YWxsLWRlcGVuZGVuY2llcworKysgYi9Ub29scy93 cGUvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAgLTEyMiw2ICsxMjIsNyBAQCBmdW5jdGlvbiBpbnN0 YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAgICAgIGxpYnZweC1kZXYgXAogICAgICAgICBs aWJ4Y2IteGtiLWRldiBcCiAgICAgICAgIGxpYnhtbC1saWJ4bWwtcGVybCBcCisgICAgICAgIGxp YndheWxhbmQtZGV2IFwKICAgICAgICAgbHVhaml0IgogCiAgICAgIyBUaGVzZSBhcmUgZGVwZW5k ZW5jaWVzIG5lY2Vzc2FyeSBmb3IgdXNpbmcgd2Via2l0LXBhdGNoCkBAIC0yMTAsOCArMjExLDkg QEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhQYWNtYW4gewogICAgICAgICBtZXNh LWxpYmdsIFwKICAgICAgICAgb3B1cyBcCiAgICAgICAgIG9yYyBcCi0gICAgICAgIHBlcmwteG1s LWxpYnhtbFwKLSAgICAgICAgdjRsLXV0aWxzIgorICAgICAgICBwZXJsLXhtbC1saWJ4bWwgXAor ICAgICAgICB2NGwtdXRpbHMgXAorICAgICAgICB3YXlsYW5kIgogCiAgICAgIyBUaGVzZSBhcmUg ZGVwZW5kZW5jaWVzIG5lY2Vzc2FyeSBmb3IgdXNpbmcgd2Via2l0LXBhdGNoCiAgICAgcGFja2Fn ZXM9IiRwYWNrYWdlcyBcCkBAIC0yOTIsNyArMjk0LDggQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVu ZGVuY2llc1dpdGhEbmYgewogICAgICAgICBvcHVzLWRldmVsIFwKICAgICAgICAgb3JjLWRldmVs IFwKICAgICAgICAgcGVybC1YTUwtTGliWE1MIFwKLSAgICAgICAgcHVsc2VhdWRpby1saWJzLWRl dmVsIgorICAgICAgICBwdWxzZWF1ZGlvLWxpYnMtZGV2ZWwgXAorICAgICAgICB3YXlsYW5kLWRl dmVsIgogCiAgICAgIyBUaGVzZSBhcmUgZGVwZW5kZW5jaWVzIG5lY2Vzc2FyeSBmb3IgdXNpbmcg d2Via2l0LXBhdGNoCiAgICAgcGFja2FnZXM9IiRwYWNrYWdlcwpkaWZmIC0tZ2l0IGEvVG9vbHMv d3BlL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggNzBk OTgyMmJlNGUyYTExYmM2Y2U3ZWM3ZmY2ZTI4ZjdlZjg2MjE0Ny4uM2ZlMmFiNGUxMmRhOGVlZjYz NDFjMjNkODNlODUwOGEwNzI4ZmU2ZCAxMDA2NDQKLS0tIGEvVG9vbHMvd3BlL2poYnVpbGQubW9k dWxlcworKysgYi9Ub29scy93cGUvamhidWlsZC5tb2R1bGVzCkBAIC0xNiw3ICsxNiw2IEBACiAg ICAgICA8ZGVwIHBhY2thZ2U9ImZyZWV0eXBlNiIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJoYXJm YnV6eiIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJ4a2Jjb21tb24iLz4KLSAgICAgIDxkZXAgcGFj a2FnZT0id2F5bGFuZCIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJ3ZWJraXQtZ3N0cmVhbWVyLXRl c3RpbmctZGVwZW5kZW5jaWVzIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9IndwZSIvPgogICAgICAg PGRlcCBwYWNrYWdlPSJ3cGUtbWVzYSIvPgpAQCAtMzYsOCArMzUsNiBAQAogICAgICAgaHJlZj0i aHR0cDovL2NhaXJvZ3JhcGhpY3Mub3JnIi8+CiAgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwi IG5hbWU9ImZyZWVkZXNrdG9wLm9yZyIKICAgICAgIGhyZWY9Imh0dHA6Ly93d3cuZnJlZWRlc2t0 b3Aub3JnIi8+Ci0gIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9IndheWxhbmQuZnJl ZWRlc2t0b3Aub3JnIgotICAgICAgaHJlZj0iaHR0cDovL3dheWxhbmQuZnJlZWRlc2t0b3Aub3Jn Ii8+CiAgIDxyZXBvc2l0b3J5IHR5cGU9ImdpdCIgbmFtZT0iZ2l0aHViLmNvbSIKICAgICAgIGhy ZWY9Imh0dHBzOi8vZ2l0aHViLmNvbSIvPgogICA8cmVwb3NpdG9yeSB0eXBlPSJ0YXJiYWxsIiBu YW1lPSJnaXRodWItdGFyYmFsbCIKQEAgLTE2MSwxNCArMTU4LDYgQEAKICAgICAgICAgICAgIGhh c2g9InNoYTE6NzEyNzk5M2JmYjY5ZTEzY2RmZjI1ZmI4YjNjOGYyNmNlNmJlNWJmYSIvPgogICA8 L2F1dG90b29scz4KIAotICA8YXV0b3Rvb2xzIGlkPSJ3YXlsYW5kIgotICAgICAgICAgICAgIGF1 dG9nZW4tc2g9ImNvbmZpZ3VyZSIKLSAgICAgICAgICAgICBhdXRvZ2VuYXJncz0iLS1kaXNhYmxl LWRvY3VtZW50YXRpb24iPgotICAgIDxicmFuY2ggbW9kdWxlPSJyZWxlYXNlcy93YXlsYW5kLTEu MTAuMC50YXIueHoiIHZlcnNpb249IjEuMTAuMCIKLSAgICAgICAgICAgIHJlcG89IndheWxhbmQu ZnJlZWRlc2t0b3Aub3JnIgotICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjRiZjZlNzkwYWE2ZjUw YWIzODI1Njc2MjgyZWNkNzU4NTBlYzljNDc2N2FmOTZlY2I3MTI3YjFmM2MzZDYwZGMiLz4KLSAg PC9hdXRvdG9vbHM+Ci0KICAgPGNtYWtlIGlkPSJ3cGUiPgogICAgIDxicmFuY2ggcmVwbz0iZ2l0 aHViLmNvbSIgbW9kdWxlPSJXZWJQbGF0Zm9ybUZvckVtYmVkZGVkL1dQRUJhY2tlbmQuZ2l0Igog ICAgICAgICAgICAgdGFnPSIzMDEzZmFhZWJhYjQyZTdlZjc0OTdiMzg1MGEyOTAyOTc4ZWIzZDZm IiAvPgpAQCAtMTc4LDcgKzE2Nyw2IEBACiAgICAgPGRlcGVuZGVuY2llcz4KICAgICAgIDxkZXAg cGFja2FnZT0id3BlIiAvPgogICAgICAgPGRlcCBwYWNrYWdlPSJnbGliIiAvPgotICAgICAgPGRl cCBwYWNrYWdlPSJ3YXlsYW5kIiAvPgogICAgICAgPGRlcCBwYWNrYWdlPSJ4a2Jjb21tb24iIC8+ CiAgICAgPC9kZXBlbmRlbmNpZXM+CiAgICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1 bGU9IldlYlBsYXRmb3JtRm9yRW1iZWRkZWQvV1BFQmFja2VuZC1tZXNhLmdpdCIK 327468 2017-11-22 12:04:35 -0800 2017-11-22 15:01:23 -0800 Patch bug-179951-20171122140434.patch text/plain 1433 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MDk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGQyYTIzYjViOWNlNzBmOTE2MjA1MTVkZjY3NDg1N2U5 YmI0NDU2My4uOTZmNWNhZjJkYzM2NWQzYmZkNjY3Mjc3M2FhZmQzNDgzZGQ1ZjAxOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE3LTExLTIyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXSBVcGdyYWRlIFdheWxhbmQgaW4gSkhCdWlsZCBtb2R1bGVzZXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTk1MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZ3JhZGUg V2F5bGFuZCB0byAxLjE0LjAuIFRoaXMgaXMgbmVlZGVkIGZvciBFR0wgdG8gd29yayBvbiBteSBj b21wdXRlci4KKworICAgICAgICAqIHdwZS9qaGJ1aWxkLm1vZHVsZXM6CisKIDIwMTctMTEtMjIg IENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMjUwOTMuCmRpZmYgLS1naXQgYS9Ub29scy93cGUvamhidWls ZC5tb2R1bGVzIGIvVG9vbHMvd3BlL2poYnVpbGQubW9kdWxlcwppbmRleCA3MGQ5ODIyYmU0ZTJh MTFiYzZjZTdlYzdmZjZlMjhmN2VmODYyMTQ3Li5mN2JhMWE2YjJiOWQ0NGNhYTM2MWE0MTMxNjAw ZmUwZjA4MjZkZWRkIDEwMDY0NAotLS0gYS9Ub29scy93cGUvamhidWlsZC5tb2R1bGVzCisrKyBi L1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKQEAgLTE2NCw5ICsxNjQsOSBAQAogICA8YXV0b3Rv b2xzIGlkPSJ3YXlsYW5kIgogICAgICAgICAgICAgIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSIKICAg ICAgICAgICAgICBhdXRvZ2VuYXJncz0iLS1kaXNhYmxlLWRvY3VtZW50YXRpb24iPgotICAgIDxi cmFuY2ggbW9kdWxlPSJyZWxlYXNlcy93YXlsYW5kLTEuMTAuMC50YXIueHoiIHZlcnNpb249IjEu MTAuMCIKKyAgICA8YnJhbmNoIG1vZHVsZT0icmVsZWFzZXMvd2F5bGFuZC0ke3ZlcnNpb259LnRh ci54eiIgdmVyc2lvbj0iMS4xNC4wIgogICAgICAgICAgICAgcmVwbz0id2F5bGFuZC5mcmVlZGVz a3RvcC5vcmciCi0gICAgICAgICAgICBoYXNoPSJzaGEyNTY6NGJmNmU3OTBhYTZmNTBhYjM4MjU2 NzYyODJlY2Q3NTg1MGVjOWM0NzY3YWY5NmVjYjcxMjdiMWYzYzNkNjBkYyIvPgorICAgICAgICAg ICAgaGFzaD0ic2hhMjU2OmVkODBjYWJjMDk2MWE3NTlhNDIwOTJlMmMzOWFhYmZjMWVjOWExM2M4 NmM5OGJiZTJiODEyZjAwOGRhMjdhYjgiLz4KICAgPC9hdXRvdG9vbHM+CiAKICAgPGNtYWtlIGlk PSJ3cGUiPgo=