179940 2017-11-22 03:49:55 -0800 WebDriver: add timeout option to run-webdriver-tests script 2017-11-28 04:46:31 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg clopez ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1374166 0 cgarcia 2017-11-22 03:49:55 -0800 We need to support timeouts to be able to run the tests in the bots. 1374167 1 327449 cgarcia 2017-11-22 03:55:31 -0800 Created attachment 327449 Patch 1374168 2 ews-watchlist 2017-11-22 03:58:07 -0800 Attachment 327449 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:44: No name 'pytest_timeout' in module 'webkitpy.thirdparty.autoinstalled' [pylint/E0611] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:141: [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'do_wdspec' member [pylint/E1101] [5] ERROR: Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:141: [WebDriverW3CExecutor.run] Instance of 'WebDriverW3CExecutor' has no 'protocol' member [pylint/E1101] [5] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 1375309 3 cgarcia 2017-11-28 04:45:38 -0800 Committed r225211: <https://trac.webkit.org/changeset/225211> 1375310 4 webkit-bug-importer 2017-11-28 04:46:31 -0800 <rdar://problem/35720714> 327449 2017-11-22 03:55:31 -0800 2017-11-28 04:04:12 -0800 Patch wd-test-timeouts.diff text/plain 6558 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZDg1 YWYwZmVjNS4uZjlhYjhhZDM4ODkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxNy0xMS0yMiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViRHJpdmVyOiBhZGQg dGltZW91dCBvcHRpb24gdG8gcnVuLXdlYmRyaXZlci10ZXN0cyBzY3JpcHQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTk0MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gaGFuZGxlIHRp bWVvdXRzIHRvIGJlIGFibGUgdG8gcnVuIHRoZSB0ZXN0cyBpbiB0aGUgYm90cy4gcHl0ZXN0IGRv ZXNuJ3Qgc3VwcG9ydCB0aW1lb3V0cywgYnV0IHRoZXJlJ3MKKyAgICAgICAgYSBwbHVnaW4gcHl0 ZXN0X3RpbWVvdXQgdGhhdCBjYW4gYmUgdXNlZCBmb3IgdGhhdC4KKworICAgICAgICAqIFNjcmlw dHMvcnVuLXdlYmRyaXZlci10ZXN0czogQWRkIC0tdGltZW91dCBjb21tYW5kIGxpbmUgb3B0aW9u LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weToKKyAg ICAgICAgKEF1dG9pbnN0YWxsSW1wb3J0SG9vay5maW5kX21vZHVsZSk6IENoZWNrIGlmIHB5dGVz dF90aW1lb3V0IGlzIGltcG9ydGVkIHRvIGluc3RhbGwgaXQuCisgICAgICAgIChBdXRvaW5zdGFs bEltcG9ydEhvb2suX2luc3RhbGxfcHl0ZXN0X3RpbWVvdXQpOiBJbnN0YWxsIHB5dGVzdF90aW1l b3V0IGZyb20gcHlwaS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3dlYmRyaXZlcl90ZXN0 cy93ZWJkcml2ZXJfdGVzdF9ydW5uZXJfdzNjLnB5OgorICAgICAgICAoV2ViRHJpdmVyVGVzdFJ1 bm5lclczQy5fX2luaXRfXyk6IFNldCBQWVRFU1RfVElNRU9VVCBlbnYgdmFyIHdpdGggdGhlIHRp bWVvdXQgZ2l2ZW4uCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMv d2ViZHJpdmVyX3czY19leGVjdXRvci5weToKKyAgICAgICAgKFdlYkRyaXZlclczQ0V4ZWN1dG9y LnJ1bik6IENsYXJpZnkgdGhhdCB0aGUgdGltZW91dCByZWNlaXZlZCBieSBkb193ZHNwZWMoKSBp cyBpZ25vcmVkLCBhbmQgcGFzcyAwIGluc3RlYWQgb2YgMjUuCisKIDIwMTctMTEtMjEgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIFJ1 biB1bml0IHRlc3RzIGluIHRoZSBib3RzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi13 ZWJkcml2ZXItdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJkcml2ZXItdGVzdHMKaW5kZXgg Zjc1MzRhYzVlY2MuLjJlNjAxY2Y2MzNmIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi13 ZWJkcml2ZXItdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4td2ViZHJpdmVyLXRlc3RzCkBA IC00NSw2ICs0NSw4IEBAIG9wdGlvbl9wYXJzZXIuYWRkX29wdGlvbignLS1yZWxlYXNlJywgYWN0 aW9uPSdzdG9yZV9jb25zdCcsIGNvbnN0PSdSZWxlYXNlJywgZGVzCiAgICAgICAgICAgICAgICAg ICAgICAgICAgaGVscD0nU2V0IHRoZSBjb25maWd1cmF0aW9uIHRvIFJlbGVhc2UnKQogb3B0aW9u X3BhcnNlci5hZGRfb3B0aW9uKCctLWRlYnVnJywgYWN0aW9uPSdzdG9yZV9jb25zdCcsIGNvbnN0 PSdEZWJ1ZycsIGRlc3Q9ImNvbmZpZ3VyYXRpb24iLAogICAgICAgICAgICAgICAgICAgICAgICAg IGhlbHA9J1NldCB0aGUgY29uZmlndXJhdGlvbiB0byBEZWJ1ZycpCitvcHRpb25fcGFyc2VyLmFk ZF9vcHRpb24oJy0tdGltZW91dCcsIGFjdGlvbj0nc3RvcmUnLCB0eXBlPSdpbnQnLCBkZXN0PSd0 aW1lb3V0JywgZGVmYXVsdD0xMCwKKyAgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSdUaW1l IGluIHNlY29uZHMgdW50aWwgYSB0ZXN0IHRpbWVzIG91dCAodXNlIDAgdG8gZGlzYWJsZSknKQog b3B0aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctLWRpc3BsYXktc2VydmVyJywgY2hvaWNlcz1bJ3h2 ZmInLCAneG9yZycsICd3ZXN0b24nLCAnd2F5bGFuZCddLCBkZWZhdWx0PSd4dmZiJywKICAgICAg ICAgICAgICAgICAgICAgICAgICBoZWxwPScieHZmYiI6IFVzZSBhIHZpcnR1YWxpemVkIFgxMSBz ZXJ2ZXIuICJ4b3JnIjogVXNlIHRoZSBjdXJyZW50IFgxMSBzZXNzaW9uLiAnCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnIndlc3RvbiI6IFVzZSBhIHZpcnR1YWxpemVkIFdlc3RvbiBz ZXJ2ZXIuICJ3YXlsYW5kIjogVXNlIHRoZSBjdXJyZW50IHdheWxhbmQgc2Vzc2lvbi4nKQpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5CmluZGV4IDc0MmZj Mjk2ZWU5Li5kNzBjMWJmYjliMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 aGlyZHBhcnR5L19faW5pdF9fLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRw YXJ0eS9fX2luaXRfXy5weQpAQCAtMTEwLDYgKzExMCw4IEBAIGNsYXNzIEF1dG9pbnN0YWxsSW1w b3J0SG9vayhvYmplY3QpOgogICAgICAgICAgICAgc2VsZi5faW5zdGFsbF9tb3psb2coKQogICAg ICAgICBlbGlmICcubW96cHJvY2VzcycgaW4gZnVsbG5hbWU6CiAgICAgICAgICAgICBzZWxmLl9p bnN0YWxsX21venByb2Nlc3MoKQorICAgICAgICBlbGlmICcucHl0ZXN0X3RpbWVvdXQnIGluIGZ1 bGxuYW1lOgorICAgICAgICAgICAgc2VsZi5faW5zdGFsbF9weXRlc3RfdGltZW91dCgpCiAKICAg ICBkZWYgX2luc3RhbGxfbWVjaGFuaXplKHNlbGYpOgogICAgICAgICBzZWxmLl9pbnN0YWxsKCJo dHRwczovL3B5cGkucHl0aG9uLm9yZy9wYWNrYWdlcy9zb3VyY2UvbS9tZWNoYW5pemUvbWVjaGFu aXplLTAuMi41LnRhci5neiIsCkBAIC0xMzMsNiArMTM1LDEwIEBAIGNsYXNzIEF1dG9pbnN0YWxs SW1wb3J0SG9vayhvYmplY3QpOgogICAgICAgICBzZWxmLl9pbnN0YWxsKCJodHRwczovL3B5cGku cHl0aG9uLm9yZy9wYWNrYWdlcy9jYi8yNi8xNDRkYmMyOGQxZjQwZTM5MmY4YTBjYmVlNzcxYmE2 MjRhNjEwMTdmMDE2Yzc3YWQ4ODQyNGQ4NGIyMzAvbW96cHJvY2Vzcy0wLjI1LnRhci5neiNtZDU9 MDdhMDRlNmFlMWE3MDU3MDVlNGI0NDk2OWZlN2ExODIiLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIm1venByb2Nlc3MtMC4yNS9tb3pwcm9jZXNzIikKIAorICAgIGRlZiBfaW5zdGFs bF9weXRlc3RfdGltZW91dChzZWxmKToKKyAgICAgICAgc2VsZi5faW5zdGFsbCgiaHR0cHM6Ly9w eXBpLnB5dGhvbi5vcmcvcGFja2FnZXMvY2MvYjcvYjJhNjEzNjVlYTZiNmQyZTg4ODEzNjBhZTdl ZDhkYWQwMzI3YWQyZGY4OWYyZjBiZTRhMDIzMDRkZWIyL3B5dGVzdC10aW1lb3V0LTEuMi4wLnRh ci5neiNtZDU9ODM2MDdkOTFhYTE2MzU2MmM3ZWU4MzVkYTU3ZDA2MWQiLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgInB5dGVzdC10aW1lb3V0LTEuMi4wL3B5dGVzdF90aW1lb3V0LnB5 IikKKwogICAgIGRlZiBfaW5zdGFsbF9weWxpbnQoc2VsZik6CiAgICAgICAgIHNlbGYuX2Vuc3Vy ZV9hdXRvaW5zdGFsbGVkX2Rpcl9pc19pbl9zeXNfcGF0aCgpCiAgICAgICAgIGlmIChub3Qgc2Vs Zi5fZnMuZXhpc3RzKHNlbGYuX2ZzLmpvaW4oX0FVVE9JTlNUQUxMRURfRElSLCAicHlsaW50Iikp IG9yCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3dlYmRyaXZlcl90ZXN0cy93 ZWJkcml2ZXJfdGVzdF9ydW5uZXJfdzNjLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93ZWJk cml2ZXJfdGVzdHMvd2ViZHJpdmVyX3Rlc3RfcnVubmVyX3czYy5weQppbmRleCA2YzlhYjE0ZDZm MS4uMGJkZDkzZjBkNDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvd2ViZHJp dmVyX3Rlc3RzL3dlYmRyaXZlcl90ZXN0X3J1bm5lcl93M2MucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX3Rlc3RfcnVubmVyX3czYy5weQpA QCAtNDQsNiArNDQsMTAgQEAgY2xhc3MgV2ViRHJpdmVyVGVzdFJ1bm5lclczQyhvYmplY3QpOgog ICAgICAgICBfbG9nLmluZm8oJ1VzaW5nIGRyaXZlciBhdCAlcycgJSAoc2VsZi5fZHJpdmVyLmJp bmFyeV9wYXRoKCkpKQogICAgICAgICBfbG9nLmluZm8oJ0Jyb3dzZXI6ICVzJyAlIChzZWxmLl9k cml2ZXIuYnJvd3Nlcl9uYW1lKCkpKQogCisgICAgICAgIHRpbWVvdXQgPSBzZWxmLl9wb3J0Lmdl dF9vcHRpb24oJ3RpbWVvdXQnKQorICAgICAgICBpZiB0aW1lb3V0ID4gMDoKKyAgICAgICAgICAg IG9zLmVudmlyb25bJ1BZVEVTVF9USU1FT1VUJ10gPSBzdHIodGltZW91dCkKKwogICAgICAgICBz ZWxmLl9yZXN1bHRzID0gW10KICAgICAgICAgc2VsZi5fc2VydmVyID0gV2ViRHJpdmVyVzNDV2Vi U2VydmVyKHNlbGYuX3BvcnQpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv d2ViZHJpdmVyX3Rlc3RzL3dlYmRyaXZlcl93M2NfZXhlY3V0b3IucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3dlYmRyaXZlcl90ZXN0cy93ZWJkcml2ZXJfdzNjX2V4ZWN1dG9yLnB5CmluZGV4 IDkzNTE3YmQ1MmJmLi45NTNhMDA1MGZlMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX3czY19leGVjdXRvci5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3dlYmRyaXZlcl90ZXN0cy93ZWJkcml2ZXJfdzNjX2V4ZWN1dG9y LnB5CkBAIC00MSw2ICs0MSw3IEBAIF9lbnN1cmVfZGlyZWN0b3J5X2luX3BhdGgob3MucGF0aC5q b2luKHczY190b29sc19kaXIsICd3ZWJkcml2ZXInKSkKIF9lbnN1cmVfZGlyZWN0b3J5X2luX3Bh dGgob3MucGF0aC5qb2luKHczY190b29sc19kaXIsICd3cHRydW5uZXInKSkKIF9lbnN1cmVfZGly ZWN0b3J5X2luX3BhdGgob3MucGF0aC5qb2luKHczY190b29sc19kaXIsICJ3ZWJkcml2ZXIiKSkK IAoraW1wb3J0IHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5weXRlc3RfdGltZW91 dAogZnJvbSB3cHRydW5uZXIuZXhlY3V0b3JzLmJhc2UgaW1wb3J0IFdkc3BlY0V4ZWN1dG9yLCBX ZWJEcml2ZXJQcm90b2NvbAogZnJvbSB3cHRydW5uZXIud2ViZHJpdmVyX3NlcnZlciBpbXBvcnQg V2ViRHJpdmVyU2VydmVyCiAKQEAgLTEzNiw0ICsxMzcsNSBAQCBjbGFzcyBXZWJEcml2ZXJXM0NF eGVjdXRvcihXZHNwZWNFeGVjdXRvcik6CiAgICAgICAgIHNlbGYucHJvdG9jb2wudGVhcmRvd24o KQogCiAgICAgZGVmIHJ1bihzZWxmLCBwYXRoKToKLSAgICAgICAgcmV0dXJuIHNlbGYuZG9fd2Rz cGVjKHNlbGYucHJvdG9jb2wuc2Vzc2lvbl9jb25maWcsIHBhdGgsIDI1KQorICAgICAgICAjIFRp bWVvdXQgaGVyZSBkb2Vzbid0IHJlYWxseSBtYXR0ZXIgYmVjYXVzZSBpdCdzIGlnbm9yZWQsIHNv IHdlIHBhc3MgMC4KKyAgICAgICAgcmV0dXJuIHNlbGYuZG9fd2RzcGVjKHNlbGYucHJvdG9jb2wu c2Vzc2lvbl9jb25maWcsIHBhdGgsIDApCmRpZmYgLS1naXQgYS9XZWJEcml2ZXJUZXN0cy9DaGFu Z2VMb2cgYi9XZWJEcml2ZXJUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTJmZDFmZjA1OTIuLjVjYWIy NWRjYWFkIDEwMDY0NAotLS0gYS9XZWJEcml2ZXJUZXN0cy9DaGFuZ2VMb2cKKysrIGIvV2ViRHJp dmVyVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTEtMjIgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFdlYkRyaXZlcjog YWRkIHRpbWVvdXQgb3B0aW9uIHRvIHJ1bi13ZWJkcml2ZXItdGVzdHMgc2NyaXB0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk5NDAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBiYXNlIGNvbmZ0 ZXN0LnB5IHRvIGxvYWQgcHl0ZXN0X3RpbWVvdXQgcGx1Z2luLgorCisgICAgICAgICogaW1wb3J0 ZWQvdzNjL2NvbmZ0ZXN0LnB5OiBBZGRlZC4KKwogMjAxNy0xMS0yMSAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRl IFczQyBXZWJEcml2ZXIgaW1wb3J0ZWQgdGVzdHMuCmRpZmYgLS1naXQgYS9XZWJEcml2ZXJUZXN0 cy9pbXBvcnRlZC93M2MvY29uZnRlc3QucHkgYi9XZWJEcml2ZXJUZXN0cy9pbXBvcnRlZC93M2Mv Y29uZnRlc3QucHkKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjkxMDFl NTUxMDMwCi0tLSAvZGV2L251bGwKKysrIGIvV2ViRHJpdmVyVGVzdHMvaW1wb3J0ZWQvdzNjL2Nv bmZ0ZXN0LnB5CkBAIC0wLDAgKzEgQEAKK3B5dGVzdF9wbHVnaW5zID0gJ3B5dGVzdF90aW1lb3V0 JywK