179931 2017-11-21 16:05:47 -0800 WebCoreObjCExtras.h is being included in too many places 2017-11-22 11:45:18 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned aboxhall achristensen apinheiro ap cfleizach chris.reid commit-queue darin dmazzoni don.olmstead ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1374109 0 chris.reid 2017-11-21 16:05:47 -0800 It looks like WebCoreObjCExtras had more functionality which has since been removed without the includes being updated. 1374229 1 327461 chris.reid 2017-11-22 10:34:09 -0800 Created attachment 327461 Patch 1374254 2 327461 commit-queue 2017-11-22 11:45:00 -0800 Comment on attachment 327461 Patch Clearing flags on attachment: 327461 Committed r225100: <https://trac.webkit.org/changeset/225100> 1374255 3 commit-queue 2017-11-22 11:45:02 -0800 All reviewed patches have been landed. Closing bug. 1374256 4 webkit-bug-importer 2017-11-22 11:45:18 -0800 <rdar://problem/35669308> 327461 2017-11-22 10:34:09 -0800 2017-11-22 11:45:00 -0800 Patch 179931.diff text/plain 7234 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZTFkZWMwMjBhOS4uYjI3MWZlNjFjNWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0xMS0yMSAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgV2ViQ29yZU9iakNFeHRyYXMuaCBpcyBiZWluZyBpbmNsdWRlZCBp biB0b28gbWFueSBwbGFjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3OTkzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAg Rml4aW5nIGNhc2VzIHdoZXJlIFdlYkNvcmVPYmpDRXh0cmFzLmggaXMgaW1wb3J0ZWQgYnV0IG5v dCB1c2VkLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJCYXNlLm1tOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vz c2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9XZWJD b3JlTlNVUkxFeHRyYXMubW06CisKIDIwMTctMTEtMjEgIENocmlzdG9waGVyIFJlaWQgIDxjaHJp cy5yZWlkQHNvbnkuY29tPgogCiAgICAgICAgIFtQQUxdIFJlbW92ZSBGaWxlU3lzdGVtJ3MgZGVw ZW5kZW5jeSBvbiBXZWJDb3JlTlNTdHJpbmdFeHRyYXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQmFzZS5t bSBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmpl Y3RXcmFwcGVyQmFzZS5tbQppbmRleCA0MmNkMDE5NGY0Yy4uYmQyNTdkYzdlZjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmpl Y3RXcmFwcGVyQmFzZS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckJhc2UubW0KQEAgLTYxLDcgKzYxLDYgQEAKICNp bXBvcnQgIlRleHRDaGVja2luZ0hlbHBlci5oIgogI2ltcG9ydCAiVmlzaWJsZVVuaXRzLmgiCiAj aW1wb3J0ICJXZWJDb3JlRnJhbWVWaWV3LmgiCi0jaW1wb3J0ICJXZWJDb3JlT2JqQ0V4dHJhcy5o IgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3Np YmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv bWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tCmluZGV4IGU2MmE2NWY5NGZh Li43ZmRlNWYzNTM4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9t YWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0K QEAgLTc3LDcgKzc3LDYgQEAKICNpbXBvcnQgIlRleHRJdGVyYXRvci5oIgogI2ltcG9ydCAiVmlz aWJsZVVuaXRzLmgiCiAjaW1wb3J0ICJXZWJDb3JlRnJhbWVWaWV3LmgiCi0jaW1wb3J0ICJXZWJD b3JlT2JqQ0V4dHJhcy5oIgogI2ltcG9ydCA8cGFsL3NwaS9tYWMvSElTZXJ2aWNlc1NQSS5oPgog I2ltcG9ydCA8cGFsL3NwaS9tYWMvTlNBY2Nlc3NpYmlsaXR5U1BJLmg+CiAjaW1wb3J0IDx3dGYv T2JqY1J1bnRpbWVFeHRyYXMuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9XZWJDb3JlTlNVUkxFeHRyYXMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv V2ViQ29yZU5TVVJMRXh0cmFzLm1tCmluZGV4IGEzNDBkYjIwZTYzLi5lNmMwOGY0MzIzNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVOU1VSTEV4dHJhcy5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZU5TVVJMRXh0cmFzLm1t CkBAIC0yOCw3ICsyOCw2IEBACiAKICNpbXBvcnQgImNvbmZpZy5oIgogI2ltcG9ydCAiVVJMUGFy c2VyLmgiCi0jaW1wb3J0ICJXZWJDb3JlT2JqQ0V4dHJhcy5oIgogI2ltcG9ydCAiV2ViQ29yZU5T VVJMRXh0cmFzLmgiCiAjaW1wb3J0IDx3dGYvRnVuY3Rpb24uaD4KICNpbXBvcnQgPHd0Zi9IZXhO dW1iZXIuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwppbmRleCBlY2RiODZlYTM2Yi4uZjM3 MGQxZmI4MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAor MjAxNy0xMS0yMSAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29ueS5jb20+CisKKyAg ICAgICAgV2ViQ29yZU9iakNFeHRyYXMuaCBpcyBiZWluZyBpbmNsdWRlZCBpbiB0b28gbWFueSBw bGFjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTkzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog UGx1Z2lucy9Ib3N0ZWQvV2ViSG9zdGVkTmV0c2NhcGVQbHVnaW5WaWV3Lm1tOgorICAgICAgICAq IFBsdWdpbnMvV2ViQmFzZU5ldHNjYXBlUGx1Z2luVmlldy5tbToKKyAgICAgICAgKiBQbHVnaW5z L1dlYkJhc2VQbHVnaW5QYWNrYWdlLm1tOgorICAgICAgICAqIFBsdWdpbnMvV2ViTmV0c2NhcGVQ bHVnaW5TdHJlYW0ubW06CisgICAgICAgICogUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblZpZXcu bW06CisgICAgICAgICogV2ViVmlldy9XZWJUZXh0SXRlcmF0b3IubW06CisgICAgICAgICogV2Vi Vmlldy9XZWJWaWV3RGF0YS5tbToKKwogMjAxNy0xMS0yMSAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNo cmlzLnJlaWRAc29ueS5jb20+CiAKICAgICAgICAgW1BBTF0gUmVtb3ZlIEZpbGVTeXN0ZW0ncyBk ZXBlbmRlbmN5IG9uIFdlYkNvcmVOU1N0cmluZ0V4dHJhcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdExlZ2FjeS9tYWMvUGx1Z2lucy9Ib3N0ZWQvV2ViSG9zdGVkTmV0c2NhcGVQbHVnaW5WaWV3 Lm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lucy9Ib3N0ZWQvV2ViSG9zdGVkTmV0 c2NhcGVQbHVnaW5WaWV3Lm1tCmluZGV4IGY5NDk4ZDhlMmM0Li43ZTQ0YjMzZTMxYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lucy9Ib3N0ZWQvV2ViSG9zdGVkTmV0 c2NhcGVQbHVnaW5WaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMv SG9zdGVkL1dlYkhvc3RlZE5ldHNjYXBlUGx1Z2luVmlldy5tbQpAQCAtNDYsNyArNDYsNiBAQAog I2ltcG9ydCA8V2ViQ29yZS9SZW5kZXJFbWJlZGRlZE9iamVjdC5oPgogI2ltcG9ydCA8V2ViQ29y ZS9SZXNvdXJjZUVycm9yLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1dlYkNvcmVDQUxheWVyRXh0cmFz Lmg+Ci0jaW1wb3J0IDxXZWJDb3JlL1dlYkNvcmVPYmpDRXh0cmFzLmg+CiAjaW1wb3J0IDxXZWJD b3JlL3J1bnRpbWVfcm9vdC5oPgogI2ltcG9ydCA8cGFsL3NwaS9jb2NvYS9RdWFydHpDb3JlU1BJ Lmg+CiAjaW1wb3J0IDxydW50aW1lL0luaXRpYWxpemVUaHJlYWRpbmcuaD4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMvV2ViQmFzZU5ldHNjYXBlUGx1Z2luVmll dy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMvV2ViQmFzZU5ldHNjYXBlUGx1 Z2luVmlldy5tbQppbmRleCAyZTVkYmJlMGViMS4uNzRlNzljMGRlNGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMvV2ViQmFzZU5ldHNjYXBlUGx1Z2luVmlldy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5zL1dlYkJhc2VOZXRzY2FwZVBs dWdpblZpZXcubW0KQEAgLTUxLDcgKzUxLDYgQEAKICNpbXBvcnQgPFdlYkNvcmUvUmVuZGVyRW1i ZWRkZWRPYmplY3QuaD4KICNpbXBvcnQgPFdlYkNvcmUvUmVuZGVyVmlldy5oPgogI2ltcG9ydCA8 V2ViQ29yZS9TZWN1cml0eU9yaWdpbi5oPgotI2ltcG9ydCA8V2ViQ29yZS9XZWJDb3JlT2JqQ0V4 dHJhcy5oPgogI2ltcG9ydCA8V2ViS2l0TGVnYWN5L0RPTVByaXZhdGUuaD4KICNpbXBvcnQgPHBh bC9zcGkvY2cvQ29yZUdyYXBoaWNzU1BJLmg+CiAjaW1wb3J0IDxydW50aW1lL0luaXRpYWxpemVU aHJlYWRpbmcuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMv V2ViQmFzZVBsdWdpblBhY2thZ2UubW0gYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5z L1dlYkJhc2VQbHVnaW5QYWNrYWdlLm1tCmluZGV4IGNhMjAzMTMwMDk3Li44NTkxMmMxMzA2MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lucy9XZWJCYXNlUGx1Z2lu UGFja2FnZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5zL1dlYkJhc2VQ bHVnaW5QYWNrYWdlLm1tCkBAIC0zMyw3ICszMyw2IEBACiAjaW1wb3J0ICJXZWJOZXRzY2FwZVBs dWdpblBhY2thZ2UuaCIKICNpbXBvcnQgIldlYlBsdWdpblBhY2thZ2UuaCIKICNpbXBvcnQgIldl YlR5cGVzSW50ZXJuYWwuaCIKLSNpbXBvcnQgPFdlYkNvcmUvV2ViQ29yZU9iakNFeHRyYXMuaD4K ICNpbXBvcnQgPGFsZ29yaXRobT4KICNpbXBvcnQgPG1hY2gtby9hcmNoLmg+CiAjaW1wb3J0IDxt YWNoLW8vZmF0Lmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5z L1dlYk5ldHNjYXBlUGx1Z2luU3RyZWFtLm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1 Z2lucy9XZWJOZXRzY2FwZVBsdWdpblN0cmVhbS5tbQppbmRleCA5MzBkZjNkNDAxMS4uMjFmZjBl Mjg0ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1BsdWdpbnMvV2ViTmV0 c2NhcGVQbHVnaW5TdHJlYW0ubW0KKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvUGx1Z2lu cy9XZWJOZXRzY2FwZVBsdWdpblN0cmVhbS5tbQpAQCAtNDksNyArNDksNiBAQAogI2ltcG9ydCA8 V2ViQ29yZS9QbGF0Zm9ybVN0cmF0ZWdpZXMuaD4KICNpbXBvcnQgPFdlYkNvcmUvU2VjdXJpdHlP cmlnaW4uaD4KICNpbXBvcnQgPFdlYkNvcmUvU2VjdXJpdHlQb2xpY3kuaD4KLSNpbXBvcnQgPFdl YkNvcmUvV2ViQ29yZU9iakNFeHRyYXMuaD4KICNpbXBvcnQgPFdlYkNvcmUvV2ViQ29yZVVSTFJl c3BvbnNlLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oPgogI2ltcG9ydCA8 cnVudGltZS9KU0xvY2suaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1Bs dWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMv UGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpblZpZXcubW0KaW5kZXggYWY3YmFjMTBlMGUuLjE0ZjBk Mjk1NThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5zL1dlYk5l dHNjYXBlUGx1Z2luVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9QbHVnaW5z L1dlYk5ldHNjYXBlUGx1Z2luVmlldy5tbQpAQCAtNjYsNyArNjYsNiBAQAogI2ltcG9ydCA8V2Vi Q29yZS9TY3JpcHRDb250cm9sbGVyLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1NlY3VyaXR5T3JpZ2lu Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL1VzZXJHZXN0dXJlSW5kaWNhdG9yLmg+Ci0jaW1wb3J0IDxX ZWJDb3JlL1dlYkNvcmVPYmpDRXh0cmFzLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1dlYkNvcmVVUkxS ZXNwb25zZS5oPgogI2ltcG9ydCA8V2ViQ29yZS9ucHJ1bnRpbWVfaW1wbC5oPgogI2ltcG9ydCA8 V2ViQ29yZS9ydW50aW1lX3Jvb3QuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kv bWFjL1dlYlZpZXcvV2ViVGV4dEl0ZXJhdG9yLm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMv V2ViVmlldy9XZWJUZXh0SXRlcmF0b3IubW0KaW5kZXggMDA3OWNkYWM3ZWUuLjNiNDBkNjEzNGYw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlRleHRJdGVy YXRvci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlRleHRJdGVy YXRvci5tbQpAQCAtMjksNyArMjksNiBAQAogI2ltcG9ydCAiRE9NUmFuZ2VJbnRlcm5hbC5oIgog I2ltcG9ydCAiV2ViVHlwZXNJbnRlcm5hbC5oIgogI2ltcG9ydCA8V2ViQ29yZS9UZXh0SXRlcmF0 b3IuaD4KLSNpbXBvcnQgPFdlYkNvcmUvV2ViQ29yZU9iakNFeHRyYXMuaD4KICNpbXBvcnQgPHJ1 bnRpbWUvSW5pdGlhbGl6ZVRocmVhZGluZy5oPgogI2ltcG9ydCA8d3RmL01haW5UaHJlYWQuaD4K ICNpbXBvcnQgPHd0Zi9SdW5Mb29wLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5 L21hYy9XZWJWaWV3L1dlYlZpZXdEYXRhLm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2Vi Vmlldy9XZWJWaWV3RGF0YS5tbQppbmRleCBmOTMwZmE5NmM4OC4uNTYyYzAwYzM3YzggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlld0RhdGEubW0KKysr IGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3RGF0YS5tbQpAQCAtMzQs NyArMzQsNiBAQAogI2ltcG9ydCAiV2ViU2VsZWN0aW9uU2VydmljZUNvbnRyb2xsZXIuaCIKICNp bXBvcnQgIldlYlZpZXdHcm91cC5oIgogI2ltcG9ydCA8V2ViQ29yZS9BbHRlcm5hdGl2ZVRleHRV SUNvbnRyb2xsZXIuaD4KLSNpbXBvcnQgPFdlYkNvcmUvV2ViQ29yZU9iakNFeHRyYXMuaD4KICNp bXBvcnQgPFdlYkNvcmUvSGlzdG9yeUl0ZW0uaD4KICNpbXBvcnQgPFdlYkNvcmUvVGV4dEluZGlj YXRvcldpbmRvdy5oPgogI2ltcG9ydCA8V2ViQ29yZS9WYWxpZGF0aW9uQnViYmxlLmg+Cg==