179928 2017-11-21 13:59:35 -0800 Use vImage to do alpha premultiplication/unpremultiplication in FilterEffect 2017-11-21 16:55:27 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser dino ews-watchlist kondapallykalyan simon.fraser thorton webkit-bug-importer oldest_to_newest 1374085 0 simon.fraser 2017-11-21 13:59:35 -0800 Use vImage to do alpha premultiplication/unpremultiplication in FilterEffect 1374086 1 327429 simon.fraser 2017-11-21 14:02:00 -0800 Created attachment 327429 Patch 1374087 2 thorton 2017-11-21 14:07:51 -0800 Nice. Would be neat to see what the numbers are like on iOS too. 1374094 3 simon.fraser 2017-11-21 14:58:50 -0800 https://trac.webkit.org/changeset/225086/webkit 1374115 4 webkit-bug-importer 2017-11-21 16:55:27 -0800 <rdar://problem/35661412> 327429 2017-11-21 14:02:00 -0800 2017-11-21 14:07:19 -0800 Patch bug-179928-20171121140159.patch text/plain 7464 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI4ODA3ZDAwN2EzMWNi MGU2ZjcyNzAzOWQ5MDYyZjMxMTA4MThiMS4uZWIwOWYxMTZjZTBjODcyOWQ2ZjM3YWU2YWQ5ZTJj NDk3NWE1Y2VkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTExLTIxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFVzZSB2SW1hZ2Ug dG8gZG8gYWxwaGEgcHJlbXVsdGlwbGljYXRpb24vdW5wcmVtdWx0aXBsaWNhdGlvbiBpbiBGaWx0 ZXJFZmZlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3OTkyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoZSB2SW1hZ2UgZnVuY3Rpb25zIGFyZSBhYm91dCB0d2ljZSBhcyBmYXN0IGFzIHRoZSBleGlz dGluZyBjb2RlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJF ZmZlY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29weVByZW11bHRpcGx5aW5nQWxwaGEpOgor ICAgICAgICAoV2ViQ29yZTo6Y29weVVucHJlbXVsdGlwbHlpbmdBbHBoYSk6CisgICAgICAgIChX ZWJDb3JlOjpGaWx0ZXJFZmZlY3Q6OmNvcHlVbm11bHRpcGxpZWRJbWFnZSk6CisgICAgICAgIChX ZWJDb3JlOjpGaWx0ZXJFZmZlY3Q6OmNvcHlQcmVtdWx0aXBsaWVkSW1hZ2UpOgorCiAyMDE3LTEx LTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR0xJQl0gVGVzdCBGaWxlTW9uaXRvclRlc3QuRGV0ZWN0Q2hhbmdlQW5kVGhlbkRlbGV0ZSBz b21ldGltZXMgY3Jhc2hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZmlsdGVycy9GaWx0ZXJFZmZlY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJFZmZlY3QuY3BwCmluZGV4IGJhYzJlZDRkNWUwMjIzODRk MTk5OTE3MjI5N2VjMDI4NzRlNWRkZDQuLmE3MDUzNGRiZDY1YTY2MmQ2ZjYwM2MzNTFmZWE4ZjA0 NGJjZTg2NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvRmlsdGVyRWZmZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9maWx0ZXJzL0ZpbHRlckVmZmVjdC5jcHAKQEAgLTM1LDYgKzM1LDEwIEBACiAjaW5jbHVk ZSA8YXJtX25lb24uaD4KICNlbmRpZgogCisjaWYgVVNFKEFDQ0VMRVJBVEUpCisjaW5jbHVkZSA8 QWNjZWxlcmF0ZS9BY2NlbGVyYXRlLmg+CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewog CiBGaWx0ZXJFZmZlY3Q6OkZpbHRlckVmZmVjdChGaWx0ZXImIGZpbHRlcikKQEAgLTMwMiw2ICsz MDYsODEgQEAgaW5saW5lIHZvaWQgRmlsdGVyRWZmZWN0Ojpjb3B5SW1hZ2VCeXRlcyhVaW50OENs YW1wZWRBcnJheSogc291cmNlLCBVaW50OENsYW1wZWQKICAgICB9CiB9CiAKK3N0YXRpYyB2b2lk IGNvcHlQcmVtdWx0aXBseWluZ0FscGhhKGNvbnN0IFVpbnQ4Q2xhbXBlZEFycmF5KiBzb3VyY2Us IFVpbnQ4Q2xhbXBlZEFycmF5KiBkZXN0aW5hdGlvbiwgY29uc3QgSW50U2l6ZSYgaW5wdXRTaXpl KQoreworI2lmIFVTRShBQ0NFTEVSQVRFKQorICAgIHNpemVfdCByb3dCeXRlcyA9IGlucHV0U2l6 ZS53aWR0aCgpICogNDsKKworICAgIHZJbWFnZV9CdWZmZXIgc3JjOworICAgIHNyYy53aWR0aCA9 IGlucHV0U2l6ZS53aWR0aCgpOworICAgIHNyYy5oZWlnaHQgPSBpbnB1dFNpemUuaGVpZ2h0KCk7 CisgICAgc3JjLnJvd0J5dGVzID0gcm93Qnl0ZXM7CisgICAgc3JjLmRhdGEgPSByZWludGVycHJl dF9jYXN0PHZvaWQqPihzb3VyY2UtPmRhdGEoKSk7CisKKyAgICB2SW1hZ2VfQnVmZmVyIGRlc3Q7 CisgICAgZGVzdC53aWR0aCA9IGlucHV0U2l6ZS53aWR0aCgpOworICAgIGRlc3QuaGVpZ2h0ID0g aW5wdXRTaXplLmhlaWdodCgpOworICAgIGRlc3Qucm93Qnl0ZXMgPSByb3dCeXRlczsKKyAgICBk ZXN0LmRhdGEgPSByZWludGVycHJldF9jYXN0PHZvaWQqPihkZXN0aW5hdGlvbi0+ZGF0YSgpKTsK KworICAgIHZJbWFnZVByZW11bHRpcGx5RGF0YV9SR0JBODg4OCgmc3JjLCAmZGVzdCwga3ZJbWFn ZU5vRmxhZ3MpOworI2Vsc2UKKyAgICB1bnNpZ25lZCBjaGFyKiBzb3VyY2VDb21wb25lbnQgPSBz b3VyY2UtPmRhdGEoKTsKKyAgICB1bnNpZ25lZCBjaGFyKiBkZXN0aW5hdGlvbkNvbXBvbmVudCA9 IGRlc3RpbmF0aW9uLT5kYXRhKCk7CisgICAgdW5zaWduZWQgY2hhciogZW5kID0gc291cmNlQ29t cG9uZW50ICsgKGlucHV0U2l6ZS5hcmVhKCkgKiA0KS51bnNhZmVHZXQoKTsKKworICAgIHdoaWxl IChzb3VyY2VDb21wb25lbnQgPCBlbmQpIHsKKyAgICAgICAgaW50IGFscGhhID0gc291cmNlQ29t cG9uZW50WzNdOworICAgICAgICBkZXN0aW5hdGlvbkNvbXBvbmVudFswXSA9IHN0YXRpY19jYXN0 PGludD4oc291cmNlQ29tcG9uZW50WzBdKSAqIGFscGhhIC8gMjU1OworICAgICAgICBkZXN0aW5h dGlvbkNvbXBvbmVudFsxXSA9IHN0YXRpY19jYXN0PGludD4oc291cmNlQ29tcG9uZW50WzFdKSAq IGFscGhhIC8gMjU1OworICAgICAgICBkZXN0aW5hdGlvbkNvbXBvbmVudFsyXSA9IHN0YXRpY19j YXN0PGludD4oc291cmNlQ29tcG9uZW50WzJdKSAqIGFscGhhIC8gMjU1OworICAgICAgICBkZXN0 aW5hdGlvbkNvbXBvbmVudFszXSA9IGFscGhhOworICAgICAgICBzb3VyY2VDb21wb25lbnQgKz0g NDsKKyAgICAgICAgZGVzdGluYXRpb25Db21wb25lbnQgKz0gNDsKKyAgICB9CisjZW5kaWYKK30K Kworc3RhdGljIHZvaWQgY29weVVucHJlbXVsdGlwbHlpbmdBbHBoYShjb25zdCBVaW50OENsYW1w ZWRBcnJheSogc291cmNlLCBVaW50OENsYW1wZWRBcnJheSogZGVzdGluYXRpb24sIGNvbnN0IElu dFNpemUmIGlucHV0U2l6ZSkKK3sKKyNpZiBVU0UoQUNDRUxFUkFURSkKKyAgICBzaXplX3Qgcm93 Qnl0ZXMgPSBpbnB1dFNpemUud2lkdGgoKSAqIDQ7CisKKyAgICB2SW1hZ2VfQnVmZmVyIHNyYzsK KyAgICBzcmMud2lkdGggPSBpbnB1dFNpemUud2lkdGgoKTsKKyAgICBzcmMuaGVpZ2h0ID0gaW5w dXRTaXplLmhlaWdodCgpOworICAgIHNyYy5yb3dCeXRlcyA9IHJvd0J5dGVzOworICAgIHNyYy5k YXRhID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oc291cmNlLT5kYXRhKCkpOworCisgICAgdklt YWdlX0J1ZmZlciBkZXN0OworICAgIGRlc3Qud2lkdGggPSBpbnB1dFNpemUud2lkdGgoKTsKKyAg ICBkZXN0LmhlaWdodCA9IGlucHV0U2l6ZS5oZWlnaHQoKTsKKyAgICBkZXN0LnJvd0J5dGVzID0g cm93Qnl0ZXM7CisgICAgZGVzdC5kYXRhID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oZGVzdGlu YXRpb24tPmRhdGEoKSk7CisKKyAgICB2SW1hZ2VVbnByZW11bHRpcGx5RGF0YV9SR0JBODg4OCgm c3JjLCAmZGVzdCwga3ZJbWFnZU5vRmxhZ3MpOworI2Vsc2UKKyAgICB1bnNpZ25lZCBjaGFyKiBz b3VyY2VDb21wb25lbnQgPSBzb3VyY2UtPmRhdGEoKTsKKyAgICB1bnNpZ25lZCBjaGFyKiBkZXN0 aW5hdGlvbkNvbXBvbmVudCA9IGRlc3RpbmF0aW9uLT5kYXRhKCk7CisgICAgdW5zaWduZWQgY2hh ciogZW5kID0gc291cmNlQ29tcG9uZW50ICsgKGlucHV0U2l6ZS5hcmVhKCkgKiA0KS51bnNhZmVH ZXQoKTsKKyAgICB3aGlsZSAoc291cmNlQ29tcG9uZW50IDwgZW5kKSB7CisgICAgICAgIGludCBh bHBoYSA9IHNvdXJjZUNvbXBvbmVudFszXTsKKyAgICAgICAgaWYgKGFscGhhKSB7CisgICAgICAg ICAgICBkZXN0aW5hdGlvbkNvbXBvbmVudFswXSA9IHN0YXRpY19jYXN0PGludD4oc291cmNlQ29t cG9uZW50WzBdKSAqIDI1NSAvIGFscGhhOworICAgICAgICAgICAgZGVzdGluYXRpb25Db21wb25l bnRbMV0gPSBzdGF0aWNfY2FzdDxpbnQ+KHNvdXJjZUNvbXBvbmVudFsxXSkgKiAyNTUgLyBhbHBo YTsKKyAgICAgICAgICAgIGRlc3RpbmF0aW9uQ29tcG9uZW50WzJdID0gc3RhdGljX2Nhc3Q8aW50 Pihzb3VyY2VDb21wb25lbnRbMl0pICogMjU1IC8gYWxwaGE7CisgICAgICAgIH0gZWxzZSB7Cisg ICAgICAgICAgICBkZXN0aW5hdGlvbkNvbXBvbmVudFswXSA9IDA7CisgICAgICAgICAgICBkZXN0 aW5hdGlvbkNvbXBvbmVudFsxXSA9IDA7CisgICAgICAgICAgICBkZXN0aW5hdGlvbkNvbXBvbmVu dFsyXSA9IDA7CisgICAgICAgIH0KKyAgICAgICAgZGVzdGluYXRpb25Db21wb25lbnRbM10gPSBh bHBoYTsKKyAgICAgICAgc291cmNlQ29tcG9uZW50ICs9IDQ7CisgICAgICAgIGRlc3RpbmF0aW9u Q29tcG9uZW50ICs9IDQ7CisgICAgfQorI2VuZGlmCit9CisKIHZvaWQgRmlsdGVyRWZmZWN0Ojpj b3B5VW5tdWx0aXBsaWVkSW1hZ2UoVWludDhDbGFtcGVkQXJyYXkqIGRlc3RpbmF0aW9uLCBjb25z dCBJbnRSZWN0JiByZWN0KQogewogICAgIEFTU0VSVChoYXNSZXN1bHQoKSk7CkBAIC0zMTksMjQg KzM5OCw4IEBAIHZvaWQgRmlsdGVyRWZmZWN0Ojpjb3B5VW5tdWx0aXBsaWVkSW1hZ2UoVWludDhD bGFtcGVkQXJyYXkqIGRlc3RpbmF0aW9uLCBjb25zdCBJCiAgICAgICAgICAgICAgICAgV1RGTG9n QWx3YXlzKCJGaWx0ZXJFZmZlY3Q6OmNvcHlVbm11bHRpcGxpZWRJbWFnZSBVbmFibGUgdG8gY3Jl YXRlIGJ1ZmZlci4gUmVxdWVzdGVkIHNpemUgd2FzICVkIHggJWRcbiIsIGlucHV0U2l6ZS53aWR0 aCgpLCBpbnB1dFNpemUuaGVpZ2h0KCkpOwogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgICAgIH0KLSAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIqIHNvdXJjZUNvbXBvbmVudCA9IG1f cHJlbXVsdGlwbGllZEltYWdlUmVzdWx0LT5kYXRhKCk7Ci0gICAgICAgICAgICB1bnNpZ25lZCBj aGFyKiBkZXN0aW5hdGlvbkNvbXBvbmVudCA9IG1fdW5tdWx0aXBsaWVkSW1hZ2VSZXN1bHQtPmRh dGEoKTsKLSAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIqIGVuZCA9IHNvdXJjZUNvbXBvbmVudCAr IChpbnB1dFNpemUuYXJlYSgpICogNCkudW5zYWZlR2V0KCk7Ci0gICAgICAgICAgICB3aGlsZSAo c291cmNlQ29tcG9uZW50IDwgZW5kKSB7Ci0gICAgICAgICAgICAgICAgaW50IGFscGhhID0gc291 cmNlQ29tcG9uZW50WzNdOwotICAgICAgICAgICAgICAgIGlmIChhbHBoYSkgewotICAgICAgICAg ICAgICAgICAgICBkZXN0aW5hdGlvbkNvbXBvbmVudFswXSA9IHN0YXRpY19jYXN0PGludD4oc291 cmNlQ29tcG9uZW50WzBdKSAqIDI1NSAvIGFscGhhOwotICAgICAgICAgICAgICAgICAgICBkZXN0 aW5hdGlvbkNvbXBvbmVudFsxXSA9IHN0YXRpY19jYXN0PGludD4oc291cmNlQ29tcG9uZW50WzFd KSAqIDI1NSAvIGFscGhhOwotICAgICAgICAgICAgICAgICAgICBkZXN0aW5hdGlvbkNvbXBvbmVu dFsyXSA9IHN0YXRpY19jYXN0PGludD4oc291cmNlQ29tcG9uZW50WzJdKSAqIDI1NSAvIGFscGhh OwotICAgICAgICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgICAgIGRlc3RpbmF0 aW9uQ29tcG9uZW50WzBdID0gMDsKLSAgICAgICAgICAgICAgICAgICAgZGVzdGluYXRpb25Db21w b25lbnRbMV0gPSAwOwotICAgICAgICAgICAgICAgICAgICBkZXN0aW5hdGlvbkNvbXBvbmVudFsy XSA9IDA7Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgIGRlc3RpbmF0aW9uQ29t cG9uZW50WzNdID0gYWxwaGE7Ci0gICAgICAgICAgICAgICAgc291cmNlQ29tcG9uZW50ICs9IDQ7 Ci0gICAgICAgICAgICAgICAgZGVzdGluYXRpb25Db21wb25lbnQgKz0gNDsKLSAgICAgICAgICAg IH0KKyAgICAgICAgICAgIAorICAgICAgICAgICAgY29weVVucHJlbXVsdGlwbHlpbmdBbHBoYSht X3ByZW11bHRpcGxpZWRJbWFnZVJlc3VsdC5nZXQoKSwgbV91bm11bHRpcGxpZWRJbWFnZVJlc3Vs dC5nZXQoKSwgaW5wdXRTaXplKTsKICAgICAgICAgfQogICAgIH0KICAgICBjb3B5SW1hZ2VCeXRl cyhtX3VubXVsdGlwbGllZEltYWdlUmVzdWx0LmdldCgpLCBkZXN0aW5hdGlvbiwgcmVjdCk7CkBA IC0zNTksMTggKzQyMiw4IEBAIHZvaWQgRmlsdGVyRWZmZWN0Ojpjb3B5UHJlbXVsdGlwbGllZElt YWdlKFVpbnQ4Q2xhbXBlZEFycmF5KiBkZXN0aW5hdGlvbiwgY29uc3QKICAgICAgICAgICAgICAg ICBXVEZMb2dBbHdheXMoIkZpbHRlckVmZmVjdDo6Y29weVByZW11bHRpcGxpZWRJbWFnZSBVbmFi bGUgdG8gY3JlYXRlIGJ1ZmZlci4gUmVxdWVzdGVkIHNpemUgd2FzICVkIHggJWRcbiIsIGlucHV0 U2l6ZS53aWR0aCgpLCBpbnB1dFNpemUuaGVpZ2h0KCkpOwogICAgICAgICAgICAgICAgIHJldHVy bjsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIqIHNvdXJjZUNvbXBv bmVudCA9IG1fdW5tdWx0aXBsaWVkSW1hZ2VSZXN1bHQtPmRhdGEoKTsKLSAgICAgICAgICAgIHVu c2lnbmVkIGNoYXIqIGRlc3RpbmF0aW9uQ29tcG9uZW50ID0gbV9wcmVtdWx0aXBsaWVkSW1hZ2VS ZXN1bHQtPmRhdGEoKTsKLSAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIqIGVuZCA9IHNvdXJjZUNv bXBvbmVudCArIChpbnB1dFNpemUuYXJlYSgpICogNCkudW5zYWZlR2V0KCk7Ci0gICAgICAgICAg ICB3aGlsZSAoc291cmNlQ29tcG9uZW50IDwgZW5kKSB7Ci0gICAgICAgICAgICAgICAgaW50IGFs cGhhID0gc291cmNlQ29tcG9uZW50WzNdOwotICAgICAgICAgICAgICAgIGRlc3RpbmF0aW9uQ29t cG9uZW50WzBdID0gc3RhdGljX2Nhc3Q8aW50Pihzb3VyY2VDb21wb25lbnRbMF0pICogYWxwaGEg LyAyNTU7Ci0gICAgICAgICAgICAgICAgZGVzdGluYXRpb25Db21wb25lbnRbMV0gPSBzdGF0aWNf Y2FzdDxpbnQ+KHNvdXJjZUNvbXBvbmVudFsxXSkgKiBhbHBoYSAvIDI1NTsKLSAgICAgICAgICAg ICAgICBkZXN0aW5hdGlvbkNvbXBvbmVudFsyXSA9IHN0YXRpY19jYXN0PGludD4oc291cmNlQ29t cG9uZW50WzJdKSAqIGFscGhhIC8gMjU1OwotICAgICAgICAgICAgICAgIGRlc3RpbmF0aW9uQ29t cG9uZW50WzNdID0gYWxwaGE7Ci0gICAgICAgICAgICAgICAgc291cmNlQ29tcG9uZW50ICs9IDQ7 Ci0gICAgICAgICAgICAgICAgZGVzdGluYXRpb25Db21wb25lbnQgKz0gNDsKLSAgICAgICAgICAg IH0KKyAgICAgICAgICAgIAorICAgICAgICAgICAgY29weVByZW11bHRpcGx5aW5nQWxwaGEobV91 bm11bHRpcGxpZWRJbWFnZVJlc3VsdC5nZXQoKSwgbV9wcmVtdWx0aXBsaWVkSW1hZ2VSZXN1bHQu Z2V0KCksIGlucHV0U2l6ZSk7CiAgICAgICAgIH0KICAgICB9CiAgICAgY29weUltYWdlQnl0ZXMo bV9wcmVtdWx0aXBsaWVkSW1hZ2VSZXN1bHQuZ2V0KCksIGRlc3RpbmF0aW9uLCByZWN0KTsK