179926 2017-11-21 11:22:48 -0800 tuple related items are used in WTF without including tuple 2017-11-22 09:57:33 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned achristensen benjamin cdumez cmarcelo commit-queue darin dbates don.olmstead ews-watchlist mjs webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1374069 0 stephan.szabo 2017-11-21 11:22:48 -0800 There are some cases where a few WTF headers that use tuple without including <tuple> (HashFunctions.h, PrintStream.h, Signals.h) can cause compilation failures on toolchains where tuple isn't being already defined (for example via include from another previously included STL header) and don't delay templates like MSVC. For Signals.h, it appears that the only place in Signals.cpp the additional <tuple> include would work in break the header include order (it would have to be before the include of Signals.h itself). For PrintStream.h, it might be possible to find another location, although the first specific error we see is in SlotVisitor.cpp and adding in the accepted header include position in either that file or SlotVisitor.h did not fix the error. For HashFunctions (or at least HashTraits that uses it), there appeared to be failures in WTF, LLIntOffsetsExtractor, and JavaScriptCore and test* apps for failures to find make_tuple via paths including it from heap/Weak.h and text/CString.h across at least 5 of the JSC unified sources. 1374070 1 327423 stephan.szabo 2017-11-21 11:30:07 -0800 Created attachment 327423 Add tuple includes to WTF headers. 1374072 2 don.olmstead 2017-11-21 11:49:29 -0800 This was brought up at the contributors meeting so hopefully we can land this. STL makes no guarantees that any one header includes another header within the STL so that's one reason we believe that other platforms are not having these problems. 1374078 3 stephan.szabo 2017-11-21 12:45:18 -0800 Adding Alex as he had commented on https://bugs.webkit.org/show_bug.cgi?id=169769 1374112 4 don.olmstead 2017-11-21 16:16:16 -0800 *** Bug 169769 has been marked as a duplicate of this bug. *** 1374214 5 327423 commit-queue 2017-11-22 09:56:15 -0800 Comment on attachment 327423 Add tuple includes to WTF headers. Clearing flags on attachment: 327423 Committed r225096: <https://trac.webkit.org/changeset/225096> 1374215 6 commit-queue 2017-11-22 09:56:16 -0800 All reviewed patches have been landed. Closing bug. 1374217 7 webkit-bug-importer 2017-11-22 09:57:33 -0800 <rdar://problem/35668618> 327423 2017-11-21 11:30:07 -0800 2017-11-22 09:56:15 -0800 Add tuple includes to WTF headers. 179926-1.diff text/plain 1658 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZjE2MTM1NDUxYmEuLmIxMGY3ZDAwMDBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3 LTExLTIxICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAg ICB0dXBsZSByZWxhdGVkIGl0ZW1zIGFyZSB1c2VkIGluIFdURiB3aXRob3V0IGluY2x1ZGluZyB0 dXBsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5 OTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvSGFzaEZ1bmN0aW9ucy5oOgorICAgICAgICAqIHd0Zi9QcmludFN0cmVhbS5oOgorICAgICAg ICAqIHd0Zi90aHJlYWRzL1NpZ25hbHMuaDoKKwogMjAxNy0xMS0xOSAgVGltIEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIFRPVUNIX0lD T05fTE9BRElORyBmZWF0dXJlIGZsYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0hhc2hG dW5jdGlvbnMuaCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hGdW5jdGlvbnMuaAppbmRleCBhZjBhNTFm ODk3OC4uZGM0MmYyNzFkZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0hhc2hGdW5jdGlv bnMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoRnVuY3Rpb25zLmgKQEAgLTIyLDYgKzIyLDcg QEAKICNkZWZpbmUgV1RGX0hhc2hGdW5jdGlvbnNfaAogCiAjaW5jbHVkZSA8c3RkaW50Lmg+Cisj aW5jbHVkZSA8dHVwbGU+CiAjaW5jbHVkZSA8d3RmL0dldFB0ci5oPgogI2luY2x1ZGUgPHd0Zi9S ZWZQdHIuaD4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUHJpbnRTdHJlYW0uaCBiL1Nv dXJjZS9XVEYvd3RmL1ByaW50U3RyZWFtLmgKaW5kZXggNWIzOTEzYzZkYTUuLmE2OWQxZDBkN2Zj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QcmludFN0cmVhbS5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL1ByaW50U3RyZWFtLmgKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2luY2x1ZGUgPG1lbW9y eT4KICNpbmNsdWRlIDxzdGRhcmcuaD4KKyNpbmNsdWRlIDx0dXBsZT4KICNpbmNsdWRlIDx3dGYv RmFzdE1hbGxvYy5oPgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogI2luY2x1ZGUgPHd0 Zi9PcHRpb25hbC5oPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxz LmggYi9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuaAppbmRleCA5YzhkMTBjZjYxMy4u ZDU4ZmM2OGE4NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5o CisrKyBiL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5oCkBAIC0yOCw2ICsyOCw3IEBA CiAjaWYgVVNFKFBUSFJFQURTKSAmJiBIQVZFKE1BQ0hJTkVfQ09OVEVYVCkKIAogI2luY2x1ZGUg PHNpZ25hbC5oPgorI2luY2x1ZGUgPHR1cGxlPgogI2luY2x1ZGUgPHd0Zi9GdW5jdGlvbi5oPgog I2luY2x1ZGUgPHd0Zi9PcHRpb25hbC5oPgogI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybVJlZ2lzdGVy cy5oPgo=