179918 2017-11-21 05:26:32 -0800 WebDriver: do not try to parse http body if method is not POST 2017-11-21 08:57:17 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg darin webkit-bug-importer oldest_to_newest 1373987 0 cgarcia 2017-11-21 05:26:32 -0800 As said in the spec: 5. If request’s method is POST: 1. Let parse result be the result of parsing as JSON with request’s body as the argument. If this process throws an exception, return an error with error code invalid argument and jump back to step 1 in this overall algorithm. 2. If parse result is not an Object, send an error with error code invalid argument and jump back to step 1 in this overall algorithm. Otherwise, let parameters be parse result. Otherwise, let parameters be null. 6.3 Processing Model https://w3c.github.io/webdriver/webdriver-spec.html#processing-model Now, w3c tests are sending null as body of delete session command (it used to be just empty), making it fail with invalid argument. 1373988 1 327403 cgarcia 2017-11-21 05:30:03 -0800 Created attachment 327403 Patch 1374040 2 cgarcia 2017-11-21 08:56:54 -0800 Committed r225083: <https://trac.webkit.org/changeset/225083> 1374041 3 webkit-bug-importer 2017-11-21 08:57:17 -0800 <rdar://problem/35658285> 327403 2017-11-21 05:30:03 -0800 2017-11-21 08:46:47 -0800 Patch wd-post-body.diff text/plain 4759 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggNmY0OTE3ZTZjNzQuLjgxNTczMzk2MTJhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDM2IEBACisyMDE3LTExLTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGRvIG5vdCB0cnkgdG8gcGFy c2UgaHR0cCBib2R5IGlmIG1ldGhvZCBpcyBub3QgUE9TVAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5OTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgc2FpZCBpbiB0aGUgc3BlYzoKKworICAgICAg ICAgIDUuIElmIHJlcXVlc3TigJlzIG1ldGhvZCBpcyBQT1NUOgorCisgICAgICAgICAgICAxLiBM ZXQgcGFyc2UgcmVzdWx0IGJlIHRoZSByZXN1bHQgb2YgcGFyc2luZyBhcyBKU09OIHdpdGggcmVx dWVzdOKAmXMgYm9keSBhcyB0aGUgYXJndW1lbnQuIElmIHRoaXMgcHJvY2VzcworICAgICAgICAg ICAgICAgdGhyb3dzIGFuIGV4Y2VwdGlvbiwgcmV0dXJuIGFuIGVycm9yIHdpdGggZXJyb3IgY29k ZSBpbnZhbGlkIGFyZ3VtZW50IGFuZCBqdW1wIGJhY2sgdG8gc3RlcCAxIGluIHRoaXMKKyAgICAg ICAgICAgICAgIG92ZXJhbGwgYWxnb3JpdGhtLgorCisgICAgICAgICAgICAyLiBJZiBwYXJzZSBy ZXN1bHQgaXMgbm90IGFuIE9iamVjdCwgc2VuZCBhbiBlcnJvciB3aXRoIGVycm9yIGNvZGUgaW52 YWxpZCBhcmd1bWVudCBhbmQganVtcCBiYWNrIHRvIHN0ZXAgMQorICAgICAgICAgICAgICAgaW4g dGhpcyBvdmVyYWxsIGFsZ29yaXRobS4KKworICAgICAgICAgICAgT3RoZXJ3aXNlLCBsZXQgcGFy YW1ldGVycyBiZSBwYXJzZSByZXN1bHQuCisKKyAgICAgICAgICBPdGhlcndpc2UsIGxldCBwYXJh bWV0ZXJzIGJlIG51bGwuCisKKyAgICAgICAgNi4zIFByb2Nlc3NpbmcgTW9kZWwKKyAgICAgICAg aHR0cHM6Ly93M2MuZ2l0aHViLmlvL3dlYmRyaXZlci93ZWJkcml2ZXItc3BlYy5odG1sI3Byb2Nl c3NpbmctbW9kZWwKKworICAgICAgICBOb3csIHczYyB0ZXN0cyBhcmUgc2VuZGluZyBudWxsIGFz IGJvZHkgb2YgZGVsZXRlIHNlc3Npb24gY29tbWFuZCAoaXQgdXNlZCB0byBiZSBqdXN0IGVtcHR5 KSwgbWFraW5nIGl0IGZhaWwKKyAgICAgICAgd2l0aCBpbnZhbGlkIGFyZ3VtZW50IGVycm9yLgor CisgICAgICAgICogV2ViRHJpdmVyU2VydmljZS5jcHA6CisgICAgICAgIChXZWJEcml2ZXI6Oldl YkRyaXZlclNlcnZpY2U6OmZpbmRDb21tYW5kKToKKyAgICAgICAgKFdlYkRyaXZlcjo6V2ViRHJp dmVyU2VydmljZTo6aGFuZGxlUmVxdWVzdCk6CisgICAgICAgICogV2ViRHJpdmVyU2VydmljZS5o OgorCiAyMDE3LTExLTIxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBXZWJEcml2ZXI6IGNyYXNoIGluIFNlc3Npb246OmNvbXB1dGVFbGVtZW50 TGF5b3V0IHdoZW4gY2FsbGVkIHdpdGhvdXQgYSBjdXJyZW50IGJyb3dzaW5nIGNvbnRleHQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAgYi9Tb3VyY2Uv V2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCmluZGV4IDQyM2I4YzU0NWMzLi5jN2FiMWRi NzY1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcAor KysgYi9Tb3VyY2UvV2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwCkBAIC0xNzQsMTUgKzE3 NCwxMSBAQCBzdGQ6Om9wdGlvbmFsPFdlYkRyaXZlclNlcnZpY2U6OkhUVFBNZXRob2Q+IFdlYkRy aXZlclNlcnZpY2U6OnRvQ29tbWFuZEhUVFBNZXRobwogICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7 CiB9CiAKLWJvb2wgV2ViRHJpdmVyU2VydmljZTo6ZmluZENvbW1hbmQoY29uc3QgU3RyaW5nJiBt ZXRob2QsIGNvbnN0IFN0cmluZyYgcGF0aCwgQ29tbWFuZEhhbmRsZXIqIGhhbmRsZXIsIEhhc2hN YXA8U3RyaW5nLCBTdHJpbmc+JiBwYXJhbWV0ZXJzKQorYm9vbCBXZWJEcml2ZXJTZXJ2aWNlOjpm aW5kQ29tbWFuZChIVFRQTWV0aG9kIG1ldGhvZCwgY29uc3QgU3RyaW5nJiBwYXRoLCBDb21tYW5k SGFuZGxlciogaGFuZGxlciwgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4mIHBhcmFtZXRlcnMpCiB7 Ci0gICAgYXV0byBjb21tYW5kTWV0aG9kID0gdG9Db21tYW5kSFRUUE1ldGhvZChtZXRob2QpOwot ICAgIGlmICghY29tbWFuZE1ldGhvZCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCiAgICAgc2l6 ZV90IGxlbmd0aCA9IFdURl9BUlJBWV9MRU5HVEgoc19jb21tYW5kcyk7CiAgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewotICAgICAgICBpZiAoc19jb21tYW5kc1tpXS5t ZXRob2QgIT0gKmNvbW1hbmRNZXRob2QpCisgICAgICAgIGlmIChzX2NvbW1hbmRzW2ldLm1ldGhv ZCAhPSBtZXRob2QpCiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICBWZWN0b3I8U3Ry aW5nPiBwYXRoVG9rZW5zOwpAQCAtMjEzLDE1ICsyMDksMjAgQEAgYm9vbCBXZWJEcml2ZXJTZXJ2 aWNlOjpmaW5kQ29tbWFuZChjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3QgU3RyaW5nJiBwYXRo LCBDb20KIAogdm9pZCBXZWJEcml2ZXJTZXJ2aWNlOjpoYW5kbGVSZXF1ZXN0KEhUVFBSZXF1ZXN0 SGFuZGxlcjo6UmVxdWVzdCYmIHJlcXVlc3QsIEZ1bmN0aW9uPHZvaWQgKEhUVFBSZXF1ZXN0SGFu ZGxlcjo6UmVzcG9uc2UmJik+JiYgcmVwbHlIYW5kbGVyKQogeworICAgIGF1dG8gbWV0aG9kID0g dG9Db21tYW5kSFRUUE1ldGhvZChyZXF1ZXN0Lm1ldGhvZCk7CisgICAgaWYgKCFtZXRob2QpIHsK KyAgICAgICAgc2VuZFJlc3BvbnNlKFdURk1vdmUocmVwbHlIYW5kbGVyKSwgQ29tbWFuZFJlc3Vs dDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6OlVua25vd25Db21tYW5kLCBTdHJpbmco IlVua25vd24gbWV0aG9kOiAiICsgcmVxdWVzdC5tZXRob2QpKSk7CisgICAgICAgIHJldHVybjsK KyAgICB9CiAgICAgQ29tbWFuZEhhbmRsZXIgaGFuZGxlcjsKICAgICBIYXNoTWFwPFN0cmluZywg U3RyaW5nPiBwYXJhbWV0ZXJzOwotICAgIGlmICghZmluZENvbW1hbmQocmVxdWVzdC5tZXRob2Qs IHJlcXVlc3QucGF0aCwgJmhhbmRsZXIsIHBhcmFtZXRlcnMpKSB7CisgICAgaWYgKCFmaW5kQ29t bWFuZChtZXRob2QudmFsdWUoKSwgcmVxdWVzdC5wYXRoLCAmaGFuZGxlciwgcGFyYW1ldGVycykp IHsKICAgICAgICAgc2VuZFJlc3BvbnNlKFdURk1vdmUocmVwbHlIYW5kbGVyKSwgQ29tbWFuZFJl c3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6OlVua25vd25Db21tYW5kLCBTdHJp bmcoIlVua25vd24gY29tbWFuZDogIiArIHJlcXVlc3QucGF0aCkpKTsKICAgICAgICAgcmV0dXJu OwogICAgIH0KIAogICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IHBhcmFtZXRlcnNPYmplY3Q7 Ci0gICAgaWYgKHJlcXVlc3QuZGF0YUxlbmd0aCkgeworICAgIGlmIChtZXRob2QudmFsdWUoKSA9 PSBIVFRQTWV0aG9kOjpQb3N0ICYmIHJlcXVlc3QuZGF0YUxlbmd0aCkgewogICAgICAgICBSZWZQ dHI8SW5zcGVjdG9yVmFsdWU+IG1lc3NhZ2VWYWx1ZTsKICAgICAgICAgaWYgKCFJbnNwZWN0b3JW YWx1ZTo6cGFyc2VKU09OKFN0cmluZzo6ZnJvbVVURjgocmVxdWVzdC5kYXRhLCByZXF1ZXN0LmRh dGFMZW5ndGgpLCBtZXNzYWdlVmFsdWUpKSB7CiAgICAgICAgICAgICBzZW5kUmVzcG9uc2UoV1RG TW92ZShyZXBseUhhbmRsZXIpLCBDb21tYW5kUmVzdWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVy cm9yQ29kZTo6SW52YWxpZEFyZ3VtZW50KSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L1dlYkRyaXZlclNlcnZpY2UuaCBiL1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5o CmluZGV4IGQyOTYwOTAwZjU1Li4zOWE5YjNjOTg5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRy aXZlci9XZWJEcml2ZXJTZXJ2aWNlLmgKKysrIGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2ZXJT ZXJ2aWNlLmgKQEAgLTYyLDcgKzYyLDcgQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgY29uc3QgQ29t bWFuZCBzX2NvbW1hbmRzW107CiAKICAgICBzdGF0aWMgc3RkOjpvcHRpb25hbDxIVFRQTWV0aG9k PiB0b0NvbW1hbmRIVFRQTWV0aG9kKGNvbnN0IFN0cmluZyYgbWV0aG9kKTsKLSAgICBzdGF0aWMg Ym9vbCBmaW5kQ29tbWFuZChjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3QgU3RyaW5nJiBwYXRo LCBDb21tYW5kSGFuZGxlciosIEhhc2hNYXA8U3RyaW5nLCBTdHJpbmc+JiBwYXJhbWV0ZXJzKTsK KyAgICBzdGF0aWMgYm9vbCBmaW5kQ29tbWFuZChIVFRQTWV0aG9kLCBjb25zdCBTdHJpbmcmIHBh dGgsIENvbW1hbmRIYW5kbGVyKiwgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4mIHBhcmFtZXRlcnMp OwogCiAgICAgdm9pZCBuZXdTZXNzaW9uKFJlZlB0cjxJbnNwZWN0b3I6Okluc3BlY3Rvck9iamVj dD4mJiwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7CiAgICAgdm9pZCBkZWxl dGVTZXNzaW9uKFJlZlB0cjxJbnNwZWN0b3I6Okluc3BlY3Rvck9iamVjdD4mJiwgRnVuY3Rpb248 dm9pZCAoQ29tbWFuZFJlc3VsdCYmKT4mJik7Cg==