179908 2017-11-20 19:50:44 -0800 [WinCairo] Enable WebP support 2023-04-19 01:20:47 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=255649 InRadar P2 Normal --- 170594 1 don.olmstead don.olmstead achristensen annulen bfulgham commit-queue ews-watchlist pvollan webkit-bug-importer oldest_to_newest 1373913 0 don.olmstead 2017-11-20 19:50:44 -0800 WinCairoRequirements is building WebP. Now it just needs to be enabled. 1373914 1 don.olmstead 2017-11-20 19:51:58 -0800 Currently blocked on enabling due to WebKit using /MT instead of /MD 1373915 2 327384 don.olmstead 2017-11-20 19:54:38 -0800 Created attachment 327384 Patch 1373916 3 327384 don.olmstead 2017-11-20 19:55:35 -0800 Comment on attachment 327384 Patch Will only commit after the dependent bug is landed. 1374082 4 annulen 2017-11-21 13:33:01 -0800 It might make sense to have WebP as optional dependency, as it is not really essential for Web 1374083 5 don.olmstead 2017-11-21 13:36:49 -0800 (In reply to Konstantin Tokarev from comment #4) > It might make sense to have WebP as optional dependency, as it is not really > essential for Web Its being distributed in the updated WinCairoRequirements. Also GTK/WPE have it as REQUIRED as well. 1374963 6 achristensen 2017-11-27 09:22:42 -0800 Is there a specific reason why WebP is needed? Do you have content that requires it? 1380821 7 329149 don.olmstead 2017-12-12 13:41:45 -0800 Created attachment 329149 Patch Add webp but make it optional 1380822 8 ews-watchlist 2017-12-12 13:43:40 -0800 Attachment 329149 did not pass style-queue: ERROR: Source/cmake/OptionsWinCairo.cmake:18: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1380832 9 329153 don.olmstead 2017-12-12 14:11:20 -0800 Created attachment 329153 Patch 1380909 10 329153 commit-queue 2017-12-12 15:41:29 -0800 Comment on attachment 329153 Patch Clearing flags on attachment: 329153 Committed r225817: <https://trac.webkit.org/changeset/225817> 1380910 11 commit-queue 2017-12-12 15:41:31 -0800 All reviewed patches have been landed. Closing bug. 1380911 12 webkit-bug-importer 2017-12-12 15:42:23 -0800 <rdar://problem/36007096> 327384 2017-11-20 19:54:38 -0800 2017-12-12 13:41:45 -0800 Patch bug-179908.diff text/plain 1109 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxMDgxMzBlNTMwOC4uZDZi MjBiMTBmN2YgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0xMS0yMCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5DYWlyb10gRW5hYmxlIFdlYlAgc3VwcG9ydAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5OTA4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c1dpbkNhaXJvLmNtYWtlOgorCiAyMDE3LTExLTIwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFX0FMTElOT05FX0JVSUxE IG9wdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5jbWFrZSBi L1NvdXJjZS9jbWFrZS9PcHRpb25zV2luQ2Fpcm8uY21ha2UKaW5kZXggODM0MDA0ZmM1MjUuLjY1 MTczODQ0NjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNhaXJvLmNtYWtl CisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luQ2Fpcm8uY21ha2UKQEAgLTksNiArOSw3IEBA IGZpbmRfcGFja2FnZShMaWJYbWwyIDIuOS43IFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKE9wZW5T U0wgMi4wLjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoUE5HIDEuNi4zNCBSRVFVSVJFRCkKIGZp bmRfcGFja2FnZShTcWxpdGUgMy4yMS4wIFJFUVVJUkVEKQorZmluZF9wYWNrYWdlKFdlYlAgMC42 LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoWkxJQiAxLjIuMTEgUkVRVUlSRUQpCiAKIGlmIChF TkFCTEVfWFNMVCkKQEAgLTE3LDYgKzE4LDcgQEAgZW5kaWYgKCkKIAogU0VUX0FORF9FWFBPU0Vf VE9fQlVJTEQoVVNFX0NBSVJPIE9OKQogU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX0NGIE9O KQorU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX1dFQlAgT04pCiAKIHNldChVU0VfQ1VSTCAx KQogc2V0KFVTRV9JQ1VfVU5JQ09ERSAxKQo= 329149 2017-12-12 13:41:45 -0800 2017-12-12 14:11:20 -0800 Patch bug-179908.diff text/plain 981 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzNWMxZDU3YzgyNC4uZmY0 OWI0NzBhNWMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0xMi0xMiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5DYWlyb10gRW5hYmxlIFdlYlAgc3VwcG9ydAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5OTA4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c1dpbkNhaXJvLmNtYWtlOgorCiAyMDE3LTEyLTA4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb11bTmluamFdIEluY3JlbWVudGFs IGJ1aWxkIGZhaWx1cmUgb2YgV1RGCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dp bkNhaXJvLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5jbWFrZQppbmRleCA4 MzQwMDRmYzUyNS4uNjc2ZjVlODA1OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25z V2luQ2Fpcm8uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5jbWFrZQpA QCAtMTEsNiArMTEsMTIgQEAgZmluZF9wYWNrYWdlKFBORyAxLjYuMzQgUkVRVUlSRUQpCiBmaW5k X3BhY2thZ2UoU3FsaXRlIDMuMjEuMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShaTElCIDEuMi4x MSBSRVFVSVJFRCkKIAorZmluZF9wYWNrYWdlKFdlYlAgMC42LjApCisKK2lmIChXRUJQX0ZPVU5E KQorICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9XRUJQIE9OKQorZW5kaWYoKQorCiBp ZiAoRU5BQkxFX1hTTFQpCiAgICAgZmluZF9wYWNrYWdlKExpYlhzbHQgMS4xLjMyIFJFUVVJUkVE KQogZW5kaWYgKCkK 329153 2017-12-12 14:11:20 -0800 2017-12-12 15:41:29 -0800 Patch bug-179908.diff text/plain 982 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzNWMxZDU3YzgyNC4uZmY0 OWI0NzBhNWMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0xMi0xMiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5DYWlyb10gRW5hYmxlIFdlYlAgc3VwcG9ydAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5OTA4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c1dpbkNhaXJvLmNtYWtlOgorCiAyMDE3LTEyLTA4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb11bTmluamFdIEluY3JlbWVudGFs IGJ1aWxkIGZhaWx1cmUgb2YgV1RGCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dp bkNhaXJvLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5jbWFrZQppbmRleCA4 MzQwMDRmYzUyNS4uNjc2ZjVlODA1OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25z V2luQ2Fpcm8uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5jbWFrZQpA QCAtMTEsNiArMTEsMTIgQEAgZmluZF9wYWNrYWdlKFBORyAxLjYuMzQgUkVRVUlSRUQpCiBmaW5k X3BhY2thZ2UoU3FsaXRlIDMuMjEuMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShaTElCIDEuMi4x MSBSRVFVSVJFRCkKIAorZmluZF9wYWNrYWdlKFdlYlAgMC42LjApCisKK2lmIChXRUJQX0ZPVU5E KQorICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFVTRV9XRUJQIE9OKQorZW5kaWYgKCkKKwog aWYgKEVOQUJMRV9YU0xUKQogICAgIGZpbmRfcGFja2FnZShMaWJYc2x0IDEuMS4zMiBSRVFVSVJF RCkKIGVuZGlmICgpCg==