<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>179892</bug_id>
          
          <creation_ts>2017-11-20 11:29:09 -0800</creation_ts>
          <short_desc>Detect __declspec within JSBase.h</short_desc>
          <delta_ts>2017-11-20 18:50:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1373808</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2017-11-20 11:29:09 -0800</bug_when>
    <thetext>Clang has support for a Microsoft style __declspec attribute, https://clang.llvm.org/docs/LanguageExtensions.html#has-declspec-attribute, and this should be detected within JSBase.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373809</commentid>
    <comment_count>1</comment_count>
      <attachid>327369</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2017-11-20 11:33:34 -0800</bug_when>
    <thetext>Created attachment 327369
Patch

Uses clangs declspec detection. Also getting rid of WIN_CE define.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373810</commentid>
    <comment_count>2</comment_count>
      <attachid>327370</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2017-11-20 12:05:24 -0800</bug_when>
    <thetext>Created attachment 327370
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373833</commentid>
    <comment_count>3</comment_count>
      <attachid>327375</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2017-11-20 14:17:02 -0800</bug_when>
    <thetext>Created attachment 327375
Patch

Moving declaration to its own block. Adding RealView ARM Compiler support of declspec.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373834</commentid>
    <comment_count>4</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2017-11-20 14:18:28 -0800</bug_when>
    <thetext>Attachment 327375 did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSBase.h:72:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/API/JSBase.h:72:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373866</commentid>
    <comment_count>5</comment_count>
      <attachid>327375</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2017-11-20 16:32:07 -0800</bug_when>
    <thetext>Comment on attachment 327375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327375&amp;action=review

&gt; Source/JavaScriptCore/API/JSBase.h:80
&gt; +#ifndef __has_declspec_attribute
&gt; +#if defined(WIN32) || defined(_WIN32) || defined(__CC_ARM) || defined(__ARMCC__)
&gt; +#define __has_declspec_attribute(x) 1
&gt; +#else
&gt; +#define __has_declspec_attribute(x) 0
&gt; +#endif
&gt; +#endif

Defining this macro isn’t great in a public header like JSBase.h, but I guess we can live with it.

&gt; Source/JavaScriptCore/API/JSBase.h:88
&gt; +#elif (__has_declspec_attribute(dllimport) &amp;&amp; __has_declspec_attribute(dllexport))

No need for these parentheses.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373881</commentid>
    <comment_count>6</comment_count>
      <attachid>327380</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2017-11-20 17:21:35 -0800</bug_when>
    <thetext>Created attachment 327380
Patch

Addressing feedback</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373882</commentid>
    <comment_count>7</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2017-11-20 17:23:08 -0800</bug_when>
    <thetext>Attachment 327380 did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSBase.h:72:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/API/JSBase.h:72:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373893</commentid>
    <comment_count>8</comment_count>
      <attachid>327380</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2017-11-20 18:28:18 -0800</bug_when>
    <thetext>Comment on attachment 327380
Patch

Apple Win failures are around FourCC which is unrelated</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373894</commentid>
    <comment_count>9</comment_count>
      <attachid>327380</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-20 18:48:17 -0800</bug_when>
    <thetext>Comment on attachment 327380
Patch

Clearing flags on attachment: 327380

Committed r225063: &lt;https://trac.webkit.org/changeset/225063&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373895</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-20 18:48:19 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373899</commentid>
    <comment_count>11</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-11-20 18:50:26 -0800</bug_when>
    <thetext>&lt;rdar://problem/35651308&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>327369</attachid>
            <date>2017-11-20 11:33:34 -0800</date>
            <delta_ts>2017-11-20 12:05:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179892.diff</filename>
            <type>text/plain</type>
            <size>1668</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmggYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCmluZGV4IDY3N2RmZjE2ODA1Li4yNjcyNjM2NmEx
OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Jhc2UuaAorKysgYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCkBAIC03NCwxNCArNzQsMTQgQEAgdHlw
ZWRlZiBzdHJ1Y3QgT3BhcXVlSlNWYWx1ZSogSlNPYmplY3RSZWY7CiAjdW5kZWYgSlNfRVhQT1JU
CiAjaWYgZGVmaW5lZChKU19OT19FWFBPUlQpCiAjZGVmaW5lIEpTX0VYUE9SVAotI2VsaWYgZGVm
aW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19DQ19BUk0pICYmICFkZWZpbmVkKF9fQVJNQ0Nf
XykKLSNkZWZpbmUgSlNfRVhQT1JUIF9fYXR0cmlidXRlX18oKHZpc2liaWxpdHkoImRlZmF1bHQi
KSkpCi0jZWxpZiBkZWZpbmVkKFdJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMikgfHwgZGVmaW5lZChf
V0lOMzJfV0NFKSB8fCBkZWZpbmVkKF9fQ0NfQVJNKSB8fCBkZWZpbmVkKF9fQVJNQ0NfXykKKyNl
bGlmIGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKSB8fCAoZGVmaW5lZChfX2hhc19k
ZWNsc3BlY19hdHRyaWJ1dGUpICYmIF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZShkbGxpbXBvcnQp
ICYmIF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZShkbGxleHBvcnQpKQogI2lmIGRlZmluZWQoQlVJ
TERJTkdfSmF2YVNjcmlwdENvcmUpIHx8IGRlZmluZWQoU1RBVElDQUxMWV9MSU5LRURfV0lUSF9K
YXZhU2NyaXB0Q29yZSkKICNkZWZpbmUgSlNfRVhQT1JUIF9fZGVjbHNwZWMoZGxsZXhwb3J0KQog
I2Vsc2UKICNkZWZpbmUgSlNfRVhQT1JUIF9fZGVjbHNwZWMoZGxsaW1wb3J0KQogI2VuZGlmCisj
ZWxpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX0NDX0FSTSkgJiYgIWRlZmluZWQo
X19BUk1DQ19fKQorI2RlZmluZSBKU19FWFBPUlQgX19hdHRyaWJ1dGVfXygodmlzaWJpbGl0eSgi
ZGVmYXVsdCIpKSkKICNlbHNlIC8qICFkZWZpbmVkKEpTX05PX0VYUE9SVCkgKi8KICNkZWZpbmUg
SlNfRVhQT1JUCiAjZW5kaWYgLyogZGVmaW5lZChKU19OT19FWFBPUlQpICovCmRpZmYgLS1naXQg
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl
L0NoYW5nZUxvZwppbmRleCBmOTJmNDBhOGQ4NS4uMjZlNWY3YWYzOWYgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTExLTIwICBEb24gT2xtc3RlYWQgIDxk
b24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgRGV0ZWN0IF9fZGVjbHNwZWMgd2l0aGlu
IEpTQmFzZS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xNzk4OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIEFQSS9KU0Jhc2UuaDoKKwogMjAxNy0xMS0xOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9y
dG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIFRPVUNIX0lDT05fTE9BRElO
RyBmZWF0dXJlIGZsYWcK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>327370</attachid>
            <date>2017-11-20 12:05:24 -0800</date>
            <delta_ts>2017-11-20 14:17:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179892.diff</filename>
            <type>text/plain</type>
            <size>1796</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmggYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCmluZGV4IDY3N2RmZjE2ODA1Li44ODFkOWQ0OWZl
ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Jhc2UuaAorKysgYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCkBAIC03MiwxNiArNzIsMTkgQEAgdHlw
ZWRlZiBzdHJ1Y3QgT3BhcXVlSlNWYWx1ZSogSlNPYmplY3RSZWY7CiAvKiBUaGVzZSBydWxlcyBz
aG91bGQgc3RheSB0aGUgc2FtZSBhcyBpbiBXZWJLaXQyL1NoYXJlZC9BUEkvYy9XS0Jhc2UuaCAq
LwogCiAjdW5kZWYgSlNfRVhQT1JUCisjaWYgIWRlZmluZWQoX19oYXNfZGVjbHNwZWNfYXR0cmli
dXRlKQorI2RlZmluZSBfX2hhc19kZWNsc3BlY19hdHRyaWJ1dGUoeCkgMAorI2VuZGlmCiAjaWYg
ZGVmaW5lZChKU19OT19FWFBPUlQpCiAjZGVmaW5lIEpTX0VYUE9SVAotI2VsaWYgZGVmaW5lZChf
X0dOVUNfXykgJiYgIWRlZmluZWQoX19DQ19BUk0pICYmICFkZWZpbmVkKF9fQVJNQ0NfXykKLSNk
ZWZpbmUgSlNfRVhQT1JUIF9fYXR0cmlidXRlX18oKHZpc2liaWxpdHkoImRlZmF1bHQiKSkpCi0j
ZWxpZiBkZWZpbmVkKFdJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMikgfHwgZGVmaW5lZChfV0lOMzJf
V0NFKSB8fCBkZWZpbmVkKF9fQ0NfQVJNKSB8fCBkZWZpbmVkKF9fQVJNQ0NfXykKKyNlbGlmIGRl
ZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKSB8fCAoX19oYXNfZGVjbHNwZWNfYXR0cmli
dXRlKGRsbGltcG9ydCkgJiYgX19oYXNfZGVjbHNwZWNfYXR0cmlidXRlKGRsbGV4cG9ydCkpCiAj
aWYgZGVmaW5lZChCVUlMRElOR19KYXZhU2NyaXB0Q29yZSkgfHwgZGVmaW5lZChTVEFUSUNBTExZ
X0xJTktFRF9XSVRIX0phdmFTY3JpcHRDb3JlKQogI2RlZmluZSBKU19FWFBPUlQgX19kZWNsc3Bl
YyhkbGxleHBvcnQpCiAjZWxzZQogI2RlZmluZSBKU19FWFBPUlQgX19kZWNsc3BlYyhkbGxpbXBv
cnQpCiAjZW5kaWYKKyNlbGlmIGRlZmluZWQoX19HTlVDX18pICYmICFkZWZpbmVkKF9fQ0NfQVJN
KSAmJiAhZGVmaW5lZChfX0FSTUNDX18pCisjZGVmaW5lIEpTX0VYUE9SVCBfX2F0dHJpYnV0ZV9f
KCh2aXNpYmlsaXR5KCJkZWZhdWx0IikpKQogI2Vsc2UgLyogIWRlZmluZWQoSlNfTk9fRVhQT1JU
KSAqLwogI2RlZmluZSBKU19FWFBPUlQKICNlbmRpZiAvKiBkZWZpbmVkKEpTX05PX0VYUE9SVCkg
Ki8KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGY5MmY0MGE4ZDg1Li4yNmU1ZjdhZjM5ZiAx
MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMTEtMjAgIERv
biBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KKworICAgICAgICBEZXRlY3QgX19k
ZWNsc3BlYyB3aXRoaW4gSlNCYXNlLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTE3OTg5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogQVBJL0pTQmFzZS5oOgorCiAyMDE3LTExLTE5ICBUaW0gSG9ydG9u
ICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgVE9V
Q0hfSUNPTl9MT0FESU5HIGZlYXR1cmUgZmxhZwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>327375</attachid>
            <date>2017-11-20 14:17:02 -0800</date>
            <delta_ts>2017-11-20 17:21:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179892.diff</filename>
            <type>text/plain</type>
            <size>2139</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmggYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCmluZGV4IDY3N2RmZjE2ODA1Li4xMjY5OTNiMmY2
MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Jhc2UuaAorKysgYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCkBAIC02OCwyMCArNjgsMzEgQEAgdHlw
ZWRlZiBjb25zdCBzdHJ1Y3QgT3BhcXVlSlNWYWx1ZSogSlNWYWx1ZVJlZjsKIC8qISBAdHlwZWRl
ZiBKU09iamVjdFJlZiBBIEphdmFTY3JpcHQgb2JqZWN0LiBBIEpTT2JqZWN0IGlzIGEgSlNWYWx1
ZS4gKi8KIHR5cGVkZWYgc3RydWN0IE9wYXF1ZUpTVmFsdWUqIEpTT2JqZWN0UmVmOwogCisvKiBD
bGFuZydzIF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZSBlbXVsYXRpb24gKi8KKy8qIGh0dHBzOi8v
Y2xhbmcubGx2bS5vcmcvZG9jcy9MYW5ndWFnZUV4dGVuc2lvbnMuaHRtbCNoYXMtZGVjbHNwZWMt
YXR0cmlidXRlICovCisKKyNpZm5kZWYgX19oYXNfZGVjbHNwZWNfYXR0cmlidXRlCisjaWYgZGVm
aW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIpIHx8IGRlZmluZWQoX19DQ19BUk0pIHx8IGRl
ZmluZWQoX19BUk1DQ19fKQorI2RlZmluZSBfX2hhc19kZWNsc3BlY19hdHRyaWJ1dGUoeCkgMQor
I2Vsc2UKKyNkZWZpbmUgX19oYXNfZGVjbHNwZWNfYXR0cmlidXRlKHgpIDAKKyNlbmRpZgorI2Vu
ZGlmCisKIC8qIEphdmFTY3JpcHQgc3ltYm9sIGV4cG9ydHMgKi8KIC8qIFRoZXNlIHJ1bGVzIHNo
b3VsZCBzdGF5IHRoZSBzYW1lIGFzIGluIFdlYktpdDIvU2hhcmVkL0FQSS9jL1dLQmFzZS5oICov
CiAKICN1bmRlZiBKU19FWFBPUlQKICNpZiBkZWZpbmVkKEpTX05PX0VYUE9SVCkKICNkZWZpbmUg
SlNfRVhQT1JUCi0jZWxpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX0NDX0FSTSkg
JiYgIWRlZmluZWQoX19BUk1DQ19fKQotI2RlZmluZSBKU19FWFBPUlQgX19hdHRyaWJ1dGVfXygo
dmlzaWJpbGl0eSgiZGVmYXVsdCIpKSkKLSNlbGlmIGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQo
X1dJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMl9XQ0UpIHx8IGRlZmluZWQoX19DQ19BUk0pIHx8IGRl
ZmluZWQoX19BUk1DQ19fKQorI2VsaWYgKF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZShkbGxpbXBv
cnQpICYmIF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZShkbGxleHBvcnQpKQogI2lmIGRlZmluZWQo
QlVJTERJTkdfSmF2YVNjcmlwdENvcmUpIHx8IGRlZmluZWQoU1RBVElDQUxMWV9MSU5LRURfV0lU
SF9KYXZhU2NyaXB0Q29yZSkKICNkZWZpbmUgSlNfRVhQT1JUIF9fZGVjbHNwZWMoZGxsZXhwb3J0
KQogI2Vsc2UKICNkZWZpbmUgSlNfRVhQT1JUIF9fZGVjbHNwZWMoZGxsaW1wb3J0KQogI2VuZGlm
CisjZWxpZiBkZWZpbmVkKF9fR05VQ19fKQorI2RlZmluZSBKU19FWFBPUlQgX19hdHRyaWJ1dGVf
XygodmlzaWJpbGl0eSgiZGVmYXVsdCIpKSkKICNlbHNlIC8qICFkZWZpbmVkKEpTX05PX0VYUE9S
VCkgKi8KICNkZWZpbmUgSlNfRVhQT1JUCiAjZW5kaWYgLyogZGVmaW5lZChKU19OT19FWFBPUlQp
ICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBmOTJmNDBhOGQ4NS4uMjZlNWY3YWYzOWYg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTExLTIwICBE
b24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgRGV0ZWN0IF9f
ZGVjbHNwZWMgd2l0aGluIEpTQmFzZS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xNzk4OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICAqIEFQSS9KU0Jhc2UuaDoKKwogMjAxNy0xMS0xOSAgVGltIEhvcnRv
biAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIFRP
VUNIX0lDT05fTE9BRElORyBmZWF0dXJlIGZsYWcK
</data>
<flag name="review"
          id="346613"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>327380</attachid>
            <date>2017-11-20 17:21:35 -0800</date>
            <delta_ts>2017-11-20 18:48:17 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179892.diff</filename>
            <type>text/plain</type>
            <size>2080</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmggYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCmluZGV4IDY3N2RmZjE2ODA1Li5mZTAwYThkMzU3
NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Jhc2UuaAorKysgYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCkBAIC02OCwyMCArNjgsMjcgQEAgdHlw
ZWRlZiBjb25zdCBzdHJ1Y3QgT3BhcXVlSlNWYWx1ZSogSlNWYWx1ZVJlZjsKIC8qISBAdHlwZWRl
ZiBKU09iamVjdFJlZiBBIEphdmFTY3JpcHQgb2JqZWN0LiBBIEpTT2JqZWN0IGlzIGEgSlNWYWx1
ZS4gKi8KIHR5cGVkZWYgc3RydWN0IE9wYXF1ZUpTVmFsdWUqIEpTT2JqZWN0UmVmOwogCisvKiBD
bGFuZydzIF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZSBlbXVsYXRpb24gKi8KKy8qIGh0dHBzOi8v
Y2xhbmcubGx2bS5vcmcvZG9jcy9MYW5ndWFnZUV4dGVuc2lvbnMuaHRtbCNoYXMtZGVjbHNwZWMt
YXR0cmlidXRlICovCisKKyNpZm5kZWYgX19oYXNfZGVjbHNwZWNfYXR0cmlidXRlCisjZGVmaW5l
IF9faGFzX2RlY2xzcGVjX2F0dHJpYnV0ZSh4KSAwCisjZW5kaWYKKwogLyogSmF2YVNjcmlwdCBz
eW1ib2wgZXhwb3J0cyAqLwogLyogVGhlc2UgcnVsZXMgc2hvdWxkIHN0YXkgdGhlIHNhbWUgYXMg
aW4gV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tCYXNlLmggKi8KIAogI3VuZGVmIEpTX0VYUE9SVAog
I2lmIGRlZmluZWQoSlNfTk9fRVhQT1JUKQogI2RlZmluZSBKU19FWFBPUlQKLSNlbGlmIGRlZmlu
ZWQoX19HTlVDX18pICYmICFkZWZpbmVkKF9fQ0NfQVJNKSAmJiAhZGVmaW5lZChfX0FSTUNDX18p
Ci0jZGVmaW5lIEpTX0VYUE9SVCBfX2F0dHJpYnV0ZV9fKCh2aXNpYmlsaXR5KCJkZWZhdWx0Iikp
KQotI2VsaWYgZGVmaW5lZChXSU4zMikgfHwgZGVmaW5lZChfV0lOMzIpIHx8IGRlZmluZWQoX1dJ
TjMyX1dDRSkgfHwgZGVmaW5lZChfX0NDX0FSTSkgfHwgZGVmaW5lZChfX0FSTUNDX18pCisjZWxp
ZiBkZWZpbmVkKFdJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMikgfHwgZGVmaW5lZChfX0NDX0FSTSkg
fHwgZGVmaW5lZChfX0FSTUNDX18pIHx8IChfX2hhc19kZWNsc3BlY19hdHRyaWJ1dGUoZGxsaW1w
b3J0KSAmJiBfX2hhc19kZWNsc3BlY19hdHRyaWJ1dGUoZGxsZXhwb3J0KSkKICNpZiBkZWZpbmVk
KEJVSUxESU5HX0phdmFTY3JpcHRDb3JlKSB8fCBkZWZpbmVkKFNUQVRJQ0FMTFlfTElOS0VEX1dJ
VEhfSmF2YVNjcmlwdENvcmUpCiAjZGVmaW5lIEpTX0VYUE9SVCBfX2RlY2xzcGVjKGRsbGV4cG9y
dCkKICNlbHNlCiAjZGVmaW5lIEpTX0VYUE9SVCBfX2RlY2xzcGVjKGRsbGltcG9ydCkKICNlbmRp
ZgorI2VsaWYgZGVmaW5lZChfX0dOVUNfXykKKyNkZWZpbmUgSlNfRVhQT1JUIF9fYXR0cmlidXRl
X18oKHZpc2liaWxpdHkoImRlZmF1bHQiKSkpCiAjZWxzZSAvKiAhZGVmaW5lZChKU19OT19FWFBP
UlQpICovCiAjZGVmaW5lIEpTX0VYUE9SVAogI2VuZGlmIC8qIGRlZmluZWQoSlNfTk9fRVhQT1JU
KSAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZjkyZjQwYThkODUuLjI2ZTVmN2FmMzlm
IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0xMS0yMCAg
RG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIERldGVjdCBf
X2RlY2xzcGVjIHdpdGhpbiBKU0Jhc2UuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTc5ODkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs
ZXIuCisKKyAgICAgICAgKiBBUEkvSlNCYXNlLmg6CisKIDIwMTctMTEtMTkgIFRpbSBIb3J0b24g
IDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBUT1VD
SF9JQ09OX0xPQURJTkcgZmVhdHVyZSBmbGFnCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>