179864 2017-11-18 13:03:06 -0800 filter-build-webkit filters out useful compiler error lines 2018-01-03 16:43:24 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser ap commit-queue dbates dino jbedard lforschler simon.fraser thorton webkit-bug-importer oldest_to_newest 1373574 0 simon.fraser 2017-11-18 13:03:06 -0800 filter-build-webkit turns this: In file included from /Volumes/DataSSD/Development/apple/webkit/OpenSource/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource356.cpp:1: /Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing] std::max(0, std::min(static_cast<int>(floatComponents.components[0] * 255), 255)), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: note: insert an explicit cast to silence this issue std::max(0, std::min(static_cast<int>(floatComponents.components[0] * 255), 255)), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ static_cast<float>( ) into this: In file included from /Volumes/DataSSD/Development/apple/webkit/OpenSource/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource356.cpp:1: /Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: note: insert an explicit cast to silence this issue ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ static_cast<float>( ) which hides some detail needed to fix bugs. 1383842 1 329955 simon.fraser 2017-12-20 14:52:06 -0800 Created attachment 329955 Patch 1385528 2 330405 simon.fraser 2018-01-03 11:48:55 -0800 Created attachment 330405 Patch 1385609 3 330405 commit-queue 2018-01-03 16:42:24 -0800 Comment on attachment 330405 Patch Clearing flags on attachment: 330405 Committed r226378: <https://trac.webkit.org/changeset/226378> 1385610 4 commit-queue 2018-01-03 16:42:26 -0800 All reviewed patches have been landed. Closing bug. 1385611 5 webkit-bug-importer 2018-01-03 16:43:24 -0800 <rdar://problem/36287675> 329955 2017-12-20 14:52:06 -0800 2018-01-03 11:48:52 -0800 Patch patch.txt text/plain 1143 simon.fraser ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdCBiL1Rvb2xzL1Nj cmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdAppbmRleCA0MWNlMDE3ZTJhYmFmMmUyZWVjNzBjNGZj MjZhMjhiNDlkNjA2ZDRjLi5kMGFiZWQ5YTVhYTU0NGI3MDZhNGJkMWYwMzg4NmI4NWQ4OTdiZGEy IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQKKysrIGIvVG9v bHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0CkBAIC0yMjksNiArMjI5LDE2IEBAIHN1YiBz ZXRPdXRwdXRGb3JtYXRPcHRpb24oJCQpCiAgICAgJG91dHB1dEZvcm1hdCA9ICR2YWx1ZTsKIH0K IAorc3ViIHNob3VsZFNob3dTdWJzZXF1ZW50TGluZSgkKQoreworICAgIG15ICgkbGluZSkgPSBA XzsKKworICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9yZWZlcmVuY2VkIGZyb206JC87CisgICAg cmV0dXJuIDEgaWYgJGxpbmUgPX4gLyhub3RlOnxlcnJvcjopLzsKKyAgICAKKyAgICByZXR1cm4g MDsKK30KKwogc3ViIHNob3VsZElnbm9yZUxpbmUoJCQpCiB7CiAgICAgbXkgKCRwcmV2aW91c0xp bmUsICRsaW5lKSA9IEBfOwpAQCAtMjgxLDcgKzI5MSw3IEBAIHN1YiBzaG91bGRJZ25vcmVMaW5l KCQkKQogICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvd2hpY2guZXhlIGJhc2gvOwogICAg IH0gZWxzZSB7CiAgICAgICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eKHRvdWNofHBlcmx8Y2F0 fHJtIC1mfGJpc29ufGZsZXh8cHl0aG9ufFwvdXNyXC9iaW5cL2dcK1wrfFwvYmluXC9sbnxncGVy ZnxlY2hvfHNlZHxpZiBcWyBcLWZ8V2ViQ29yZVwvZ2VuZXJhdGUtZXhwb3J0LWZpbGV8d3JpdGUt ZmlsZXxjaG1vZCkgLzsKLSAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL14gICAgLyAmJiAk cHJldmlvdXNMaW5lICF+IC9yZWZlcmVuY2VkIGZyb206JC87CisgICAgICAgIHJldHVybiAxIGlm ICRsaW5lID1+IC9eICAgIC8gJiYgIXNob3VsZFNob3dTdWJzZXF1ZW50TGluZSgkcHJldmlvdXNM aW5lKTsKICAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15wcmludGYgLzsKICAgICAgICAg cmV0dXJuIDEgaWYgJGxpbmUgPX4gL15vZmZsaW5lYXNtOiBOb3RoaW5nIGNoYW5nZWQvOwogICAg IH0K 330405 2018-01-03 11:48:55 -0800 2018-01-03 16:42:24 -0800 Patch bug-179864-20180103114854.patch text/plain 2003 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjI2MzY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBkYTBjZjU2NjdlN2M2MDk4Y2RmMTU3N2Y5NzgxN2E1 ODI3ZjRhOS4uMTNlYTc5MmRmM2NmNzk4MjhlYzJjZTczZDZiYmUwNDVlNDJjOGU4NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTAxLTAzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIGZpbHRlci1idWlsZC13ZWJraXQgZmlsdGVycyBvdXQgdXNlZnVsIGNvbXBpbGVy IGVycm9yIGxpbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzk4NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEb24ndCBmaWx0ZXIgb3V0IGxpbmVzIHRoYXQgY29udGFpbiBpbmZvcm1hdGlvbiBhYm91 dCBidWlsZCBlcnJvcnMgYnkgYWx3YXlzIHNob3dpbmcgbGluZXMKKyAgICAgICAgYWZ0ZXIgYSBs aW5lIHRoYXQgY29udGFpbnMgIm5vdGU6IiBvciAiZXJyb3I6Ii4KKworICAgICAgICAqIFNjcmlw dHMvZmlsdGVyLWJ1aWxkLXdlYmtpdDoKKyAgICAgICAgKHNob3VsZFNob3dTdWJzZXF1ZW50TGlu ZSk6CisgICAgICAgIChzaG91bGRJZ25vcmVMaW5lKToKKwogMjAxOC0wMS0wMyAgTWljaGFlbCBD YXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHdl YiBwcm9jZXNzIEFQSSB0byBkZXRlY3Qgd2hlbiBmb3JtIGlzIHN1Ym1pdHRlZCB2aWEgSmF2YVNj cmlwdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0IGIvVG9v bHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0CmluZGV4IDQxY2UwMTdlMmFiYWYyZTJlZWM3 MGM0ZmMyNmEyOGI0OWQ2MDZkNGMuLmQwYWJlZDlhNWFhNTQ0YjcwNmE0YmQxZjAzODg2Yjg1ZDg5 N2JkYTIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdAorKysg Yi9Ub29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQKQEAgLTIyOSw2ICsyMjksMTYgQEAg c3ViIHNldE91dHB1dEZvcm1hdE9wdGlvbigkJCkKICAgICAkb3V0cHV0Rm9ybWF0ID0gJHZhbHVl OwogfQogCitzdWIgc2hvdWxkU2hvd1N1YnNlcXVlbnRMaW5lKCQpCit7CisgICAgbXkgKCRsaW5l KSA9IEBfOworCisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL3JlZmVyZW5jZWQgZnJvbTokLzsK KyAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvKG5vdGU6fGVycm9yOikvOworICAgIAorICAgIHJl dHVybiAwOworfQorCiBzdWIgc2hvdWxkSWdub3JlTGluZSgkJCkKIHsKICAgICBteSAoJHByZXZp b3VzTGluZSwgJGxpbmUpID0gQF87CkBAIC0yODEsNyArMjkxLDcgQEAgc3ViIHNob3VsZElnbm9y ZUxpbmUoJCQpCiAgICAgICAgIHJldHVybiAxIGlmICRsaW5lID1+IC93aGljaC5leGUgYmFzaC87 CiAgICAgfSBlbHNlIHsKICAgICAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL14odG91Y2h8cGVy bHxjYXR8cm0gLWZ8Ymlzb258ZmxleHxweXRob258XC91c3JcL2JpblwvZ1wrXCt8XC9iaW5cL2xu fGdwZXJmfGVjaG98c2VkfGlmIFxbIFwtZnxXZWJDb3JlXC9nZW5lcmF0ZS1leHBvcnQtZmlsZXx3 cml0ZS1maWxlfGNobW9kKSAvOwotICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXiAgICAv ICYmICRwcmV2aW91c0xpbmUgIX4gL3JlZmVyZW5jZWQgZnJvbTokLzsKKyAgICAgICAgcmV0dXJu IDEgaWYgJGxpbmUgPX4gL14gICAgLyAmJiAhc2hvdWxkU2hvd1N1YnNlcXVlbnRMaW5lKCRwcmV2 aW91c0xpbmUpOwogICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXnByaW50ZiAvOwogICAg ICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXm9mZmxpbmVhc206IE5vdGhpbmcgY2hhbmdlZC87 CiAgICAgfQo=