179834 2017-11-17 12:03:22 -0800 Do not run webkitpy tests on multiple EWSes 2017-11-27 17:27:29 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1373198 0 aakash_jain 2017-11-17 12:03:22 -0800 We now have a separate webkitpy test EWS which run webkitpy-tests on every patch (as appropriate). Currently all the EWSes which run tests also run webkitpy tests, but ignore it's output. There is no point in running these tests and ignoring the output. We should remove this old code. 1373201 1 aakash_jain 2017-11-17 12:12:20 -0800 To clarify, we don't want to run these tests on multiple EWSes. EWSes use the parameter --non-interactive. We still want to run these tests when running manually, i.e. when --non-interactive option is not passed. 1373202 2 327210 aakash_jain 2017-11-17 12:12:38 -0800 Created attachment 327210 Proposed patch 1373639 3 327210 ap 2017-11-18 21:10:41 -0800 Comment on attachment 327210 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=327210&action=review > Tools/Scripts/webkitpy/tool/steps/runtests.py:87 > + python_unittests_command = self._tool.deprecated_port().run_python_unittests_command() The FIXME above doesn’t seem accurate for webkitpy 1375222 4 327716 aakash_jain 2017-11-27 16:55:35 -0800 Created attachment 327716 Updated patch Patch for landing. 1375228 5 327716 commit-queue 2017-11-27 17:21:43 -0800 Comment on attachment 327716 Updated patch Clearing flags on attachment: 327716 Committed r225206: <https://trac.webkit.org/changeset/225206> 1375229 6 commit-queue 2017-11-27 17:21:45 -0800 All reviewed patches have been landed. Closing bug. 1375230 7 webkit-bug-importer 2017-11-27 17:27:29 -0800 <rdar://problem/35712592> 327210 2017-11-17 12:12:38 -0800 2017-11-27 16:55:35 -0800 Proposed patch ews_webkitpy_remove.patch text/plain 2790 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNDk3NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTExLTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEbyBub3QgcnVuIHdlYmtpdHB5IHRlc3RzIG9uIG11bHRpcGxlIEVXU2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk4MzQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3Qg cnVuIHdlYmtpdHB5IHRlc3RzIGluIGV2ZXJ5IEVXUy4gV2Ugbm93IGhhdmUKKyAgICAgICAgYSBk ZWRpY2F0ZWQgYmluZGluZ3MgdGVzdCBFV1MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvc3RlcHMvcnVudGVzdHMucHk6CisgICAgICAgIChSdW5UZXN0cy5ydW4pOiBEbyBub3Qg cnVuIHdlYmtpdHB5IHRlc3RzIGluIEVXU2VzLiBUaGVzZSB0ZXN0cyB3aWxsIHN0aWxsIHJ1bgor ICAgICAgICB3aGVuIC0tbm9uLWludGVyYWN0aXZlIG9wdGlvbiBpcyBub3QgcGFzc2VkLiAKKwog MjAxNy0xMS0xNiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAg ICAgIFtXaW5DYWlyb10gVXBkYXRlIFdpbkNhaXJvUmVxdWlyZW1lbnRzCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcnVudGVzdHMucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3J1bnRlc3RzLnB5CShyZXZpc2lvbiAyMjQ5 NzcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcnVudGVzdHMucHkJKHdv cmtpbmcgY29weSkKQEAgLTgxLDIzICs4MSwxNCBAQCBjbGFzcyBSdW5UZXN0cyhBYnN0cmFjdFN0 ZXApOgogICAgICAgICBpZiBub3Qgc2VsZi5fb3B0aW9ucy50ZXN0OgogICAgICAgICAgICAgcmV0 dXJuCiAKLSAgICAgICAgcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kID0gc2VsZi5fdG9vbC5kZXBy ZWNhdGVkX3BvcnQoKS5ydW5fcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kKCkKLSAgICAgICAgaWYg cHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kOgotICAgICAgICAgICAgX2xvZy5pbmZvKCJSdW5uaW5n IFB5dGhvbiB1bml0IHRlc3RzIikKLSAgICAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMubm9uX2lu dGVyYWN0aXZlOgotICAgICAgICAgICAgICAgIGZpbGVzeXN0ZW0gPSBzZWxmLl90b29sLmZpbGVz eXN0ZW0KLSAgICAgICAgICAgICAgICBweXRob25fdW5pdHRlc3RfcmVzdWx0c19kaXJlY3Rvcnkg PSBzZWxmLl90b29sLnBvcnRfZmFjdG9yeS5nZXQoKS5weXRob25fdW5pdHRlc3RfcmVzdWx0c19k aXJlY3RvcnkoKQotICAgICAgICAgICAgICAgIGZpbGVzeXN0ZW0ubWF5YmVfbWFrZV9kaXJlY3Rv cnkocHl0aG9uX3VuaXR0ZXN0X3Jlc3VsdHNfZGlyZWN0b3J5KQotCi0gICAgICAgICAgICAgICAg cHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kLmFwcGVuZCgnLS1qc29uJykKLSAgICAgICAgICAgICAg ICBvdXRwdXQgPSBzZWxmLl90b29sLmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChweXRob25fdW5pdHRl c3RzX2NvbW1hbmQsIGN3ZD1zZWxmLl90b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QsIGVycm9yX2hh bmRsZXI9RXhlY3V0aXZlLmlnbm9yZV9lcnJvciwgcmV0dXJuX3N0ZGVycj1GYWxzZSkKLSAgICAg ICAgICAgICAgICBmaWxlc3lzdGVtLndyaXRlX3RleHRfZmlsZShmaWxlc3lzdGVtLmpvaW4ocHl0 aG9uX3VuaXR0ZXN0X3Jlc3VsdHNfZGlyZWN0b3J5LCAicmVzdWx0cy5qc29uIiksIG91dHB1dCkK LSAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICAgICAgc2VsZi5fdG9vbC5leGVjdXRpdmUu cnVuX2FuZF90aHJvd19pZl9mYWlsKHB5dGhvbl91bml0dGVzdHNfY29tbWFuZCwgY3dkPXNlbGYu X3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKLQogICAgICAgICBpZiBub3Qgc2VsZi5fb3B0aW9u cy5ub25faW50ZXJhY3RpdmU6CiAgICAgICAgICAgICAjIEZJWE1FOiBXZSBzaG91bGQgdGVhY2gg dGhlIGNvbW1pdC1xdWV1ZSBhbmQgdGhlIEVXUyBob3cgdG8gcnVuIHRoZXNlIHRlc3RzLgogCisg ICAgICAgICAgICBweXRob25fdW5pdHRlc3RzX2NvbW1hbmQgPSBzZWxmLl90b29sLmRlcHJlY2F0 ZWRfcG9ydCgpLnJ1bl9weXRob25fdW5pdHRlc3RzX2NvbW1hbmQoKQorICAgICAgICAgICAgaWYg cHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kOgorICAgICAgICAgICAgICAgIF9sb2cuaW5mbygiUnVu bmluZyBQeXRob24gdW5pdCB0ZXN0cyIpCisgICAgICAgICAgICAgICAgc2VsZi5fdG9vbC5leGVj dXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKHB5dGhvbl91bml0dGVzdHNfY29tbWFuZCwgY3dk PXNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKKwogICAgICAgICAgICAgcGVybF91bml0 dGVzdHNfY29tbWFuZCA9IHNlbGYuX3Rvb2wuZGVwcmVjYXRlZF9wb3J0KCkucnVuX3BlcmxfdW5p dHRlc3RzX2NvbW1hbmQoKQogICAgICAgICAgICAgaWYgcGVybF91bml0dGVzdHNfY29tbWFuZDoK ICAgICAgICAgICAgICAgICBfbG9nLmluZm8oIlJ1bm5pbmcgUGVybCB1bml0IHRlc3RzIikK 327716 2017-11-27 16:55:35 -0800 2017-11-27 17:21:43 -0800 Updated patch ews_webkitpy_remove1.patch text/plain 2746 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNTIwNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTExLTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEbyBub3QgcnVuIHdlYmtpdHB5IHRlc3RzIG9uIG11bHRpcGxlIEVXU2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk4MzQK KworICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgorCisgICAgICAgIERv IG5vdCBydW4gd2Via2l0cHkgdGVzdHMgaW4gZXZlcnkgRVdTLiBXZSBub3cgaGF2ZQorICAgICAg ICBhIGRlZGljYXRlZCB3ZWJraXRweSB0ZXN0IEVXUy4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zdGVwcy9ydW50ZXN0cy5weToKKyAgICAgICAgKFJ1blRlc3RzLnJ1bik6IERv IG5vdCBydW4gd2Via2l0cHkgdGVzdHMgaW4gRVdTZXMuIFRoZXNlIHRlc3RzIHdpbGwgc3RpbGwg cnVuCisgICAgICAgIHdoZW4gLS1ub24taW50ZXJhY3RpdmUgb3B0aW9uIGlzIG5vdCBwYXNzZWQu IAorCiAyMDE3LTExLTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAog ICAgICAgICB3ZWJraXRweTogQmV0dGVyIG5hbWUtdmVyc2lvbiBtYXBwaW5nIChQYXJ0IDEpCklu ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcnVudGVzdHMucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3J1bnRlc3RzLnB5CShy ZXZpc2lvbiAyMjUyMDUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcnVu dGVzdHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTgxLDIyICs4MSwxMSBAQCBjbGFzcyBSdW5UZXN0 cyhBYnN0cmFjdFN0ZXApOgogICAgICAgICBpZiBub3Qgc2VsZi5fb3B0aW9ucy50ZXN0OgogICAg ICAgICAgICAgcmV0dXJuCiAKLSAgICAgICAgcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kID0gc2Vs Zi5fdG9vbC5kZXByZWNhdGVkX3BvcnQoKS5ydW5fcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kKCkK LSAgICAgICAgaWYgcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kOgotICAgICAgICAgICAgX2xvZy5p bmZvKCJSdW5uaW5nIFB5dGhvbiB1bml0IHRlc3RzIikKLSAgICAgICAgICAgIGlmIHNlbGYuX29w dGlvbnMubm9uX2ludGVyYWN0aXZlOgotICAgICAgICAgICAgICAgIGZpbGVzeXN0ZW0gPSBzZWxm Ll90b29sLmZpbGVzeXN0ZW0KLSAgICAgICAgICAgICAgICBweXRob25fdW5pdHRlc3RfcmVzdWx0 c19kaXJlY3RvcnkgPSBzZWxmLl90b29sLnBvcnRfZmFjdG9yeS5nZXQoKS5weXRob25fdW5pdHRl c3RfcmVzdWx0c19kaXJlY3RvcnkoKQotICAgICAgICAgICAgICAgIGZpbGVzeXN0ZW0ubWF5YmVf bWFrZV9kaXJlY3RvcnkocHl0aG9uX3VuaXR0ZXN0X3Jlc3VsdHNfZGlyZWN0b3J5KQotCi0gICAg ICAgICAgICAgICAgcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kLmFwcGVuZCgnLS1qc29uJykKLSAg ICAgICAgICAgICAgICBvdXRwdXQgPSBzZWxmLl90b29sLmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChw eXRob25fdW5pdHRlc3RzX2NvbW1hbmQsIGN3ZD1zZWxmLl90b29sLnNjbSgpLmNoZWNrb3V0X3Jv b3QsIGVycm9yX2hhbmRsZXI9RXhlY3V0aXZlLmlnbm9yZV9lcnJvciwgcmV0dXJuX3N0ZGVycj1G YWxzZSkKLSAgICAgICAgICAgICAgICBmaWxlc3lzdGVtLndyaXRlX3RleHRfZmlsZShmaWxlc3lz dGVtLmpvaW4ocHl0aG9uX3VuaXR0ZXN0X3Jlc3VsdHNfZGlyZWN0b3J5LCAicmVzdWx0cy5qc29u IiksIG91dHB1dCkKLSAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAgICAgICAgc2VsZi5fdG9v bC5leGVjdXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKHB5dGhvbl91bml0dGVzdHNfY29tbWFu ZCwgY3dkPXNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKLQogICAgICAgICBpZiBub3Qg c2VsZi5fb3B0aW9ucy5ub25faW50ZXJhY3RpdmU6Ci0gICAgICAgICAgICAjIEZJWE1FOiBXZSBz aG91bGQgdGVhY2ggdGhlIGNvbW1pdC1xdWV1ZSBhbmQgdGhlIEVXUyBob3cgdG8gcnVuIHRoZXNl IHRlc3RzLgorICAgICAgICAgICAgcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kID0gc2VsZi5fdG9v bC5kZXByZWNhdGVkX3BvcnQoKS5ydW5fcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5kKCkKKyAgICAg ICAgICAgIGlmIHB5dGhvbl91bml0dGVzdHNfY29tbWFuZDoKKyAgICAgICAgICAgICAgICBfbG9n LmluZm8oIlJ1bm5pbmcgUHl0aG9uIHVuaXQgdGVzdHMiKQorICAgICAgICAgICAgICAgIHNlbGYu X3Rvb2wuZXhlY3V0aXZlLnJ1bl9hbmRfdGhyb3dfaWZfZmFpbChweXRob25fdW5pdHRlc3RzX2Nv bW1hbmQsIGN3ZD1zZWxmLl90b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpCiAKICAgICAgICAgICAg IHBlcmxfdW5pdHRlc3RzX2NvbW1hbmQgPSBzZWxmLl90b29sLmRlcHJlY2F0ZWRfcG9ydCgpLnJ1 bl9wZXJsX3VuaXR0ZXN0c19jb21tYW5kKCkKICAgICAgICAgICAgIGlmIHBlcmxfdW5pdHRlc3Rz X2NvbW1hbmQ6Cg==