179832 2017-11-17 11:04:42 -0800 FETurbulence const and inline cleanup 2017-11-17 11:41:37 -0800 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser webkit-unassigned commit-queue dino ews-watchlist kondapallykalyan simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1373162 0 simon.fraser 2017-11-17 11:04:42 -0800 Minor cleanup. 1373164 1 327198 simon.fraser 2017-11-17 11:06:25 -0800 Created attachment 327198 Patch 1373179 2 327198 commit-queue 2017-11-17 11:40:01 -0800 Comment on attachment 327198 Patch Clearing flags on attachment: 327198 Committed r224977: <https://trac.webkit.org/changeset/224977> 1373180 3 commit-queue 2017-11-17 11:40:03 -0800 All reviewed patches have been landed. Closing bug. 1373184 4 webkit-bug-importer 2017-11-17 11:41:37 -0800 <rdar://problem/35620198> 327198 2017-11-17 11:06:25 -0800 2017-11-17 11:40:01 -0800 Patch const-line.patch text/plain 7011 simon.fraser ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNDEwMmI0NmY1YTQ5MDdmMGFjMjJjOTA2ODM1ZTE3ZDYyNWI1ZDk5Li4y Zjk4N2NiYTdiY2IxMWJhZDMwMzhjNDZmM2Y4MDhlYjAyNzQwNjFmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMjQgQEAKIDIwMTctMTEtMTcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKKyAgICAgICAgRkVUdXJidWxlbmNlIGNvbnN0IGFuZCBpbmxpbmUgY2xlYW51cAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5ODMyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFzcyB0aGUg UGFpbnRpbmdEYXRhJiBhcm91bmQgYXMgY29uc3QsIGFuZCByZW1vdmUgc29tZSAnaW5saW5lJywg bGV0dGluZyB0aGUgY29tcGlsZXIKKyAgICAgICAgZGVjaWRlLiBBbHNvIGRlY2xhcmUgYSBmZXcg dmFyaWFibGVzIGNsb3NlciB0byBmaXJzdCB1c2UuCisgICAgICAgIAorICAgICAgICBTcGVlZHMg dXAgRkVUdXJidWxlbmNlIGJ5IGFib3V0IDElLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvZmlsdGVycy9GRVR1cmJ1bGVuY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RkVUdXJidWxl bmNlOjppbml0UGFpbnQpOgorICAgICAgICAoV2ViQ29yZTo6RkVUdXJidWxlbmNlOjpub2lzZTJE KToKKyAgICAgICAgKFdlYkNvcmU6OkZFVHVyYnVsZW5jZTo6Y2FsY3VsYXRlVHVyYnVsZW5jZVZh bHVlRm9yUG9pbnQpOgorICAgICAgICAoV2ViQ29yZTo6RkVUdXJidWxlbmNlOjpmaWxsUmVnaW9u KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFVHVyYnVsZW5jZS5oOgor CisyMDE3LTExLTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCiAg ICAgICAgIERvbid0IGludmVydCBhIG1hdHJpeCBmb3IgZXZlcnkgY2hhbm5lbCBvZiBldmVyeSBw aXhlbCBvZiBhbiBGRVR1cmJ1bGVuY2UgZmlsdGVyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk4MjkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRVR1cmJ1bGVuY2UuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRVR1cmJ1bGVuY2UuY3BwCmluZGV4IDA1 Y2Y5ODY0OWM2MmZhMjY5ZjE4ODQxODljNGY0ODA1ZTA3NDhlOWIuLjIzNGY3MGI3MDcyYjA4YzY0 YzBmZDBlNmY0MzQyOGMwYTM4ODAxNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVUdXJidWxlbmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFVHVyYnVsZW5jZS5jcHAKQEAgLTE2NSw3ICsx NjUsNyBAQCBpbmxpbmUgZmxvYXQgbGluZWFySW50ZXJwb2xhdGlvbihmbG9hdCB0LCBmbG9hdCBh LCBmbG9hdCBiKQogICAgIHJldHVybiBhICsgdCAqIChiIC0gYSk7CiB9CiAKLWlubGluZSB2b2lk IEZFVHVyYnVsZW5jZTo6aW5pdFBhaW50KFBhaW50aW5nRGF0YSYgcGFpbnRpbmdEYXRhKQordm9p ZCBGRVR1cmJ1bGVuY2U6OmluaXRQYWludChQYWludGluZ0RhdGEmIHBhaW50aW5nRGF0YSkKIHsK ICAgICBmbG9hdCBub3JtYWxpemF0aW9uRmFjdG9yOwogCkBAIC0xODksNiArMTg5LDcgQEAgaW5s aW5lIHZvaWQgRkVUdXJidWxlbmNlOjppbml0UGFpbnQoUGFpbnRpbmdEYXRhJiBwYWludGluZ0Rh dGEpCiAgICAgICAgICAgICBncmFkaWVudFsxXSAvPSBub3JtYWxpemF0aW9uRmFjdG9yOwogICAg ICAgICB9CiAgICAgfQorCiAgICAgZm9yIChpbnQgaSA9IHNfYmxvY2tTaXplIC0gMTsgaSA+IDA7 IC0taSkgewogICAgICAgICBpbnQgayA9IHBhaW50aW5nRGF0YS5sYXR0aWNlU2VsZWN0b3JbaV07 CiAgICAgICAgIGludCBqID0gcGFpbnRpbmdEYXRhLnJhbmRvbSgpICUgc19ibG9ja1NpemU7CkBA IC0xOTcsNiArMTk4LDcgQEAgaW5saW5lIHZvaWQgRkVUdXJidWxlbmNlOjppbml0UGFpbnQoUGFp bnRpbmdEYXRhJiBwYWludGluZ0RhdGEpCiAgICAgICAgIHBhaW50aW5nRGF0YS5sYXR0aWNlU2Vs ZWN0b3JbaV0gPSBwYWludGluZ0RhdGEubGF0dGljZVNlbGVjdG9yW2pdOwogICAgICAgICBwYWlu dGluZ0RhdGEubGF0dGljZVNlbGVjdG9yW2pdID0gazsKICAgICB9CisKICAgICBmb3IgKGludCBp ID0gMDsgaSA8IHNfYmxvY2tTaXplICsgMjsgKytpKSB7CiAgICAgICAgIHBhaW50aW5nRGF0YS5s YXR0aWNlU2VsZWN0b3Jbc19ibG9ja1NpemUgKyBpXSA9IHBhaW50aW5nRGF0YS5sYXR0aWNlU2Vs ZWN0b3JbaV07CiAgICAgICAgIGZvciAoaW50IGNoYW5uZWwgPSAwOyBjaGFubmVsIDwgNDsgKytj aGFubmVsKSB7CkBAIC0yMTQsNyArMjE2LDcgQEAgaW5saW5lIHZvaWQgY2hlY2tOb2lzZShpbnQm IG5vaXNlVmFsdWUsIGludCBsaW1pdFZhbHVlLCBpbnQgbmV3VmFsdWUpCiAgICAgICAgIG5vaXNl VmFsdWUgLT0gbmV3VmFsdWUgLSAxOwogfQogCi1mbG9hdCBGRVR1cmJ1bGVuY2U6Om5vaXNlMkQo aW50IGNoYW5uZWwsIFBhaW50aW5nRGF0YSYgcGFpbnRpbmdEYXRhLCBTdGl0Y2hEYXRhJiBzdGl0 Y2hEYXRhLCBjb25zdCBGbG9hdFBvaW50JiBub2lzZVZlY3RvcikKK2Zsb2F0IEZFVHVyYnVsZW5j ZTo6bm9pc2UyRChpbnQgY2hhbm5lbCwgY29uc3QgUGFpbnRpbmdEYXRhJiBwYWludGluZ0RhdGEs IFN0aXRjaERhdGEmIHN0aXRjaERhdGEsIGNvbnN0IEZsb2F0UG9pbnQmIG5vaXNlVmVjdG9yKQog ewogICAgIHN0cnVjdCBOb2lzZSB7CiAgICAgICAgIGludCBub2lzZVBvc2l0aW9uSW50ZWdlclZh bHVlOwpAQCAtMjMwLDggKzIzMiw2IEBAIGZsb2F0IEZFVHVyYnVsZW5jZTo6bm9pc2UyRChpbnQg Y2hhbm5lbCwgUGFpbnRpbmdEYXRhJiBwYWludGluZ0RhdGEsIFN0aXRjaERhdGEmCiAKICAgICBO b2lzZSBub2lzZVgobm9pc2VWZWN0b3IueCgpKTsKICAgICBOb2lzZSBub2lzZVkobm9pc2VWZWN0 b3IueSgpKTsKLSAgICBmbG9hdCogcTsKLSAgICBmbG9hdCBzeCwgc3ksIGEsIGIsIHUsIHY7CiAK ICAgICAvLyBJZiBzdGl0Y2hpbmcsIGFkanVzdCBsYXR0aWNlIHBvaW50cyBhY2NvcmRpbmdseS4K ICAgICBpZiAobV9zdGl0Y2hUaWxlcykgewpAQCAtMjQ0LDEyICsyNDQsMTMgQEAgZmxvYXQgRkVU dXJidWxlbmNlOjpub2lzZTJEKGludCBjaGFubmVsLCBQYWludGluZ0RhdGEmIHBhaW50aW5nRGF0 YSwgU3RpdGNoRGF0YSYKICAgICBpbnQgbGF0dGljZUluZGV4ID0gcGFpbnRpbmdEYXRhLmxhdHRp Y2VTZWxlY3Rvcltub2lzZVgubm9pc2VQb3NpdGlvbkludGVnZXJWYWx1ZV07CiAgICAgaW50IG5l eHRMYXR0aWNlSW5kZXggPSBwYWludGluZ0RhdGEubGF0dGljZVNlbGVjdG9yWyhub2lzZVgubm9p c2VQb3NpdGlvbkludGVnZXJWYWx1ZSArIDEpICYgc19ibG9ja01hc2tdOwogCi0gICAgc3ggPSBz bW9vdGhDdXJ2ZShub2lzZVgubm9pc2VQb3NpdGlvbkZyYWN0aW9uVmFsdWUpOwotICAgIHN5ID0g c21vb3RoQ3VydmUobm9pc2VZLm5vaXNlUG9zaXRpb25GcmFjdGlvblZhbHVlKTsKKyAgICBmbG9h dCBzeCA9IHNtb290aEN1cnZlKG5vaXNlWC5ub2lzZVBvc2l0aW9uRnJhY3Rpb25WYWx1ZSk7Cisg ICAgZmxvYXQgc3kgPSBzbW9vdGhDdXJ2ZShub2lzZVkubm9pc2VQb3NpdGlvbkZyYWN0aW9uVmFs dWUpOworICAgIGZsb2F0IGEsIGIsIHUsIHY7CiAKICAgICAvLyBUaGlzIGlzIHRha2VuIDE6MSBm cm9tIFNWRyBzcGVjOiBodHRwOi8vd3d3LnczLm9yZy9UUi9TVkcxMS9maWx0ZXJzLmh0bWwjZmVU dXJidWxlbmNlRWxlbWVudC4KICAgICBpbnQgdGVtcCA9IHBhaW50aW5nRGF0YS5sYXR0aWNlU2Vs ZWN0b3JbbGF0dGljZUluZGV4ICsgbm9pc2VZLm5vaXNlUG9zaXRpb25JbnRlZ2VyVmFsdWVdOwot ICAgIHEgPSBwYWludGluZ0RhdGEuZ3JhZGllbnRbY2hhbm5lbF1bdGVtcF07CisgICAgY29uc3Qg ZmxvYXQqIHEgPSBwYWludGluZ0RhdGEuZ3JhZGllbnRbY2hhbm5lbF1bdGVtcF07CiAgICAgdSA9 IG5vaXNlWC5ub2lzZVBvc2l0aW9uRnJhY3Rpb25WYWx1ZSAqIHFbMF0gKyBub2lzZVkubm9pc2VQ b3NpdGlvbkZyYWN0aW9uVmFsdWUgKiBxWzFdOwogICAgIHRlbXAgPSBwYWludGluZ0RhdGEubGF0 dGljZVNlbGVjdG9yW25leHRMYXR0aWNlSW5kZXggKyBub2lzZVkubm9pc2VQb3NpdGlvbkludGVn ZXJWYWx1ZV07CiAgICAgcSA9IHBhaW50aW5nRGF0YS5ncmFkaWVudFtjaGFubmVsXVt0ZW1wXTsK QEAgLTI2NSw3ICsyNjYsNyBAQCBmbG9hdCBGRVR1cmJ1bGVuY2U6Om5vaXNlMkQoaW50IGNoYW5u ZWwsIFBhaW50aW5nRGF0YSYgcGFpbnRpbmdEYXRhLCBTdGl0Y2hEYXRhJgogICAgIHJldHVybiBs aW5lYXJJbnRlcnBvbGF0aW9uKHN5LCBhLCBiKTsKIH0KIAotdW5zaWduZWQgY2hhciBGRVR1cmJ1 bGVuY2U6OmNhbGN1bGF0ZVR1cmJ1bGVuY2VWYWx1ZUZvclBvaW50KGludCBjaGFubmVsLCBQYWlu dGluZ0RhdGEmIHBhaW50aW5nRGF0YSwgU3RpdGNoRGF0YSYgc3RpdGNoRGF0YSwgY29uc3QgRmxv YXRQb2ludCYgcG9pbnQpCit1bnNpZ25lZCBjaGFyIEZFVHVyYnVsZW5jZTo6Y2FsY3VsYXRlVHVy YnVsZW5jZVZhbHVlRm9yUG9pbnQoaW50IGNoYW5uZWwsIGNvbnN0IFBhaW50aW5nRGF0YSYgcGFp bnRpbmdEYXRhLCBTdGl0Y2hEYXRhJiBzdGl0Y2hEYXRhLCBjb25zdCBGbG9hdFBvaW50JiBwb2lu dCkKIHsKICAgICBmbG9hdCB0aWxlV2lkdGggPSBwYWludGluZ0RhdGEuZmlsdGVyU2l6ZS53aWR0 aCgpOwogICAgIGZsb2F0IHRpbGVIZWlnaHQgPSBwYWludGluZ0RhdGEuZmlsdGVyU2l6ZS5oZWln aHQoKTsKQEAgLTI5OSw2ICszMDAsNyBAQCB1bnNpZ25lZCBjaGFyIEZFVHVyYnVsZW5jZTo6Y2Fs Y3VsYXRlVHVyYnVsZW5jZVZhbHVlRm9yUG9pbnQoaW50IGNoYW5uZWwsIFBhaW50aQogICAgICAg ICBzdGl0Y2hEYXRhLmhlaWdodCA9IHJvdW5kZih0aWxlSGVpZ2h0ICogYmFzZUZyZXF1ZW5jeVkp OwogICAgICAgICBzdGl0Y2hEYXRhLndyYXBZID0gc19wZXJsaW5Ob2lzZSArIHN0aXRjaERhdGEu aGVpZ2h0OwogICAgIH0KKwogICAgIGZsb2F0IHR1cmJ1bGVuY2VGdW5jdGlvblJlc3VsdCA9IDA7 CiAgICAgRmxvYXRQb2ludCBub2lzZVZlY3Rvcihwb2ludC54KCkgKiBiYXNlRnJlcXVlbmN5WCwg cG9pbnQueSgpICogYmFzZUZyZXF1ZW5jeVkpOwogICAgIGZsb2F0IHJhdGlvID0gMTsKQEAgLTMy OSw3ICszMzEsNyBAQCB1bnNpZ25lZCBjaGFyIEZFVHVyYnVsZW5jZTo6Y2FsY3VsYXRlVHVyYnVs ZW5jZVZhbHVlRm9yUG9pbnQoaW50IGNoYW5uZWwsIFBhaW50aQogICAgIHJldHVybiBzdGF0aWNf Y2FzdDx1bnNpZ25lZCBjaGFyPih0dXJidWxlbmNlRnVuY3Rpb25SZXN1bHQgKiAyNTUpOwogfQog Ci1pbmxpbmUgdm9pZCBGRVR1cmJ1bGVuY2U6OmZpbGxSZWdpb24oVWludDhDbGFtcGVkQXJyYXkq IHBpeGVsQXJyYXksIFBhaW50aW5nRGF0YSYgcGFpbnRpbmdEYXRhLCBpbnQgc3RhcnRZLCBpbnQg ZW5kWSkKK3ZvaWQgRkVUdXJidWxlbmNlOjpmaWxsUmVnaW9uKFVpbnQ4Q2xhbXBlZEFycmF5KiBw aXhlbEFycmF5LCBjb25zdCBQYWludGluZ0RhdGEmIHBhaW50aW5nRGF0YSwgaW50IHN0YXJ0WSwg aW50IGVuZFkpCiB7CiAgICAgSW50UmVjdCBmaWx0ZXJSZWdpb24gPSBhYnNvbHV0ZVBhaW50UmVj dCgpOwogICAgIEludFBvaW50IHBvaW50KDAsIGZpbHRlclJlZ2lvbi55KCkgKyBzdGFydFkpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRVR1 cmJ1bGVuY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVU dXJidWxlbmNlLmgKaW5kZXggZDkxYmRkOTNkNGNhMjdkY2I1OGE1YTU1ZTRkMmI2MzgyYzM2YjRj YS4uZmMxZDc5ZDZkMzFmZDc4ODAzMWQyOTVjZjJkYzJjY2EwOTRlNjcxMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GRVR1cmJ1bGVuY2UuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFVHVyYnVsZW5j ZS5oCkBAIC0xMTcsMTAgKzExNywxMCBAQCBwcml2YXRlOgogCiAgICAgRkVUdXJidWxlbmNlKEZp bHRlciYsIFR1cmJ1bGVuY2VUeXBlLCBmbG9hdCwgZmxvYXQsIGludCwgZmxvYXQsIGJvb2wpOwog Ci0gICAgaW5saW5lIHZvaWQgaW5pdFBhaW50KFBhaW50aW5nRGF0YSYpOwotICAgIGZsb2F0IG5v aXNlMkQoaW50IGNoYW5uZWwsIFBhaW50aW5nRGF0YSYsIFN0aXRjaERhdGEmLCBjb25zdCBGbG9h dFBvaW50Jik7Ci0gICAgdW5zaWduZWQgY2hhciBjYWxjdWxhdGVUdXJidWxlbmNlVmFsdWVGb3JQ b2ludChpbnQgY2hhbm5lbCwgUGFpbnRpbmdEYXRhJiwgU3RpdGNoRGF0YSYsIGNvbnN0IEZsb2F0 UG9pbnQmKTsKLSAgICBpbmxpbmUgdm9pZCBmaWxsUmVnaW9uKFVpbnQ4Q2xhbXBlZEFycmF5Kiwg UGFpbnRpbmdEYXRhJiwgaW50LCBpbnQpOworICAgIHZvaWQgaW5pdFBhaW50KFBhaW50aW5nRGF0 YSYpOworICAgIGZsb2F0IG5vaXNlMkQoaW50IGNoYW5uZWwsIGNvbnN0IFBhaW50aW5nRGF0YSYs IFN0aXRjaERhdGEmLCBjb25zdCBGbG9hdFBvaW50Jik7CisgICAgdW5zaWduZWQgY2hhciBjYWxj dWxhdGVUdXJidWxlbmNlVmFsdWVGb3JQb2ludChpbnQgY2hhbm5lbCwgY29uc3QgUGFpbnRpbmdE YXRhJiwgU3RpdGNoRGF0YSYsIGNvbnN0IEZsb2F0UG9pbnQmKTsKKyAgICB2b2lkIGZpbGxSZWdp b24oVWludDhDbGFtcGVkQXJyYXkqLCBjb25zdCBQYWludGluZ0RhdGEmLCBpbnQsIGludCk7CiAK ICAgICBUdXJidWxlbmNlVHlwZSBtX3R5cGU7CiAgICAgZmxvYXQgbV9iYXNlRnJlcXVlbmN5WDsK