17981 2008-03-21 06:51:41 -0700 CPPFLAGS are not configured properly in autotools build 2008-03-21 11:24:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 dobey webkit-unassigned oldest_to_newest 74621 0 dobey 2008-03-21 06:51:41 -0700 Currently the CPPFLAGS configuration for the autotools build causes the JavaScriptCore includes to come before the WebCore includes. When building WebCore, it should find WebCore/config.h before others, which is not currently the case. The attached patch removes the JSCore include path options from global_cppflags, and places them in javascriptcore_cppflags instead, updating the other cppflags variables to use javascriptcore_cppflags when needed. 74622 1 19924 dobey 2008-03-21 06:52:11 -0700 Created attachment 19924 Patch to fix cppflags usage in autotools build 74654 2 19924 zecke 2008-03-21 11:08:08 -0700 Comment on attachment 19924 Patch to fix cppflags usage in autotools build The addition of WebCore cppflags to the programs in WebKitTools is wrong and should be removed when landing this patch. 74661 3 zecke 2008-03-21 11:24:06 -0700 Landed in r31214. 19924 2008-03-21 06:52:11 -0700 2008-03-21 11:08:08 -0700 Patch to fix cppflags usage in autotools build webkit-cppflags-fix.patch text/plain 4507 dobey SW5kZXg6IEphdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT Y3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiAzMTE3NikKKysrIEphdmFTY3JpcHRD b3JlL0dOVW1ha2VmaWxlLmFtCSh3b3JraW5nIGNvcHkpCkBAIC0xMzksNyArMTM5LDcgQEAgUHJv Z3JhbXNfbWluaWRvbV9TT1VSQ0VTID0gXAogCUphdmFTY3JpcHRDb3JlL0FQSS9Ob2RlLmMgXAog CUphdmFTY3JpcHRDb3JlL0FQSS9Ob2RlTGlzdC5jIFwKIAlKYXZhU2NyaXB0Q29yZS9BUEkvbWlu aWRvbS5jCi1Qcm9ncmFtc19taW5pZG9tX0NQUEZMQUdTID0gJChnbG9iYWxfY3BwZmxhZ3MpCitQ cm9ncmFtc19taW5pZG9tX0NQUEZMQUdTID0gJChnbG9iYWxfY3BwZmxhZ3MpICQoamF2YXNjcmlw dGNvcmVfY3BwZmxhZ3MpCiBQcm9ncmFtc19taW5pZG9tX0NGTEFHUyA9IFwKIAkkKGdsb2JhbF9j ZmxhZ3MpIFwKIAkkKEdMT0JBTERFUFNfQ0ZMQUdTKQpJbmRleDogR05VbWFrZWZpbGUuYW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gR05VbWFrZWZpbGUuYW0JKHJldmlzaW9uIDMxMTc2KQorKysgR05VbWFrZWZp bGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTUyLDEzICs1Miw2IEBAIEVYVFJBX0RJU1QgOj0KIGds b2JhbF9jcHBmbGFncyA6PQogCiBnbG9iYWxfY3BwZmxhZ3MgKz0gXAotCS1JJChzcmNkaXIpL0ph dmFTY3JpcHRDb3JlIFwKLQktSSQoc3JjZGlyKS9KYXZhU2NyaXB0Q29yZS9Gb3J3YXJkaW5nSGVh ZGVycyBcCi0JLUkkKHNyY2RpcikvSmF2YVNjcmlwdENvcmUvd3RmIFwKLQktSSQoc3JjZGlyKS9K YXZhU2NyaXB0Q29yZS9ranMgXAotCS1JJCh0b3BfYnVpbGRkaXIpL0Rlcml2ZWRTb3VyY2VzCi0K LWdsb2JhbF9jcHBmbGFncyArPSBcCiAJLURXVEZfVVNFX0lDVV9VTklDT0RFPTEKIAogIyBEZWZh dWx0IGNvbXBpbGVyIGZsYWdzCkBAIC05Nyw2ICs5MCwxMyBAQCBqYXZhc2NyaXB0Y29yZV9zb3Vy Y2VzIDo9CiBqYXZhc2NyaXB0Y29yZV9idWlsdF9zb3VyY2VzIDo9CiBqYXZhc2NyaXB0Y29yZV9i dWlsdF9ub3NvdXJjZXMgOj0KIAoramF2YXNjcmlwdGNvcmVfY3BwZmxhZ3MgKz0gXAorCS1JJChz cmNkaXIpL0phdmFTY3JpcHRDb3JlIFwKKwktSSQoc3JjZGlyKS9KYXZhU2NyaXB0Q29yZS9Gb3J3 YXJkaW5nSGVhZGVycyBcCisJLUkkKHNyY2RpcikvSmF2YVNjcmlwdENvcmUvd3RmIFwKKwktSSQo c3JjZGlyKS9KYXZhU2NyaXB0Q29yZS9ranMgXAorCS1JJCh0b3BfYnVpbGRkaXIpL0Rlcml2ZWRT b3VyY2VzCisKICMgVGhlIHZhcmlhYmxlcyBhYm92ZSBhcmUgYWxyZWFkeSBpbmNsdWRlZCBiZWxv dyBzbyBubyBuZWVkIHRvIHRvdWNoCiAjIHRoZXNlIHZhcmlhYmxlcyB1bmxlc3MgeW91IHJlYWxs eSBoYXZlIHRvCiBsaWJKYXZhU2NyaXB0Q29yZV9sYWRpciA9ICQocHJlZml4KS9pbmNsdWRlL3dl YmtpdC0xLjAvSmF2YVNjcmlwdENvcmUKQEAgLTE4NSw2ICsxODUsNyBAQCBsaWJXZWJDb3JlX2xh X0NGTEFHUyA9IFwKIGxpYldlYkNvcmVfbGFfQ1BQRkxBR1MgPSBcCiAJJChnbG9iYWxfY3BwZmxh Z3MpIFwKIAkkKHdlYmNvcmVfY3BwZmxhZ3MpIFwKKwkkKGphdmFzY3JpcHRjb3JlX2NwcGZsYWdz KSBcCiAJJCh3ZWJraXRndGtfY3BwZmxhZ3MpCiAKIGxpYldlYkNvcmVfbGFfTElCQUREID0gXApJ bmRleDogV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0dOVW1h a2VmaWxlLmFtCShyZXZpc2lvbiAzMTE3NikKKysrIFdlYkNvcmUvR05VbWFrZWZpbGUuYW0JKHdv cmtpbmcgY29weSkKQEAgLTYsNyArNiw2IEBAIFNWR19GRUFUVVJFUyA6PQogCiB3ZWJjb3JlX2Nw cGZsYWdzICs9IFwKIAktSSQoc3JjZGlyKS9XZWJDb3JlIFwKLQktSSQoc3JjZGlyKS9XZWJDb3Jl L0ZvcndhcmRpbmdIZWFkZXJzIFwKIAktSSQoc3JjZGlyKS9XZWJDb3JlL3BsYXRmb3JtIFwKIAkt SSQoc3JjZGlyKS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsgXAogCS1JJChzcmNkaXIpL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MgXApJbmRleDogV2ViS2l0VG9vbHMvR05VbWFrZWZpbGUuYW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvR05VbWFrZWZpbGUuYW0JKHJldmlzaW9uIDMxMTc2 KQorKysgV2ViS2l0VG9vbHMvR05VbWFrZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTUsNyAr NSw5IEBAIG5vaW5zdF9QUk9HUkFNUyArPSBcCiAjIEd0a0xhdW5jaGVyCiBQcm9ncmFtc19HdGtM YXVuY2hlcl9DUFBGTEFHUyA9IFwKIAktSSQoc3JjZGlyKS9XZWJLaXQvZ3RrIFwKLQkkKGdsb2Jh bF9jcHBmbGFncykKKwkkKGdsb2JhbF9jcHBmbGFncykgXAorCSQod2ViY29yZV9jcHBmbGFncykg XAorCSQoamF2YXNjcmlwdGNvcmVfY3BwZmxhZ3MpCiAKIFByb2dyYW1zX0d0a0xhdW5jaGVyX1NP VVJDRVMgPSBcCiAJV2ViS2l0VG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCkBAIC0yNSw3ICsyNyw5 IEBAIFByb2dyYW1zX0R1bXBSZW5kZXJUcmVlX0NQUEZMQUdTID0gXAogCS1JJChzcmNkaXIpL1dl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlIFwKIAktSSQoc3JjZGlyKS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9ndGsgXAogCS1JJChzcmNkaXIpL1dlYktpdC9ndGsgXAotCSQoZ2xvYmFsX2Nw cGZsYWdzKQorCSQoZ2xvYmFsX2NwcGZsYWdzKSBcCisJJCh3ZWJjb3JlX2NwcGZsYWdzKSBcCisJ JChqYXZhc2NyaXB0Y29yZV9jcHBmbGFncykKIAogUHJvZ3JhbXNfRHVtcFJlbmRlclRyZWVfU09V UkNFUyA9IFwKIAlXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUu Y3BwIFwKSW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDMxMjA4KQorKysgSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDMtMjEgIFJv ZG5leSBEYXdlcyAgPGRvYmV5QHdheW9mdGhlbW9ua2V5LmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhISkKKworICAgICAgICBBZGQgamF2YXNjcmlwdGNvcmVfY3BwZmxh Z3MgdG8gUHJvZ3JhbXNfbWluaWRvbV9DUFBGTEFHUy4KKworICAgICAgICAqIEdOVW1ha2VmaWxl LmFtOgorCiAyMDA4LTAzLTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAzMTIwOCkKKysr IFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgt MDMtMjEgIFJvZG5leSBEYXdlcyAgPGRvYmV5QHdheW9mdGhlbW9ua2V5LmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhISkKKworICAgICAgICBSZW1vdmUgV2ViQ29yZS9G b3J3YXJkaW5nSGVhZGVycyBmcm9tIGNwcGZsYWdzIGFzIGl0IGlzIG5vdCBuZWVkZWQsCisgICAg ICAgIGFuZCBjYXVzZXMgYnVpbGQgcHJvYmxlbXMgd2l0aCBHVEsrLgorCisgICAgICAgICogR05V bWFrZWZpbGUuYW06CisKIDIwMDgtMDMtMjAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBXZWJLaXRU b29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCShyZXZp c2lvbiAzMTIwOCkKKysrIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDExIEBACisyMDA4LTAzLTIxICBSb2RuZXkgRGF3ZXMgIDxkb2JleUB3YXlvZnRoZW1v bmtleS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISEpCisKKyAgICAg ICAgQWRkIHdlYmNvcmUgYW5kIGphdmFzY3JpcHRjb3JlIGNwcGZsYWdzIHRvIHByb2dyYW1zJyBf Q1BQRkxBR1MuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKwogMjAwOC0wMy0yMCAgTWFy ayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWlu aWcuCg==