179806 2017-11-16 17:08:48 -0800 REGRESSION (224348?): [mac-wk1] LayoutTest media/video-src-remove.html is a flaky timeout 2018-01-18 12:36:09 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181553 InRadar P2 Normal --- 1 ryanhaddad achristensen achristensen ap bfulgham eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1372904 0 ryanhaddad 2017-11-16 17:08:48 -0800 LayoutTest media/video-src-remove.html is a flaky timeout https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224926%20(4889)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-src-remove.html 1372906 1 ryanhaddad 2017-11-16 17:11:06 -0800 This is limited to Mac-wk1 debug bots. The earliest timeout on the dashboard blames https://trac.webkit.org/log/webkit/?verbose=on&rev=224350&stop_rev=224349 (but this is a flaky timeout). 1372971 2 ap 2017-11-16 21:35:51 -0800 Possibly <http://trac.webkit.org/projects/webkit/changeset/224348>? 1372972 3 ap 2017-11-16 21:37:24 -0800 This test was absolutely stable, and now times out very frequently. 1372973 4 webkit-bug-importer 2017-11-16 21:38:55 -0800 <rdar://problem/35608336> 1373361 5 achristensen 2017-11-17 15:43:07 -0800 I can reproduce this quite reliably with guardmalloc. We needed callOnMainThread for UIWebView to work correctly with the web thread, but I guess we need dispatch_async on mac. 1373365 6 327257 achristensen 2017-11-17 15:45:39 -0800 Created attachment 327257 Patch 1373383 7 327263 achristensen 2017-11-17 16:14:16 -0800 Created attachment 327263 Patch 1373430 8 achristensen 2017-11-17 17:01:02 -0800 http://trac.webkit.org/r225003 1375009 9 ap 2017-11-27 10:52:45 -0800 Thanks for fixing the test! Not sure if this is the right kind of technical debt to have long term though, this sounds very fragile. 1375010 10 achristensen 2017-11-27 10:53:36 -0800 Long-term we should deprecate and remove WebView.scheduleInRunLoop 1375013 11 achristensen 2017-11-27 10:54:10 -0800 And stop using the web thread in UIWebView 327257 2017-11-17 15:45:39 -0800 2017-11-17 16:14:15 -0800 Patch bug-179806-20171117154538.patch text/plain 2271 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDk5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTExLTE3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TigyMjQzNDgpOiBbbWFjLXdrMV0gTGF5b3V0VGVzdCBtZWRpYS92aWRlby1zcmMtcmVtb3ZlLmh0 bWwgaXMgYSBmbGFreSB0aW1lb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzk4MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbiByMjI0MzQ4IEkgdXNlZCBjYWxsT25NYWluVGhyZWFkIHRvIGZpeCBV SVdlYlZpZXcgd2hpY2ggdXNlcyB0aGUgd2ViIHRocmVhZCwgYnV0IE1hYyBkb2Vzbid0CisgICAg ICAgIHVzZSB0aGUgd2ViIHRocmVhZC4gU29tZXRoaW5nIGFib3V0IHRoZSB0aW1pbmcgb2Ygb3Bl cmF0aW9ucyBpbiB0aGUgbWVkaWEgc3RhY2sgcmVxdWlyZXMgdGhhdAorICAgICAgICBkaXNwYXRj aF9hc3luYyBiZSB1c2VkIGluc3RlYWQgb2YgcGVyZm9ybVNlbGVjdG9yT25NYWluVGhyZWFkLgor ICAgICAgICAKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9XZWJDb3JlUmVzb3VyY2VI YW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUubW06CisgICAgICAgICgtW1dlYkNvcmVSZXNv dXJjZUhhbmRsZUFzT3BlcmF0aW9uUXVldWVEZWxlZ2F0ZSBjYWxsRnVuY3Rpb25Pbk1haW5UaHJl YWQ6XSk6CisgICAgICAgIFVzZSBjYWxsT25NYWluVGhyZWFkIG9uIGlPUywgZGlzcGF0Y2hfYXN5 bmMgb24gTWFjLgorCiAyMDE3LTExLTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIERvbid0IGludmVydCBhIG1hdHJpeCBmb3IgZXZlcnkgY2hhbm5l bCBvZiBldmVyeSBwaXhlbCBvZiBhbiBGRVR1cmJ1bGVuY2UgZmlsdGVyCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9XZWJDb3JlUmVzb3VyY2VIYW5kbGVBc09wZXJh dGlvblF1ZXVlRGVsZWdhdGUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9tYWMvV2ViQ29yZVJlc291cmNlSGFuZGxlQXNPcGVyYXRpb25RdWV1ZURlbGVn YXRlLm1tCShyZXZpc2lvbiAyMjQ5ODQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL21hYy9XZWJDb3JlUmVzb3VyY2VIYW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUubW0J KHdvcmtpbmcgY29weSkKQEAgLTY0LDkgKzY0LDE0IEBAIC0gKHZvaWQpY2FsbEZ1bmN0aW9uT25N YWluVGhyZWFkOihGdW5jdGkKIAogICAgIC8vIFRoaXMgaXMgdGhlIGNvbW1vbiBjYXNlLgogICAg IFNjaGVkdWxlUGFpckhhc2hTZXQqIHBhaXJzID0gbV9oYW5kbGUgJiYgbV9oYW5kbGUtPmNvbnRl eHQoKSA/IG1faGFuZGxlLT5jb250ZXh0KCktPnNjaGVkdWxlZFJ1bkxvb3BQYWlycygpIDogbnVs bHB0cjsKLSAgICBpZiAoIXNjaGVkdWxlZFdpdGhDdXN0b21SdW5Mb29wTW9kZShwYWlycykpCisg ICAgaWYgKCFzY2hlZHVsZWRXaXRoQ3VzdG9tUnVuTG9vcE1vZGUocGFpcnMpKSB7CisjaWYgUExB VEZPUk0oTUFDKQorICAgICAgICByZXR1cm4gZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21h aW5fcXVldWUoKSwgQmxvY2tQdHI8dm9pZCgpPjo6ZnJvbUNhbGxhYmxlKFdURk1vdmUoZnVuY3Rp b24pKSkuZ2V0KCkpOworI2Vsc2UKICAgICAgICAgcmV0dXJuIGNhbGxPbk1haW5UaHJlYWQoV1RG TW92ZShmdW5jdGlvbikpOwotICAgIAorI2VuZGlmCisgICAgfQorCiAgICAgLy8gSWYgd2UgaGF2 ZSBiZWVuIHNjaGVkdWxlZCBpbiBhIGN1c3RvbSBydW4gbG9vcCBtb2RlLCBzY2hlZHVsZSBhIGJs b2NrIGluIHRoYXQgbW9kZS4KICAgICBhdXRvIGJsb2NrID0gQmxvY2tQdHI8dm9pZCgpPjo6ZnJv bUNhbGxhYmxlKFthbHJlYWR5Q2FsbGVkID0gZmFsc2UsIGZ1bmN0aW9uID0gV1RGTW92ZShmdW5j dGlvbildICgpIG11dGFibGUgewogICAgICAgICBpZiAoYWxyZWFkeUNhbGxlZCkK 327263 2017-11-17 16:14:16 -0800 2017-11-17 16:26:24 -0800 Patch bug-179806-20171117161415.patch text/plain 2270 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDk5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTExLTE3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TigyMjQzNDgpOiBbbWFjLXdrMV0gTGF5b3V0VGVzdCBtZWRpYS92aWRlby1zcmMtcmVtb3ZlLmh0 bWwgaXMgYSBmbGFreSB0aW1lb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzk4MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbiByMjI0MzQ4IEkgdXNlZCBjYWxsT25NYWluVGhyZWFkIHRvIGZpeCBV SVdlYlZpZXcgd2hpY2ggdXNlcyB0aGUgd2ViIHRocmVhZCwgYnV0IE1hYyBkb2Vzbid0CisgICAg ICAgIHVzZSB0aGUgd2ViIHRocmVhZC4gU29tZXRoaW5nIGFib3V0IHRoZSB0aW1pbmcgb2Ygb3Bl cmF0aW9ucyBpbiB0aGUgbWVkaWEgc3RhY2sgcmVxdWlyZXMgdGhhdAorICAgICAgICBkaXNwYXRj aF9hc3luYyBiZSB1c2VkIGluc3RlYWQgb2YgcGVyZm9ybVNlbGVjdG9yT25NYWluVGhyZWFkLgor ICAgICAgICAKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9XZWJDb3JlUmVzb3VyY2VI YW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUubW06CisgICAgICAgICgtW1dlYkNvcmVSZXNv dXJjZUhhbmRsZUFzT3BlcmF0aW9uUXVldWVEZWxlZ2F0ZSBjYWxsRnVuY3Rpb25Pbk1haW5UaHJl YWQ6XSk6CisgICAgICAgIFVzZSBjYWxsT25NYWluVGhyZWFkIG9uIGlPUywgZGlzcGF0Y2hfYXN5 bmMgb24gTWFjLgorCiAyMDE3LTExLTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIERvbid0IGludmVydCBhIG1hdHJpeCBmb3IgZXZlcnkgY2hhbm5l bCBvZiBldmVyeSBwaXhlbCBvZiBhbiBGRVR1cmJ1bGVuY2UgZmlsdGVyCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9XZWJDb3JlUmVzb3VyY2VIYW5kbGVBc09wZXJh dGlvblF1ZXVlRGVsZWdhdGUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9tYWMvV2ViQ29yZVJlc291cmNlSGFuZGxlQXNPcGVyYXRpb25RdWV1ZURlbGVn YXRlLm1tCShyZXZpc2lvbiAyMjQ5ODQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL21hYy9XZWJDb3JlUmVzb3VyY2VIYW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUubW0J KHdvcmtpbmcgY29weSkKQEAgLTY0LDkgKzY0LDE0IEBAIC0gKHZvaWQpY2FsbEZ1bmN0aW9uT25N YWluVGhyZWFkOihGdW5jdGkKIAogICAgIC8vIFRoaXMgaXMgdGhlIGNvbW1vbiBjYXNlLgogICAg IFNjaGVkdWxlUGFpckhhc2hTZXQqIHBhaXJzID0gbV9oYW5kbGUgJiYgbV9oYW5kbGUtPmNvbnRl eHQoKSA/IG1faGFuZGxlLT5jb250ZXh0KCktPnNjaGVkdWxlZFJ1bkxvb3BQYWlycygpIDogbnVs bHB0cjsKLSAgICBpZiAoIXNjaGVkdWxlZFdpdGhDdXN0b21SdW5Mb29wTW9kZShwYWlycykpCisg ICAgaWYgKCFzY2hlZHVsZWRXaXRoQ3VzdG9tUnVuTG9vcE1vZGUocGFpcnMpKSB7CisjaWYgUExB VEZPUk0oTUFDKQorICAgICAgICByZXR1cm4gZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21h aW5fcXVldWUoKSwgQmxvY2tQdHI8dm9pZCgpPjo6ZnJvbUNhbGxhYmxlKFdURk1vdmUoZnVuY3Rp b24pKS5nZXQoKSk7CisjZWxzZQogICAgICAgICByZXR1cm4gY2FsbE9uTWFpblRocmVhZChXVEZN b3ZlKGZ1bmN0aW9uKSk7Ci0gICAgCisjZW5kaWYKKyAgICB9CisKICAgICAvLyBJZiB3ZSBoYXZl IGJlZW4gc2NoZWR1bGVkIGluIGEgY3VzdG9tIHJ1biBsb29wIG1vZGUsIHNjaGVkdWxlIGEgYmxv Y2sgaW4gdGhhdCBtb2RlLgogICAgIGF1dG8gYmxvY2sgPSBCbG9ja1B0cjx2b2lkKCk+Ojpmcm9t Q2FsbGFibGUoW2FscmVhZHlDYWxsZWQgPSBmYWxzZSwgZnVuY3Rpb24gPSBXVEZNb3ZlKGZ1bmN0 aW9uKV0gKCkgbXV0YWJsZSB7CiAgICAgICAgIGlmIChhbHJlYWR5Q2FsbGVkKQo=