179781 2017-11-16 09:51:45 -0800 LayoutTest http/tests/inspector/network/har/har-page.html is a flaky failure 2019-11-27 04:49:39 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned bburg commit-queue inspector-bugzilla-changes joepeck magomez webkit-bug-importer zimmermann oldest_to_newest 1372670 0 ryanhaddad 2017-11-16 09:51:45 -0800 LayoutTest http/tests/inspector/network/har/har-page.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r224920%20(5780)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt @@ -70,7 +70,7 @@ "request": { "method": "GET", "url": "http://127.0.0.1:8000/inspector/resources/inspector-test.js", - "httpVersion": "", + "httpVersion": "HTTP/1.1", "cookies": [], "headers": "<filtered>", "queryString": [], @@ -80,11 +80,11 @@ "response": { "status": 200, "statusText": "OK", - "httpVersion": "", + "httpVersion": "HTTP/1.1", "cookies": [], "headers": "<filtered>", "content": { - "size": 0, + "size": 6707, "compression": 0, "mimeType": "application/x-javascript", "text": "<filtered text (6707)>" 1372969 1 bburg 2017-11-16 20:48:44 -0800 Thanks Ryan. Joe should take a look when he's back in. 1373166 2 joepeck 2017-11-17 11:08:33 -0800 We can just filter out this value. I'll make that change now. 1373196 3 327209 joepeck 2017-11-17 12:01:55 -0800 Created attachment 327209 [PATCH] Proposed Fix 1373199 4 327209 ap 2017-11-17 12:10:49 -0800 Comment on attachment 327209 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=327209&action=review r=me on filtering, but I don't understand why the size changes. > LayoutTests/http/tests/inspector/network/har/har-page-expected.txt:46 > - "size": 2915, > + "size": 3042, I don't understand this part. 1373200 5 joepeck 2017-11-17 12:12:05 -0800 > > LayoutTests/http/tests/inspector/network/har/har-page-expected.txt:46 > > - "size": 2915, > > + "size": 3042, > > I don't understand this part. That is the size of the test page itself. 1373218 6 327209 commit-queue 2017-11-17 12:43:15 -0800 Comment on attachment 327209 [PATCH] Proposed Fix Clearing flags on attachment: 327209 Committed r224979: <https://trac.webkit.org/changeset/224979> 1373219 7 commit-queue 2017-11-17 12:43:16 -0800 All reviewed patches have been landed. Closing bug. 1373220 8 webkit-bug-importer 2017-11-17 12:44:35 -0800 <rdar://problem/35621576> 1373859 9 mcatanzaro 2017-11-20 16:13:18 -0800 *** Bug 179173 has been marked as a duplicate of this bug. *** 327209 2017-11-17 12:01:55 -0800 2017-11-17 12:43:15 -0800 [PATCH] Proposed Fix har-fix-1.patch text/plain 3279 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MDI2Y2FkNzYwOC4uZjg2Y2U2ZjM5ZDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxNy0xMS0xNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIExheW91dFRlc3QgaHR0cC90ZXN0cy9pbnNwZWN0b3IvbmV0d29yay9oYXIvaGFyLXBhZ2Uu aHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3OTc4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3IvbmV0d29yay9oYXIvaGFyLXBh Z2UtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsv aGFyL2hhci1wYWdlLmh0bWw6CisgICAgICAgIEZpbHRlciBvdXQgdGhlIHByb3RvY29sIHZhbHVl IHNpbmNlIGl0IG1pZ2h0IG5vdCBiZSBhdmFpbGFibGUgaWYgdGhlIHJlc291cmNlIHdhcyBjYWNo ZWQuCisKIDIwMTctMTEtMTcgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxl LmNvbT4KIAogICAgICAgICBTVkcgc2Nyb2xsaW5nIGFuY2hvciBzaG91bGQgYmUgcmVzZXQgaWYg dGhlIGZyYWdtZW50SWRlbnRpZmllciBkb2VzIG5vdCBleGlzdCBvciBpcyBub3QgcHJvdmlkZWQK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvaGFy L2hhci1wYWdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9y L25ldHdvcmsvaGFyL2hhci1wYWdlLWV4cGVjdGVkLnR4dAppbmRleCBlNzljZGZjNDhkNy4uNDIy NWIzY2QyNWQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL25l dHdvcmsvaGFyL2hhci1wYWdlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2luc3BlY3Rvci9uZXR3b3JrL2hhci9oYXItcGFnZS1leHBlY3RlZC50eHQKQEAgLTI5LDcg KzI5LDcgQEAgSEFSIFBhZ2UgVGVzdC4KICAgICAgICAgInJlcXVlc3QiOiB7CiAgICAgICAgICAg Im1ldGhvZCI6ICJHRVQiLAogICAgICAgICAgICJ1cmwiOiAiaHR0cDovLzEyNy4wLjAuMTo4MDAw L2luc3BlY3Rvci9uZXR3b3JrL2hhci9oYXItcGFnZS5odG1sIiwKLSAgICAgICAgICAiaHR0cFZl cnNpb24iOiAiSFRUUC8xLjEiLAorICAgICAgICAgICJodHRwVmVyc2lvbiI6ICI8ZmlsdGVyZWQ+ IiwKICAgICAgICAgICAiY29va2llcyI6IFtdLAogICAgICAgICAgICJoZWFkZXJzIjogIjxmaWx0 ZXJlZD4iLAogICAgICAgICAgICJxdWVyeVN0cmluZyI6IFtdLApAQCAtMzksMTQgKzM5LDE0IEBA IEhBUiBQYWdlIFRlc3QuCiAgICAgICAgICJyZXNwb25zZSI6IHsKICAgICAgICAgICAic3RhdHVz IjogMjAwLAogICAgICAgICAgICJzdGF0dXNUZXh0IjogIk9LIiwKLSAgICAgICAgICAiaHR0cFZl cnNpb24iOiAiSFRUUC8xLjEiLAorICAgICAgICAgICJodHRwVmVyc2lvbiI6ICI8ZmlsdGVyZWQ+ IiwKICAgICAgICAgICAiY29va2llcyI6IFtdLAogICAgICAgICAgICJoZWFkZXJzIjogIjxmaWx0 ZXJlZD4iLAogICAgICAgICAgICJjb250ZW50IjogewotICAgICAgICAgICAgInNpemUiOiAyOTE1 LAorICAgICAgICAgICAgInNpemUiOiAzMDQyLAogICAgICAgICAgICAgImNvbXByZXNzaW9uIjog MCwKICAgICAgICAgICAgICJtaW1lVHlwZSI6ICJ0ZXh0L2h0bWwiLAotICAgICAgICAgICAgInRl eHQiOiAiPGZpbHRlcmVkIHRleHQgKDI5MTUpPiIKKyAgICAgICAgICAgICJ0ZXh0IjogIjxmaWx0 ZXJlZCB0ZXh0ICgzMDQyKT4iCiAgICAgICAgICAgfSwKICAgICAgICAgICAicmVkaXJlY3RVUkwi OiAiIiwKICAgICAgICAgICAiaGVhZGVyc1NpemUiOiAiPGZpbHRlcmVkPiIsCkBAIC03MCw3ICs3 MCw3IEBAIEhBUiBQYWdlIFRlc3QuCiAgICAgICAgICJyZXF1ZXN0IjogewogICAgICAgICAgICJt ZXRob2QiOiAiR0VUIiwKICAgICAgICAgICAidXJsIjogImh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9p bnNwZWN0b3IvcmVzb3VyY2VzL2luc3BlY3Rvci10ZXN0LmpzIiwKLSAgICAgICAgICAiaHR0cFZl cnNpb24iOiAiIiwKKyAgICAgICAgICAiaHR0cFZlcnNpb24iOiAiPGZpbHRlcmVkPiIsCiAgICAg ICAgICAgImNvb2tpZXMiOiBbXSwKICAgICAgICAgICAiaGVhZGVycyI6ICI8ZmlsdGVyZWQ+IiwK ICAgICAgICAgICAicXVlcnlTdHJpbmciOiBbXSwKQEAgLTgwLDcgKzgwLDcgQEAgSEFSIFBhZ2Ug VGVzdC4KICAgICAgICAgInJlc3BvbnNlIjogewogICAgICAgICAgICJzdGF0dXMiOiAyMDAsCiAg ICAgICAgICAgInN0YXR1c1RleHQiOiAiT0siLAotICAgICAgICAgICJodHRwVmVyc2lvbiI6ICIi LAorICAgICAgICAgICJodHRwVmVyc2lvbiI6ICI8ZmlsdGVyZWQ+IiwKICAgICAgICAgICAiY29v a2llcyI6IFtdLAogICAgICAgICAgICJoZWFkZXJzIjogIjxmaWx0ZXJlZD4iLAogICAgICAgICAg ICJjb250ZW50IjogewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0 b3IvbmV0d29yay9oYXIvaGFyLXBhZ2UuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5z cGVjdG9yL25ldHdvcmsvaGFyL2hhci1wYWdlLmh0bWwKaW5kZXggNWZhZDdkMDY0ZDAuLjNiYjk5 MzcwOTcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3 b3JrL2hhci9oYXItcGFnZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVj dG9yL25ldHdvcmsvaGFyL2hhci1wYWdlLmh0bWwKQEAgLTIzLDYgKzIzLDEwIEBAIGZ1bmN0aW9u IHRlc3QoKQogICAgICAgICBpZiAoa2V5ID09PSAiX2ZldGNoVHlwZSIpCiAgICAgICAgICAgICBy ZXR1cm4gdW5kZWZpbmVkOwogCisgICAgICAgIC8vIElmIGNhY2hlZCB0aGUgcHJvdG9jb2wgbWln aHQgbm90IGJlIGF2YWlsYWJsZS4KKyAgICAgICAgaWYgKGtleSA9PT0gImh0dHBWZXJzaW9uIikK KyAgICAgICAgICAgIHJldHVybiAiPGZpbHRlcmVkPiI7CisKICAgICAgICAgLy8gSGVhZGVycyBp bmNsdWRlIGR5bmFtaWMgZGF0YS4KICAgICAgICAgaWYgKGtleSA9PT0gImhlYWRlcnMiKQogICAg ICAgICAgICAgcmV0dXJuICI8ZmlsdGVyZWQ+IjsK