179764 2017-11-16 06:06:26 -0800 Fix null pointer dereference in bytecodeDumper 2017-11-17 13:01:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset buildbot commit-queue keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1372582 0 rmorisset 2017-11-16 06:06:26 -0800 Found accidentally by running dumping bytecode in a version of JSC compiled with ASAN. The problem is just a call to lastSeenCallee on a CallLinkInfo that was unguarded by haveLastSeenCallee(). 1372583 1 327059 rmorisset 2017-11-16 06:09:42 -0800 Created attachment 327059 Patch 1372590 2 327059 mark.lam 2017-11-16 06:47:54 -0800 Comment on attachment 327059 Patch r=me 1372597 3 327059 commit-queue 2017-11-16 07:08:14 -0800 Comment on attachment 327059 Patch Clearing flags on attachment: 327059 Committed r224916: <https://trac.webkit.org/changeset/224916> 1372598 4 commit-queue 2017-11-16 07:08:15 -0800 All reviewed patches have been landed. Closing bug. 1373230 5 webkit-bug-importer 2017-11-17 13:01:34 -0800 <rdar://problem/35621867> 327059 2017-11-16 06:09:42 -0800 2017-11-16 07:08:14 -0800 Patch bug-179764-20171116150941.patch text/plain 2176 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0Njc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MTMwNTFjYzNmZWFmNTFkYTZkNDk0MGQ3MDgzMTAyZmYzMTYwZDdmLi5lMzBhZDcwNzEyZjllNTBm NDI0ZWY1ZTc3YTYzMjBhMzFjMTgwNWZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNy0xMS0xNiAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgogCisgICAgICAgIEZpeCBudWxsIHBvaW50ZXIgZGVyZWZlcmVuY2UgaW4gYnl0ZWNvZGVE dW1wZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTc2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBwcm9ibGVtIHdhcyBqdXN0IGEgY2FsbCB0byBsYXN0U2VlbkNhbGxlZSgpIHRoYXQgd2FzIHVu Z3VhcmRlZCBieSBoYXZlTGFzdFNlZW5DYWxsZWUoKS4KKworICAgICAgICAqIGJ5dGVjb2RlL0J5 dGVjb2RlRHVtcGVyLmNwcDoKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVEdW1wZXI8QmxvY2s+Ojpw cmludENhbGxPcCk6CisKKzIwMTctMTEtMTYgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFw cGxlLmNvbT4KKwogICAgICAgICBSRUdSRVNTSU9OIChyMjI0NTkyKTogb3NzLWZ1eno6IGpzYzog TnVsbC1kZXJlZmVyZW5jZSBSRUFEIGluIEpTQzo6SlNDZWxsOjppc09iamVjdCAoNDIxNikKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTc2MwogICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzU1NTA1MTM+CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvQnl0ZWNvZGVEdW1wZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0J5dGVjb2RlRHVtcGVyLmNwcAppbmRleCA1YTBkNmQxNmM5OWUwNmQ5MmM3 ZTk2Y2YxMGRjNGYzN2IyYWZmYWYyLi4zNTcwMWEwOGIzNjE3ZGZiYjJmNTYyOWYzMmM5MDM2YmY2 YWMzZDJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQnl0ZWNv ZGVEdW1wZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9CeXRlY29k ZUR1bXBlci5jcHAKQEAgLTU4NiwxMSArNTg2LDEzIEBAIHZvaWQgQnl0ZWNvZGVEdW1wZXI8Qmxv Y2s+OjpwcmludENhbGxPcChQcmludFN0cmVhbSYgb3V0LCBpbnQgbG9jYXRpb24sIGNvbnN0IHR5 CiAgICAgICAgIH0KICNpZiBFTkFCTEUoSklUKQogICAgICAgICBpZiAoQ2FsbExpbmtJbmZvKiBp bmZvID0gbWFwLmdldChDb2RlT3JpZ2luKGxvY2F0aW9uKSkpIHsKLSAgICAgICAgICAgIEpTT2Jq ZWN0KiBvYmplY3QgPSBpbmZvLT5sYXN0U2VlbkNhbGxlZSgpOwotICAgICAgICAgICAgaWYgKGF1 dG8qIGZ1bmN0aW9uID0ganNEeW5hbWljQ2FzdDxKU0Z1bmN0aW9uKj4oKnZtKCksIG9iamVjdCkp Ci0gICAgICAgICAgICAgICAgb3V0LnByaW50ZigiIGppdCglcCwgZXhlYyAlcCkiLCBmdW5jdGlv biwgZnVuY3Rpb24tPmV4ZWN1dGFibGUoKSk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAg ICAgICAgb3V0LnByaW50ZigiIGppdCglcCkiLCBvYmplY3QpOworICAgICAgICAgICAgaWYgKGlu Zm8tPmhhdmVMYXN0U2VlbkNhbGxlZSgpKSB7CisgICAgICAgICAgICAgICAgSlNPYmplY3QqIG9i amVjdCA9IGluZm8tPmxhc3RTZWVuQ2FsbGVlKCk7CisgICAgICAgICAgICAgICAgaWYgKGF1dG8q IGZ1bmN0aW9uID0ganNEeW5hbWljQ2FzdDxKU0Z1bmN0aW9uKj4oKnZtKCksIG9iamVjdCkpCisg ICAgICAgICAgICAgICAgICAgIG91dC5wcmludGYoIiBqaXQoJXAsIGV4ZWMgJXApIiwgZnVuY3Rp b24sIGZ1bmN0aW9uLT5leGVjdXRhYmxlKCkpOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAg ICAgICAgICAgICAgICAgb3V0LnByaW50ZigiIGppdCglcCkiLCBvYmplY3QpOworICAgICAgICAg ICAgfQogICAgICAgICB9CiAKICAgICAgICAgZHVtcENhbGxMaW5rU3RhdHVzKG91dCwgbG9jYXRp b24sIG1hcCk7Cg==