179749 2017-11-15 16:13:00 -0800 Fix fast/events/message-port-postMessage-recursive.html after r224896 2017-11-16 22:16:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen ap benjamin buildbot cdumez cmarcelo dbates jer.noble webkit-bug-importer oldest_to_newest 1372488 0 achristensen 2017-11-15 16:13:00 -0800 Fix fast/events/message-port-postMessage-recursive.html after r224896 1372490 1 327033 achristensen 2017-11-15 16:15:46 -0800 Created attachment 327033 Patch 1372492 2 327034 achristensen 2017-11-15 16:19:37 -0800 Created attachment 327034 Patch 1372495 3 achristensen 2017-11-15 16:36:51 -0800 https://trac.webkit.org/changeset/224907/webkit 1372497 4 webkit-bug-importer 2017-11-15 16:38:15 -0800 <rdar://problem/35575676> 1372991 5 327034 ap 2017-11-16 22:16:18 -0800 Comment on attachment 327034 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327034&action=review > Source/WTF/wtf/mac/MainThreadMac.mm:128 > + return currentMode == (NSString *)kCFRunLoopCommonModes I don't see how this can work. According to documentation, "Run loops never run in this mode". https://developer.apple.com/documentation/corefoundation/cfrunloop/common_mode_flag 327033 2017-11-15 16:15:46 -0800 2017-11-15 16:19:36 -0800 Patch bug-179749-20171115161545.patch text/plain 1653 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjQ5MDUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTExLTE1ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGZhc3QvZXZlbnRzL21lc3Nh Z2UtcG9ydC1wb3N0TWVzc2FnZS1yZWN1cnNpdmUuaHRtbCBhZnRlciByMjI0ODk2CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk3NDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9tYWMvTWFpblRo cmVhZE1hYy5tbToKKyAgICAgICAgKFdURjo6Y3VycmVudFJ1bkxvb3BJbkNvbW1vbk1vZGUpOgor ICAgICAgICBXZSBzb21ldGltZXMgcnVuIHRoZSBydW5sb29wIGluIGtDRlJ1bkxvb3BEZWZhdWx0 TW9kZSwgd2hpY2ggc2hvdWxkIGFsc28gaGF2ZSB0aGUgcmVzcG9uc2l2ZW5lc3Mgb3B0aW1pemF0 aW9uLgorICAgICAgICBUaGlzIGFsbG93cyB0aGUgcnVubG9vcCB0byBjb250aW51ZSB0byBpdGVy YXRlIHdoZW4gd2UgYXJlIGRvaW5nIGxvdHMgb2YgdGhpbmdzIG9uIHRoZSBtYWluIHRocmVhZC4K KyAgICAgICAgQ0ZSdW5Mb29wLmggaGFzIGEgc3BlY2lhbCBkZWZpbml0aW9uIG9mIHRoZXNlIHR3 byBjb25zdGFudHMuCisKIDIwMTctMTEtMTUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z ZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBXZWJWaWV3cyBzY2hlZHVsZWQgaW4gY3VzdG9tIHJ1 biBsb29wIG1vZGVzIHNob3VsZCBiZSBhYmxlIHRvIGRvIG1vcmUgdGhhbiA1MG1zIG9mIHdvcmsg YXQgYSB0aW1lCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQkocmV2aXNpb24g MjI0OTA1KQorKysgU291cmNlL1dURi93dGYvbWFjL01haW5UaHJlYWRNYWMubW0JKHdvcmtpbmcg Y29weSkKQEAgLTEyNCw3ICsxMjQsOSBAQCBzdGF0aWMgdm9pZCBwb3N0VGltZXIoKQogCiBib29s IGN1cnJlbnRSdW5Mb29wSW5Db21tb25Nb2RlKCkKIHsKLSAgICByZXR1cm4gW1tOU1J1bkxvb3Ag Y3VycmVudFJ1bkxvb3BdIGN1cnJlbnRNb2RlXSA9PSAoTlNTdHJpbmcgKilrQ0ZSdW5Mb29wQ29t bW9uTW9kZXM7CisgICAgTlNSdW5Mb29wTW9kZSBjdXJyZW50TW9kZSA9IFtbTlNSdW5Mb29wIGN1 cnJlbnRSdW5Mb29wXSBjdXJyZW50TW9kZV07CisgICAgcmV0dXJuIGN1cnJlbnRNb2RlID09IChO U1N0cmluZyAqKWtDRlJ1bkxvb3BDb21tb25Nb2RlcworICAgICAgICB8fCBjdXJyZW50TW9kZSA9 PSAoTlNTdHJpbmcgKilrQ0ZSdW5Mb29wRGVmYXVsdE1vZGU7CiB9CiAKIHZvaWQgc2NoZWR1bGVE aXNwYXRjaEZ1bmN0aW9uc09uTWFpblRocmVhZChTY2hlZHVsZVBhaXJIYXNoU2V0KiBwYWlycykK 327034 2017-11-15 16:19:37 -0800 2017-11-15 16:29:59 -0800 Patch bug-179749-20171115161937.patch text/plain 1649 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjQ5MDUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTExLTE1ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGZhc3QvZXZlbnRzL21lc3Nh Z2UtcG9ydC1wb3N0TWVzc2FnZS1yZWN1cnNpdmUuaHRtbCBhZnRlciByMjI0ODk2CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk3NDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9tYWMvTWFpblRo cmVhZE1hYy5tbToKKyAgICAgICAgKFdURjo6Y3VycmVudFJ1bkxvb3BJbkNvbW1vbk1vZGUpOgor ICAgICAgICBXZSBzb21ldGltZXMgcnVuIHRoZSBydW5sb29wIGluIGtDRlJ1bkxvb3BEZWZhdWx0 TW9kZSwgd2hpY2ggc2hvdWxkIGFsc28gaGF2ZSB0aGUgcmVzcG9uc2l2ZW5lc3Mgb3B0aW1pemF0 aW9uLgorICAgICAgICBUaGlzIGFsbG93cyB0aGUgcnVubG9vcCB0byBjb250aW51ZSB0byBpdGVy YXRlIHdoZW4gd2UgYXJlIGRvaW5nIGxvdHMgb2YgdGhpbmdzIG9uIHRoZSBtYWluIHRocmVhZC4K KyAgICAgICAgQ0ZSdW5Mb29wLmggaGFzIGEgc3BlY2lhbCBkZWZpbml0aW9uIG9mIHRoZXNlIHR3 byBjb25zdGFudHMuCisKIDIwMTctMTEtMTUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z ZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBXZWJWaWV3cyBzY2hlZHVsZWQgaW4gY3VzdG9tIHJ1 biBsb29wIG1vZGVzIHNob3VsZCBiZSBhYmxlIHRvIGRvIG1vcmUgdGhhbiA1MG1zIG9mIHdvcmsg YXQgYSB0aW1lCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQkocmV2aXNpb24g MjI0OTA1KQorKysgU291cmNlL1dURi93dGYvbWFjL01haW5UaHJlYWRNYWMubW0JKHdvcmtpbmcg Y29weSkKQEAgLTEyNCw3ICsxMjQsOSBAQCBzdGF0aWMgdm9pZCBwb3N0VGltZXIoKQogCiBib29s IGN1cnJlbnRSdW5Mb29wSW5Db21tb25Nb2RlKCkKIHsKLSAgICByZXR1cm4gW1tOU1J1bkxvb3Ag Y3VycmVudFJ1bkxvb3BdIGN1cnJlbnRNb2RlXSA9PSAoTlNTdHJpbmcgKilrQ0ZSdW5Mb29wQ29t bW9uTW9kZXM7CisgICAgTlNTdHJpbmcgKmN1cnJlbnRNb2RlID0gW1tOU1J1bkxvb3AgY3VycmVu dFJ1bkxvb3BdIGN1cnJlbnRNb2RlXTsKKyAgICByZXR1cm4gY3VycmVudE1vZGUgPT0gKE5TU3Ry aW5nICopa0NGUnVuTG9vcENvbW1vbk1vZGVzCisgICAgICAgIHx8IGN1cnJlbnRNb2RlID09IChO U1N0cmluZyAqKWtDRlJ1bkxvb3BEZWZhdWx0TW9kZTsKIH0KIAogdm9pZCBzY2hlZHVsZURpc3Bh dGNoRnVuY3Rpb25zT25NYWluVGhyZWFkKFNjaGVkdWxlUGFpckhhc2hTZXQqIHBhaXJzKQo=