179746 2017-11-15 15:15:55 -0800 Web Inspector: Remove WI.instanceForClass 2017-11-17 13:29:48 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1372474 0 mattbaker 2017-11-15 15:15:55 -0800 View classes lazily create their DOM, so there should not be a need for this. 1372487 1 327032 mattbaker 2017-11-15 16:11:28 -0800 Created attachment 327032 Patch 1373236 2 webkit-bug-importer 2017-11-17 13:18:26 -0800 <rdar://problem/35622220> 1373247 3 327032 commit-queue 2017-11-17 13:29:47 -0800 Comment on attachment 327032 Patch Clearing flags on attachment: 327032 Committed r224981: <https://trac.webkit.org/changeset/224981> 1373248 4 commit-queue 2017-11-17 13:29:48 -0800 All reviewed patches have been landed. Closing bug. 327032 2017-11-15 16:11:28 -0800 2017-11-17 13:29:47 -0800 Patch bug-179746-20171115161128.patch text/plain 4556 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 MWVkNmI1NTNiMWE2YjkyZTIyZmI4NjZkYzkxMjhkMjZkM2NhNzQ0Li5lNjRjODNkZDdiZWFiNTg4 YzViZGNhYTc4NzVkZmM4NGI4ZGZmNDg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNCBAQAogMjAxNy0xMS0xNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIFdJLmluc3RhbmNlRm9yQ2xhc3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTc0NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpbXBsZW1l bnRhdGlvbnMgb2YgRGV0YWlsc1NpZGViYXJQYW5lbCBzdWJjbGFzc2VzIGFzc3VtZSB0aGF0IHBh bmVscworICAgICAgICBhcmUgY2xvc2VkIGFuZCByZWxlYXNlZCB3aGVuIG5vIGxvbmdlciBuZWVk ZWQuIEtlZXBpbmcgdGhlbSBhbGl2ZSB3aXRoCisgICAgICAgIGluc3RhbmNlRm9yQ2xhc3MgaXNu J3QgdGhlIHJpZ2h0IGNob2ljZSwgc2luY2Ugc2lkZWJhciBwYW5lbHMgcmVtb3ZlIHRoZWlyCisg ICAgICAgIGV2ZW50IGxpc3RlbmVycyB3aGVuIGNsb3NlZC4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kuaW5zdGFuY2VGb3JDbGFzcyk6IERlbGV0 ZWQuCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclRhYkNvbnRlbnRWaWV3 LmpzOgorICAgICAgICAoV0kuRGVidWdnZXJUYWJDb250ZW50Vmlldy5wcm90b3R5cGUuc2hvd0Rl dGFpbHNTaWRlYmFyUGFuZWxzKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkNv bnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuVGFiQ29udGVudFZpZXcucHJvdG90eXBlLmdldCBk ZXRhaWxzU2lkZWJhclBhbmVscyk6CisKKzIwMTctMTEtMTUgIE1hdHQgQmFrZXIgIDxtYXR0YmFr ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04gKHIyMTc3 NTApOiBOYXZpZ2F0aW9uIHNpZGViYXIgYnJva2VuIGFmdGVyIGNsb3NpbmcgYW5kIHJlLW9wZW5p bmcgdGFiCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Nzk3MTcKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1NTUxNTQxPgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDcxMTRhODUwZTMz NTExMWUxZTEyMTllNjFlMzAxNGRiMGJiMGYzN2QuLmYxZDUxODJmZjg3YjRmYWY3YmRkMWRkN2Y4 MTdiN2RmZTAwMmNjN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL01haW4uanMKQEAgLTUwMiwyNCArNTAyLDYgQEAgV0kuY29udGVudExvYWRlZCA9 IGZ1bmN0aW9uKCkKICAgICAgICAgdGhpcy5ydW5Cb290c3RyYXBPcGVyYXRpb25zKCk7CiB9Owog Ci0vLyBUaGlzIGZ1bmN0aW9uIHJldHVybnMgYSBsYXppbHkgY29uc3RydWN0ZWQgaW5zdGFuY2Ug b2YgYSBjbGFzcyBzY29wZWQgdG8gdGhpcyBXZWJJbnNwZWN0b3IKLS8vIGluc3RhbmNlLiBJbiB0 aGUgdW5saWtlbHkgZXZlbnQgdGhhdCB3ZSBldmVyIG5lZWQgdG8gY29uc3RydWN0IG11bHRpcGxl IFdlYkluc3BlY3RvciBpbnN0YW5jZXMKLS8vIHRoaXMgYWxsb3dzIHVzIHRvIHNjb3BlIG9iamVj dHMgd2l0aGluIHRoZSBXSS4KLS8vIENsYXNzZXMgY2FuIHByZXZlbnQgdXNhZ2Ugb2YgdGhpcyBm dW5jdGlvbiB2aWEgYSBzdGF0aWMgYGRpc2FsbG93SW5zdGFuY2VGb3JDbGFzc2AgZnVuY3Rpb24g dGhhdAotLy8gcmV0dXJucyB0cnVlLiBJdCBpcyB0aGVuIHRoZWlyIHJlc3BvbnNpYmlsaXR5IHRv IGVuc3VyZSB0aGF0IHRoZSByZXR1cm5lZCB2YWx1ZSBpcyB0cmFja2VkLgotLy8gQ3VycmVudGx5 IGl0IGlzIG9ubHkgdXNlZCBmb3Igc2lkZWJhcnMuCi1XSS5pbnN0YW5jZUZvckNsYXNzID0gZnVu Y3Rpb24oY29uc3RydWN0b3IpCi17Ci0gICAgY29uc29sZS5hc3NlcnQodHlwZW9mIGNvbnN0cnVj dG9yID09PSAiZnVuY3Rpb24iKTsKLSAgICBpZiAodHlwZW9mIGNvbnN0cnVjdG9yLmRpc2FsbG93 SW5zdGFuY2VGb3JDbGFzcyA9PT0gImZ1bmN0aW9uIiAmJiBjb25zdHJ1Y3Rvci5kaXNhbGxvd0lu c3RhbmNlRm9yQ2xhc3MoKSkKLSAgICAgICAgcmV0dXJuIG5ldyBjb25zdHJ1Y3RvcjsKLQotICAg IGxldCBrZXkgPSBgX18ke2NvbnN0cnVjdG9yLm5hbWV9YDsKLSAgICBpZiAoIVdJW2tleV0pCi0g ICAgICAgIFdJW2tleV0gPSBuZXcgY29uc3RydWN0b3I7Ci0gICAgcmV0dXJuIFdJW2tleV07Ci19 OwotCiBXSS5pc1RhYlR5cGVBbGxvd2VkID0gZnVuY3Rpb24odGFiVHlwZSkKIHsKICAgICBsZXQg dGFiQ2xhc3MgPSB0aGlzLl9rbm93blRhYkNsYXNzZXNCeVR5cGUuZ2V0KHRhYlR5cGUpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdn ZXJUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0RlYnVnZ2VyVGFiQ29udGVudFZpZXcuanMKaW5kZXggNWU3ZjEyNjk1NjAwNTI2NzJj YWQ0ODcxM2U4Y2VhNDI3MjFlMGJiOS4uM2NiNzZhNmI3MjU5YzIzNjQxMGQ4YzFjMGZmZTA5NTYx MzQ3OTEzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRGVidWdnZXJUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclRhYkNvbnRlbnRWaWV3LmpzCkBAIC03Miw3 ICs3MiwxMCBAQCBXSS5EZWJ1Z2dlclRhYkNvbnRlbnRWaWV3ID0gY2xhc3MgRGVidWdnZXJUYWJD b250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRCcm93cwogICAgICAgICBpZiAoIXRoaXMuX3No b3dTY29wZUNoYWluRGV0YWlsc1NpZGViYXJQYW5lbCkKICAgICAgICAgICAgIHJldHVybjsKIAot ICAgICAgICBsZXQgc2NvcGVDaGFpbkRldGFpbHNTaWRlYmFyUGFuZWwgPSBXSS5pbnN0YW5jZUZv ckNsYXNzKFdJLlNjb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsKTsKKyAgICAgICAgbGV0IHNj b3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsID0gdGhpcy5kZXRhaWxzU2lkZWJhclBhbmVscy5m aW5kKChpdGVtKSA9PiBpdGVtIGluc3RhbmNlb2YgV0kuU2NvcGVDaGFpbkRldGFpbHNTaWRlYmFy UGFuZWwpOworICAgICAgICBpZiAoIXNjb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsKQorICAg ICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGxldCBzaWRlYmFyID0gc2NvcGVDaGFpbkRldGFp bHNTaWRlYmFyUGFuZWwucGFyZW50U2lkZWJhcjsKICAgICAgICAgaWYgKCFzaWRlYmFyKQogICAg ICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UYWJDb250ZW50Vmlldy5qcwppbmRleCAwYjI0ZWYzOTBlZTFl ODQzZDRjNjJlY2YzYTgyNGEzOWM1MWFmY2YxLi4zMTU5MmRiYThkNjc1MzA4NmE0Yzg1MmI1MjFm YWRmODc4MmYwYjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UYWJDb250ZW50Vmlldy5qcwpAQCAtMTg5LDcgKzE4OSw3IEBA IFdJLlRhYkNvbnRlbnRWaWV3ID0gY2xhc3MgVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250 ZW50VmlldwogICAgIGdldCBkZXRhaWxzU2lkZWJhclBhbmVscygpCiAgICAgewogICAgICAgICBp ZiAoIXRoaXMuX2RldGFpbHNTaWRlYmFyUGFuZWxzKQotICAgICAgICAgICAgdGhpcy5fZGV0YWls c1NpZGViYXJQYW5lbHMgPSB0aGlzLl9kZXRhaWxzU2lkZWJhclBhbmVsQ29uc3RydWN0b3JzLm1h cChjb25zdHJ1Y3RvciA9PiBXSS5pbnN0YW5jZUZvckNsYXNzKGNvbnN0cnVjdG9yKSk7CisgICAg ICAgICAgICB0aGlzLl9kZXRhaWxzU2lkZWJhclBhbmVscyA9IHRoaXMuX2RldGFpbHNTaWRlYmFy UGFuZWxDb25zdHJ1Y3RvcnMubWFwKChjb25zdHJ1Y3RvcikgPT4gbmV3IGNvbnN0cnVjdG9yKTsK IAogICAgICAgICByZXR1cm4gdGhpcy5fZGV0YWlsc1NpZGViYXJQYW5lbHM7CiAgICAgfQo=