17974 2008-03-20 17:20:28 -0700 REGRESSION: npfunctions.h should not import npruntime_internal.h 2008-03-22 15:03:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mrowe webkit-unassigned dobey mrowe oldest_to_newest 74587 0 mrowe 2008-03-20 17:20:28 -0700 npfunctions.h is a public header file on the Mac, so it must not import npruntime_internal.h. 74588 1 mrowe 2008-03-20 17:21:07 -0700 <rdar://problem/5782310> 74589 2 mrowe 2008-03-20 17:21:31 -0700 Rodney, your change introduced this include. Are you able to restructure things so that this import is not required? 74620 3 19923 dobey 2008-03-21 06:37:53 -0700 Created attachment 19923 Patch to rearrange includes 74744 4 19923 mrowe 2008-03-21 22:17:50 -0700 Comment on attachment 19923 Patch to rearrange includes r=me 74820 5 mrowe 2008-03-22 15:03:12 -0700 Landed in r31234. 19923 2008-03-21 06:37:53 -0700 2008-03-21 22:17:50 -0700 Patch to rearrange includes webkit-npfunctions.patch text/plain 2875 dobey SW5kZXg6IFdlYkNvcmUvYnJpZGdlL25wcnVudGltZV9pbnRlcm5hbC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvYnJpZGdlL25wcnVudGltZV9pbnRlcm5hbC5oCShyZXZpc2lvbiAzMTE3NikKKysr IFdlYkNvcmUvYnJpZGdlL25wcnVudGltZV9pbnRlcm5hbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0y NSw2ICsyNSw4IEBACiAgKiBpbmNsdWRlIHRoaXMgZmlsZSBpbnN0ZWFkIG9mIHRoZSBhY3R1YWwg bnBhcGkuaCBvciBucHJ1bnRpbWUuaAogICovCiAKKyNpbmNsdWRlICJucGFwaS5oIgorI2luY2x1 ZGUgIm5wZnVuY3Rpb25zLmgiCiAjaW5jbHVkZSAibnBydW50aW1lLmgiCiAKICNpZmRlZiBYUF9V TklYCkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvbnBmdW5jdGlvbnMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsdWdpbnMvbnBmdW5jdGlvbnMuaAkocmV2aXNpb24gMzExNzYpCisrKyBXZWJDb3Jl L3BsdWdpbnMvbnBmdW5jdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMjYsNyArMjYsOCBAQAog I2lmbmRlZiBfTlBGVU5DVElPTlNfSF8KICNkZWZpbmUgX05QRlVOQ1RJT05TX0hfCiAKLSNpbmNs dWRlICJucHJ1bnRpbWVfaW50ZXJuYWwuaCIKKyNpbmNsdWRlICJucHJ1bnRpbWUuaCIKKyNpbmNs dWRlICJucGFwaS5oIgogCiAjaWZkZWYgX19jcGx1c3BsdXMKIGV4dGVybiAiQyIgewpJbmRleDog V2ViQ29yZS9wbHVnaW5zL25wYXBpLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMv bnBhcGkuY3BwCShyZXZpc2lvbiAzMTE3NikKKysrIFdlYkNvcmUvcGx1Z2lucy9ucGFwaS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI3LDcgKzI3LDcgQEAKIAogI2luY2x1ZGUgIlBsdWdpbkluZm9T dG9yZS5oIgogI2luY2x1ZGUgIlBsdWdpblZpZXcuaCIKLSNpbmNsdWRlICJucGFwaS5oIiAvLyAj aW5jbHVkZXMgPHdpbmRvd3MuaD4KKyNpbmNsdWRlICJucHJ1bnRpbWVfaW50ZXJuYWwuaCIKIAog dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5T dHJlYW0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luU3RyZWFtLmgJKHJl dmlzaW9uIDMxMTc2KQorKysgV2ViQ29yZS9wbHVnaW5zL1BsdWdpblN0cmVhbS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMCw3ICszMCw3IEBACiAjaW5jbHVkZSAiQ1N0cmluZy5oIgogI2luY2x1ZGUg IkZpbGVTeXN0ZW0uaCIKICNpbmNsdWRlICJLVVJMLmgiCi0jaW5jbHVkZSAibnBmdW5jdGlvbnMu aCIKKyNpbmNsdWRlICJucHJ1bnRpbWVfaW50ZXJuYWwuaCIKICNpbmNsdWRlICJOZXRzY2FwZVBs dWdJblN0cmVhbUxvYWRlci5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVk ZSAiUGx1Z2luUXVpcmtTZXQuaCIKSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdl LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuaAkocmV2aXNp b24gMzExNzYpCisrKyBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5oCSh3b3JraW5nIGNv cHkpCkBAIC0zMiw3ICszMiw3IEBACiAjaW5jbHVkZSAiUGx1Z2luUXVpcmtTZXQuaCIKICNpbmNs dWRlICJTdHJpbmdIYXNoLmgiCiAjaW5jbHVkZSAiVGltZXIuaCIKLSNpbmNsdWRlICJucGZ1bmN0 aW9ucy5oIgorI2luY2x1ZGUgIm5wcnVudGltZV9pbnRlcm5hbC5oIgogI2luY2x1ZGUgPHd0Zi9I YXNoTWFwLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KIApJbmRleDogV2ViQ29yZS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDMxMjA4 KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMCBAQAor MjAwOC0wMy0yMSAgUm9kbmV5IERhd2VzICA8ZG9iZXlAd2F5b2Z0aGVtb25rZXkuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEhKQorCisgICAgICAgIDxodHRwOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk3ND4KKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzU3ODIzMTA+CisKKyAgICAgICAgSW5jbHVkZSBucGFwaS5oIGFuZCBucHJ1bnRpbWUuaCBk aXJlY3RseSBpbiBucGZ1bmN0aW9ucy5oLgorICAgICAgICBBZGQgbnBmdW5jdGlvbnMuaCBhbmQg bnBhcGkuaCB0byBucHJ1bnRpbWVfaW50ZXJuYWwuaC4KKyAgICAgICAgUmVwbGFjZSBpbmNsdWRl cyBvZiBucGZ1bmN0aW9ucy5oIHdpdGggbnBydW50aW1lX2ludGVybmFsLmguCisKKyAgICAgICAg KiBicmlkZ2UvbnBydW50aW1lX2ludGVybmFsLmg6CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5Q YWNrYWdlLmg6CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5TdHJlYW0uaDoKKyAgICAgICAgKiBw bHVnaW5zL25wYXBpLmNwcDoKKyAgICAgICAgKiBwbHVnaW5zL25wZnVuY3Rpb25zLmg6CisKIDIw MDgtMDMtMjAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCg==