179729 2017-11-15 06:34:19 -0800 [Cairo] Clang warns about mismatched declaration type tag for GraphicsContextState 2017-11-15 12:06:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez commit-queue mcatanzaro webkit-bug-importer zan oldest_to_newest 1371800 0 aperez 2017-11-15 06:34:19 -0800 The warning itself should be harmless, but it pops a few times during compilation and we would rather have build output as clean as possible. Warning message follows. --- In file included from DerivedSources/WebCore/unified-sources/UnifiedSource332.cpp:2: In file included from ../../Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:34: ../../Source/WebCore/platform/graphics/cairo/CairoOperations.h:51:1: warning: class 'GraphicsContextState' was previously declared as a struct [-Wmismatched-tags] class GraphicsContextState; ^ ../../Source/WebCore/platform/graphics/GraphicsContext.h:116:8: note: previous use is here struct GraphicsContextState { ^ ../../Source/WebCore/platform/graphics/cairo/CairoOperations.h:51:1: note: did you mean struct here? class GraphicsContextState; ^~~~~ struct 1371801 1 326980 aperez 2017-11-15 06:36:37 -0800 Created attachment 326980 Patch 1371813 2 326980 mcatanzaro 2017-11-15 07:39:24 -0800 Comment on attachment 326980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326980&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.h:51 > +struct GraphicsContextState; I think it should follow the class declarations, with a blank line in between. 1371815 3 aperez 2017-11-15 07:44:02 -0800 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 326980 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326980&action=review > > > Source/WebCore/platform/graphics/cairo/CairoOperations.h:51 > > +struct GraphicsContextState; > > I think it should follow the class declarations, with a blank line in > between. TBH, I was surprised that the style checker didn't complain now that there's both “class” and “struct” mixed in a block of forward declarations. Let's try your suggestion and see whether it will complain or accept it ;-) 1371816 4 326983 aperez 2017-11-15 07:45:22 -0800 Created attachment 326983 Patch 1371999 5 326983 commit-queue 2017-11-15 10:06:09 -0800 Comment on attachment 326983 Patch Clearing flags on attachment: 326983 Committed r224882: <https://trac.webkit.org/changeset/224882> 1372000 6 commit-queue 2017-11-15 10:06:10 -0800 All reviewed patches have been landed. Closing bug. 1372067 7 webkit-bug-importer 2017-11-15 12:06:10 -0800 <rdar://problem/35566940> 326980 2017-11-15 06:36:37 -0800 2017-11-15 07:45:19 -0800 Patch bug-179729-20171115163635.patch text/plain 1394 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0ODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM2N2Y1MjI0ZjllYTli YWJlNWEzYWE1MzhhMzE0MmYxMjYxYTYxNS4uYjM2MWRhN2IzYjEyMTgyZWUxNjExNDA1ZWZlOTkw ZjkyOWM2ZDY0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTExLTE1ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NhaXJv XSBDbGFuZyB3YXJucyBhYm91dCBtaXNtYXRjaGVkIGRlY2xhcmF0aW9uIHR5cGUgdGFnIGZvciBH cmFwaGljc0NvbnRleHRTdGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc5NzI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL0NhaXJvT3BlcmF0aW9ucy5oOiBNYWtlIHRoZSBmb3J3YXJkIGRlY2xhcmF0 aW9uIHVzZSAic3RydWN0IiAKKyAgICAgICAgYXMgdGhlIGFjdHVhbCBpbXBsZW1lbnRhdGlvbiBv ZiB0aGUgdHlwZSBkb2VzLgorCiAyMDE3LTExLTE1ICBHYWJyaWVsIEl2YXNjdSAgPGdpdmFzY3VA aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBdXRvbWF0aWNhbGx5IGFkanVzdCBmb250IHNp emUgd2hlbiBndGsteGZ0LWRwaSBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9DYWlyb09wZXJhdGlvbnMuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvT3BlcmF0aW9ucy5oCmluZGV4IDdjOGQwNzdj MjQwZjFmMmM5ODM4M2M5NGIzMzA5NmNhNjExMDA1NDkuLmZjNzYzODU5MWQyMWM4ZDY0M2VkZjdj NDBkZDNkN2M2MGE0M2FmZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL0NhaXJvT3BlcmF0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvT3BlcmF0aW9ucy5oCkBAIC00OCw3ICs0OCw3IEBAIGNs YXNzIEZsb2F0UmVjdDsKIGNsYXNzIEZsb2F0Um91bmRlZFJlY3Q7CiBjbGFzcyBGbG9hdFNpemU7 CiBjbGFzcyBHcmFwaGljc0NvbnRleHQ7Ci1jbGFzcyBHcmFwaGljc0NvbnRleHRTdGF0ZTsKK3N0 cnVjdCBHcmFwaGljc0NvbnRleHRTdGF0ZTsKIGNsYXNzIEltYWdlOwogY2xhc3MgUGF0aDsKIGNs YXNzIFBsYXRmb3JtQ29udGV4dENhaXJvOwo= 326983 2017-11-15 07:45:22 -0800 2017-11-15 10:06:09 -0800 Patch bug-179729-20171115174521.patch text/plain 1440 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0ODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM2N2Y1MjI0ZjllYTli YWJlNWEzYWE1MzhhMzE0MmYxMjYxYTYxNS4uYjM2MWRhN2IzYjEyMTgyZWUxNjExNDA1ZWZlOTkw ZjkyOWM2ZDY0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTExLTE1ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NhaXJv XSBDbGFuZyB3YXJucyBhYm91dCBtaXNtYXRjaGVkIGRlY2xhcmF0aW9uIHR5cGUgdGFnIGZvciBH cmFwaGljc0NvbnRleHRTdGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc5NzI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL0NhaXJvT3BlcmF0aW9ucy5oOiBNYWtlIHRoZSBmb3J3YXJkIGRlY2xhcmF0 aW9uIHVzZSAic3RydWN0IiAKKyAgICAgICAgYXMgdGhlIGFjdHVhbCBpbXBsZW1lbnRhdGlvbiBv ZiB0aGUgdHlwZSBkb2VzLgorCiAyMDE3LTExLTE1ICBHYWJyaWVsIEl2YXNjdSAgPGdpdmFzY3VA aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBdXRvbWF0aWNhbGx5IGFkanVzdCBmb250IHNp emUgd2hlbiBndGsteGZ0LWRwaSBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9DYWlyb09wZXJhdGlvbnMuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvT3BlcmF0aW9ucy5oCmluZGV4IDdjOGQwNzdj MjQwZjFmMmM5ODM4M2M5NGIzMzA5NmNhNjExMDA1NDkuLmE4NzdmNjMzNDAzYzdlYmFkOGYyZjcx NzEwYWE0NTE0N2MzMTUxZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL0NhaXJvT3BlcmF0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvT3BlcmF0aW9ucy5oCkBAIC00OCwxMSArNDgsMTIgQEAg Y2xhc3MgRmxvYXRSZWN0OwogY2xhc3MgRmxvYXRSb3VuZGVkUmVjdDsKIGNsYXNzIEZsb2F0U2l6 ZTsKIGNsYXNzIEdyYXBoaWNzQ29udGV4dDsKLWNsYXNzIEdyYXBoaWNzQ29udGV4dFN0YXRlOwog Y2xhc3MgSW1hZ2U7CiBjbGFzcyBQYXRoOwogY2xhc3MgUGxhdGZvcm1Db250ZXh0Q2Fpcm87CiAK K3N0cnVjdCBHcmFwaGljc0NvbnRleHRTdGF0ZTsKKwogbmFtZXNwYWNlIENhaXJvIHsKIAogbmFt ZXNwYWNlIFN0YXRlIHsK