179723 2017-11-15 03:51:26 -0800 [GTK] accessibility/accessibility-object-model.html fails 2017-11-15 12:43:49 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179494 P2 Normal --- 1 Ms2ger webkit-unassigned aboxhall apinheiro bugs-noreply buildbot cfleizach commit-queue dmazzoni jcraig jdiggs n_wang samuel_white oldest_to_newest 1371779 0 Ms2ger 2017-11-15 03:51:26 -0800 Since it was added in r224871. Looks like some labels are missing. --- /accessibility/accessibility-object-model-expected.txt +++ /accessibility/accessibility-object-model-actual.txt @@ -13,7 +13,7 @@ ARIA attributes should not be reflected into AOM properties. PASS axButton.role is 'AXRole: AXCheckBox' -PASS axButton.description is 'AXDescription: label' +FAIL axButton.description should be AXDescription: label. Was AXDescription: . PASS button.accessibleNode.role is null PASS button.accessibleNode.label is null @@ -21,7 +21,7 @@ PASS button.accessibleNode.role is 'slider' PASS button.accessibleNode.label is 'AOM Label' PASS axButton.role is 'AXRole: AXSlider' -PASS axButton.description is 'AXDescription: AOM Label' +FAIL axButton.description should be AXDescription: AOM Label. Was AXDescription: . Setting some of the AOM properties should be able to make an element accessible. PASS axParagraph == null || axParagraph == undefined is true 1372034 1 cfleizach 2017-11-15 11:13:31 -0800 Joanie can we enable AOM for GTK? 1372040 2 n_wang 2017-11-15 11:19:23 -0800 I think AOM is enabled in the tests, since the role is working correctly. I think on GTK it's not using axobject.description as the label. 1372049 3 327002 n_wang 2017-11-15 11:31:14 -0800 Created attachment 327002 patch 1372063 4 327002 commit-queue 2017-11-15 12:02:08 -0800 Comment on attachment 327002 patch Clearing flags on attachment: 327002 Committed r224893: <https://trac.webkit.org/changeset/224893> 1372064 5 commit-queue 2017-11-15 12:02:09 -0800 All reviewed patches have been landed. Closing bug. 1372224 6 jdiggs 2017-11-15 12:43:49 -0800 Nan I see you found the cross-platform-friend utilities. Thanks for updating your tests so quickly!! :) 327002 2017-11-15 11:31:14 -0800 2017-11-15 12:02:08 -0800 patch patch.txt text/plain 2970 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyNDg4OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTExLTE1ICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgW0dUS10gYWNjZXNzaWJpbGl0eS9hY2Nlc3NpYmlsaXR5 LW9iamVjdC1tb2RlbC5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzk3MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVcGRhdGVkIHRoZSB0ZXN0IHRvIHN1cHBvcnQgZGlmZmVyZW50IHBs YXRmb3Jtcy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYWNjZXNzaWJpbGl0eS1vYmplY3Qt bW9kZWwtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYWNjZXNzaWJpbGl0 eS1vYmplY3QtbW9kZWwuaHRtbDoKKwogMjAxNy0xMS0xNSAgTWF0dCBMZXdpcyAgPGpsZXdpczNA YXBwbGUuY29tPgogCiAgICAgICAgIEFkanVzdGVkIGV4cGVjdGF0aW9ucyBmb3IgY29tcG9zaXRp bmcvcmVwYWludC9maXhlZC1iYWNrZ3JvdW5kLXNjcm9sbC5odG1sLgpJbmRleDogTGF5b3V0VGVz dHMvYWNjZXNzaWJpbGl0eS9hY2Nlc3NpYmlsaXR5LW9iamVjdC1tb2RlbC1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hY2Nlc3NpYmlsaXR5LW9i amVjdC1tb2RlbC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDIyNDg4NCkKKysrIExheW91dFRlc3Rz L2FjY2Vzc2liaWxpdHkvYWNjZXNzaWJpbGl0eS1vYmplY3QtbW9kZWwtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC0xMyw3ICsxMyw3IEBAIFBBU1MgYnV0dG9uLmFjY2Vzc2libGVOb2Rl LmZvbyBpcyB1bmRlZmkKIAogQVJJQSBhdHRyaWJ1dGVzIHNob3VsZCBub3QgYmUgcmVmbGVjdGVk IGludG8gQU9NIHByb3BlcnRpZXMuCiBQQVNTIGF4QnV0dG9uLnJvbGUgaXMgJ0FYUm9sZTogQVhD aGVja0JveCcKLVBBU1MgYXhCdXR0b24uZGVzY3JpcHRpb24gaXMgJ0FYRGVzY3JpcHRpb246IGxh YmVsJworUEFTUyBwbGF0Zm9ybVZhbHVlRm9yVzNDTmFtZShheEJ1dHRvbikgaXMgImxhYmVsIgog UEFTUyBidXR0b24uYWNjZXNzaWJsZU5vZGUucm9sZSBpcyBudWxsCiBQQVNTIGJ1dHRvbi5hY2Nl c3NpYmxlTm9kZS5sYWJlbCBpcyBudWxsCiAKQEAgLTIxLDcgKzIxLDcgQEAgVGVzdCBzZXR0aW5n IEFPTSBwcm9wZXJ0aWVzLiBBbmQgbWFrZSBzdQogUEFTUyBidXR0b24uYWNjZXNzaWJsZU5vZGUu cm9sZSBpcyAnc2xpZGVyJwogUEFTUyBidXR0b24uYWNjZXNzaWJsZU5vZGUubGFiZWwgaXMgJ0FP TSBMYWJlbCcKIFBBU1MgYXhCdXR0b24ucm9sZSBpcyAnQVhSb2xlOiBBWFNsaWRlcicKLVBBU1Mg YXhCdXR0b24uZGVzY3JpcHRpb24gaXMgJ0FYRGVzY3JpcHRpb246IEFPTSBMYWJlbCcKK1BBU1Mg cGxhdGZvcm1WYWx1ZUZvclczQ05hbWUoYXhCdXR0b24pIGlzICJBT00gTGFiZWwiCiAKIFNldHRp bmcgc29tZSBvZiB0aGUgQU9NIHByb3BlcnRpZXMgc2hvdWxkIGJlIGFibGUgdG8gbWFrZSBhbiBl bGVtZW50IGFjY2Vzc2libGUuCiBQQVNTIGF4UGFyYWdyYXBoID09IG51bGwgfHwgYXhQYXJhZ3Jh cGggPT0gdW5kZWZpbmVkIGlzIHRydWUKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkv YWNjZXNzaWJpbGl0eS1vYmplY3QtbW9kZWwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9hY2Nlc3NpYmlsaXR5L2FjY2Vzc2liaWxpdHktb2JqZWN0LW1vZGVsLmh0bWwJKHJldmlzaW9u IDIyNDg4NCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYWNjZXNzaWJpbGl0eS1vYmpl Y3QtbW9kZWwuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNDUsNyArNDUsNyBAQAogICAgICAgICBi dXR0b24uc2V0QXR0cmlidXRlKCJyb2xlIiwgImNoZWNrYm94Iik7CiAgICAgICAgIGJ1dHRvbi5z ZXRBdHRyaWJ1dGUoImFyaWEtbGFiZWwiLCAibGFiZWwiKTsKICAgICAgICAgc2hvdWxkQmUoImF4 QnV0dG9uLnJvbGUiLCAiJ0FYUm9sZTogQVhDaGVja0JveCciKTsKLSAgICAgICAgc2hvdWxkQmUo ImF4QnV0dG9uLmRlc2NyaXB0aW9uIiwgIidBWERlc2NyaXB0aW9uOiBsYWJlbCciKTsKKyAgICAg ICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJwbGF0Zm9ybVZhbHVlRm9yVzNDTmFtZShheEJ1dHRv bikiLCAibGFiZWwiKTsKICAgICAgICAgCiAgICAgICAgIC8vIEFPTSBwcm9wZXJ0aWVzIHNob3Vs ZCBiZSBudWxsIGV2ZW4gaWYgd2UgaGF2ZSBzZXQgQVJJQSBhdHRyaWJ1dGVzLgogICAgICAgICBz aG91bGRCZU51bGwoImJ1dHRvbi5hY2Nlc3NpYmxlTm9kZS5yb2xlIik7CkBAIC02Nyw3ICs2Nyw3 IEBACiAgICAgICAgIAogICAgICAgICAvLyBUaGUgQU9NIHByb3BlcnR5IHZhbHVlcyBzaG91bGQg b3ZlcnJpZGUgQVJJQSBhdHRyaWJ1dGVzLgogICAgICAgICBzaG91bGRCZSgiYXhCdXR0b24ucm9s ZSIsICInQVhSb2xlOiBBWFNsaWRlciciKTsKLSAgICAgICAgc2hvdWxkQmUoImF4QnV0dG9uLmRl c2NyaXB0aW9uIiwgIidBWERlc2NyaXB0aW9uOiBBT00gTGFiZWwnIik7CisgICAgICAgIHNob3Vs ZEJlRXF1YWxUb1N0cmluZygicGxhdGZvcm1WYWx1ZUZvclczQ05hbWUoYXhCdXR0b24pIiwgIkFP TSBMYWJlbCIpOwogICAgIH0KICAgICAKICAgICBmdW5jdGlvbiB0ZXN0QmVjb21lQWNjZXNzaWJs ZSgpIHsK