179710 2017-11-14 16:51:25 -0800 Clean up URL.h 2017-11-20 22:09:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen beidson darin webkit-bug-importer oldest_to_newest 1371664 0 achristensen 2017-11-14 16:51:25 -0800 Clean up URL.h 1371666 1 326947 achristensen 2017-11-14 16:52:49 -0800 Created attachment 326947 Patch 1373260 2 achristensen 2017-11-17 13:38:31 -0800 http://trac.webkit.org/r224984 1373261 3 webkit-bug-importer 2017-11-17 13:39:37 -0800 <rdar://problem/35622767> 1373924 4 326947 darin 2017-11-20 22:09:29 -0800 Comment on attachment 326947 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326947&action=review > Source/WebCore/platform/URL.h:459 > +// URLHash is the default hash for String I think this should say URLHash is the default hash for *URL*, not String. > Source/WebCore/platform/URL.h:460 > +template<typename T> struct DefaultHash; No need for "T" here, just <typename>. > Source/WebCore/platform/URL.h:462 > + typedef WebCore::URLHash Hash; Should use "using" instead of typedef if touching this. 326947 2017-11-14 16:52:49 -0800 2017-11-17 10:22:36 -0800 Patch bug-179710-20171114165249.patch text/plain 4851 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDg2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE3LTExLTE0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ2xlYW4gdXAg VVJMLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 OTcxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIE1vZHVsZXMvZmV0Y2gvRmV0Y2hSZXF1 ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZldGNoUmVxdWVzdDo6dXJsU3RyaW5nIGNvbnN0 KToKKyAgICAgICAgKiBNb2R1bGVzL2ZldGNoL0ZldGNoUmVzcG9uc2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RmV0Y2hSZXNwb25zZTo6dXJsIGNvbnN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9V UkwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VVJMOjpzZXJpYWxpemUgY29uc3QpOiBEZWxldGVk LgorICAgICAgICAqIHBsYXRmb3JtL1VSTC5oOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9VUkxN YWMubW06CisgICAgICAgIChXZWJDb3JlOjpVUkw6OmNyZWF0ZUNGVVJMIGNvbnN0KToKKwogMjAx Ny0xMS0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgTW92ZSBKU09OVmFsdWVzIHRvIFdURiBhbmQgY29udmVydCB1c2VzIG9mIEluc3BlY3Rv clZhbHVlcy5oIHRvIEpTT05WYWx1ZXMuaApJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9m ZXRjaC9GZXRjaFJlcXVlc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvZmV0Y2gvRmV0Y2hSZXF1ZXN0LmNwcAkocmV2aXNpb24gMjI0ODQ1KQorKysgU291cmNlL1dl YkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlcXVlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NjMsNyArMjYzLDcgQEAgU3RyaW5nIEZldGNoUmVxdWVzdDo6cmVmZXJyZXIoKSBjb25zdAogY29u c3QgU3RyaW5nJiBGZXRjaFJlcXVlc3Q6OnVybFN0cmluZygpIGNvbnN0CiB7CiAgICAgaWYgKG1f cmVxdWVzdFVSTC5pc051bGwoKSkKLSAgICAgICAgbV9yZXF1ZXN0VVJMID0gbV9yZXF1ZXN0LnVy bCgpLnNlcmlhbGl6ZSgpOworICAgICAgICBtX3JlcXVlc3RVUkwgPSBtX3JlcXVlc3QudXJsKCk7 CiAgICAgcmV0dXJuIG1fcmVxdWVzdFVSTDsKIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvTW9k dWxlcy9mZXRjaC9GZXRjaFJlc3BvbnNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL2ZldGNoL0ZldGNoUmVzcG9uc2UuY3BwCShyZXZpc2lvbiAyMjQ4NDUpCisrKyBT b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNoUmVzcG9uc2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xODYsOCArMTg2LDExIEBAIHZvaWQgRmV0Y2hSZXNwb25zZTo6ZmV0Y2goU2NyaXB0 RXhlY3V0aW8KIAogY29uc3QgU3RyaW5nJiBGZXRjaFJlc3BvbnNlOjp1cmwoKSBjb25zdAogewot ICAgIGlmIChtX3Jlc3BvbnNlVVJMLmlzTnVsbCgpKQotICAgICAgICBtX3Jlc3BvbnNlVVJMID0g bV9yZXNwb25zZS51cmwoKS5zZXJpYWxpemUodHJ1ZSk7CisgICAgaWYgKG1fcmVzcG9uc2VVUkwu aXNOdWxsKCkpIHsKKyAgICAgICAgVVJMIHVybCA9IG1fcmVzcG9uc2UudXJsKCk7CisgICAgICAg IHVybC5yZW1vdmVGcmFnbWVudElkZW50aWZpZXIoKTsKKyAgICAgICAgbV9yZXNwb25zZVVSTCA9 IHVybC5zdHJpbmcoKTsKKyAgICB9CiAgICAgcmV0dXJuIG1fcmVzcG9uc2VVUkw7CiB9CiAKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vVVJMLmNwcAkocmV2aXNpb24gMjI0ODQ1KQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vVVJMLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjgyLDEzICs2ODIsNiBA QCBTdHJpbmcgZGVjb2RlVVJMRXNjYXBlU2VxdWVuY2VzKGNvbnN0IFN0CiAgICAgcmV0dXJuIGRl Y29kZUVzY2FwZVNlcXVlbmNlczxVUkxFc2NhcGVTZXF1ZW5jZT4oc3RyaW5nLCBlbmNvZGluZyk7 CiB9CiAKLVN0cmluZyBVUkw6OnNlcmlhbGl6ZShib29sIG9taXRGcmFnbWVudCkgY29uc3QKLXsK LSAgICBpZiAob21pdEZyYWdtZW50KQotICAgICAgICByZXR1cm4gbV9zdHJpbmcubGVmdChtX3F1 ZXJ5RW5kKTsKLSAgICByZXR1cm4gbV9zdHJpbmc7Ci19Ci0KICNpZiBQTEFURk9STShJT1MpCiAK IHN0YXRpYyBib29sIHNob3VsZENhbm9uaWNhbGl6ZVNjaGVtZSA9IHRydWU7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9VUkwuaAkocmV2aXNpb24gMjI0ODQ1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vVVJMLmgJKHdvcmtpbmcgY29weSkKQEAgLTIwNyw4ICsyMDcsNiBAQCBwdWJsaWM6CiAgICAg dGVtcGxhdGUgPGNsYXNzIERlY29kZXI+IHN0YXRpYyBib29sIGRlY29kZShEZWNvZGVyJiwgVVJM Jik7CiAgICAgdGVtcGxhdGUgPGNsYXNzIERlY29kZXI+IHN0YXRpYyBzdGQ6Om9wdGlvbmFsPFVS TD4gZGVjb2RlKERlY29kZXImKTsKIAotICAgIFN0cmluZyBzZXJpYWxpemUoYm9vbCBvbWl0RnJh Z21lbnQgPSBmYWxzZSkgY29uc3Q7Ci0KIHByaXZhdGU6CiAgICAgZnJpZW5kIGNsYXNzIFVSTFBh cnNlcjsKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGludmFsaWRhdGUoKTsKQEAgLTIxNiwxMiAr MjE0LDYgQEAgcHJpdmF0ZToKICAgICB2b2lkIGluaXQoY29uc3QgVVJMJiwgY29uc3QgU3RyaW5n JiwgY29uc3QgVGV4dEVuY29kaW5nJik7CiAgICAgdm9pZCBjb3B5VG9CdWZmZXIoVmVjdG9yPGNo YXIsIDUxMj4mIGJ1ZmZlcikgY29uc3Q7CiAKLSAgICAvLyBQYXJzZXMgdGhlIGdpdmVuIFVSTC4g VGhlIG9yaWdpbmFsU3RyaW5nIHBhcmFtZXRlciBhbGxvd3MgZm9yIGFuCi0gICAgLy8gb3B0aW1p emF0aW9uOiBXaGVuIHRoZSBzb3VyY2UgaXMgdGhlIHNhbWUgYXMgdGhlIGZpeGVkLXVwIHN0cmlu ZywKLSAgICAvLyBpdCB3aWxsIHVzZSB0aGUgcGFzc2VkLWluIHN0cmluZyBpbnN0ZWFkIG9mIGFs bG9jYXRpbmcgYSBuZXcgb25lLgotICAgIHZvaWQgcGFyc2UoY29uc3QgU3RyaW5nJik7Ci0gICAg dm9pZCBwYXJzZShjb25zdCBjaGFyKiB1cmwsIGNvbnN0IFN0cmluZyogb3JpZ2luYWxTdHJpbmcg PSAwKTsKLQogICAgIGJvb2wgaGFzUGF0aCgpIGNvbnN0OwogCiAgICAgU3RyaW5nIG1fc3RyaW5n OwpAQCAtNDY0LDEwICs0NTYsMTAgQEAgV1RGOjpUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFdURjo6 VGV4dFN0cgogCiBuYW1lc3BhY2UgV1RGIHsKIAotICAgIC8vIFVSTEhhc2ggaXMgdGhlIGRlZmF1 bHQgaGFzaCBmb3IgU3RyaW5nCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gc3RydWN0IERlZmF1 bHRIYXNoOwotICAgIHRlbXBsYXRlPD4gc3RydWN0IERlZmF1bHRIYXNoPFdlYkNvcmU6OlVSTD4g ewotICAgICAgICB0eXBlZGVmIFdlYkNvcmU6OlVSTEhhc2ggSGFzaDsKLSAgICB9OworLy8gVVJM SGFzaCBpcyB0aGUgZGVmYXVsdCBoYXNoIGZvciBTdHJpbmcKK3RlbXBsYXRlPHR5cGVuYW1lIFQ+ IHN0cnVjdCBEZWZhdWx0SGFzaDsKK3RlbXBsYXRlPD4gc3RydWN0IERlZmF1bHRIYXNoPFdlYkNv cmU6OlVSTD4geworICAgIHR5cGVkZWYgV2ViQ29yZTo6VVJMSGFzaCBIYXNoOworfTsKIAogfSAv LyBuYW1lc3BhY2UgV1RGCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVVJMTWFj Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9VUkxNYWMubW0J KHJldmlzaW9uIDIyNDg0NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9VUkxNYWMu bW0JKHdvcmtpbmcgY29weSkKQEAgLTU3LDcgKzU3LDcgQEAgVVJMOjpvcGVyYXRvciBOU1VSTCAq KCkgY29uc3QKIFJldGFpblB0cjxDRlVSTFJlZj4gVVJMOjpjcmVhdGVDRlVSTCgpIGNvbnN0CiB7 CiAgICAgaWYgKGlzTnVsbCgpKQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIG51 bGxwdHI7CiAKICAgICBpZiAoaXNFbXB0eSgpKSB7CiAgICAgICAgIC8vIFdlIHVzZSB0aGUgdG9s bC1mcmVlIGJyaWRnZSBiZXR3ZWVuIE5TVVJMIGFuZCBDRlVSTCB0byBjcmVhdGUgYSBDRlVSTFJl ZiBzdXBwb3J0aW5nIGJvdGggZW1wdHkgYW5kIG51bGwgdmFsdWVzLgpAQCAtNzQsNiArNzQsNCBA QCBSZXRhaW5QdHI8Q0ZVUkxSZWY+IFVSTDo6Y3JlYXRlQ0ZVUkwoKSBjCiAgICAgcmV0dXJuIGNy ZWF0ZUNGVVJMRnJvbUJ1ZmZlcihidWZmZXIuZGF0YSgpLCBidWZmZXIuc2l6ZSgpKTsKIH0KIAot Ci0KIH0K