179704 2017-11-14 16:21:54 -0800 REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures 2017-11-15 12:06:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179451 InRadar P2 Normal --- 1 mcatanzaro keith_miller bugs-noreply clopez commit-queue keith_miller mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1371635 0 mcatanzaro 2017-11-14 16:21:54 -0800 r224787 "Async iteration should only fetch the next method once and add feature flag" introduced 144 JS test failures for GTK and WPE. Keith, maybe the tests depend on the ASYNC_ITERATION feature? After that commit, it's now disabled for CMake builds and enabled for XCode builds. Note: if you want to enable it for CMake builds, it just needs added to Source/cmake/WebKitFeatures.cmake. (It probably does not make sense to have any build flags not listed there, anyway.) 1372001 1 326994 keith_miller 2017-11-15 10:07:46 -0800 Created attachment 326994 Patch 1372002 2 326994 ysuzuki 2017-11-15 10:08:27 -0800 Comment on attachment 326994 Patch r=me 1372013 3 326994 commit-queue 2017-11-15 10:31:07 -0800 Comment on attachment 326994 Patch Clearing flags on attachment: 326994 Committed r224884: <https://trac.webkit.org/changeset/224884> 1372014 4 commit-queue 2017-11-15 10:31:09 -0800 All reviewed patches have been landed. Closing bug. 1372025 5 mcatanzaro 2017-11-15 10:54:13 -0800 Could you alphabetize it please? :) 1372039 6 keith_miller 2017-11-15 11:17:16 -0800 (In reply to Michael Catanzaro from comment #5) > Could you alphabetize it please? :) Oh, I missed that they were alphabetized... I'll make another patch. 1372042 7 keith_miller 2017-11-15 11:22:59 -0800 Sorted in: https://trac.webkit.org/changeset/224888 1372073 8 webkit-bug-importer 2017-11-15 12:06:56 -0800 <rdar://problem/35566964> 326994 2017-11-15 10:07:46 -0800 2017-11-15 10:31:07 -0800 Patch bug-179704-20171115100745.patch text/plain 1599 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0ODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggMTBiMjQyZGQzYWMwNzM1NDI1YjA4MGY1Y2ZkMTFlMjU5YjViYTJjNS4uYzJmZDcyYzVhMGE5 ZGExZGRlMjExYTlmOGYwZDBjZTU1ZWI3ZTk0YSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMTA3LDYgKzEwNyw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VC S0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0ZJTFRFUlNfTEVWRUxfMiAiVG9nZ2xlIEZpbHRlcnMg TW9kdWxlIExldmVsIDIiIFBSSVZBVEUgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVO QUJMRV9GVFBESVIgIlRvZ2dsZSBGVFAgZGlyZWN0b3J5IHN1cHBvcnQiIFBSSVZBVEUgT04pCiAg ICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0ZUTF9KSVQgIlRvZ2dsZSBGVEwgc3VwcG9y dCBmb3IgSlNDIiBQUklWQVRFICR7RU5BQkxFX0ZUTF9ERUZBVUxUfSkKKyAgICBXRUJLSVRfT1BU SU9OX0RFRklORShFTkFCTEVfQVNZTkNfSVRFUkFUSU9OICJUb2dnbGUgdGhlIGFzeW5jIGl0ZXJh dGlvbiBBUEkuIiBQUklWQVRFIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9G VUxMU0NSRUVOX0FQSSAiVG9nZ2xlIEZ1bGxzY3JlZW4gQVBJIHN1cHBvcnQiIFBSSVZBVEUgT0ZG KQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9HQU1FUEFEICJUb2dnbGUgR2FtZXBh ZCBzdXBwb3J0IiBQUklWQVRFIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVf R0VPTE9DQVRJT04gIlRvZ2dsZSBHZW9sb2NhdGlvbiBzdXBwb3J0IiBQUklWQVRFIE9GRikKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZDQyOTRmYmY3YTllMDA4NDZm NjgxZTcwODVmYTkzOGE0ZDQzZmFiLi43M2JkZTFiNzg3MzdmOTJlYjQ5Y2Y5OTc4OTI2MGEwZDFi MTUwODBhIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTctMTEtMTUgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjI0Nzg3KTogW0xpbnV4XSBJbnRyb2R1Y2VkIDE0NCBH VEsvV1BFIEpTIHRlc3QgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3OTcwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBmZWF0dXJlIGZsYWcgZm9yIEFzeW5jIGl0ZXJhdGlvbi4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZToKKwogMjAxNy0xMS0x MyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gUmVxdWlyZSB3b2ZmMiAxLjAuMiBhbmQgZHJvcCBkaXJlY3QgYnJvdGxpIGRlcGVuZGVu Y3kK