<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>179702</bug_id>
          
          <creation_ts>2017-11-14 16:04:06 -0800</creation_ts>
          <short_desc>Add WebKitAdditions extension point to add user-agent stylesheet</short_desc>
          <delta_ts>2017-11-28 10:34:05 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Local Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=179785</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>aestes</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1371621</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-11-14 16:04:06 -0800</bug_when>
    <thetext>Add WebKitAdditions extension point to add user-agent stylesheet.

This is will be used towards &lt;rdar://problem/34917108&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1371633</commentid>
    <comment_count>1</comment_count>
      <attachid>326937</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-11-14 16:17:00 -0800</bug_when>
    <thetext>Created attachment 326937
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1372701</commentid>
    <comment_count>2</comment_count>
      <attachid>326937</attachid>
    <who name="Andy Estes">aestes</who>
    <bug_when>2017-11-16 10:33:41 -0800</bug_when>
    <thetext>Comment on attachment 326937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326937&amp;action=review

&gt; Source/WebCore/DerivedSources.make:1218
&gt; +USER_AGENT_STYLE_SHEETS = css/html.css css/quirks.css css/plugIns.css
&gt; +USER_AGENT_STYLE_SHEETS += css/svg.css

Why does svg.css have to be appended separately?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1372754</commentid>
    <comment_count>3</comment_count>
      <attachid>326937</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-11-16 12:13:32 -0800</bug_when>
    <thetext>Comment on attachment 326937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326937&amp;action=review

&gt;&gt; Source/WebCore/DerivedSources.make:1218
&gt;&gt; +USER_AGENT_STYLE_SHEETS += css/svg.css
&gt; 
&gt; Why does svg.css have to be appended separately?

It does not need to be. Will fix before landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1372803</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-11-16 14:23:42 -0800</bug_when>
    <thetext>Part of &lt;rdar://problem/34917108&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375210</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-11-27 16:23:34 -0800</bug_when>
    <thetext>&lt;rdar://problem/35711147&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1375394</commentid>
    <comment_count>6</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-11-28 10:34:05 -0800</bug_when>
    <thetext>Committed r225224: &lt;https://trac.webkit.org/changeset/225224&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>326937</attachid>
            <date>2017-11-14 16:17:00 -0800</date>
            <delta_ts>2017-11-16 10:33:41 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179702-20171114161659.patch</filename>
            <type>text/plain</type>
            <size>4123</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzliMzg3MWUzMGQxNzdh
YTM2MGVhZDYzNmJjM2QyZTdiYzgwNTc0Ni4uZjkxYjk1N2RhNTE1YmVlNWVlZjBiZGZhZTVkNWE0
NjlkNDFlMDk5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTExLTE0ICBEYW5p
ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgV2ViS2l0QWRkaXRp
b25zIGV4dGVuc2lvbiBwb2ludCB0byBhZGQgdXNlci1hZ2VudCBzdHlsZXNoZWV0CisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk3MDIKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIERlcml2ZWRTb3VyY2Vz
Lm1ha2U6IFdyaXRlIHVzZXIgYWdlbnQgc3R5bGVzaGVldCBnZW5lcmF0aW9uIHJlY2lwZSBpbiB0
ZXJtcyBvZiB0aGUKKyAgICAgICAgYXV0b21hdGljIHZhcmlhYmxlICReLCB3aGljaCByZXByZXNl
bnRzIHRoZSBsaXN0IG9mIHRoZSBuYW1lcyBvZiBhbGwgcHJlcmVxdWlzaXRlcworICAgICAgICBm
b3IgdGhlIHJ1bGUuIE1ha2UgYXV0b21hdGljYWxseSBleHBhbmRzIHRoZSBuYW1lcyBpbiAkXiB1
cCB0byB0aGVpciBmdWxsIGFic29sdXRlCisgICAgICAgIHBhdGguCisKIDIwMTctMTEtMTQgIERh
bmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBjb21tZW50
IGluIEZlYXR1cmVEZWZpbmVzLnhjY29uZmlnIHRvIHJlZmxlY3QgbG9jYXRpb24gb2YgVmlzdWFs
IFN0dWRpbyBwcm9wZXJ0eSBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRGVyaXZl
ZFNvdXJjZXMubWFrZSBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKaW5kZXgg
YjM3ZTVmNWZmOGUxMGU3NGZlNjBlNDMzYzY4NTY4OWY0NmI0YjZhZS4uMmIxZDFhNWU3MWUzMWFi
NDgyODI4ODQzZGFjMTI2NTExMjQ4YjgwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvRGVy
aXZlZFNvdXJjZXMubWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtl
CkBAIC0xMDE3LDkgKzEwMTcsMTMgQEAgZW5kaWYKIGVuZGlmICMgSU9TCiAKIHZwYXRoICUuaW4g
JChXRUJLSVRBRERJVElPTlNfSEVBREVSX1NFQVJDSF9QQVRIUykKK3ZwYXRoICUuY3NzICQoV0VC
S0lUQURESVRJT05TX0hFQURFUl9TRUFSQ0hfUEFUSFMpCiAKIEFERElUSU9OQUxfRVZFTlRfTkFN
RVMgPQogQURESVRJT05BTF9FVkVOVF9UQVJHRVRfRkFDVE9SWSA9CitBRERJVElPTkFMX1VTRVJf
QUdFTlRfU1RZTEVfU0hFRVRTID0KKworLWluY2x1ZGUgV2ViQ29yZURlcml2ZWRTb3VyY2VzQWRk
aXRpb25zLm1ha2UKIAogSlNfQklORElOR19JRExTICs9ICQoQURESVRJT05BTF9CSU5ESU5HX0lE
TFMpCiAKQEAgLTEyMTAsMzkgKzEyMTQsNDEgQEAgQ29sb3JEYXRhLmNwcCA6IHBsYXRmb3JtL0Nv
bG9yRGF0YS5ncGVyZiAkKFdlYkNvcmUpL21ha2UtaGFzaC10b29scy5wbAogCiAjIHVzZXIgYWdl
bnQgc3R5bGUgc2hlZXRzCiAKLVVTRVJfQUdFTlRfU1RZTEVfU0hFRVRTID0gJChXZWJDb3JlKS9j
c3MvaHRtbC5jc3MgJChXZWJDb3JlKS9jc3MvcXVpcmtzLmNzcyAkKFdlYkNvcmUpL2Nzcy9wbHVn
SW5zLmNzcwotVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMgOj0gJChVU0VSX0FHRU5UX1NUWUxFX1NI
RUVUUykgJChXZWJDb3JlKS9jc3Mvc3ZnLmNzcworVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMgPSBj
c3MvaHRtbC5jc3MgY3NzL3F1aXJrcy5jc3MgY3NzL3BsdWdJbnMuY3NzCitVU0VSX0FHRU5UX1NU
WUxFX1NIRUVUUyArPSBjc3Mvc3ZnLmNzcwogCiBpZmVxICgkKGZpbmRzdHJpbmcgRU5BQkxFX01B
VEhNTCwkKEZFQVRVUkVfREVGSU5FUykpLCBFTkFCTEVfTUFUSE1MKQotICAgIFVTRVJfQUdFTlRf
U1RZTEVfU0hFRVRTIDo9ICQoVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMpICQoV2ViQ29yZSkvY3Nz
L21hdGhtbC5jc3MKKyAgICBVU0VSX0FHRU5UX1NUWUxFX1NIRUVUUyArPSBjc3MvbWF0aG1sLmNz
cwogZW5kaWYKIAogaWZlcSAoJChmaW5kc3RyaW5nIEVOQUJMRV9WSURFTywkKEZFQVRVUkVfREVG
SU5FUykpLCBFTkFCTEVfVklERU8pCi0gICAgVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMgOj0gJChV
U0VSX0FHRU5UX1NUWUxFX1NIRUVUUykgJChXZWJDb3JlKS9jc3MvbWVkaWFDb250cm9scy5jc3MK
KyAgICBVU0VSX0FHRU5UX1NUWUxFX1NIRUVUUyArPSBjc3MvbWVkaWFDb250cm9scy5jc3MKIGVu
ZGlmCiAKIGlmZXEgKCQoZmluZHN0cmluZyBFTkFCTEVfRlVMTFNDUkVFTl9BUEksJChGRUFUVVJF
X0RFRklORVMpKSwgRU5BQkxFX0ZVTExTQ1JFRU5fQVBJKQotICAgIFVTRVJfQUdFTlRfU1RZTEVf
U0hFRVRTIDo9ICQoVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMpICQoV2ViQ29yZSkvY3NzL2Z1bGxz
Y3JlZW4uY3NzCisgICAgVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMgKz0gY3NzL2Z1bGxzY3JlZW4u
Y3NzCiBlbmRpZgogCiBpZmVxICgkKGZpbmRzdHJpbmcgRU5BQkxFX1NFUlZJQ0VfQ09OVFJPTFMs
JChGRUFUVVJFX0RFRklORVMpKSwgRU5BQkxFX1NFUlZJQ0VfQ09OVFJPTFMpCi0gICAgVVNFUl9B
R0VOVF9TVFlMRV9TSEVFVFMgOj0gJChVU0VSX0FHRU5UX1NUWUxFX1NIRUVUUykgJChXZWJDb3Jl
KS9odG1sL3NoYWRvdy9tYWMvaW1hZ2VDb250cm9sc01hYy5jc3MKKyAgICBVU0VSX0FHRU5UX1NU
WUxFX1NIRUVUUyArPSBodG1sL3NoYWRvdy9tYWMvaW1hZ2VDb250cm9sc01hYy5jc3MKIGVuZGlm
CiAKIGlmZXEgKCQoT1MpLE1BQ09TKQotICAgIFVTRVJfQUdFTlRfU1RZTEVfU0hFRVRTIDo9ICQo
VVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMpICQoV2ViQ29yZSkvTW9kdWxlcy9wbHVnaW5zL1F1aWNr
VGltZVBsdWdpblJlcGxhY2VtZW50LmNzcworICAgIFVTRVJfQUdFTlRfU1RZTEVfU0hFRVRTICs9
IE1vZHVsZXMvcGx1Z2lucy9RdWlja1RpbWVQbHVnaW5SZXBsYWNlbWVudC5jc3MKIGVuZGlmCiAK
IGlmZXEgKCQoT1MpLCBXaW5kb3dzX05UKQotICAgIFVTRVJfQUdFTlRfU1RZTEVfU0hFRVRTIDo9
ICQoVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMpICQoV2ViQ29yZSkvY3NzL3RoZW1lV2luLmNzcyAk
KFdlYkNvcmUpL2Nzcy90aGVtZVdpblF1aXJrcy5jc3MKKyAgICBVU0VSX0FHRU5UX1NUWUxFX1NI
RUVUUyArPSBjc3MvdGhlbWVXaW4uY3NzIGNzcy90aGVtZVdpblF1aXJrcy5jc3MKIGVuZGlmCiAK
IGlmZXEgKCQoZmluZHN0cmluZyBFTkFCTEVfTUVURVJfRUxFTUVOVCwkKEZFQVRVUkVfREVGSU5F
UykpLCBFTkFCTEVfTUVURVJfRUxFTUVOVCkKLQlVU0VSX0FHRU5UX1NUWUxFX1NIRUVUUyA6PSAk
KFVTRVJfQUdFTlRfU1RZTEVfU0hFRVRTKSAkKFdlYkNvcmUpL2h0bWwvc2hhZG93L21ldGVyRWxl
bWVudFNoYWRvdy5jc3MKKwlVU0VSX0FHRU5UX1NUWUxFX1NIRUVUUyArPSBodG1sL3NoYWRvdy9t
ZXRlckVsZW1lbnRTaGFkb3cuY3NzCiBlbmRpZgogCitVU0VSX0FHRU5UX1NUWUxFX1NIRUVUUyAr
PSAkKEFERElUSU9OQUxfVVNFUl9BR0VOVF9TVFlMRV9TSEVFVFMpCisKIFVzZXJBZ2VudFN0eWxl
U2hlZXRzLmggOiBjc3MvbWFrZS1jc3MtZmlsZS1hcnJheXMucGwgYmluZGluZ3Mvc2NyaXB0cy9w
cmVwcm9jZXNzb3IucG0gJChVU0VSX0FHRU5UX1NUWUxFX1NIRUVUUykgJChQTEFURk9STV9GRUFU
VVJFX0RFRklORVMpCi0JJChQRVJMKSAkPCAtLWRlZmluZXMgIiQoRkVBVFVSRV9ERUZJTkVTKSIg
JEAgVXNlckFnZW50U3R5bGVTaGVldHNEYXRhLmNwcCAkKFVTRVJfQUdFTlRfU1RZTEVfU0hFRVRT
KQorCSQoUEVSTCkgJDwgLS1kZWZpbmVzICIkKEZFQVRVUkVfREVGSU5FUykiICRAIFVzZXJBZ2Vu
dFN0eWxlU2hlZXRzRGF0YS5jcHAgJChmb3JlYWNoIGZpbGUsICReLCAkKGlmICQoZmluZHN0cmlu
ZyAkKG5vdGRpciAkKGZpbGUpKSwgJChVU0VSX0FHRU5UX1NUWUxFX1NIRUVUUykpLCAkKGZpbGUp
KSkKIAogIyAtLS0tLS0tLQogCg==
</data>
<flag name="review"
          id="346195"
          type_id="1"
          status="+"
          setter="aestes"
    />
          </attachment>
      

    </bug>

</bugzilla>