179680 2017-11-14 11:13:59 -0800 Don't use -[NSString stringWithFormat:] to build defaults keys 2017-11-15 09:31:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton aestes commit-queue simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1371466 0 thorton 2017-11-14 11:13:59 -0800 Don't use -[NSString stringWithFormat:] to build defaults keys 1371476 1 326894 thorton 2017-11-14 11:17:30 -0800 Created attachment 326894 Patch 1371488 2 326894 commit-queue 2017-11-14 11:43:29 -0800 Comment on attachment 326894 Patch Clearing flags on attachment: 326894 Committed r224825: <https://trac.webkit.org/changeset/224825> 1371489 3 commit-queue 2017-11-14 11:43:30 -0800 All reviewed patches have been landed. Closing bug. 1371861 4 webkit-bug-importer 2017-11-15 09:31:30 -0800 <rdar://problem/35561859> 326894 2017-11-14 11:17:30 -0800 2017-11-14 11:43:29 -0800 Patch bug-179680-20171114111730.patch text/plain 2729 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0Nzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE0ZmQ5MTU5YWJlZTEzNzI2 YTFlODU2M2I2ZTc0MzZlMTgwNThiNzAuLjAyNDVjN2ZmZTFjNzY4MzdmOTNmMjk0OTg5ZTg0OWM4 YzUyMjdlZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMTEtMTMgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgdXNlIC1bTlNT dHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpdIHRvIGJ1aWxkIGRlZmF1bHRzIGtleXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTY4MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9X ZWJQcmVmZXJlbmNlc01hYy5tbToKKyAgICAgICAgKFdlYktpdDo6bWFrZUtleSk6CisgICAgICAg IChXZWJLaXQ6OmRlYnVnVXNlckRlZmF1bHRzVmFsdWUpOgorICAgICAgICBVc2Ugc3RyaW5nIGNv bmNhdGVuYXRpb24gaW5zdGVhZCBvZiBzdHJpbmdXaXRoRm9ybWF0IHRvIGJ1aWxkCisgICAgICAg IHByZWZlcmVuY2Uga2V5cy4gVGhpcyB3YXNuJ3QgYSBodWdlIGNvc3QsIGJ1dCBpdCBzaGF2ZXMg YSBmZXcgbWlsbGlzZWNvbmRzCisgICAgICAgIG9mZiBwcm9jZXNzIGxhdW5jaC4KKwogMjAxNy0x MS0xMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIG1vcmUg b3ZlcmZsb3cgY2hlY2sgYm9vay1rZWVwaW5nIGZvciBNYXJrZWRBcmd1bWVudEJ1ZmZlci4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJQcmVmZXJlbmNlc01hYy5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJQcmVmZXJlbmNlc01hYy5tbQppbmRl eCBmYTQ5MjEyM2Y2ZTI1MWZhOTcyMjhkMDgyZDM4N2IxZTY2ZGJkOGY4Li5hYmUyOTVjYzBiNGZm N2FmOTg2YzAyZTQxMjViMjI1ZTczYzRjYWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9tYWMvV2ViUHJlZmVyZW5jZXNNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvbWFjL1dlYlByZWZlcmVuY2VzTWFjLm1tCkBAIC0zMiwxMyArMzIsMTAgQEAKIAogbmFt ZXNwYWNlIFdlYktpdCB7CiAKLXN0YXRpYyBpbmxpbmUgTlNTdHJpbmcqIG1ha2VLZXkoTlNTdHJp bmcgKmlkZW50aWZpZXIsIE5TU3RyaW5nICprZXlQcmVmaXgsIE5TU3RyaW5nICprZXkpCitzdGF0 aWMgaW5saW5lIE5TU3RyaW5nICptYWtlS2V5KGNvbnN0IFN0cmluZyYgaWRlbnRpZmllciwgY29u c3QgU3RyaW5nJiBrZXlQcmVmaXgsIGNvbnN0IFN0cmluZyYga2V5KQogewotICAgIEFTU0VSVChp ZGVudGlmaWVyLmxlbmd0aCk7Ci0gICAgQVNTRVJUKGtleVByZWZpeCk7Ci0gICAgQVNTRVJUKGtl eSk7Ci0KLSAgICByZXR1cm4gW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCIlQCVAJUAiLCBp ZGVudGlmaWVyLCBrZXlQcmVmaXgsIGtleV07CisgICAgQVNTRVJUKCFpZGVudGlmaWVyLmlzRW1w dHkoKSk7CisgICAgcmV0dXJuIFN0cmluZyhpZGVudGlmaWVyICsga2V5UHJlZml4ICsga2V5KTsK IH0KIAogYm9vbCBXZWJQcmVmZXJlbmNlczo6cGxhdGZvcm1HZXRTdHJpbmdVc2VyVmFsdWVGb3JL ZXkoY29uc3QgU3RyaW5nJiBrZXksIFN0cmluZyYgdXNlclZhbHVlKQpAQCAtMTAxLDE2ICs5OCwx MyBAQCBib29sIFdlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUdldERvdWJsZVVzZXJWYWx1ZUZvcktl eShjb25zdCBTdHJpbmcmIGtleSwgZG91YmxlJgogICAgIHJldHVybiB0cnVlOwogfQogCi1zdGF0 aWMgaWQgZGVidWdVc2VyRGVmYXVsdHNWYWx1ZShOU1N0cmluZyAqaWRlbnRpZmllciwgTlNTdHJp bmcgKmtleVByZWZpeCwgTlNTdHJpbmcgKmdsb2JhbERlYnVnS2V5UHJlZml4LCBOU1N0cmluZyAq a2V5KQorc3RhdGljIGlkIGRlYnVnVXNlckRlZmF1bHRzVmFsdWUoY29uc3QgU3RyaW5nJiBpZGVu dGlmaWVyLCBjb25zdCBTdHJpbmcmIGtleVByZWZpeCwgY29uc3QgU3RyaW5nJiBnbG9iYWxEZWJ1 Z0tleVByZWZpeCwgY29uc3QgU3RyaW5nJiBrZXkpCiB7Ci0gICAgQVNTRVJUKGtleVByZWZpeCk7 Ci0gICAgQVNTRVJUKGtleSk7Ci0KICAgICBOU1VzZXJEZWZhdWx0cyAqc3RhbmRhcmRVc2VyRGVm YXVsdHMgPSBbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdOwogICAgIGlkIG9i amVjdCA9IG5pbDsKIAotICAgIGlmIChpZGVudGlmaWVyLmxlbmd0aCkKLSAgICAgICAgb2JqZWN0 ID0gW3N0YW5kYXJkVXNlckRlZmF1bHRzIG9iamVjdEZvcktleTpbTlNTdHJpbmcgc3RyaW5nV2l0 aEZvcm1hdDpAIiVAJUAlQCIsIGlkZW50aWZpZXIsIGtleVByZWZpeCwga2V5XV07CisgICAgaWYg KCFpZGVudGlmaWVyLmlzRW1wdHkoKSkKKyAgICAgICAgb2JqZWN0ID0gW3N0YW5kYXJkVXNlckRl ZmF1bHRzIG9iamVjdEZvcktleTptYWtlS2V5KGlkZW50aWZpZXIsIGtleVByZWZpeCwga2V5KV07 CiAKICAgICBpZiAoIW9iamVjdCkgewogICAgICAgICAvLyBBbGxvdyBkZWJ1ZyBwcmVmZXJlbmNl cyB0byBiZSBzZXQgZ2xvYmFsbHksIHVzaW5nIHRoZSBkZWJ1ZyBrZXkgcHJlZml4Lgo=