179678 2017-11-14 11:13:14 -0800 Remove StyleResolver::State::document() 2017-11-15 09:31:53 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue graouts simon.fraser webkit-bug-importer oldest_to_newest 1371463 0 koivisto 2017-11-14 11:13:14 -0800 We don't need both StyleResolver::document() and StyleResolver::State::document() 1371470 1 326893 koivisto 2017-11-14 11:15:43 -0800 Created attachment 326893 patch 1371543 2 326893 commit-queue 2017-11-14 13:26:52 -0800 Comment on attachment 326893 patch Clearing flags on attachment: 326893 Committed r224840: <https://trac.webkit.org/changeset/224840> 1371544 3 commit-queue 2017-11-14 13:26:53 -0800 All reviewed patches have been landed. Closing bug. 1371866 4 webkit-bug-importer 2017-11-15 09:31:53 -0800 <rdar://problem/35561862> 326893 2017-11-14 11:15:43 -0800 2017-11-14 13:26:52 -0800 patch styleresolver-state-document-remove.patch text/plain 3807 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyNDgyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTExLTE0ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgU3R5bGVSZXNvbHZl cjo6U3RhdGU6OmRvY3VtZW50KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3OTY3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlIGRvbid0IG5lZWQgYm90aCBTdHlsZVJlc29sdmVyOjpkb2N1bWVudCgp IGFuZCBTdHlsZVJlc29sdmVyOjpTdGF0ZTo6ZG9jdW1lbnQoKS4KKworICAgICAgICAqIGNzcy9T dHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OlN0YXRl Ojp1cGRhdGVDb252ZXJzaW9uRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVy OjpyZXNvbHZlZFZhcmlhYmxlVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSZXNvbHZl cjo6Y29sb3JGcm9tUHJpbWl0aXZlVmFsdWUgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6U3R5 bGVSZXNvbHZlcjo6Y3JlYXRlRmlsdGVyT3BlcmF0aW9ucyk6CisgICAgICAgICogY3NzL1N0eWxl UmVzb2x2ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OlN0YXRlOjpkb2N1 bWVudCBjb25zdCk6IERlbGV0ZWQuCisKIDIwMTctMTEtMTQgIEFudHRpIEtvaXZpc3RvICA8YW50 dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBkaXNwbGF5OmNvbnRlbnRzIGJ5IGRlZmF1 bHQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAJKHJldmlzaW9uIDIyNDc5 MCkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzE5LDcgKzMxOSw3IEBAIFN0eWxlUmVzb2x2ZXI6OlN0YXRlOjpTdGF0ZShjb25zdCBF bGVtZW4KIAogaW5saW5lIHZvaWQgU3R5bGVSZXNvbHZlcjo6U3RhdGU6OnVwZGF0ZUNvbnZlcnNp b25EYXRhKCkKIHsKLSAgICBtX2Nzc1RvTGVuZ3RoQ29udmVyc2lvbkRhdGEgPSBDU1NUb0xlbmd0 aENvbnZlcnNpb25EYXRhKG1fc3R5bGUuZ2V0KCksIG1fcm9vdEVsZW1lbnRTdHlsZSwgbV9lbGVt ZW50ID8gZG9jdW1lbnQoKS5yZW5kZXJWaWV3KCkgOiBudWxscHRyKTsKKyAgICBtX2Nzc1RvTGVu Z3RoQ29udmVyc2lvbkRhdGEgPSBDU1NUb0xlbmd0aENvbnZlcnNpb25EYXRhKG1fc3R5bGUuZ2V0 KCksIG1fcm9vdEVsZW1lbnRTdHlsZSwgbV9lbGVtZW50ID8gbV9lbGVtZW50LT5kb2N1bWVudCgp LnJlbmRlclZpZXcoKSA6IG51bGxwdHIpOwogfQogCiBpbmxpbmUgdm9pZCBTdHlsZVJlc29sdmVy OjpTdGF0ZTo6c2V0U3R5bGUoc3RkOjp1bmlxdWVfcHRyPFJlbmRlclN0eWxlPiBzdHlsZSkKQEAg LTE3MDIsNyArMTcwMiw3IEBAIHZvaWQgU3R5bGVSZXNvbHZlcjo6YXBwbHlQcm9wZXJ0eShDU1NQ cm8KIAogUmVmUHRyPENTU1ZhbHVlPiBTdHlsZVJlc29sdmVyOjpyZXNvbHZlZFZhcmlhYmxlVmFs dWUoQ1NTUHJvcGVydHlJRCBwcm9wSUQsIGNvbnN0IENTU1ZhbHVlJiB2YWx1ZSkKIHsKLSAgICBD U1NQYXJzZXIgcGFyc2VyKG1fc3RhdGUuZG9jdW1lbnQoKSk7CisgICAgQ1NTUGFyc2VyIHBhcnNl cihkb2N1bWVudCgpKTsKICAgICByZXR1cm4gcGFyc2VyLnBhcnNlVmFsdWVXaXRoVmFyaWFibGVS ZWZlcmVuY2VzKHByb3BJRCwgdmFsdWUsIG1fc3RhdGUuc3R5bGUoKS0+Y3VzdG9tUHJvcGVydGll cygpLCBtX3N0YXRlLnN0eWxlKCktPmRpcmVjdGlvbigpLCBtX3N0YXRlLnN0eWxlKCktPndyaXRp bmdNb2RlKCkpOwogfQogCkBAIC0xODI2LDExICsxODI2LDExIEBAIENvbG9yIFN0eWxlUmVzb2x2 ZXI6OmNvbG9yRnJvbVByaW1pdGl2ZVYKICAgICBjYXNlIDA6CiAgICAgICAgIHJldHVybiBDb2xv cigpOwogICAgIGNhc2UgQ1NTVmFsdWVXZWJraXRUZXh0OgotICAgICAgICByZXR1cm4gc3RhdGUu ZG9jdW1lbnQoKS50ZXh0Q29sb3IoKTsKKyAgICAgICAgcmV0dXJuIGRvY3VtZW50KCkudGV4dENv bG9yKCk7CiAgICAgY2FzZSBDU1NWYWx1ZVdlYmtpdExpbms6Ci0gICAgICAgIHJldHVybiAoc3Rh dGUuZWxlbWVudCgpLT5pc0xpbmsoKSAmJiBmb3JWaXNpdGVkTGluaykgPyBzdGF0ZS5kb2N1bWVu dCgpLnZpc2l0ZWRMaW5rQ29sb3IoKSA6IHN0YXRlLmRvY3VtZW50KCkubGlua0NvbG9yKCk7Cisg ICAgICAgIHJldHVybiAoc3RhdGUuZWxlbWVudCgpLT5pc0xpbmsoKSAmJiBmb3JWaXNpdGVkTGlu aykgPyBkb2N1bWVudCgpLnZpc2l0ZWRMaW5rQ29sb3IoKSA6IGRvY3VtZW50KCkubGlua0NvbG9y KCk7CiAgICAgY2FzZSBDU1NWYWx1ZVdlYmtpdEFjdGl2ZWxpbms6Ci0gICAgICAgIHJldHVybiBz dGF0ZS5kb2N1bWVudCgpLmFjdGl2ZUxpbmtDb2xvcigpOworICAgICAgICByZXR1cm4gZG9jdW1l bnQoKS5hY3RpdmVMaW5rQ29sb3IoKTsKICAgICBjYXNlIENTU1ZhbHVlV2Via2l0Rm9jdXNSaW5n Q29sb3I6CiAgICAgICAgIHJldHVybiBSZW5kZXJUaGVtZTo6Zm9jdXNSaW5nQ29sb3IoKTsKICAg ICBjYXNlIENTU1ZhbHVlQ3VycmVudGNvbG9yOgpAQCAtMTkyOCw3ICsxOTI4LDcgQEAgYm9vbCBT dHlsZVJlc29sdmVyOjpjcmVhdGVGaWx0ZXJPcGVyYXRpbwogICAgICAgICAgICAgICAgIGNvbnRp bnVlOwogCiAgICAgICAgICAgICBTdHJpbmcgY3NzVXJsID0gcHJpbWl0aXZlVmFsdWUuc3RyaW5n VmFsdWUoKTsKLSAgICAgICAgICAgIFVSTCB1cmwgPSBtX3N0YXRlLmRvY3VtZW50KCkuY29tcGxl dGVVUkwoY3NzVXJsKTsKKyAgICAgICAgICAgIFVSTCB1cmwgPSBkb2N1bWVudCgpLmNvbXBsZXRl VVJMKGNzc1VybCk7CiAKICAgICAgICAgICAgIFJlZlB0cjxSZWZlcmVuY2VGaWx0ZXJPcGVyYXRp b24+IG9wZXJhdGlvbiA9IFJlZmVyZW5jZUZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlKGNzc1VybCwg dXJsLmZyYWdtZW50SWRlbnRpZmllcigpKTsKICAgICAgICAgICAgIG9wZXJhdGlvbnMub3BlcmF0 aW9ucygpLmFwcGVuZChvcGVyYXRpb24pOwpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL1N0eWxl UmVzb2x2ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZl ci5oCShyZXZpc2lvbiAyMjQ3OTApCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZl ci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNDgsNyArMzQ4LDYgQEAgcHVibGljOgogICAgIHB1Ymxp YzoKICAgICAgICAgdm9pZCBjbGVhcigpOwogCi0gICAgICAgIERvY3VtZW50JiBkb2N1bWVudCgp IGNvbnN0IHsgcmV0dXJuIG1fZWxlbWVudC0+ZG9jdW1lbnQoKTsgfQogICAgICAgICBjb25zdCBF bGVtZW50KiBlbGVtZW50KCkgY29uc3QgeyByZXR1cm4gbV9lbGVtZW50OyB9CiAKICAgICAgICAg dm9pZCBzZXRTdHlsZShzdGQ6OnVuaXF1ZV9wdHI8UmVuZGVyU3R5bGU+KTsK