179651 2017-11-13 19:40:00 -0800 iOS: Enable release asserts in updateStyleIfNeeded() and updateLayout() for WebKit2 2017-11-17 19:30:31 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179442 InRadar P2 Normal --- 1 rniwa rniwa ap bfulgham buildbot cdumez commit-queue dbates ddkilzer esprehn+autocc fpizlo ggaren jlewis3 joepeck kangil.han koivisto ryanhaddad simon.fraser webkit-bug-importer zalan oldest_to_newest 1371221 0 rniwa 2017-11-13 19:40:00 -0800 https://trac.webkit.org/r224604 disabled these release asserts in iOS due to a bug in UIKit for WebKit1. Re-enable these release assertions in iOS WebKit2 port. 1371222 1 webkit-bug-importer 2017-11-13 19:40:30 -0800 <rdar://problem/35523034> 1371225 2 326841 rniwa 2017-11-13 19:47:12 -0800 Created attachment 326841 Re-enables the asserts 1371226 3 326841 koivisto 2017-11-13 19:55:05 -0800 Comment on attachment 326841 Re-enables the asserts View in context: https://bugs.webkit.org/attachment.cgi?id=326841&action=review r=me > Source/WebCore/dom/Document.cpp:1931 > + bool usingWebThread = WebThreadIsEnabled(); :( 1371231 4 326841 simon.fraser 2017-11-13 20:11:15 -0800 Comment on attachment 326841 Re-enables the asserts View in context: https://bugs.webkit.org/attachment.cgi?id=326841&action=review > Source/WebCore/dom/Document.cpp:1935 > + return NoEventDispatchAssertion::InMainThread::isEventAllowed() || (frameView && frameView->isInChildFrameWithFrameFlattening()) || usingWebThread; This is pretty confusing to read. This function is about it being safe to update style or do layout, but to a lay reader, what does that have to do with event dispatch or frame flattening? Also NoEventDispatchAssertion::InMainThread::isEventAllowed(): so there's the "no event" negative vs. the "is event allowed", then there's InMainThread but the later usingWebThread check There's altogether too much discordance here. And, as Darin recommends, an assertion should only check one thing, not a list of things (because then you can't tell which failed). 1371246 5 rniwa 2017-11-13 20:41:32 -0800 (In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 326841 [details] > Re-enables the asserts > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326841&action=review > > > Source/WebCore/dom/Document.cpp:1935 > > + return NoEventDispatchAssertion::InMainThread::isEventAllowed() || (frameView && frameView->isInChildFrameWithFrameFlattening()) || usingWebThread; > > This is pretty confusing to read. This function is about it being safe to > update style or do layout, but to a lay reader, what does that have to do > with event dispatch or frame flattening? Indeed. I'd refactor it to as: bool isSafeToExecuteScript = NoEventDispatchAssertion::InMainThread::isEventAllowed(); bool isInFrameFlattening = frameView && frameView->isInChildFrameWithFrameFlattening(); return isSafeToExecuteScript || isInFrameFlattening || usingWebThread; > Also NoEventDispatchAssertion::InMainThread::isEventAllowed(): so there's > the "no event" negative vs. the "is event allowed", then there's > InMainThread but the later usingWebThread check I agree we should rename that but such a renaming / refactoring is outside the scope of this patch. > There's altogether too much discordance here. And, as Darin recommends, an > assertion should only check one thing, not a list of things (because then > you can't tell which failed). The problem is that we can't do it until frame flattening stops doing a nested layout or iOS WebKit bug (<rdar://problem/35522719>) is fixed. An alternative is to do something like this: if (!isInFrameFlattening && !usingWebThread) RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::InMainThread::isEventAllowed()); I'm not certain if that code is better. 1371255 6 326851 rniwa 2017-11-13 21:17:16 -0800 Created attachment 326851 Patch for landing 1371271 7 commit-queue 2017-11-13 22:02:36 -0800 The commit-queue encountered the following flaky tests while processing attachment 326851: svg/animations/svgtransform-animation-1.html bug 179354 (authors: ap@webkit.org, arv@chromium.org, krit@webkit.org, mark.lam@apple.com, and zimmermann@kde.org) The commit-queue is continuing to process your patch. 1371272 8 326851 commit-queue 2017-11-13 22:03:11 -0800 Comment on attachment 326851 Patch for landing Clearing flags on attachment: 326851 Committed r224803: <https://trac.webkit.org/changeset/224803> 1371273 9 commit-queue 2017-11-13 22:03:13 -0800 All reviewed patches have been landed. Closing bug. 1371284 10 simon.fraser 2017-11-13 22:34:56 -0800 > An alternative is to do something like this: > if (!isInFrameFlattening && !usingWebThread) > > RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion:: > InMainThread::isEventAllowed()); > > I'm not certain if that code is better. Maybe better? RELEASE_ASSERT_IMPLIES_WITH_SECURITY_IMPLICATION(!isInFrameFlattening && !usingWebThread, NoEventDispatchAssertion::InMainThread::isEventAllowed()); if we make that macro. What's the difference between RELEASE_ASSERT_IMPLIES_WITH_SECURITY_IMPLICATION and RELEASE_ASSERT? 1371305 11 ddkilzer 2017-11-13 23:39:59 -0800 (In reply to Simon Fraser (smfr) from comment #10) > > An alternative is to do something like this: > > if (!isInFrameFlattening && !usingWebThread) > > > > RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion:: > > InMainThread::isEventAllowed()); > > > > I'm not certain if that code is better. > > Maybe better? > > RELEASE_ASSERT_IMPLIES_WITH_SECURITY_IMPLICATION(!isInFrameFlattening && > !usingWebThread, NoEventDispatchAssertion::InMainThread::isEventAllowed()); > > if we make that macro. I'm not sure what that macro does or what it's based on, but maybe I'm missing something. > What's the difference between > RELEASE_ASSERT_IMPLIES_WITH_SECURITY_IMPLICATION and RELEASE_ASSERT? Did you mean RELEASE_ASSERT_WITH_SECURITY_IMPLICATION? In Release builds, they're the same. In Debug builds, they'll have a different exception code (0xfbadbeef for security, 0xbbadbeef for non-security). See also: <https://bugs.webkit.org/show_bug.cgi?id=178269#c0> 1373128 12 ap 2017-11-17 10:14:15 -0800 > The commit-queue encountered the following flaky tests while processing attachment 326851 [details]: > svg/animations/svgtransform-animation-1.html bug 179354 (authors: ap@webkit.org, arv@chromium.org, krit@webkit.org, mark.lam@apple.com, and zimmermann@kde.org) Was this a legitimate issue discovered by EWS? 1373488 13 rniwa 2017-11-17 19:30:31 -0800 (In reply to Alexey Proskuryakov from comment #12) > > The commit-queue encountered the following flaky tests while processing attachment 326851 [details]: > > > svg/animations/svgtransform-animation-1.html bug 179354 (authors: ap@webkit.org, arv@chromium.org, krit@webkit.org, mark.lam@apple.com, and zimmermann@kde.org) > > Was this a legitimate issue discovered by EWS? Oh, I didn't even see it but it is https://bugs.webkit.org/show_bug.cgi?id=179306. 326841 2017-11-13 19:47:12 -0800 2017-11-13 21:17:02 -0800 Re-enables the asserts bug-179651-20171113194711.patch text/plain 3091 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2RmZjY1ZWJhMDAxYjA4 MzAxMDFhY2VmNzRlNGVmZWZkNWNlNjg4Ni4uYzFlZmQxYTM5Nzg0OTBlNGI2MzBlYjI5MmMzOGM5 NzdiZDViNGZlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTExLTEzICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGlPUzogRW5hYmxlIHJlbGVh c2UgYXNzZXJ0cyBpbiB1cGRhdGVTdHlsZUlmTmVlZGVkKCkgYW5kIHVwZGF0ZUxheW91dCgpIGZv ciBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzk2NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICByMjI0NjA0IGRpc2FibGVkIHRoZSByZWxlYXNlIGFzc2VydGlvbnMgb24gaU9TIGVudGlyZWx5 IGV2ZW4gdGhvdWdoIHRoZSB1bmRlcmx5aW5nIGJ1ZyBvbmx5IGFmZmVjdGVkIGlPUyBXZWJLaXQx IHBvcnQKKyAgICAgICAgZHVlIHRvIHZhcmlvdXMgdGltZSBjb25zdHJhaW50cy4gRW5hYmxlIHRo ZW0gYmFjayBvbiBpT1MgV2ViS2l0MiBwb3J0LgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmlzU2FmZVRvVXBkYXRlU3R5bGVPckxheW91dCk6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlU3R5bGVJZk5lZWRlZCk6CisgICAgICAgIChX ZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlTGF5b3V0KToKKwogMjAxNy0xMS0xMyAgUGVyIEFybmUg Vm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGhlIGNzcyBwcm9wZXJ0aWVz IHN0cm9rZS13aWR0aC9zdHJva2UtY29sb3IgYW5kIC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGgv LXdlYmtpdC10ZXh0LXN0cm9rZS1jb2xvciBzaG91bGQgbm90IGJlIG1peGVkLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKaW5kZXggYWMxODU3ZWY1N2FhMTU0MjFkMTIzYWI1YzJkODEwMjg2ZDI2ZDdj Ni4uYjAyYTkwNjhiMjAyNzk0OTU4NjExNzg5ODJjMjRjZDA4ODgyZDRjYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCkBAIC0xOTI0LDYgKzE5MjQsMTcgQEAgYm9vbCBEb2N1bWVudDo6bmVlZHNT dHlsZVJlY2FsYygpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitpbmxpbmUgYm9vbCBz dGF0aWMgaXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0KEZyYW1lVmlldyogZnJhbWVWaWV3KQor eworI2lmIFVTRShXRUJfVEhSRUFEKQorICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBjb2RlOiA8 cmRhcjovL3Byb2JsZW0vMzU1MjI3MTk+CisgICAgYm9vbCB1c2luZ1dlYlRocmVhZCA9IFdlYlRo cmVhZElzRW5hYmxlZCgpOworI2Vsc2UKKyAgICBib29sIHVzaW5nV2ViVGhyZWFkID0gZmFsc2U7 CisjZW5kaWYKKyAgICByZXR1cm4gTm9FdmVudERpc3BhdGNoQXNzZXJ0aW9uOjpJbk1haW5UaHJl YWQ6OmlzRXZlbnRBbGxvd2VkKCkgfHwgKGZyYW1lVmlldyAmJiBmcmFtZVZpZXctPmlzSW5DaGls ZEZyYW1lV2l0aEZyYW1lRmxhdHRlbmluZygpKSB8fCB1c2luZ1dlYlRocmVhZDsKK30KKwogYm9v bCBEb2N1bWVudDo6dXBkYXRlU3R5bGVJZk5lZWRlZCgpCiB7CiAgICAgUmVmUHRyPEZyYW1lVmll dz4gZnJhbWVWaWV3ID0gdmlldygpOwpAQCAtMTk0MSwxMCArMTk1Miw4IEBAIGJvb2wgRG9jdW1l bnQ6OnVwZGF0ZVN0eWxlSWZOZWVkZWQoKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg IH0KIAotICAgIC8vIFRoZSBlYXJseSBleGl0IGZvciBuZWVkc1N0eWxlUmVjYWxjKCkgaXMgbmVl ZGVkIHdoZW4gdXBkYXRlV2lkZ2V0UG9zaXRpb25zKCkgaXMgY2FsbGVkIGluIHJ1bk9yU2NoZWR1 bGVBc3luY2hyb25vdXNUYXNrcygpLgotI2lmICFVU0UoV0VCX1RIUkVBRCkKLSAgICBSRUxFQVNF X0FTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKE5vRXZlbnREaXNwYXRjaEFzc2VydGlv bjo6SW5NYWluVGhyZWFkOjppc0V2ZW50QWxsb3dlZCgpIHx8IChmcmFtZVZpZXcgJiYgZnJhbWVW aWV3LT5pc0luQ2hpbGRGcmFtZVdpdGhGcmFtZUZsYXR0ZW5pbmcoKSkpOwotI2VuZGlmCisgICAg Ly8gVGhlIGVhcmx5IGV4aXQgYWJvdmUgZm9yICFuZWVkc1N0eWxlUmVjYWxjKCkgaXMgbmVlZGVk IHdoZW4gdXBkYXRlV2lkZ2V0UG9zaXRpb25zKCkgaXMgY2FsbGVkIGluIHJ1bk9yU2NoZWR1bGVB c3luY2hyb25vdXNUYXNrcygpLgorICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1Q TElDQVRJT04oaXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0KGZyYW1lVmlldy5nZXQoKSkpOwog CiAgICAgcmVzb2x2ZVN0eWxlKCk7CiAgICAgcmV0dXJuIHRydWU7CkBAIC0xOTYxLDkgKzE5NzAs NyBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVMYXlvdXQoKQogICAgICAgICBBU1NFUlRfTk9UX1JF QUNIRUQoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSNpZiAhVVNFKFdFQl9USFJFQUQpCi0g ICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihOb0V2ZW50RGlzcGF0 Y2hBc3NlcnRpb246OkluTWFpblRocmVhZDo6aXNFdmVudEFsbG93ZWQoKSB8fCAoZnJhbWVWaWV3 ICYmIGZyYW1lVmlldy0+aXNJbkNoaWxkRnJhbWVXaXRoRnJhbWVGbGF0dGVuaW5nKCkpKTsKLSNl bmRpZgorICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oaXNTYWZl VG9VcGRhdGVTdHlsZU9yTGF5b3V0KGZyYW1lVmlldy5nZXQoKSkpOwogCiAgICAgUmVuZGVyVmll dzo6UmVwYWludFJlZ2lvbkFjY3VtdWxhdG9yIHJlcGFpbnRSZWdpb25BY2N1bXVsYXRvcihyZW5k ZXJWaWV3KCkpOwogCg== 326851 2017-11-13 21:17:16 -0800 2017-11-13 22:03:11 -0800 Patch for landing bug-179651-20171113211711.patch text/plain 3199 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2RmZjY1ZWJhMDAxYjA4 MzAxMDFhY2VmNzRlNGVmZWZkNWNlNjg4Ni4uMDA4MTE1YWExMTdjNGNkYmE0M2JhOGI4N2U4NWMx Nzc0NzI3NmRhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTExLTEzICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGlPUzogRW5hYmxlIHJlbGVh c2UgYXNzZXJ0cyBpbiB1cGRhdGVTdHlsZUlmTmVlZGVkKCkgYW5kIHVwZGF0ZUxheW91dCgpIGZv ciBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzk2NTEKKworICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KKworICAgICAg ICByMjI0NjA0IGRpc2FibGVkIHRoZSByZWxlYXNlIGFzc2VydGlvbnMgb24gaU9TIGVudGlyZWx5 IGV2ZW4gdGhvdWdoIHRoZSB1bmRlcmx5aW5nIGJ1ZyBvbmx5IGFmZmVjdGVkIGlPUyBXZWJLaXQx IHBvcnQKKyAgICAgICAgZHVlIHRvIHZhcmlvdXMgdGltZSBjb25zdHJhaW50cy4gRW5hYmxlIHRo ZW0gYmFjayBvbiBpT1MgV2ViS2l0MiBwb3J0LgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmlzU2FmZVRvVXBkYXRlU3R5bGVPckxheW91dCk6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlU3R5bGVJZk5lZWRlZCk6CisgICAgICAgIChX ZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlTGF5b3V0KToKKwogMjAxNy0xMS0xMyAgUGVyIEFybmUg Vm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGhlIGNzcyBwcm9wZXJ0aWVz IHN0cm9rZS13aWR0aC9zdHJva2UtY29sb3IgYW5kIC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGgv LXdlYmtpdC10ZXh0LXN0cm9rZS1jb2xvciBzaG91bGQgbm90IGJlIG1peGVkLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKaW5kZXggYWMxODU3ZWY1N2FhMTU0MjFkMTIzYWI1YzJkODEwMjg2ZDI2ZDdj Ni4uYTg4NjQ2MjczZDY3OTczYjhlNmY5MmQyZjA3ZDhmOWM5ZWI1OTE3MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCkBAIC0xOTI0LDYgKzE5MjQsMTkgQEAgYm9vbCBEb2N1bWVudDo6bmVlZHNT dHlsZVJlY2FsYygpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitpbmxpbmUgYm9vbCBz dGF0aWMgaXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0KEZyYW1lVmlldyogZnJhbWVWaWV3KQor eworI2lmIFVTRShXRUJfVEhSRUFEKQorICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBjb2RlOiA8 cmRhcjovL3Byb2JsZW0vMzU1MjI3MTk+CisgICAgYm9vbCB1c2luZ1dlYlRocmVhZCA9IFdlYlRo cmVhZElzRW5hYmxlZCgpOworI2Vsc2UKKyAgICBib29sIHVzaW5nV2ViVGhyZWFkID0gZmFsc2U7 CisjZW5kaWYKKyAgICBib29sIGlzU2FmZVRvRXhlY3V0ZVNjcmlwdCA9IE5vRXZlbnREaXNwYXRj aEFzc2VydGlvbjo6SW5NYWluVGhyZWFkOjppc0V2ZW50QWxsb3dlZCgpOworICAgIGJvb2wgaXNJ bkZyYW1lRmxhdHRlbmluZyA9IGZyYW1lVmlldyAmJiBmcmFtZVZpZXctPmlzSW5DaGlsZEZyYW1l V2l0aEZyYW1lRmxhdHRlbmluZygpOworICAgIHJldHVybiBpc1NhZmVUb0V4ZWN1dGVTY3JpcHQg fHwgaXNJbkZyYW1lRmxhdHRlbmluZyB8fCB1c2luZ1dlYlRocmVhZDsKK30KKwogYm9vbCBEb2N1 bWVudDo6dXBkYXRlU3R5bGVJZk5lZWRlZCgpCiB7CiAgICAgUmVmUHRyPEZyYW1lVmlldz4gZnJh bWVWaWV3ID0gdmlldygpOwpAQCAtMTk0MSwxMCArMTk1NCw4IEBAIGJvb2wgRG9jdW1lbnQ6OnVw ZGF0ZVN0eWxlSWZOZWVkZWQoKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAot ICAgIC8vIFRoZSBlYXJseSBleGl0IGZvciBuZWVkc1N0eWxlUmVjYWxjKCkgaXMgbmVlZGVkIHdo ZW4gdXBkYXRlV2lkZ2V0UG9zaXRpb25zKCkgaXMgY2FsbGVkIGluIHJ1bk9yU2NoZWR1bGVBc3lu Y2hyb25vdXNUYXNrcygpLgotI2lmICFVU0UoV0VCX1RIUkVBRCkKLSAgICBSRUxFQVNFX0FTU0VS VF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKE5vRXZlbnREaXNwYXRjaEFzc2VydGlvbjo6SW5N YWluVGhyZWFkOjppc0V2ZW50QWxsb3dlZCgpIHx8IChmcmFtZVZpZXcgJiYgZnJhbWVWaWV3LT5p c0luQ2hpbGRGcmFtZVdpdGhGcmFtZUZsYXR0ZW5pbmcoKSkpOwotI2VuZGlmCisgICAgLy8gVGhl IGVhcmx5IGV4aXQgYWJvdmUgZm9yICFuZWVkc1N0eWxlUmVjYWxjKCkgaXMgbmVlZGVkIHdoZW4g dXBkYXRlV2lkZ2V0UG9zaXRpb25zKCkgaXMgY2FsbGVkIGluIHJ1bk9yU2NoZWR1bGVBc3luY2hy b25vdXNUYXNrcygpLgorICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJ T04oaXNTYWZlVG9VcGRhdGVTdHlsZU9yTGF5b3V0KGZyYW1lVmlldy5nZXQoKSkpOwogCiAgICAg cmVzb2x2ZVN0eWxlKCk7CiAgICAgcmV0dXJuIHRydWU7CkBAIC0xOTYxLDkgKzE5NzIsNyBAQCB2 b2lkIERvY3VtZW50Ojp1cGRhdGVMYXlvdXQoKQogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSNpZiAhVVNFKFdFQl9USFJFQUQpCi0gICAgUkVM RUFTRV9BU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihOb0V2ZW50RGlzcGF0Y2hBc3Nl cnRpb246OkluTWFpblRocmVhZDo6aXNFdmVudEFsbG93ZWQoKSB8fCAoZnJhbWVWaWV3ICYmIGZy YW1lVmlldy0+aXNJbkNoaWxkRnJhbWVXaXRoRnJhbWVGbGF0dGVuaW5nKCkpKTsKLSNlbmRpZgor ICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oaXNTYWZlVG9VcGRh dGVTdHlsZU9yTGF5b3V0KGZyYW1lVmlldy5nZXQoKSkpOwogCiAgICAgUmVuZGVyVmlldzo6UmVw YWludFJlZ2lvbkFjY3VtdWxhdG9yIHJlcGFpbnRSZWdpb25BY2N1bXVsYXRvcihyZW5kZXJWaWV3 KCkpOwogCg==