179647 2017-11-13 17:39:57 -0800 Pass --useDollarVM=true to all JSC tests. 2017-11-22 10:11:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 179684 1 mark.lam mark.lam commit-queue saam webkit-bug-importer oldest_to_newest 1371186 0 mark.lam 2017-11-13 17:39:57 -0800 This is in preparation for moving unsafe jsc shell functions to $vm. 1371190 1 326833 mark.lam 2017-11-13 17:41:50 -0800 Created attachment 326833 proposed patch. 1371215 2 mark.lam 2017-11-13 19:00:42 -0800 Thanks for the review. Landed in r224800: <http://trac.webkit.org/r224800>. 1371510 3 commit-queue 2017-11-14 12:20:56 -0800 Re-opened since this is blocked by bug 179684 1374220 4 mark.lam 2017-11-22 10:05:33 -0800 It turns out that there's a bug in the Cloop build that can result in some stack values being wrongly nullified by the stack sanitizer (see https://bugs.webkit.org/show_bug.cgi?id=179936). This bug was triggered because the addition of the $vm object bumped allocation sufficiently such that a slow path allocation is triggered at just the right moment, which in turn, ran the stack sanitizer and manifested the bug. Incidentally, Saam added some properties to $vm (in r224938). This perturbed the allocation pattern sufficiently such that the CLoop stack sanitizer bug is now hidden again. Since the bug isn't due to this patch to add the --useDollarVM=true option, and the effects of the bug has been masked in ToT (due to r224938), I'll re-land this patch. 1374222 5 mark.lam 2017-11-22 10:09:27 -0800 Re-landed in r225097: <http://trac.webkit.org/r225097>. 1374225 6 webkit-bug-importer 2017-11-22 10:11:01 -0800 <rdar://problem/35668712> 326833 2017-11-13 17:41:50 -0800 2017-11-13 17:44:58 -0800 proposed patch. bug-179647.patch text/plain 1753 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNDc5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE3LTExLTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBQYXNzIC0tdXNlRG9sbGFyVk09dHJ1ZSB0byBhbGwgSlNDIHRlc3RzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5NjQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1q c2Mtc3RyZXNzLXRlc3RzOgorCiAyMDE3LTExLTEzICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1 enVraUBzb255LmNvbT4KIAogICAgICAgICBbV2luZG93c10gRml4IFB5dGhvbiBlcnJvciBmb3Ig c3VicHJvY2Vzcy5wb3BlbiB3aXRoIGNsb3NlX2ZkcwpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3Ry ZXNzLXRlc3RzCShyZXZpc2lvbiAyMjQ3OTUpCisrKyBUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3Ry ZXNzLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC00NTEsNyArNDUxLDcgQEAgJG51bUZhaWx1cmVz ID0gMAogJG51bVBhc3NlcyA9IDAKIAogIyBXZSBmb3JjZSBhbGwgdGVzdHMgdG8gdXNlIGEgc21h bGxlciAoMS41TSkgc3RhY2sgc28gdGhhdCBzdGFjayBvdmVyZmxvdyB0ZXN0cyBjYW4gcnVuIGZh c3Rlci4KLUJBU0VfT1BUSU9OUyA9IFsiLS11c2VGVExKSVQ9ZmFsc2UiLCAiLS11c2VGdW5jdGlv bkRvdEFyZ3VtZW50cz10cnVlIiwgIi0tdmFsaWRhdGVFeGNlcHRpb25DaGVja3M9dHJ1ZSIsICIt LW1heFBlclRocmVhZFN0YWNrVXNhZ2U9MTU3Mjg2NCJdCitCQVNFX09QVElPTlMgPSBbIi0tdXNl RlRMSklUPWZhbHNlIiwgIi0tdXNlRnVuY3Rpb25Eb3RBcmd1bWVudHM9dHJ1ZSIsICItLXZhbGlk YXRlRXhjZXB0aW9uQ2hlY2tzPXRydWUiLCAiLS11c2VEb2xsYXJWTT10cnVlIiwgIi0tbWF4UGVy VGhyZWFkU3RhY2tVc2FnZT0xNTcyODY0Il0KIEVBR0VSX09QVElPTlMgPSBbIi0tdGhyZXNob2xk Rm9ySklUQWZ0ZXJXYXJtVXA9MTAiLCAiLS10aHJlc2hvbGRGb3JKSVRTb29uPTEwIiwgIi0tdGhy ZXNob2xkRm9yT3B0aW1pemVBZnRlcldhcm1VcD0yMCIsICItLXRocmVzaG9sZEZvck9wdGltaXpl QWZ0ZXJMb25nV2FybVVwPTIwIiwgIi0tdGhyZXNob2xkRm9yT3B0aW1pemVTb29uPTIwIiwgIi0t dGhyZXNob2xkRm9yRlRMT3B0aW1pemVBZnRlcldhcm1VcD0yMCIsICItLXRocmVzaG9sZEZvckZU TE9wdGltaXplU29vbj0yMCIsICItLW1heGltdW1FdmFsQ2FjaGVhYmxlU291cmNlTGVuZ3RoPTE1 MDAwMCIsICItLXVzZUVhZ2VyQ29kZUJsb2NrSmV0dGlzb25UaW1pbmc9dHJ1ZSJdCiAjIE5PVEU6 IFRlc3RzIHJlbHkgb24gdGhpcyB1c2luZyBzY3JpYmJsZUZyZWVDZWxscy4KIE5PX0NKSVRfT1BU SU9OUyA9IFsiLS11c2VDb25jdXJyZW50SklUPWZhbHNlIiwgIi0tdGhyZXNob2xkRm9ySklUQWZ0 ZXJXYXJtVXA9MTAwIiwgIi0tc2NyaWJibGVGcmVlQ2VsbHM9dHJ1ZSJdCg==