179630 2017-11-13 13:23:03 -0800 [GTK] Require woff2 1.0.2 and drop direct brotli dependency 2017-11-19 17:45:43 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=178158 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue fred.wang mcatanzaro tpopela oldest_to_newest 1371032 0 mcatanzaro 2017-11-13 13:23:03 -0800 The initial releases of the woff2 library have a bug with the pkg-config file: they do not directly pull in brotli. We have worked around this thus far by requiring it manually, but this should not be needed. Tom fixed it with https://github.com/google/woff2/commit/aff949b84713590907b259ecb49f630a19df55c0. A new version is now available with this fix, which we should use. 1371036 1 326791 mcatanzaro 2017-11-13 13:25:55 -0800 Created attachment 326791 Patch 1371160 2 326791 commit-queue 2017-11-13 16:42:23 -0800 Comment on attachment 326791 Patch Clearing flags on attachment: 326791 Committed r224793: <https://trac.webkit.org/changeset/224793> 1371161 3 commit-queue 2017-11-13 16:42:25 -0800 All reviewed patches have been landed. Closing bug. 326791 2017-11-13 13:25:55 -0800 2017-11-13 16:42:23 -0800 Patch bug-179630-20171113152554.patch text/plain 4829 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEJyb3RsaURlYy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kQnJvdGxpRGVjLmNtYWtlCmRlbGV0 ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAzYThjZjkwMzU3ZjE4NGFhMDBiYmNiMDE0MzQxMWYw YjVkNjNlMmY0Li4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBh L1NvdXJjZS9jbWFrZS9GaW5kQnJvdGxpRGVjLmNtYWtlCisrKyAvZGV2L251bGwKQEAgLTEsNTMg KzAsMCBAQAotIyAtIFRyeSB0byBmaW5kIEJyb3RsaURlYy4KLSMgT25jZSBkb25lLCB0aGlzIHdp bGwgZGVmaW5lCi0jCi0jICBCUk9UTElERUNfRk9VTkQgLSBzeXN0ZW0gaGFzIEJyb3RsaURlYy4K LSMgIEJST1RMSURFQ19JTkNMVURFX0RJUlMgLSB0aGUgQnJvdGxpRGVjIGluY2x1ZGUgZGlyZWN0 b3JpZXMKLSMgIEJST1RMSURFQ19MSUJSQVJJRVMgLSBsaW5rIHRoZXNlIHRvIHVzZSBCcm90bGlE ZWMuCi0jCi0jIENvcHlyaWdodCAoQykgMjAxNyBJZ2FsaWEgUy5MLgotIwotIyBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK LSMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zCi0jIGFyZSBtZXQ6Ci0jIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNl IGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAotIyAgICAgbm90aWNlLCB0aGlz IGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgotIyAyLiAg UmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBj b3B5cmlnaHQKLSMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKLSMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90 aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCi0jCi0jIFRISVMg U09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVIgQU5EIElUUyBDT05U UklCVVRPUlMgYGBBUwotIyBJUycnIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJ RVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAotIyBUSEUgSU1QTElFRCBXQVJSQU5U SUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCi0jIFBV UlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQgSE9M REVSIE9SIElUUwotIyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJ UkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKLSMgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFM IERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAotIyBQUk9DVVJFTUVOVCBP RiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJP RklUUzsKLSMgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04g QU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksCi0jIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBM SUFCSUxJVFksIE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SCi0jIE9USEVSV0lTRSkg QVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4g SUYKLSMgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCi0KLWZpbmRf cGFja2FnZShQa2dDb25maWcpCi1wa2dfY2hlY2tfbW9kdWxlcyhQQ19CUk9UTElERUMgbGliYnJv dGxpZGVjKQotCi1maW5kX3BhdGgoQlJPVExJREVDX0lOQ0xVREVfRElSUwotICAgIE5BTUVTIGJy b3RsaS9kZWNvZGUuaAotICAgIEhJTlRTICR7UENfQlJPVExJREVDX0lOQ0xVREVESVJ9Ci0pCi0K LWZpbmRfbGlicmFyeShCUk9UTElERUNfTElCUkFSSUVTCi0gICAgTkFNRVMgYnJvdGxpZGVjCi0g ICAgSElOVFMgJHtQQ19CUk9UTElERUNfTElCRElSfQotKQotCi1pbmNsdWRlKEZpbmRQYWNrYWdl SGFuZGxlU3RhbmRhcmRBcmdzKQotZmluZF9wYWNrYWdlX2hhbmRsZV9zdGFuZGFyZF9hcmdzKEJy b3RsaURlYwotICAgIFJFUVVJUkVEX1ZBUlMgQlJPVExJREVDX0lOQ0xVREVfRElSUyBCUk9UTElE RUNfTElCUkFSSUVTCi0gICAgRk9VTkRfVkFSIEJST1RMSURFQ19GT1VORAotICAgIFZFUlNJT05f VkFSIFBDX0JST1RMSURFQ19WRVJTSU9OKQotCi1tYXJrX2FzX2FkdmFuY2VkKAotICAgIEJST1RM SURFQ19JTkNMVURFX0RJUlMKLSAgICBCUk9UTElERUNfTElCUkFSSUVTCi0pCmRpZmYgLS1naXQg YS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCmluZGV4IGJhN2UxMzRjN2NjZDkxNGFjZGUzZDRmYjU4NWMzMDY1ODRmYmIxNTUuLjM5 YzNhOWJlNDdlYmYyNDI3ZDY4MDY4MDgyYjg4ZTk5MDYzZGM1NWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNt YWtlCkBAIC0zNjUsMTEgKzM2NSw3IEBAIGlmIChVU0VfVVBPV0VSKQogZW5kaWYgKCkKIAogaWYg KFVTRV9XT0ZGMikKLSAgICBmaW5kX3BhY2thZ2UoQnJvdGxpRGVjIDEuMC4xKQotICAgIGlmIChO T1QgQlJPVExJREVDX0ZPVU5EKQotICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgImxpYmJyb3Rs aWRlYyBpcyBuZWVkZWQgZm9yIFVTRV9XT0ZGMi4iKQotICAgIGVuZGlmICgpCi0gICAgZmluZF9w YWNrYWdlKFdPRkYyRGVjIDEuMC4xKQorICAgIGZpbmRfcGFja2FnZShXT0ZGMkRlYyAxLjAuMikK ICAgICBpZiAoTk9UIFdPRkYyREVDX0ZPVU5EKQogICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1Ig ImxpYndvZmYyZGVjIGlzIG5lZWRlZCBmb3IgVVNFX1dPRkYyLiIpCiAgICAgZW5kaWYgKCkKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NDJiY2Mx YmJmYjdlZWQxNjcwNzU3NGRjNTc3ODc1NzdiMzkxZDBkLi5kNzcyMDBmNWRmM2QxNzEwN2EyYzIx MThlNGRmZjhmNzAzMzAwYmI5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMTEtMTMgIE1pY2hhZWwgQ2F0YW56 YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFJlcXVpcmUgd29m ZjIgMS4wLjIgYW5kIGRyb3AgZGlyZWN0IGJyb3RsaSBkZXBlbmRlbmN5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk2MzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6 CisKIDIwMTctMTEtMTMgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAg ICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBjYW5ub3QgY29uc3RydWN0IHZhbGlkIGlPUyB2ZXJz aW9uIHdpdGhvdXQgYW4gaU9TIFNESwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9k dWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggOTM0YzBhMzE1MGQyZTdkODZh NzhmNjhhNmUzNzY0OGI0MDdkYTljZS4uODEzMWYyMmI4YmZjMmEwYmIyYjBjYzFiNjAyZGMzOTQx MzkwNjVkYyAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29s cy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC04NSw3ICs4NSw3IEBACiAgIDwvY21ha2U+CiAKICAg PGNtYWtlIGlkPSJ3b2ZmMiI+Ci0gICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9 Imdvb2dsZS93b2ZmMi5naXQiIGNoZWNrb3V0ZGlyPSJ3b2ZmMiIgdGFnPSJ2MS4wLjEiLz4KKyAg ICA8YnJhbmNoIHJlcG89ImdpdGh1Yi5jb20iIG1vZHVsZT0iZ29vZ2xlL3dvZmYyLmdpdCIgY2hl Y2tvdXRkaXI9IndvZmYyIiB0YWc9InYxLjAuMiIvPgogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAg ICA8ZGVwIHBhY2thZ2U9ImJyb3RsaSIvPgogICAgIDwvZGVwZW5kZW5jaWVzPgpkaWZmIC0tZ2l0 IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDk0ZWYxNjY2ODNiODAwZjA3MDdjOTczZTU3 MzY4OWJjNzkyMjJkMjEuLjBmMDkxZmQ5NzlkY2I2ZTBhZGEyMWQyZjVlMDEzNDNhZDM1NWUwY2Ug MTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxNy0xMS0xMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gUmVxdWlyZSB3b2ZmMiAxLjAuMiBhbmQgZHJvcCBkaXJlY3QgYnJvdGxp IGRlcGVuZGVuY3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3OTYzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU291cmNlL2NtYWtlL0ZpbmRCcm90bGlEZWMuY21ha2U6IFJlbW92ZWQuCisgICAgICAg ICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisKIDIwMTctMTEtMDkgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIFVzZSBs aW5rZXIgc2NyaXB0IHRvIGNvbnRyb2wgZXhwb3J0ZWQgc3ltYm9scwo=