179617 2017-11-13 10:42:12 -0800 std::expected: fix and test move 2017-11-15 09:33:21 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jfbastien jfbastien achristensen benjamin buildbot cdumez cmarcelo commit-queue dbates jfbastien sam webkit-bug-importer oldest_to_newest 1370943 0 jfbastien 2017-11-13 10:42:12 -0800 Move doesn't seem quite right everywhere. 1370945 1 326771 jfbastien 2017-11-13 10:44:33 -0800 Created attachment 326771 patch 1370947 2 buildbot 2017-11-13 10:46:47 -0800 Attachment 326771 did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:428: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1370965 3 326771 commit-queue 2017-11-13 11:19:33 -0800 Comment on attachment 326771 patch Clearing flags on attachment: 326771 Committed r224762: <https://trac.webkit.org/changeset/224762> 1370966 4 commit-queue 2017-11-13 11:19:35 -0800 All reviewed patches have been landed. Closing bug. 1371883 5 webkit-bug-importer 2017-11-15 09:33:21 -0800 <rdar://problem/35561940> 326771 2017-11-13 10:44:33 -0800 2017-11-13 11:19:33 -0800 patch 0001-std-expected-fix-and-test-move.patch text/plain 7415 jfbastien RnJvbSBiM2U3NjgzOTZkMzJjMjY1MjQyMDhlMjg5ZTU1MDA5MDc4NDg1ZTY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBNb24sIDEzIE5vdiAyMDE3IDEwOjQ0OjAyIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gc3RkOjpl eHBlY3RlZDogZml4IGFuZCB0ZXN0IG1vdmUKCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgIHwgMTUgKysrKysrKwogU291cmNlL1dURi93dGYvRXhwZWN0ZWQu aCAgICAgICAgICAgICAgICAgIHwgMTIgKysrLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAxNiArKysrKysrCiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9FeHBlY3RlZC5jcHAgfCA2OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDQg ZmlsZXMgY2hhbmdlZCwgMTA0IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCA4 NDE2OTEzLi40OWEzZTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTExLTEzICBKRiBCYXN0 aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KKworICAgICAgICBzdGQ6OmV4cGVjdGVkOiBmaXgg YW5kIHRlc3QgbW92ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTc5NjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm9uLWNvcHlhYmxlIG1vdmUgdHlwZXMgc2hvdWxkIGJlIGFibGUgdG8gYmUgaW4gYW4g ZXhwZWN0ZWQKKyAgICAgICAgcHJvcGVybHkuCisKKyAgICAgICAgKiB3dGYvRXhwZWN0ZWQuaDoK KyAgICAgICAgKFdURjo6RXhwZWN0ZWQ6OnZhbHVlIGNvbnN0KToKKyAgICAgICAgKFdURjo6RXhw ZWN0ZWQ6OmVycm9yKToKKyAgICAgICAgKFdURjo6RXhwZWN0ZWQ6OmVycm9yIGNvbnN0KToKKwog MjAxNy0xMS0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgYSBGYWlyUGxheSBTdHJlYW1pbmcgYmFzZWQgQ0RNIGZvciBNb2Rlcm4gRU1FCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9FeHBlY3RlZC5oIGIvU291cmNlL1dURi93dGYvRXhwZWN0ZWQu aAppbmRleCAyNTBhZWE3Li43MjhiNDEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9FeHBl Y3RlZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgKQEAgLTMyNywxMiArMzI3LDEy IEBAIHB1YmxpYzoKICAgICBjb25zdGV4cHIgYm9vbCBoYXNWYWx1ZSgpIGNvbnN0IHsgcmV0dXJu IGJhc2U6OmhhczsgfQogICAgIGNvbnN0ZXhwciBjb25zdCBWYWx1ZVR5cGUmIHZhbHVlKCkgY29u c3QgJiB7IHJldHVybiBiYXNlOjpoYXMgPyBiYXNlOjpzLnZhbCA6IChFeHBlY3RlZERldGFpbDo6 VGhyb3coKSwgYmFzZTo6cy52YWwpOyB9CiAgICAgUkVMQVhFRF9DT05TVEVYUFIgVmFsdWVUeXBl JiB2YWx1ZSgpICYgeyByZXR1cm4gYmFzZTo6aGFzID8gYmFzZTo6cy52YWwgOiAoRXhwZWN0ZWRE ZXRhaWw6OlRocm93KCksIGJhc2U6OnMudmFsKTsgfQotICAgIGNvbnN0ZXhwciBjb25zdCBWYWx1 ZVR5cGUmJiB2YWx1ZSgpIGNvbnN0ICYmIHsgcmV0dXJuIGJhc2U6OmhhcyA/IGJhc2U6OnMudmFs IDogKEV4cGVjdGVkRGV0YWlsOjpUaHJvdygpLCBiYXNlOjpzLnZhbCk7IH0KKyAgICBjb25zdGV4 cHIgY29uc3QgVmFsdWVUeXBlJiYgdmFsdWUoKSBjb25zdCAmJiB7IHJldHVybiBXVEZNb3ZlKGJh c2U6OmhhcyA/IGJhc2U6OnMudmFsIDogKEV4cGVjdGVkRGV0YWlsOjpUaHJvdygpLCBiYXNlOjpz LnZhbCkpOyB9CiAgICAgUkVMQVhFRF9DT05TVEVYUFIgVmFsdWVUeXBlJiYgdmFsdWUoKSAmJiB7 IHJldHVybiBXVEZNb3ZlKGJhc2U6OmhhcyA/IGJhc2U6OnMudmFsIDogKEV4cGVjdGVkRGV0YWls OjpUaHJvdygpLCBiYXNlOjpzLnZhbCkpOyB9CiAgICAgY29uc3RleHByIGNvbnN0IEVycm9yVHlw ZSYgZXJyb3IoKSBjb25zdCAmIHsgcmV0dXJuICFiYXNlOjpoYXMgPyBiYXNlOjpzLmVyciA6IChF eHBlY3RlZERldGFpbDo6VGhyb3coKSwgYmFzZTo6cy5lcnIpOyB9CiAgICAgRXJyb3JUeXBlJiBl cnJvcigpICYgeyByZXR1cm4gIWJhc2U6OmhhcyA/IGJhc2U6OnMuZXJyIDogKEV4cGVjdGVkRGV0 YWlsOjpUaHJvdygpLCBiYXNlOjpzLmVycik7IH0KLSAgICBSRUxBWEVEX0NPTlNURVhQUiBFcnJv clR5cGUmJiBlcnJvcigpICYmIHsgcmV0dXJuICFiYXNlOjpoYXMgPyBiYXNlOjpzLmVyciA6IChF eHBlY3RlZERldGFpbDo6VGhyb3coKSwgYmFzZTo6cy5lcnIpOyB9Ci0gICAgY29uc3RleHByIGNv bnN0IEVycm9yVHlwZSYmIGVycm9yKCkgY29uc3QgJiYgeyByZXR1cm4gIWJhc2U6OmhhcyA/IGJh c2U6OnMuZXJyIDogKEV4cGVjdGVkRGV0YWlsOjpUaHJvdygpLCBiYXNlOjpzLmVycik7IH0KKyAg ICBSRUxBWEVEX0NPTlNURVhQUiBFcnJvclR5cGUmJiBlcnJvcigpICYmIHsgcmV0dXJuIFdURk1v dmUoIWJhc2U6OmhhcyA/IGJhc2U6OnMuZXJyIDogKEV4cGVjdGVkRGV0YWlsOjpUaHJvdygpLCBi YXNlOjpzLmVycikpOyB9CisgICAgY29uc3RleHByIGNvbnN0IEVycm9yVHlwZSYmIGVycm9yKCkg Y29uc3QgJiYgeyByZXR1cm4gV1RGTW92ZSghYmFzZTo6aGFzID8gYmFzZTo6cy5lcnIgOiAoRXhw ZWN0ZWREZXRhaWw6OlRocm93KCksIGJhc2U6OnMuZXJyKSk7IH0KICAgICBjb25zdGV4cHIgVW5l eHBlY3RlZFR5cGUgZ2V0VW5leHBlY3RlZCgpIGNvbnN0IHsgcmV0dXJuIFVuZXhwZWN0ZWRUeXBl KGJhc2U6OnMuZXJyKTsgfQogICAgIHRlbXBsYXRlPGNsYXNzIFU+IGNvbnN0ZXhwciBWYWx1ZVR5 cGUgdmFsdWVPcihVJiYgdSkgY29uc3QgJiB7IHJldHVybiBiYXNlOjpoYXMgPyAqKnRoaXMgOiBz dGF0aWNfY2FzdDxWYWx1ZVR5cGU+KHN0ZDo6Zm9yd2FyZDxVPih1KSk7IH0KICAgICB0ZW1wbGF0 ZTxjbGFzcyBVPiBWYWx1ZVR5cGUgdmFsdWVPcihVJiYgdSkgJiYgeyByZXR1cm4gYmFzZTo6aGFz ID8gV1RGTW92ZSgqKnRoaXMpIDogc3RhdGljX2Nhc3Q8VmFsdWVUeXBlPihzdGQ6OmZvcndhcmQ8 VT4odSkpOyB9CkBAIC0zOTEsMTAgKzM5MSw4IEBAIHB1YmxpYzoKICAgICBjb25zdGV4cHIgYm9v bCBoYXNWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIGJhc2U6OmhhczsgfQogICAgIHZvaWQgdmFsdWUo KSBjb25zdCB7ICFiYXNlOjpoYXMgPyBFeHBlY3RlZERldGFpbDo6VGhyb3coKSA6IHZvaWQoKTsg fQogICAgIGNvbnN0ZXhwciBjb25zdCBFJiBlcnJvcigpIGNvbnN0ICYgeyByZXR1cm4gIWJhc2U6 OmhhcyA/IGJhc2U6OnMuZXJyIDogKEV4cGVjdGVkRGV0YWlsOjpUaHJvdygpLCBiYXNlOjpzLmVy cik7IH0KLSAgICBFJiBlcnJvcigpICYgeyByZXR1cm4gIWJhc2U6OmhhcyA/IGJhc2U6OnMuZXJy IDogKEV4cGVjdGVkRGV0YWlsOjpUaHJvdygpLCBiYXNlOjpzLmVycik7IH0gLy8gTm90IGluIHRo ZSBjdXJyZW50IHBhcGVyLgotICAgIFJFTEFYRURfQ09OU1RFWFBSIEUmJiBlcnJvcigpICYmIHsg cmV0dXJuICFiYXNlOjpoYXMgPyBiYXNlOjpzLmVyciA6IChFeHBlY3RlZERldGFpbDo6VGhyb3co KSwgYmFzZTo6cy5lcnIpOyB9Ci0gICAgY29uc3RleHByIGNvbnN0IEUmJiBlcnJvcigpIGNvbnN0 ICYmIHsgcmV0dXJuICFiYXNlOjpoYXMgPyBiYXNlOjpzLmVyciA6IChFeHBlY3RlZERldGFpbDo6 VGhyb3coKSwgYmFzZTo6cy5lcnIpOyB9IC8vIE5vdCBpbiB0aGUgY3VycmVudCBwYXBlci4KLSAg ICAvLyBjb25zdGV4cHIgRSYgZXJyb3IoKSAmOworICAgIEUmIGVycm9yKCkgJiB7IHJldHVybiAh YmFzZTo6aGFzID8gYmFzZTo6cy5lcnIgOiAoRXhwZWN0ZWREZXRhaWw6OlRocm93KCksIGJhc2U6 OnMuZXJyKTsgfQorICAgIFJFTEFYRURfQ09OU1RFWFBSIEUmJiBlcnJvcigpICYmIHsgcmV0dXJu IFdURk1vdmUoIWJhc2U6OmhhcyA/IGJhc2U6OnMuZXJyIDogKEV4cGVjdGVkRGV0YWlsOjpUaHJv dygpLCBiYXNlOjpzLmVycikpOyB9CiAgICAgY29uc3RleHByIFVuZXhwZWN0ZWRUeXBlIGdldFVu ZXhwZWN0ZWQoKSBjb25zdCB7IHJldHVybiBVbmV4cGVjdGVkVHlwZShiYXNlOjpzLmVycik7IH0K IH07CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCAyMGY0OTE5Li5iOGM0YWFjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMTEtMTMgIEpGIEJhc3RpZW4gIDxq ZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIHN0ZDo6ZXhwZWN0ZWQ6IGZpeCBhbmQgdGVz dCBtb3ZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Nzk2MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU ZXN0IHRoYXQgdW5pcXVlX3B0ciBjYW4gYmUgbW92ZWQgYXJvdW5kIHByb3Blcmx5LCBib3RoIGhh cyBhCisgICAgICAgIHZhbHVlIGFuZCBhbiBlcnJvciAoYW5kIGluIGEgPHZvaWQsIHVuaXF1ZT4g c3BlY2lhbGl6YXRpb24pLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRXhw ZWN0ZWQuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6c25vd2ZsYWtlOjpyZXNldCk6Cisg ICAgICAgIChUZXN0V2ViS2l0QVBJOjpzbm93Zmxha2U6OnNub3dmbGFrZSk6CisgICAgICAgIChU ZXN0V2ViS2l0QVBJOjpzbm93Zmxha2U6On5zbm93Zmxha2UpOgorICAgICAgICAoVGVzdFdlYktp dEFQSTo6VEVTVCk6CisKIDIwMTctMTEtMTMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBh cHBsZS5jb20+CiAKICAgICAgICAgW0F0dGFjaG1lbnQgU3VwcG9ydF0gSW1wbGVtZW50IFNQSSBm b3IgY2xpZW50cyB0byByZXF1ZXN0IGRhdGEgZm9yIGEgZ2l2ZW4gYXR0YWNobWVudApkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRXhwZWN0ZWQuY3BwIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRXhwZWN0ZWQuY3BwCmluZGV4IDgxYTg5NjEuLmFjODAx NmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0V4cGVjdGVkLmNw cAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9FeHBlY3RlZC5jcHAKQEAgLTI3 LDkgKzI3LDExIEBACiAKICNpbmNsdWRlICJSZWZMb2dnZXIuaCIKIAorI2luY2x1ZGUgPG1lbW9y eT4KICNpbmNsdWRlIDxzdHJpbmc+CiAKICNpbmNsdWRlIDx3dGYvRXhwZWN0ZWQuaD4KKyNpbmNs dWRlIDx3dGYvU3RkTGliRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL1JlZi5oPgogCiBuYW1lc3Bh Y2UgV1RGIHsKQEAgLTM5Miw2ICszOTQsNzIgQEAgVEVTVChXVEZfRXhwZWN0ZWQsIGRlc3RydWN0 b3JzKQogICAgIEVYUEVDVF9FUShOb25Ucml2aWFsRHRvcjo6Y291bnQsIDExKTsKIH0KIAorc3Rh dGljIGludCBzbm93Zmxha2VzID0gMDsKK3N0YXRpYyBpbnQgbWVsdGVkID0gMDsKK3N0cnVjdCBz bm93Zmxha2UgeworICAgIHN0YXRpYyB2b2lkIHJlc2V0KCkgeyBzbm93Zmxha2VzID0gbWVsdGVk ID0gMDsgfQorICAgIHNub3dmbGFrZSgpIHsgKytzbm93Zmxha2VzOyB9CisgICAgfnNub3dmbGFr ZSgpIHsgKyttZWx0ZWQ7IH0KK307CisKK1RFU1QoV1RGX0V4cGVjdGVkLCB1bmlxdWVfcHRyKQor eworICAgIC8vIFVuaXF1ZSBzbm93Zmxha2VzIGNhbm5vdCBiZSBjb3BpZWQuCisgICAgeworICAg ICAgICBhdXRvIHMgPSBtYWtlVW5leHBlY3RlZChzdGQ6Om1ha2VfdW5pcXVlPHNub3dmbGFrZT4o KSk7CisgICAgICAgIEVYUEVDVF9FUShzbm93Zmxha2VzLCAxKTsKKyAgICAgICAgRVhQRUNUX0VR KG1lbHRlZCwgMCk7CisgICAgfQorICAgIEVYUEVDVF9FUShzbm93Zmxha2VzLCAxKTsKKyAgICBF WFBFQ1RfRVEobWVsdGVkLCAxKTsKKyAgICBzbm93Zmxha2U6OnJlc2V0KCk7CisKKyAgICB7Cisg ICAgICAgIGF1dG8gcyA9IG1ha2VVbmV4cGVjdGVkKHN0ZDo6bWFrZV91bmlxdWU8c25vd2ZsYWtl PigpKTsKKyAgICAgICAgVW5leHBlY3RlZDxzdGQ6OnVuaXF1ZV9wdHI8c25vd2ZsYWtlPj4gYyhX VEZNb3ZlKHMpKTsKKyAgICAgICAgRVhQRUNUX0VRKHNub3dmbGFrZXMsIDEpOworICAgICAgICBF WFBFQ1RfRVEobWVsdGVkLCAwKTsKKyAgICB9CisgICAgRVhQRUNUX0VRKHNub3dmbGFrZXMsIDEp OworICAgIEVYUEVDVF9FUShtZWx0ZWQsIDEpOworICAgIHNub3dmbGFrZTo6cmVzZXQoKTsKKwor ICAgIGF1dG8gcGxvdyA9IFtdIChzdGQ6OnVuaXF1ZV9wdHI8c25vd2ZsYWtlPiYmIHMpCisgICAg eworICAgICAgICB7CisgICAgICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8c25vd2ZsYWtlPiBtb3Zl ZCA9IFdURk1vdmUocyk7CisgICAgICAgICAgICBFWFBFQ1RfRVEoc25vd2ZsYWtlcywgMSk7Cisg ICAgICAgICAgICBFWFBFQ1RfRVEobWVsdGVkLCAwKTsKKyAgICAgICAgfQorICAgICAgICBFWFBF Q1RfRVEoc25vd2ZsYWtlcywgMSk7CisgICAgICAgIEVYUEVDVF9FUShtZWx0ZWQsIDEpOworICAg IH07CisKKyAgICB7CisgICAgICAgIEV4cGVjdGVkPHN0ZDo6dW5pcXVlX3B0cjxzbm93Zmxha2U+ LCBpbnQ+IHMoc3RkOjptYWtlX3VuaXF1ZTxzbm93Zmxha2U+KCkpOworICAgICAgICBwbG93KFdU Rk1vdmUocykudmFsdWUoKSk7CisgICAgfQorICAgIEVYUEVDVF9FUShzbm93Zmxha2VzLCAxKTsK KyAgICBFWFBFQ1RfRVEobWVsdGVkLCAxKTsKKyAgICBzbm93Zmxha2U6OnJlc2V0KCk7CisKKyAg ICB7CisgICAgICAgIEV4cGVjdGVkPGludCwgc3RkOjp1bmlxdWVfcHRyPHNub3dmbGFrZT4+IHMo bWFrZVVuZXhwZWN0ZWQoc3RkOjptYWtlX3VuaXF1ZTxzbm93Zmxha2U+KCkpKTsKKyAgICAgICAg cGxvdyhXVEZNb3ZlKHMpLmVycm9yKCkpOworICAgIH0KKyAgICBFWFBFQ1RfRVEoc25vd2ZsYWtl cywgMSk7CisgICAgRVhQRUNUX0VRKG1lbHRlZCwgMSk7CisgICAgc25vd2ZsYWtlOjpyZXNldCgp OworCisgICAgeworICAgICAgICBFeHBlY3RlZDx2b2lkLCBzdGQ6OnVuaXF1ZV9wdHI8c25vd2Zs YWtlPj4gcyhtYWtlVW5leHBlY3RlZChzdGQ6Om1ha2VfdW5pcXVlPHNub3dmbGFrZT4oKSkpOwor ICAgICAgICBwbG93KFdURk1vdmUocykuZXJyb3IoKSk7CisgICAgfQorICAgIEVYUEVDVF9FUShz bm93Zmxha2VzLCAxKTsKKyAgICBFWFBFQ1RfRVEobWVsdGVkLCAxKTsKKyAgICBzbm93Zmxha2U6 OnJlc2V0KCk7Cit9CisKIFRFU1QoV1RGX0V4cGVjdGVkLCBSZWYpCiB7CiAgICAgewotLSAKMi4x MC4xCgo=