179576 2017-11-10 23:33:51 -0800 Avoid composing the message + recipient name for crash logs until a failure actually occurs 2017-11-15 09:34:42 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue darin mitz simon.fraser webkit-bug-importer oldest_to_newest 1370656 0 thorton 2017-11-10 23:33:51 -0800 Use StringBuilder instead of NSString to build the full message name for crash logs 1370657 1 326681 thorton 2017-11-10 23:34:13 -0800 Created attachment 326681 Patch 1370658 2 326681 thorton 2017-11-10 23:34:54 -0800 Comment on attachment 326681 Patch Not totally sure what the trailing colon is about, but I kept it. 1370659 3 326681 mitz 2017-11-10 23:39:54 -0800 Comment on attachment 326681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326681&action=review > Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:291 > + message->setMessageName(messageNameBuilder.toString().createCFString().get()); I wonder why MachMessage’s messageName needs to be a CFString. 1370660 4 thorton 2017-11-10 23:45:42 -0800 It looks like it doesn't, and seems likely that will make this even faster. 1370661 5 thorton 2017-11-10 23:52:40 -0800 That makes it a 90% reduction instead. But I think we can do yet better, and only compose the string in the failure case, instead of always. 1370664 6 326682 thorton 2017-11-11 00:09:28 -0800 Created attachment 326682 Patch 1370665 7 326683 thorton 2017-11-11 00:10:46 -0800 Created attachment 326683 Patch 1370666 8 326683 mitz 2017-11-11 00:13:11 -0800 Comment on attachment 326683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326683&action=review > Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:250 > + WebKit::setCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%s::%s'", kr, message->messageReceiverName().data(), message->messageName().data()]); The :: makes more sense, but I wonder if the change in format would disturb some long-running data aggregation. Probably not! 1370671 9 thorton 2017-11-11 01:04:01 -0800 We'll see! I've only see this used for one-off investigations, though. 1370684 10 326683 commit-queue 2017-11-11 01:24:47 -0800 Comment on attachment 326683 Patch Clearing flags on attachment: 326683 Committed r224728: <https://trac.webkit.org/changeset/224728> 1370685 11 commit-queue 2017-11-11 01:24:49 -0800 All reviewed patches have been landed. Closing bug. 1370796 12 326683 darin 2017-11-12 17:06:30 -0800 Comment on attachment 326683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326683&action=review > Source/WebKit/Platform/IPC/mac/MachMessage.h:47 > + void setMessageReceiverName(const CString& messageReceiverName) { m_messageReceiverName = messageReceiverName; } CString&& and WTFMove would give us slightly more efficient code here. > Source/WebKit/Platform/IPC/mac/MachMessage.h:50 > + void setMessageName(const CString& messageName) { m_messageName = messageName; } Ditto. 1371089 13 thorton 2017-11-13 14:49:39 -0800 (In reply to Darin Adler from comment #12) > Comment on attachment 326683 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326683&action=review > > > Source/WebKit/Platform/IPC/mac/MachMessage.h:47 > > + void setMessageReceiverName(const CString& messageReceiverName) { m_messageReceiverName = messageReceiverName; } > > CString&& and WTFMove would give us slightly more efficient code here. > > > Source/WebKit/Platform/IPC/mac/MachMessage.h:50 > > + void setMessageName(const CString& messageName) { m_messageName = messageName; } > > Ditto. Did that in https://trac.webkit.org/changeset/224782/webkit 1371893 14 webkit-bug-importer 2017-11-15 09:34:42 -0800 <rdar://problem/35561994> 326681 2017-11-10 23:34:13 -0800 2017-11-11 00:09:27 -0800 Patch bug-179576-20171110233413.patch text/plain 2027 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE2NzUzYjljZDIzM2EyNGE3 ODk1Yjg1NDg4ZWRjNjIzMGI1MDFkYTQuLjkzZDcwYmUzZTM0YWQ3M2UyMzNmMmVhN2E5MjM1N2Y3 NGExNTI5NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMTEtMTAgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFN0cmluZ0J1aWxk ZXIgaW5zdGVhZCBvZiBOU1N0cmluZyB0byBidWlsZCB0aGUgZnVsbCBtZXNzYWdlIG5hbWUgZm9y IGNyYXNoIGxvZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3OTU3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tOgorICAgICAgICAoSVBDOjpD b25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlKToKKyAgICAgICAgVGhpcyByZWR1Y2VzIHRo ZSB0aW1lIHNwZW50IGJ1aWxkaW5nIHRoZSBzdHJpbmcgYnkgfjYwJS4KKyAgICAgICAgSW4gYWJz b2x1dGUgdGVybXMsIGl0J3Mgbm90IGh1Z2UsIGJ1dCBpZiB5b3UgZG8gZW5vdWdoIElQQyBpdCBz dGFydHMgdG8gYWRkIHVwLgorCiAyMDE3LTExLTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgW1NlcnZpY2UgV29ya2Vyc10gSW1wbGVtZW50ICJUcnkgQWN0aXZh dGUiIC8gIkFjdGl2YXRlIiBhbGdvcml0aG1zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Bs YXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlvbk1hYy5tbSBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0v SVBDL21hYy9Db25uZWN0aW9uTWFjLm1tCmluZGV4IDY4OWUyODEwNWVlMGVkYTRmOTc0NWM0OTU3 OTZmZWZkODdhYzYwYWIuLjkzYTc4ODdhMWEwNzBjYWUwM2U0YWEzY2E0Mzc1YTA4ODQ4NjIzYjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1t CkBAIC0yODIsNyArMjgyLDEzIEBAIGJvb2wgQ29ubmVjdGlvbjo6c2VuZE91dGdvaW5nTWVzc2Fn ZShzdGQ6OnVuaXF1ZV9wdHI8RW5jb2Rlcj4gZW5jb2RlcikKICAgICB9CiAKICAgICBhdXRvIG1l c3NhZ2UgPSBNYWNoTWVzc2FnZTo6Y3JlYXRlKG1lc3NhZ2VTaXplKTsKLSAgICBtZXNzYWdlLT5z ZXRNZXNzYWdlTmFtZSgoX19icmlkZ2UgQ0ZTdHJpbmdSZWYpW05TU3RyaW5nIHN0cmluZ1dpdGhG b3JtYXQ6QCIlczolczoiLCBlbmNvZGVyLT5tZXNzYWdlUmVjZWl2ZXJOYW1lKCkudG9TdHJpbmco KS5kYXRhKCksIGVuY29kZXItPm1lc3NhZ2VOYW1lKCkudG9TdHJpbmcoKS5kYXRhKCldKTsKKwor ICAgIFN0cmluZ0J1aWxkZXIgbWVzc2FnZU5hbWVCdWlsZGVyOworICAgIG1lc3NhZ2VOYW1lQnVp bGRlci5hcHBlbmQoZW5jb2Rlci0+bWVzc2FnZVJlY2VpdmVyTmFtZSgpLmRhdGEoKSwgZW5jb2Rl ci0+bWVzc2FnZVJlY2VpdmVyTmFtZSgpLnNpemUoKSk7CisgICAgbWVzc2FnZU5hbWVCdWlsZGVy LmFwcGVuZCgnOicpOworICAgIG1lc3NhZ2VOYW1lQnVpbGRlci5hcHBlbmQoZW5jb2Rlci0+bWVz c2FnZU5hbWUoKS5kYXRhKCksIGVuY29kZXItPm1lc3NhZ2VOYW1lKCkuc2l6ZSgpKTsKKyAgICBt ZXNzYWdlTmFtZUJ1aWxkZXIuYXBwZW5kKCc6Jyk7CisgICAgbWVzc2FnZS0+c2V0TWVzc2FnZU5h bWUobWVzc2FnZU5hbWVCdWlsZGVyLnRvU3RyaW5nKCkuY3JlYXRlQ0ZTdHJpbmcoKS5nZXQoKSk7 CiAKICAgICBib29sIGlzQ29tcGxleCA9IChudW1iZXJPZlBvcnREZXNjcmlwdG9ycyArIG51bWJl ck9mT09MTWVtb3J5RGVzY3JpcHRvcnMpID4gMDsKIAo= 326682 2017-11-11 00:09:28 -0800 2017-11-11 00:10:45 -0800 Patch bug-179576-20171111000927.patch text/plain 4079 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE2NzUzYjljZDIzM2EyNGE3 ODk1Yjg1NDg4ZWRjNjIzMGI1MDFkYTQuLjJhMTExZDdkOWQ3Y2Y1NDRmMzFlZWU1Y2E0YTZiOGZk NDQxY2U4MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTctMTEtMTEgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgY29tcG9zaW5n IHRoZSBtZXNzYWdlICsgcmVjaXBpZW50IG5hbWUgZm9yIGNyYXNoIGxvZ3MgdW50aWwgYSBmYWls dXJlIGFjdHVhbGx5IG9jY3VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc5NTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW06CisgICAgICAg IChJUEM6OkNvbm5lY3Rpb246OnNlbmRNZXNzYWdlKToKKyAgICAgICAgKElQQzo6Q29ubmVjdGlv bjo6c2VuZE91dGdvaW5nTWVzc2FnZSk6CisgICAgICAgICogUGxhdGZvcm0vSVBDL21hYy9NYWNo TWVzc2FnZS5oOgorICAgICAgICAoSVBDOjpNYWNoTWVzc2FnZTo6bWVzc2FnZVJlY2VpdmVyTmFt ZSBjb25zdCk6CisgICAgICAgIChJUEM6Ok1hY2hNZXNzYWdlOjpzZXRNZXNzYWdlUmVjZWl2ZXJO YW1lKToKKyAgICAgICAgKElQQzo6TWFjaE1lc3NhZ2U6Om1lc3NhZ2VOYW1lIGNvbnN0KToKKyAg ICAgICAgKElQQzo6TWFjaE1lc3NhZ2U6OnNldE1lc3NhZ2VOYW1lKToKKyAgICAgICAgU3RvcmUg dGhlIG1lc3NhZ2UgbmFtZSBhbmQgcmVjZWl2ZXIgbmFtZSBzZXBhcmF0ZWx5IG9uIE1hY2hNZXNz YWdlLAorICAgICAgICBvbmx5IGNvbXBvc2luZyB0aGVtIGludG8gYSBzdHJpbmcgaWYgdGhlIG1l c3NhZ2UgaXMgdW5oYW5kbGVkLiBUaGlzCisgICAgICAgIG1ha2VzIHRoZSB0aW1lIHNwZW50IGNv bXBvc2luZyB0aGUgc3RyaW5nIGluIHNlbmRPdXRnb2luZ01lc3NhZ2UKKyAgICAgICAgY29tcGxl dGVseSBkaXNhcHBlYXIuIEluIGFic29sdXRlIHRlcm1zLCBpdCB3YXNuJ3QgaHVnZSwgYnV0IGlm IHlvdQorICAgICAgICBkbyBlbm91Z2ggSVBDIGl0IHN0YXJ0cyB0byBhZGQgdXAuCisKIDIwMTct MTEtMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbU2Vydmlj ZSBXb3JrZXJzXSBJbXBsZW1lbnQgIlRyeSBBY3RpdmF0ZSIgLyAiQWN0aXZhdGUiIGFsZ29yaXRo bXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9u TWFjLm1tIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW0K aW5kZXggNjg5ZTI4MTA1ZWUwZWRhNGY5NzQ1YzQ5NTc5NmZlZmQ4N2FjNjBhYi4uZmQzMjg2MGY0 ZTA5ZDU0NjViMjExNjZlODExZTkwNmRhNjZlMzUxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9Q bGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW0KQEAgLTI0Nyw3ICsyNDcsNyBAQCBib29s IENvbm5lY3Rpb246OnNlbmRNZXNzYWdlKHN0ZDo6dW5pcXVlX3B0cjxNYWNoTWVzc2FnZT4gbWVz c2FnZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgZGVmYXVsdDoKLSAgICAgICAgV2Vi S2l0OjpzZXRDcmFzaFJlcG9ydEFwcGxpY2F0aW9uU3BlY2lmaWNJbmZvcm1hdGlvbigoQ0ZTdHJp bmdSZWYpW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJVbmhhbmRsZWQgZXJyb3IgY29kZSAl eCwgbWVzc2FnZSAnJUAnIiwga3IsIG1lc3NhZ2UtPm1lc3NhZ2VOYW1lKCldKTsKKyAgICAgICAg V2ViS2l0OjpzZXRDcmFzaFJlcG9ydEFwcGxpY2F0aW9uU3BlY2lmaWNJbmZvcm1hdGlvbigoQ0ZT dHJpbmdSZWYpW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJVbmhhbmRsZWQgZXJyb3IgY29k ZSAleCwgbWVzc2FnZSAnJXM6OiVzJyIsIGtyLCBtZXNzYWdlLT5tZXNzYWdlUmVjZWl2ZXJOYW1l KCkuZGF0YSgpLCBtZXNzYWdlLT5tZXNzYWdlTmFtZSgpLmRhdGEoKV0pOwogICAgICAgICBDUkFT SCgpOwogICAgIH0KIH0KQEAgLTI4Miw3ICsyODIsOSBAQCBib29sIENvbm5lY3Rpb246OnNlbmRP dXRnb2luZ01lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPEVuY29kZXI+IGVuY29kZXIpCiAgICAgfQog CiAgICAgYXV0byBtZXNzYWdlID0gTWFjaE1lc3NhZ2U6OmNyZWF0ZShtZXNzYWdlU2l6ZSk7Ci0g ICAgbWVzc2FnZS0+c2V0TWVzc2FnZU5hbWUoKF9fYnJpZGdlIENGU3RyaW5nUmVmKVtOU1N0cmlu ZyBzdHJpbmdXaXRoRm9ybWF0OkAiJXM6JXM6IiwgZW5jb2Rlci0+bWVzc2FnZVJlY2VpdmVyTmFt ZSgpLnRvU3RyaW5nKCkuZGF0YSgpLCBlbmNvZGVyLT5tZXNzYWdlTmFtZSgpLnRvU3RyaW5nKCku ZGF0YSgpXSk7CisKKyAgICBtZXNzYWdlLT5zZXRNZXNzYWdlUmVjZWl2ZXJOYW1lKGVuY29kZXIt Pm1lc3NhZ2VSZWNlaXZlck5hbWUoKS50b1N0cmluZygpKTsKKyAgICBtZXNzYWdlLT5zZXRNZXNz YWdlTmFtZShlbmNvZGVyLT5tZXNzYWdlTmFtZSgpLnRvU3RyaW5nKCkpOwogCiAgICAgYm9vbCBp c0NvbXBsZXggPSAobnVtYmVyT2ZQb3J0RGVzY3JpcHRvcnMgKyBudW1iZXJPZk9PTE1lbW9yeURl c2NyaXB0b3JzKSA+IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBD L21hYy9NYWNoTWVzc2FnZS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvbWFjL01hY2hN ZXNzYWdlLmgKaW5kZXggMWRlNjZmNjYwMzk1NGIzMTBjZTFmZWRhNDQ1ZGY4NjYzOWUwOTI1YS4u Yjg0NzlkMzVjYTIyNDA4MDEyZWM1YTVlMmE5OGRiMTg0YWZlMmZiZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvbWFjL01hY2hNZXNzYWdlLmgKKysrIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9JUEMvbWFjL01hY2hNZXNzYWdlLmgKQEAgLTI2LDcgKzI2LDggQEAKICNw cmFnbWEgb25jZQogCiAjaW5jbHVkZSA8bWVtb3J5PgotI2luY2x1ZGUgPHd0Zi9SZXRhaW5QdHIu aD4KKyNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmlu Zy5oPgogCiBuYW1lc3BhY2UgSVBDIHsKIApAQCAtNDMsMTMgKzQ0LDE3IEBAIHB1YmxpYzoKIAog ICAgIHZvaWQgbGVha0Rlc2NyaXB0b3JzKCk7CiAKLSAgICBDRlN0cmluZ1JlZiBtZXNzYWdlTmFt ZSgpIGNvbnN0IHsgcmV0dXJuIG1fbWVzc2FnZU5hbWUuZ2V0KCk7IH0KLSAgICB2b2lkIHNldE1l c3NhZ2VOYW1lKENGU3RyaW5nUmVmIG1lc3NhZ2VOYW1lKSB7IG1fbWVzc2FnZU5hbWUgPSBtZXNz YWdlTmFtZTsgfQorICAgIGNvbnN0IENTdHJpbmcmIG1lc3NhZ2VSZWNlaXZlck5hbWUoKSBjb25z dCB7IHJldHVybiBtX21lc3NhZ2VSZWNlaXZlck5hbWU7IH0KKyAgICB2b2lkIHNldE1lc3NhZ2VS ZWNlaXZlck5hbWUoY29uc3QgQ1N0cmluZyYgbWVzc2FnZVJlY2VpdmVyTmFtZSkgeyBtX21lc3Nh Z2VSZWNlaXZlck5hbWUgPSBtZXNzYWdlUmVjZWl2ZXJOYW1lOyB9CisKKyAgICBjb25zdCBDU3Ry aW5nJiBtZXNzYWdlTmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fbWVzc2FnZU5hbWU7IH0KKyAgICB2 b2lkIHNldE1lc3NhZ2VOYW1lKGNvbnN0IENTdHJpbmcmIG1lc3NhZ2VOYW1lKSB7IG1fbWVzc2Fn ZU5hbWUgPSBtZXNzYWdlTmFtZTsgfQogCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IE1hY2hNZXNz YWdlKHNpemVfdCk7CiAKLSAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IG1fbWVzc2FnZU5hbWU7 CisgICAgQ1N0cmluZyBtX21lc3NhZ2VSZWNlaXZlck5hbWU7CisgICAgQ1N0cmluZyBtX21lc3Nh Z2VOYW1lOwogICAgIHNpemVfdCBtX3NpemU7CiAgICAgYm9vbCBtX3Nob3VsZEZyZWVEZXNjcmlw dG9yczsKICAgICB1aW50OF90IG1fYnVmZmVyWzBdOwo= 326683 2017-11-11 00:10:46 -0800 2017-11-11 01:24:47 -0800 Patch bug-179576-20171111001046.patch text/plain 4051 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE2NzUzYjljZDIzM2EyNGE3 ODk1Yjg1NDg4ZWRjNjIzMGI1MDFkYTQuLjJhMTExZDdkOWQ3Y2Y1NDRmMzFlZWU1Y2E0YTZiOGZk NDQxY2U4MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTctMTEtMTEgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgY29tcG9zaW5n IHRoZSBtZXNzYWdlICsgcmVjaXBpZW50IG5hbWUgZm9yIGNyYXNoIGxvZ3MgdW50aWwgYSBmYWls dXJlIGFjdHVhbGx5IG9jY3VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc5NTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW06CisgICAgICAg IChJUEM6OkNvbm5lY3Rpb246OnNlbmRNZXNzYWdlKToKKyAgICAgICAgKElQQzo6Q29ubmVjdGlv bjo6c2VuZE91dGdvaW5nTWVzc2FnZSk6CisgICAgICAgICogUGxhdGZvcm0vSVBDL21hYy9NYWNo TWVzc2FnZS5oOgorICAgICAgICAoSVBDOjpNYWNoTWVzc2FnZTo6bWVzc2FnZVJlY2VpdmVyTmFt ZSBjb25zdCk6CisgICAgICAgIChJUEM6Ok1hY2hNZXNzYWdlOjpzZXRNZXNzYWdlUmVjZWl2ZXJO YW1lKToKKyAgICAgICAgKElQQzo6TWFjaE1lc3NhZ2U6Om1lc3NhZ2VOYW1lIGNvbnN0KToKKyAg ICAgICAgKElQQzo6TWFjaE1lc3NhZ2U6OnNldE1lc3NhZ2VOYW1lKToKKyAgICAgICAgU3RvcmUg dGhlIG1lc3NhZ2UgbmFtZSBhbmQgcmVjZWl2ZXIgbmFtZSBzZXBhcmF0ZWx5IG9uIE1hY2hNZXNz YWdlLAorICAgICAgICBvbmx5IGNvbXBvc2luZyB0aGVtIGludG8gYSBzdHJpbmcgaWYgdGhlIG1l c3NhZ2UgaXMgdW5oYW5kbGVkLiBUaGlzCisgICAgICAgIG1ha2VzIHRoZSB0aW1lIHNwZW50IGNv bXBvc2luZyB0aGUgc3RyaW5nIGluIHNlbmRPdXRnb2luZ01lc3NhZ2UKKyAgICAgICAgY29tcGxl dGVseSBkaXNhcHBlYXIuIEluIGFic29sdXRlIHRlcm1zLCBpdCB3YXNuJ3QgaHVnZSwgYnV0IGlm IHlvdQorICAgICAgICBkbyBlbm91Z2ggSVBDIGl0IHN0YXJ0cyB0byBhZGQgdXAuCisKIDIwMTct MTEtMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbU2Vydmlj ZSBXb3JrZXJzXSBJbXBsZW1lbnQgIlRyeSBBY3RpdmF0ZSIgLyAiQWN0aXZhdGUiIGFsZ29yaXRo bXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9u TWFjLm1tIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW0K aW5kZXggNjg5ZTI4MTA1ZWUwZWRhNGY5NzQ1YzQ5NTc5NmZlZmQ4N2FjNjBhYi4uZmQzMjg2MGY0 ZTA5ZDU0NjViMjExNjZlODExZTkwNmRhNjZlMzUxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9Q bGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW0KQEAgLTI0Nyw3ICsyNDcsNyBAQCBib29s IENvbm5lY3Rpb246OnNlbmRNZXNzYWdlKHN0ZDo6dW5pcXVlX3B0cjxNYWNoTWVzc2FnZT4gbWVz c2FnZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgZGVmYXVsdDoKLSAgICAgICAgV2Vi S2l0OjpzZXRDcmFzaFJlcG9ydEFwcGxpY2F0aW9uU3BlY2lmaWNJbmZvcm1hdGlvbigoQ0ZTdHJp bmdSZWYpW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJVbmhhbmRsZWQgZXJyb3IgY29kZSAl eCwgbWVzc2FnZSAnJUAnIiwga3IsIG1lc3NhZ2UtPm1lc3NhZ2VOYW1lKCldKTsKKyAgICAgICAg V2ViS2l0OjpzZXRDcmFzaFJlcG9ydEFwcGxpY2F0aW9uU3BlY2lmaWNJbmZvcm1hdGlvbigoQ0ZT dHJpbmdSZWYpW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJVbmhhbmRsZWQgZXJyb3IgY29k ZSAleCwgbWVzc2FnZSAnJXM6OiVzJyIsIGtyLCBtZXNzYWdlLT5tZXNzYWdlUmVjZWl2ZXJOYW1l KCkuZGF0YSgpLCBtZXNzYWdlLT5tZXNzYWdlTmFtZSgpLmRhdGEoKV0pOwogICAgICAgICBDUkFT SCgpOwogICAgIH0KIH0KQEAgLTI4Miw3ICsyODIsOSBAQCBib29sIENvbm5lY3Rpb246OnNlbmRP dXRnb2luZ01lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPEVuY29kZXI+IGVuY29kZXIpCiAgICAgfQog CiAgICAgYXV0byBtZXNzYWdlID0gTWFjaE1lc3NhZ2U6OmNyZWF0ZShtZXNzYWdlU2l6ZSk7Ci0g ICAgbWVzc2FnZS0+c2V0TWVzc2FnZU5hbWUoKF9fYnJpZGdlIENGU3RyaW5nUmVmKVtOU1N0cmlu ZyBzdHJpbmdXaXRoRm9ybWF0OkAiJXM6JXM6IiwgZW5jb2Rlci0+bWVzc2FnZVJlY2VpdmVyTmFt ZSgpLnRvU3RyaW5nKCkuZGF0YSgpLCBlbmNvZGVyLT5tZXNzYWdlTmFtZSgpLnRvU3RyaW5nKCku ZGF0YSgpXSk7CisKKyAgICBtZXNzYWdlLT5zZXRNZXNzYWdlUmVjZWl2ZXJOYW1lKGVuY29kZXIt Pm1lc3NhZ2VSZWNlaXZlck5hbWUoKS50b1N0cmluZygpKTsKKyAgICBtZXNzYWdlLT5zZXRNZXNz YWdlTmFtZShlbmNvZGVyLT5tZXNzYWdlTmFtZSgpLnRvU3RyaW5nKCkpOwogCiAgICAgYm9vbCBp c0NvbXBsZXggPSAobnVtYmVyT2ZQb3J0RGVzY3JpcHRvcnMgKyBudW1iZXJPZk9PTE1lbW9yeURl c2NyaXB0b3JzKSA+IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBD L21hYy9NYWNoTWVzc2FnZS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvbWFjL01hY2hN ZXNzYWdlLmgKaW5kZXggMWRlNjZmNjYwMzk1NGIzMTBjZTFmZWRhNDQ1ZGY4NjYzOWUwOTI1YS4u ZjhiYTIxMGUxZmE4MmE4ODM2ODY4Nzc3Zjk0NmZmOGYyY2ZlOTVkMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvbWFjL01hY2hNZXNzYWdlLmgKKysrIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9JUEMvbWFjL01hY2hNZXNzYWdlLmgKQEAgLTI2LDcgKzI2LDcgQEAKICNw cmFnbWEgb25jZQogCiAjaW5jbHVkZSA8bWVtb3J5PgotI2luY2x1ZGUgPHd0Zi9SZXRhaW5QdHIu aD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIG5hbWVzcGFjZSBJUEMgewogCkBA IC00MywxMyArNDMsMTcgQEAgcHVibGljOgogCiAgICAgdm9pZCBsZWFrRGVzY3JpcHRvcnMoKTsK IAotICAgIENGU3RyaW5nUmVmIG1lc3NhZ2VOYW1lKCkgY29uc3QgeyByZXR1cm4gbV9tZXNzYWdl TmFtZS5nZXQoKTsgfQotICAgIHZvaWQgc2V0TWVzc2FnZU5hbWUoQ0ZTdHJpbmdSZWYgbWVzc2Fn ZU5hbWUpIHsgbV9tZXNzYWdlTmFtZSA9IG1lc3NhZ2VOYW1lOyB9CisgICAgY29uc3QgQ1N0cmlu ZyYgbWVzc2FnZVJlY2VpdmVyTmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fbWVzc2FnZVJlY2VpdmVy TmFtZTsgfQorICAgIHZvaWQgc2V0TWVzc2FnZVJlY2VpdmVyTmFtZShjb25zdCBDU3RyaW5nJiBt ZXNzYWdlUmVjZWl2ZXJOYW1lKSB7IG1fbWVzc2FnZVJlY2VpdmVyTmFtZSA9IG1lc3NhZ2VSZWNl aXZlck5hbWU7IH0KKworICAgIGNvbnN0IENTdHJpbmcmIG1lc3NhZ2VOYW1lKCkgY29uc3QgeyBy ZXR1cm4gbV9tZXNzYWdlTmFtZTsgfQorICAgIHZvaWQgc2V0TWVzc2FnZU5hbWUoY29uc3QgQ1N0 cmluZyYgbWVzc2FnZU5hbWUpIHsgbV9tZXNzYWdlTmFtZSA9IG1lc3NhZ2VOYW1lOyB9CiAKIHBy aXZhdGU6CiAgICAgZXhwbGljaXQgTWFjaE1lc3NhZ2Uoc2l6ZV90KTsKIAotICAgIFJldGFpblB0 cjxDRlN0cmluZ1JlZj4gbV9tZXNzYWdlTmFtZTsKKyAgICBDU3RyaW5nIG1fbWVzc2FnZVJlY2Vp dmVyTmFtZTsKKyAgICBDU3RyaW5nIG1fbWVzc2FnZU5hbWU7CiAgICAgc2l6ZV90IG1fc2l6ZTsK ICAgICBib29sIG1fc2hvdWxkRnJlZURlc2NyaXB0b3JzOwogICAgIHVpbnQ4X3QgbV9idWZmZXJb MF07Cg==