179567 2017-11-10 17:09:34 -0800 REGRESSION(r223856): Web Inspector: Cannot view Request Data 2017-11-13 11:58:14 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1370607 0 joepeck 2017-11-10 17:09:34 -0800 REGRESSION(r223856): Cannot view Request Data Oops, a condition flipped in r223856. 1370608 1 326664 joepeck 2017-11-10 17:10:19 -0800 Created attachment 326664 [PATCH] Proposed Fix 1370674 2 326664 hi 2017-11-11 01:08:11 -0800 Comment on attachment 326664 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=326664&action=review > Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:216 > + if (this._resource.hasRequestFormParameters()) I realize that this existed before the new Network tab, but I think now would be a good time to add a comment. To me, this seems backwards, as we would want to show request data if we have form parameters. My guess is that that is either a security concern or we have a different UI for this? Either way, I don't know why this is the case right now. 1370677 3 joepeck 2017-11-11 01:15:30 -0800 (In reply to Devin Rousso from comment #2) > Comment on attachment 326664 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326664&action=review > > > Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:216 > > + if (this._resource.hasRequestFormParameters()) > > I realize that this existed before the new Network tab, but I think now > would be a good time to add a comment. To me, this seems backwards, as we > would want to show request data if we have form parameters. My guess is > that that is either a security concern or we have a different UI for this? > Either way, I don't know why this is the case right now. If the data is Form Parameters (x-www-form-urlencoded) then the data is key/value pairs like query string data. We show that in the "Headers" view like query string parameters. I suppose we could have a view here that shows them like query string parameters, but right now we only prefer showing a ContentView for requestData that is data. 1370978 4 326664 bburg 2017-11-13 11:42:20 -0800 Comment on attachment 326664 [PATCH] Proposed Fix r=me 1370981 5 webkit-bug-importer 2017-11-13 11:43:01 -0800 <rdar://problem/35510405> 1370989 6 326664 commit-queue 2017-11-13 11:58:12 -0800 Comment on attachment 326664 [PATCH] Proposed Fix Clearing flags on attachment: 326664 Committed r224767: <https://trac.webkit.org/changeset/224767> 1370990 7 commit-queue 2017-11-13 11:58:14 -0800 All reviewed patches have been landed. Closing bug. 326664 2017-11-10 17:10:19 -0800 2017-11-13 11:58:12 -0800 [PATCH] Proposed Fix flip-1.patch text/plain 1506 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE4YWZmNzMyZTJkLi4xYjFiZTlmZThiOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTctMTEtMTAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBSRUdSRVNTSU9OKHIy MjM4NTYpOiBXZWIgSW5zcGVjdG9yOiBDYW5ub3QgdmlldyBSZXF1ZXN0IERhdGEKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTU2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlJlc291cmNl Q2x1c3RlckNvbnRlbnRWaWV3LnByb3RvdHlwZS5fY2FuU2hvd1JlcXVlc3RDb250ZW50Vmlldyk6 CisgICAgICAgIFRoaXMgY29uZGl0aW9uIHVuaW50ZW50aW9uYWxseSBnb3QgZmxpcHBlZCBpbiBy MjIzODU2LgorCisyMDE3LTExLTEwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogTmV0d29yayBEZXRhaWxzIFZpZXdzIC0gbWFr ZSBzZWN0aW9uIGhlYWRlcnMgbW9yZSBwcm9taW5lbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTU2NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmll dy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNl Q2x1c3RlckNvbnRlbnRWaWV3LmpzCmluZGV4IGU4NDM0NmQ1YTQ0Li40MzA1ZGQxODRjNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3Vy Y2VDbHVzdGVyQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvUmVzb3VyY2VDbHVzdGVyQ29udGVudFZpZXcuanMKQEAgLTIxMyw3ICsy MTMsNyBAQCBXSS5SZXNvdXJjZUNsdXN0ZXJDb250ZW50VmlldyA9IGNsYXNzIFJlc291cmNlQ2x1 c3RlckNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ2x1cwogICAgICAgICBpZiAoIXJlcXVlc3REYXRh KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIGlmICghdGhpcy5fcmVzb3Vy Y2UuaGFzUmVxdWVzdEZvcm1QYXJhbWV0ZXJzKCkpCisgICAgICAgIGlmICh0aGlzLl9yZXNvdXJj ZS5oYXNSZXF1ZXN0Rm9ybVBhcmFtZXRlcnMoKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK IAogICAgICAgICByZXR1cm4gdHJ1ZTsK