179553 2017-11-10 15:11:26 -0800 [Windows] Fix Python error for subprocess.popen with close_fds 2017-11-15 09:35:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 179216 1 basuke basuke achristensen ap basuke bfulgham buildbot commit-queue don.olmstead fujii glenn lforschler pvollan webkit-bug-importer oldest_to_newest 1370529 0 basuke 2017-11-10 15:11:26 -0800 When running test-webkitpy, there're many failure caused by following error: > ValueError: close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr 1370530 1 basuke 2017-11-10 15:11:49 -0800 On Windows native command prompt (not Cygwin) 1371066 2 326798 basuke 2017-11-13 14:10:35 -0800 Created attachment 326798 fix 1371069 3 basuke 2017-11-13 14:16:28 -0800 I chose just passing False (don't close fds) because we cannot move forward with this flag True on Windows w/o Cygwin. We will figured out the actual issue caused by passing False here later. 1371141 4 326798 pvollan 2017-11-13 15:56:16 -0800 Comment on attachment 326798 fix R=me. 1371171 5 326798 commit-queue 2017-11-13 16:55:45 -0800 Comment on attachment 326798 fix Clearing flags on attachment: 326798 Committed r224795: <https://trac.webkit.org/changeset/224795> 1371172 6 commit-queue 2017-11-13 16:55:46 -0800 All reviewed patches have been landed. Closing bug. 1371899 7 webkit-bug-importer 2017-11-15 09:35:33 -0800 <rdar://problem/35562026> 326798 2017-11-13 14:10:35 -0800 2017-11-13 16:55:45 -0800 fix bug-179553.diff text/plain 2623 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NjQ4 NDFhZDE4OS4uOTJlOWZiNjM0ODYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNy0xMS0xMyAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbmRvd3NdIEZpeCBQeXRo b24gZXJyb3IgZm9yIHN1YnByb2Nlc3MucG9wZW4gd2l0aCBjbG9zZV9mZHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTU1MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9w b3J0L3NlcnZlcl9wcm9jZXNzLnB5OgorICAgICAgICAoU2VydmVyUHJvY2Vzcy5fc3RhcnQpOgor ICAgICAgICAoU2VydmVyUHJvY2Vzcy5fc2hvdWxkX2Nsb3NlX2Zkcyk6CisKIDIwMTctMTEtMTMg IEdhYnJpZWwgSXZhc2N1ICA8Z2l2YXNjdUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEF1 dG9tYXRpY2FsbHkgYWRqdXN0IGZvbnQgc2l6ZSB3aGVuIGd0ay14ZnQtZHBpIGNoYW5nZXMKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQppbmRleCAzNmRi ZTUzMTJkNS4uMmQ3ODNlNzIxZDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv c2VydmVyX3Byb2Nlc3MucHkKQEAgLTExMCwxMyArMTEwLDEwIEBAIGNsYXNzIFNlcnZlclByb2Nl c3Mob2JqZWN0KToKICAgICAgICAgaWYgc2VsZi5fcHJvYzoKICAgICAgICAgICAgIHJhaXNlIFZh bHVlRXJyb3IoIiVzIGFscmVhZHkgcnVubmluZyIgJSBzZWxmLl9uYW1lKQogICAgICAgICBzZWxm Ll9yZXNldCgpCi0gICAgICAgICMgY2xvc2VfZmRzIGlzIGEgd29ya2Fyb3VuZCBmb3IgaHR0cDov L2J1Z3MucHl0aG9uLm9yZy9pc3N1ZTIzMjAKLSAgICAgICAgIyBJbiBQeXRob24gMi43LjEwLCBj bG9zZV9mZHMgaXMgYWxzbyBzdXBwb3J0ZWQgb24gV2luZG93cy4KLSAgICAgICAgY2xvc2VfZmRz ID0gVHJ1ZQogICAgICAgICBzZWxmLl9wcm9jID0gc2VsZi5fdGFyZ2V0X2hvc3QuZXhlY3V0aXZl LnBvcGVuKHNlbGYuX2NtZCwgc3RkaW49c2VsZi5fdGFyZ2V0X2hvc3QuZXhlY3V0aXZlLlBJUEUs CiAgICAgICAgICAgICBzdGRvdXQ9c2VsZi5fdGFyZ2V0X2hvc3QuZXhlY3V0aXZlLlBJUEUsCiAg ICAgICAgICAgICBzdGRlcnI9c2VsZi5fdGFyZ2V0X2hvc3QuZXhlY3V0aXZlLlBJUEUsCi0gICAg ICAgICAgICBjbG9zZV9mZHM9Y2xvc2VfZmRzLAorICAgICAgICAgICAgY2xvc2VfZmRzPXNlbGYu X3Nob3VsZF9jbG9zZV9mZHMoKSwKICAgICAgICAgICAgIGVudj1zZWxmLl9lbnYsCiAgICAgICAg ICAgICB1bml2ZXJzYWxfbmV3bGluZXM9c2VsZi5fdW5pdmVyc2FsX25ld2xpbmVzKQogICAgICAg ICBzZWxmLl9waWQgPSBzZWxmLl9wcm9jLnBpZApAQCAtMTI0LDYgKzEyMSwxOSBAQCBjbGFzcyBT ZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CiAgICAgICAgICAgICBzZWxmLl9zZXRfZmlsZV9ub25ibG9j a2luZyhzZWxmLl9wcm9jLnN0ZG91dCkKICAgICAgICAgICAgIHNlbGYuX3NldF9maWxlX25vbmJs b2NraW5nKHNlbGYuX3Byb2Muc3RkZXJyKQogCisgICAgZGVmIF9zaG91bGRfY2xvc2VfZmRzKHNl bGYpOgorICAgICAgICAjIFdlIG5lZWQgdG8gcGFzcyBjbG9zZV9mZHM9VHJ1ZSB0byB3b3JrIGFy b3VuZCBQeXRob24gYnVnICMyMzIwCisgICAgICAgICMgKG90aGVyd2lzZSB3ZSBjYW4gaGFuZyB3 aGVuIHdlIGtpbGwgRHVtcFJlbmRlclRyZWUgd2hlbiB3ZSBhcmUgcnVubmluZworICAgICAgICAj IG11bHRpcGxlIHRocmVhZHMpLiBTZWUgaHR0cDovL2J1Z3MucHl0aG9uLm9yZy9pc3N1ZTIzMjAg LgorICAgICAgICAjIEluIFB5dGhvbiAyLjcuMTAsIGNsb3NlX2ZkcyBpcyBhbHNvIHN1cHBvcnRl ZCBvbiBXaW5kb3dzLgorICAgICAgICAjIEhvd2V2ZXIsICJ5b3UgY2Fubm90IHNldCBjbG9zZV9m ZHMgdG8gdHJ1ZSBhbmQgYWxzbyByZWRpcmVjdCB0aGUgc3RhbmRhcmQKKyAgICAgICAgIyBoYW5k bGVzIGJ5IHNldHRpbmcgc3RkaW4sIHN0ZG91dCBvciBzdGRlcnIuIi4KKyAgICAgICAgcGxhdGZv cm0gPSBzZWxmLl9wb3J0Lmhvc3QucGxhdGZvcm0KKyAgICAgICAgaWYgcGxhdGZvcm0uaXNfd2lu KCkgYW5kIG5vdCBwbGF0Zm9ybS5pc19jeWd3aW4oKToKKyAgICAgICAgICAgIHJldHVybiBGYWxz ZQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgcmV0dXJuIFRydWUKKwogICAgIGRlZiBfaGFu ZGxlX3Bvc3NpYmxlX2ludGVycnVwdChzZWxmKToKICAgICAgICAgIiIiVGhpcyByb3V0aW5lIGNo ZWNrcyB0byBzZWUgaWYgdGhlIHByb2Nlc3MgY3Jhc2hlZCBvciBleGl0ZWQKICAgICAgICAgYmVj YXVzZSBvZiBhIGtleWJvYXJkIGludGVycnVwdCBhbmQgcmFpc2VzIEtleWJvYXJkSW50ZXJydXB0 Cg==