179543 2017-11-10 13:31:44 -0800 Web Inspector: Make http status codes be "integer" instead of "number" in protocol 2017-11-15 09:35:59 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck buildbot commit-queue graouts inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1370469 0 joepeck 2017-11-10 13:31:44 -0800 Make http status codes be "integer" instead of "number" in protocol This matches a CDP change: https://github.com/ChromeDevTools/devtools-protocol/issues/58 Should not affect any code generation or clients either, just a better type, so lets do it. 1370470 1 326622 joepeck 2017-11-10 13:33:02 -0800 Created attachment 326622 [PATCH] Proposed Fix 1370496 2 326622 commit-queue 2017-11-10 14:10:08 -0800 Comment on attachment 326622 [PATCH] Proposed Fix Clearing flags on attachment: 326622 Committed r224704: <https://trac.webkit.org/changeset/224704> 1370497 3 commit-queue 2017-11-10 14:10:10 -0800 All reviewed patches have been landed. Closing bug. 1371903 4 webkit-bug-importer 2017-11-15 09:35:59 -0800 <rdar://problem/35562037> 326622 2017-11-10 13:33:02 -0800 2017-11-10 14:10:08 -0800 [PATCH] Proposed Fix better-type-1.patch text/plain 4455 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDJjZTY1MWQ3NTlhLi41ZGFiY2IxNmIzMSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTEtMTAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBNYWtlIGh0dHAgc3RhdHVzIGNvZGVzIGJlICJpbnRlZ2VyIiBpbnN0ZWFkIG9mICJudW1iZXIi IGluIHByb3RvY29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzk1NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGluc3BlY3Rvci9wcm90b2NvbC9OZXR3b3JrLmpzb246CisgICAgICAgIFVzZSBhIGJl dHRlciB0eXBlIGZvciB0aGUgc3RhdHVzIGNvZGUuCisKIDIwMTctMTEtMTAgIFJvYmluIE1vcmlz c2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBUaGUgbWVtb3J5IGNvbnN1bXB0 aW9uIG9mIERGRzo6QmFzaWNCbG9jayBjYW4gYmUgZWFzaWx5IHJlZHVjZWQgYSBiaXQKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvTmV0d29yay5q c29uIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9OZXR3b3JrLmpz b24KaW5kZXggMDk5YjQwYTE5OGYuLjFhNmIxN2EyZjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL05ldHdvcmsuanNvbgorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL05ldHdvcmsuanNvbgpAQCAtNjUsNyAr NjUsNyBAQAogICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIkhUVFAgcmVzcG9uc2UgZGF0YS4i LAogICAgICAgICAgICAgInByb3BlcnRpZXMiOiBbCiAgICAgICAgICAgICAgICAgeyAibmFtZSI6 ICJ1cmwiLCAidHlwZSI6ICJzdHJpbmciLCAiZGVzY3JpcHRpb24iOiAiUmVzcG9uc2UgVVJMLiBU aGlzIFVSTCBjYW4gYmUgZGlmZmVyZW50IGZyb20gQ2FjaGVkUmVzb3VyY2UudXJsIGluIGNhc2Ug b2YgcmVkaXJlY3QuIiB9LAotICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAic3RhdHVzIiwgInR5 cGUiOiAibnVtYmVyIiwgImRlc2NyaXB0aW9uIjogIkhUVFAgcmVzcG9uc2Ugc3RhdHVzIGNvZGUu IiB9LAorICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAic3RhdHVzIiwgInR5cGUiOiAiaW50ZWdl ciIsICJkZXNjcmlwdGlvbiI6ICJIVFRQIHJlc3BvbnNlIHN0YXR1cyBjb2RlLiIgfSwKICAgICAg ICAgICAgICAgICB7ICJuYW1lIjogInN0YXR1c1RleHQiLCAidHlwZSI6ICJzdHJpbmciLCAiZGVz Y3JpcHRpb24iOiAiSFRUUCByZXNwb25zZSBzdGF0dXMgdGV4dC4iIH0sCiAgICAgICAgICAgICAg ICAgeyAibmFtZSI6ICJoZWFkZXJzIiwgIiRyZWYiOiAiSGVhZGVycyIsICJkZXNjcmlwdGlvbiI6 ICJIVFRQIHJlc3BvbnNlIGhlYWRlcnMuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAi aGVhZGVyc1RleHQiLCAidHlwZSI6ICJzdHJpbmciLCAib3B0aW9uYWwiOiB0cnVlLCAiZGVzY3Jp cHRpb24iOiAiSFRUUCByZXNwb25zZSBoZWFkZXJzIHRleHQuIiB9LApAQCAtMTA2LDcgKzEwNiw3 IEBACiAgICAgICAgICAgICAidHlwZSI6ICJvYmplY3QiLAogICAgICAgICAgICAgImRlc2NyaXB0 aW9uIjogIldlYlNvY2tldCByZXNwb25zZSBkYXRhLiIsCiAgICAgICAgICAgICAicHJvcGVydGll cyI6IFsKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogInN0YXR1cyIsICJ0eXBlIjogIm51bWJl ciIsICJkZXNjcmlwdGlvbiI6ICJIVFRQIHJlc3BvbnNlIHN0YXR1cyBjb2RlLiIgfSwKKyAgICAg ICAgICAgICAgICB7ICJuYW1lIjogInN0YXR1cyIsICJ0eXBlIjogImludGVnZXIiLCAiZGVzY3Jp cHRpb24iOiAiSFRUUCByZXNwb25zZSBzdGF0dXMgY29kZS4iIH0sCiAgICAgICAgICAgICAgICAg eyAibmFtZSI6ICJzdGF0dXNUZXh0IiwgInR5cGUiOiAic3RyaW5nIiwgImRlc2NyaXB0aW9uIjog IkhUVFAgcmVzcG9uc2Ugc3RhdHVzIHRleHQuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUi OiAiaGVhZGVycyIsICIkcmVmIjogIkhlYWRlcnMiLCAiZGVzY3JpcHRpb24iOiAiSFRUUCByZXNw b25zZSBoZWFkZXJzLiIgfQogICAgICAgICAgICAgXQpAQCAtMTkxLDcgKzE5MSw3IEBACiAgICAg ICAgICAgICAicmV0dXJucyI6IFsKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogImNvbnRlbnQi LCAidHlwZSI6ICJzdHJpbmciLCAiZGVzY3JpcHRpb24iOiAiUmVzb3VyY2UgY29udGVudC4iIH0s CiAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJtaW1lVHlwZSIsICJ0eXBlIjogInN0cmluZyIs ICJkZXNjcmlwdGlvbiI6ICJSZXNvdXJjZSBtaW1lVHlwZS4iIH0sCi0gICAgICAgICAgICAgICAg eyAibmFtZSI6ICJzdGF0dXMiLCAidHlwZSI6ICJudW1iZXIiLCAiZGVzY3JpcHRpb24iOiAiSFRU UCByZXNwb25zZSBzdGF0dXMgY29kZS4iIH0KKyAgICAgICAgICAgICAgICB7ICJuYW1lIjogInN0 YXR1cyIsICJ0eXBlIjogImludGVnZXIiLCAiZGVzY3JpcHRpb24iOiAiSFRUUCByZXNwb25zZSBz dGF0dXMgY29kZS4iIH0KICAgICAgICAgICAgIF0KICAgICAgICAgfSwKICAgICAgICAgewpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGU1YTI4ZDVkYTA0Li4zNzFhMTZhMTZmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE3LTExLTEwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBodHRwIHN0YXR1cyBjb2RlcyBiZSAiaW50 ZWdlciIgaW5zdGVhZCBvZiAibnVtYmVyIiBpbiBwcm90b2NvbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5NTQzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvYWdlbnRzL0luc3BlY3Rv ck5ldHdvcmtBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JOZXR3b3JrQWdl bnQ6OmJ1aWxkT2JqZWN0Rm9yUmVzb3VyY2VSZXNwb25zZSk6CisgICAgICAgIE5vIG5lZWQgZm9y IHRoZSB0ZW1wb3Jhcnkgb3IgdHlwZSBjaGFuZ2UuCisKIDIwMTctMTEtMDkgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbmNs dWRlIGEgTmV0d29ya0FnZW50IGluIFNlcnZpY2VXb3JrZXJzIGZvciBuZXR3b3JrIGRlYnVnZ2lu ZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JO ZXR3b3JrQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0 b3JOZXR3b3JrQWdlbnQuY3BwCmluZGV4IGU0YzViNTczNDU4Li5lZTIxYmVhNmJhMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JOZXR3b3JrQWdl bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yTmV0 d29ya0FnZW50LmNwcApAQCAtMjg4LDEyICsyODgsMTEgQEAgUmVmUHRyPEluc3BlY3Rvcjo6UHJv dG9jb2w6Ok5ldHdvcms6OlJlc3BvbnNlPiBJbnNwZWN0b3JOZXR3b3JrQWdlbnQ6OmJ1aWxkT2Jq ZWMKICAgICBpZiAocmVzcG9uc2UuaXNOdWxsKCkpCiAgICAgICAgIHJldHVybiBudWxscHRyOwog Ci0gICAgZG91YmxlIHN0YXR1cyA9IHJlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCk7CiAgICAgUmVm PEluc3BlY3Rvck9iamVjdD4gaGVhZGVycyA9IGJ1aWxkT2JqZWN0Rm9ySGVhZGVycyhyZXNwb25z ZS5odHRwSGVhZGVyRmllbGRzKCkpOwogCiAgICAgYXV0byByZXNwb25zZU9iamVjdCA9IEluc3Bl Y3Rvcjo6UHJvdG9jb2w6Ok5ldHdvcms6OlJlc3BvbnNlOjpjcmVhdGUoKQogICAgICAgICAuc2V0 VXJsKHJlc3BvbnNlLnVybCgpLnN0cmluZygpKQotICAgICAgICAuc2V0U3RhdHVzKHN0YXR1cykK KyAgICAgICAgLnNldFN0YXR1cyhyZXNwb25zZS5odHRwU3RhdHVzQ29kZSgpKQogICAgICAgICAu c2V0U3RhdHVzVGV4dChyZXNwb25zZS5odHRwU3RhdHVzVGV4dCgpKQogICAgICAgICAuc2V0SGVh ZGVycyhXVEZNb3ZlKGhlYWRlcnMpKQogICAgICAgICAuc2V0TWltZVR5cGUocmVzcG9uc2UubWlt ZVR5cGUoKSkK