179529 2017-11-10 07:48:15 -0800 fix style failures in webkitpy: expected 2 blank lines found 1 2017-11-15 09:36:23 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179530 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain achristensen ap buildbot commit-queue dbates glenn lforschler webkit-bug-importer oldest_to_newest 1370307 0 aakash_jain 2017-11-10 07:48:15 -0800 Running check-webkit-style on webkitpy results in various failures of type: "expected 2 blank lines found 1". we should fix these to make sure webkitpy is following the style guidelines. 1370310 1 326580 aakash_jain 2017-11-10 07:52:27 -0800 Created attachment 326580 Proposed patch 1370375 2 326580 commit-queue 2017-11-10 09:39:54 -0800 Comment on attachment 326580 Proposed patch Clearing flags on attachment: 326580 Committed r224688: <https://trac.webkit.org/changeset/224688> 1370376 3 commit-queue 2017-11-10 09:39:56 -0800 All reviewed patches have been landed. Closing bug. 1371906 4 webkit-bug-importer 2017-11-15 09:36:23 -0800 <rdar://problem/35562052> 326580 2017-11-10 07:52:27 -0800 2017-11-10 09:39:54 -0800 Proposed patch style_webkitpy_two_blank_lines.patch text/plain 5025 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNDY4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTExLTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBmaXggc3R5bGUgZmFpbHVyZXMgaW4gd2Via2l0cHk6IGV4cGVjdGVkIDIg YmxhbmsgbGluZXMgZm91bmQgMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc5NTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvcnVuX2JlbmNo bWFyay5weTogQWRkZWQgYSBibGFuayBsaW5lIHRvIGZvbGxvdyBzdHlsZSBndWlkZWxpbmVzLgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9icm93c2VyX2RyaXZl ci9vc3hfY2hyb21lX2RyaXZlci5weTogRGl0dG8uCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mb19tb2NrLnB5OiBEaXR0by4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi92ZXJzaW9uLnB5OiBEaXR0by4KKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlcy5weTogRGl0dG8u CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L21hY191bml0dGVzdC5weTogRGl0dG8u CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3NpbXVsYXRvcl9wcm9jZXNzLnB5OiBE aXR0by4KKwogMjAxNy0xMS0wOSAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+ CiAKICAgICAgICAgd2Via2l0cHk6IFVuaWZ5IHZlcnNpb24gcGFyc2luZyBjb2RlCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvcnVuX2JlbmNobWFyay5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvcnVu X2JlbmNobWFyay5weQkocmV2aXNpb24gMjI0NjgxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9iZW5jaG1hcmtfcnVubmVyL3J1bl9iZW5jaG1hcmsucHkJKHdvcmtpbmcgY29weSkKQEAgLTYx LDYgKzYxLDcgQEAgZGVmIHBhcnNlX2FyZ3MoKToKIAogICAgIHJldHVybiBhcmdzCiAKKwogZGVm IHJ1bl9iZW5jaG1hcmtfcGxhbihhcmdzLCBwbGFuKToKICAgICBiZW5jaG1hcmtfcnVubmVyX2Ns YXNzID0gYmVuY2htYXJrX3J1bm5lcl9zdWJjbGFzc2VzW2FyZ3MuZHJpdmVyXQogICAgIHJ1bm5l ciA9IGJlbmNobWFya19ydW5uZXJfY2xhc3MocGxhbiwgYXJncy5sb2NhbF9jb3B5LCBhcmdzLmNv dW50LCBhcmdzLmJ1aWxkX2RpciwgYXJncy5vdXRwdXRfZmlsZSwgYXJncy5wbGF0Zm9ybSwgYXJn cy5icm93c2VyLCBhcmdzLnNjYWxlX3VuaXQsIGFyZ3MuZGV2aWNlX2lkKQpAQCAtNzIsNiArNzMs NyBAQCBkZWYgbGlzdF9iZW5jaG1hcmtfcGxhbnMoKToKICAgICBmb3IgcGxhbiBpbiBCZW5jaG1h cmtSdW5uZXIuYXZhaWxhYmxlX3BsYW5zKCk6CiAgICAgICAgIHByaW50ICJcdCVzIiAlIHBsYW4K IAorCiBkZWYgc3RhcnQoYXJncyk6CiAgICAgaWYgYXJncy5qc29uX2ZpbGU6CiAgICAgICAgIHJl c3VsdHNfanNvbiA9IGpzb24ubG9hZChvcGVuKGFyZ3MuanNvbl9maWxlLCAncicpKQpJbmRleDog VG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jyb3dzZXJfZHJpdmVyL29z eF9jaHJvbWVfZHJpdmVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv YmVuY2htYXJrX3J1bm5lci9icm93c2VyX2RyaXZlci9vc3hfY2hyb21lX2RyaXZlci5weQkocmV2 aXNpb24gMjI0NjgxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVy L2Jyb3dzZXJfZHJpdmVyL29zeF9jaHJvbWVfZHJpdmVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC04 LDYgKzgsNyBAQCBmcm9tIG9zeF9icm93c2VyX2RyaXZlciBpbXBvcnQgT1NYQnJvd3NlCiAKIF9s b2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKIAorCiBjbGFzcyBPU1hDaHJvbWVEcml2 ZXIoT1NYQnJvd3NlckRyaXZlcik6CiAgICAgcHJvY2Vzc19uYW1lID0gJ0dvb2dsZSBDaHJvbWUn CiAgICAgYnJvd3Nlcl9uYW1lID0gJ2Nocm9tZScKQEAgLTU5LDYgKzYwLDcgQEAgZGVmIGNyZWF0 ZV9hcmdzKCk6CiAgICAgYXJncyA9IFsnLS1hcmdzJywgJy0taG9tZXBhZ2UnLCBjcmVhdGVfd2lu ZG93X3NpemVfYXJnKCldCiAgICAgcmV0dXJuIGFyZ3MKIAorCiBkZWYgY3JlYXRlX2Nocm9tZV9v cHRpb25zKCk6CiAgICAgZnJvbSBzZWxlbml1bS53ZWJkcml2ZXIuY2hyb21lLm9wdGlvbnMgaW1w b3J0IE9wdGlvbnMKICAgICBjaHJvbWVfb3B0aW9ucyA9IE9wdGlvbnMoKQpJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vdmVyc2lvbi5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi92ZXJzaW9uLnB5CShyZXZpc2lvbiAyMjQ2ODEpCisrKyBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi92ZXJzaW9uLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0yMiw2ICsyMiw3IEBACiAKIGltcG9ydCBjb2xsZWN0aW9ucwogCisKIGNsYXNzIFZlcnNpb24o b2JqZWN0KToKIAogICAgIGRlZiBfX2luaXRfXyhzZWxmLCB2ZXI9JzAnKToKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm9fbW9jay5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1p bmZvX21vY2sucHkJKHJldmlzaW9uIDIyNDY4MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm9fbW9jay5weQkod29ya2luZyBjb3B5KQpAQCAtMjks NiArMjksNyBAQAogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi52ZXJzaW9uIGltcG9ydCBWZXJzaW9u CiAKKwogY2xhc3MgTW9ja1BsYXRmb3JtSW5mbyhvYmplY3QpOgogICAgIGRlZiBfX2luaXRfXyhz ZWxmLCBvc19uYW1lPSdtYWMnLCBvc192ZXJzaW9uPSdzbm93bGVvcGFyZCcpOgogICAgICAgICBz ZWxmLm9zX25hbWUgPSBvc19uYW1lCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlcy5weQkocmV2aXNp b24gMjI0NjgxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxz L3Rlc3RfZmFpbHVyZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTE2OSw2ICsxNjksNyBAQCBjbGFz cyBGYWlsdXJlTm90VGVzdGVkKEZhaWx1cmVUZXh0KToKICAgICBkZWYgbWVzc2FnZShzZWxmKToK ICAgICAgICAgcmV0dXJuICd0ZXN0IHdhcyBub3QgcnVuJwogCisKIGNsYXNzIEZhaWx1cmVUZXh0 TWlzbWF0Y2goRmFpbHVyZVRleHQpOgogICAgIGRlZiBtZXNzYWdlKHNlbGYpOgogICAgICAgICBy ZXR1cm4gInRleHQgZGlmZiIKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWNf dW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21h Y191bml0dGVzdC5weQkocmV2aXNpb24gMjI0NjgxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L21hY191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsNyBAQCBm cm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0ub3V0cHV0Y2FwdHVyCiBmcm9tIHdlYmtpdHB5LnRv b2wubW9ja3Rvb2wgaW1wb3J0IE1vY2tPcHRpb25zCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0 ZW0uZXhlY3V0aXZlX21vY2sgaW1wb3J0IE1vY2tFeGVjdXRpdmUsIE1vY2tFeGVjdXRpdmUyLCBT Y3JpcHRFcnJvcgogCisKIGNsYXNzIE1hY1Rlc3QoZGFyd2luX3Rlc3RjYXNlLkRhcndpblRlc3Qp OgogICAgIG9zX25hbWUgPSAnbWFjJwogICAgIG9zX3ZlcnNpb24gPSAnbGlvbicKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJvY2Vzcy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHkJKHJl dmlzaW9uIDIyNDY4MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3Jf cHJvY2Vzcy5weQkod29ya2luZyBjb3B5KQpAQCAtMjcsNiArMjcsNyBAQCBpbXBvcnQgdGltZQog ZnJvbSB3ZWJraXRweS5jb21tb24udGltZW91dF9jb250ZXh0IGltcG9ydCBUaW1lb3V0CiBmcm9t IHdlYmtpdHB5LnBvcnQuc2VydmVyX3Byb2Nlc3MgaW1wb3J0IFNlcnZlclByb2Nlc3MKIAorCiBj bGFzcyBTaW11bGF0b3JQcm9jZXNzKFNlcnZlclByb2Nlc3MpOgogCiAgICAgY2xhc3MgUG9wZW4o b2JqZWN0KToK