<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>179512</bug_id>
          
          <creation_ts>2017-11-09 16:38:12 -0800</creation_ts>
          <short_desc>build-jsc: build testmasm for all platforms using cmake</short_desc>
          <delta_ts>2017-11-15 09:44:47 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Guillaume Emont">guijemont</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1370108</commentid>
    <comment_count>0</comment_count>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2017-11-09 16:38:12 -0800</bug_when>
    <thetext>As of now, when using cmake, build-jsc only builds testmasm on windows. On the other platforms it builds testb3 testair testapi but not testmasm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1370111</commentid>
    <comment_count>1</comment_count>
      <attachid>326509</attachid>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2017-11-09 16:42:13 -0800</bug_when>
    <thetext>Created attachment 326509
Patch

Patch fixing the issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1370112</commentid>
    <comment_count>2</comment_count>
      <attachid>326510</attachid>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2017-11-09 16:44:06 -0800</bug_when>
    <thetext>Created attachment 326510
Patch

Corrected patch that includes ChangeLog update.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1370169</commentid>
    <comment_count>3</comment_count>
      <attachid>326532</attachid>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2017-11-09 19:06:57 -0800</bug_when>
    <thetext>Created attachment 326532
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1370170</commentid>
    <comment_count>4</comment_count>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2017-11-09 19:08:11 -0800</bug_when>
    <thetext>Sorry for the noise, it took me a while to realize that webkit-patch does not quite work when run from Tools/Scripts, or something like that. Now I finally have the patch I meant to upload ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1370334</commentid>
    <comment_count>5</comment_count>
      <attachid>326532</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-10 08:29:24 -0800</bug_when>
    <thetext>Comment on attachment 326532
Patch

Clearing flags on attachment: 326532

Committed r224683: &lt;https://trac.webkit.org/changeset/224683&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1370335</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-10 08:29:25 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1371989</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-11-15 09:44:47 -0800</bug_when>
    <thetext>&lt;rdar://problem/35562350&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>326509</attachid>
            <date>2017-11-09 16:42:13 -0800</date>
            <delta_ts>2017-11-09 16:44:05 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179512-20171109184212.patch</filename>
            <type>text/plain</type>
            <size>704</size>
            <attacher name="Guillaume Emont">guijemont</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjI0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1
aWxkLWpzYyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IGU0MzQ4ZjQ4NTUxOTcyMDEz
MjMxMjhmYzExMjE0YmFmNjVhODQ1N2UuLmM3MzYwYjkyM2ViZmYxODljNDc4Mzg0N2VkNDU1NWIw
NTYwZDhmMzkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisrKyBiL1Rvb2xz
L1NjcmlwdHMvYnVpbGQtanNjCkBAIC0xNDIsNyArMTQyLDcgQEAgaWYgKGlzQ01ha2VCdWlsZCgp
KSB7CiAgICAgdW5sZXNzIChpc0FueVdpbmRvd3MoKSkgewogICAgICAgICAjIEJ5IGRlZmF1bHQg
d2UgYnVpbGQgdXNpbmcgYWxsIG9mIHRoZSBhdmFpbGFibGUgQ1BVcwogICAgICAgICAkbWFrZUFy
Z3MgLj0gKCRtYWtlQXJncyA/ICIgIiA6ICIiKSAuICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAk
bWFrZUFyZ3MgIX4gLy1qXHMqXGQrLzsKLSAgICAgICAgJGJ1aWxkVGFyZ2V0ID0gImpzYyB0ZXN0
YjMgdGVzdGFpciB0ZXN0YXBpICRtYWtlQXJncyI7CisgICAgICAgICRidWlsZFRhcmdldCA9ICJq
c2MgdGVzdGIzIHRlc3RhaXIgdGVzdGFwaSB0ZXN0bWFzbSAkbWFrZUFyZ3MiOwogICAgIH0gZWxz
aWYgKGNhblVzZU5pbmphKCkpIHsKICAgICAgICAgJGJ1aWxkVGFyZ2V0IC49ICJqc2MgdGVzdGFw
aSB0ZXN0bWFzbSI7CiAgICAgfQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>326510</attachid>
            <date>2017-11-09 16:44:06 -0800</date>
            <delta_ts>2017-11-09 19:06:54 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179512-20171109184406.patch</filename>
            <type>text/plain</type>
            <size>704</size>
            <attacher name="Guillaume Emont">guijemont</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjI0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1
aWxkLWpzYyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCmluZGV4IGU0MzQ4ZjQ4NTUxOTcyMDEz
MjMxMjhmYzExMjE0YmFmNjVhODQ1N2UuLmM3MzYwYjkyM2ViZmYxODljNDc4Mzg0N2VkNDU1NWIw
NTYwZDhmMzkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisrKyBiL1Rvb2xz
L1NjcmlwdHMvYnVpbGQtanNjCkBAIC0xNDIsNyArMTQyLDcgQEAgaWYgKGlzQ01ha2VCdWlsZCgp
KSB7CiAgICAgdW5sZXNzIChpc0FueVdpbmRvd3MoKSkgewogICAgICAgICAjIEJ5IGRlZmF1bHQg
d2UgYnVpbGQgdXNpbmcgYWxsIG9mIHRoZSBhdmFpbGFibGUgQ1BVcwogICAgICAgICAkbWFrZUFy
Z3MgLj0gKCRtYWtlQXJncyA/ICIgIiA6ICIiKSAuICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAk
bWFrZUFyZ3MgIX4gLy1qXHMqXGQrLzsKLSAgICAgICAgJGJ1aWxkVGFyZ2V0ID0gImpzYyB0ZXN0
YjMgdGVzdGFpciB0ZXN0YXBpICRtYWtlQXJncyI7CisgICAgICAgICRidWlsZFRhcmdldCA9ICJq
c2MgdGVzdGIzIHRlc3RhaXIgdGVzdGFwaSB0ZXN0bWFzbSAkbWFrZUFyZ3MiOwogICAgIH0gZWxz
aWYgKGNhblVzZU5pbmphKCkpIHsKICAgICAgICAgJGJ1aWxkVGFyZ2V0IC49ICJqc2MgdGVzdGFw
aSB0ZXN0bWFzbSI7CiAgICAgfQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>326532</attachid>
            <date>2017-11-09 19:06:57 -0800</date>
            <delta_ts>2017-11-10 08:29:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-179512-20171109210656.patch</filename>
            <type>text/plain</type>
            <size>1253</size>
            <attacher name="Guillaume Emont">guijemont</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjk0MDdlMDAzODAwYTNlMTdlNDc3ZTUyYWQ1NzdmM2Rm
MDY2YmJkMy4uMzdlZjA0Y2M0YjBhMGQxNmNjMjI5ODMyZmM0YWRjZjMyNWVjYzE2NCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy
IEBACisyMDE3LTExLTA5ICBHdWlsbGF1bWUgRW1vbnQgIDxndWlqZW1vbnRAaWdhbGlhLmNvbT4K
KworICAgICAgICBidWlsZC1qc2M6IGJ1aWxkIHRlc3RtYXNtIGZvciBhbGwgcGxhdGZvcm1zIHVz
aW5nIGNtYWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xNzk1MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIFNjcmlwdHMvYnVpbGQtanNjOgorCiAyMDE3LTExLTA4ICBEb24gT2xtc3RlYWQgIDxkb24u
b2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgQWRkIFdpbmRvd3MgcG93ZXJzaGVsbCBFV1Mg
c2NyaXB0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYyBiL1Rvb2xzL1Njcmlw
dHMvYnVpbGQtanNjCmluZGV4IGU0MzQ4ZjQ4NTUxOTcyMDEzMjMxMjhmYzExMjE0YmFmNjVhODQ1
N2UuLmM3MzYwYjkyM2ViZmYxODljNDc4Mzg0N2VkNDU1NWIwNTYwZDhmMzkgMTAwNzU1Ci0tLSBh
L1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjCkBA
IC0xNDIsNyArMTQyLDcgQEAgaWYgKGlzQ01ha2VCdWlsZCgpKSB7CiAgICAgdW5sZXNzIChpc0Fu
eVdpbmRvd3MoKSkgewogICAgICAgICAjIEJ5IGRlZmF1bHQgd2UgYnVpbGQgdXNpbmcgYWxsIG9m
IHRoZSBhdmFpbGFibGUgQ1BVcwogICAgICAgICAkbWFrZUFyZ3MgLj0gKCRtYWtlQXJncyA/ICIg
IiA6ICIiKSAuICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAkbWFrZUFyZ3MgIX4gLy1qXHMqXGQr
LzsKLSAgICAgICAgJGJ1aWxkVGFyZ2V0ID0gImpzYyB0ZXN0YjMgdGVzdGFpciB0ZXN0YXBpICRt
YWtlQXJncyI7CisgICAgICAgICRidWlsZFRhcmdldCA9ICJqc2MgdGVzdGIzIHRlc3RhaXIgdGVz
dGFwaSB0ZXN0bWFzbSAkbWFrZUFyZ3MiOwogICAgIH0gZWxzaWYgKGNhblVzZU5pbmphKCkpIHsK
ICAgICAgICAgJGJ1aWxkVGFyZ2V0IC49ICJqc2MgdGVzdGFwaSB0ZXN0bWFzbSI7CiAgICAgfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>