179508 2017-11-09 15:17:07 -0800 [WinCairo] Cannot find ImageDiff executable 2017-11-15 09:43:35 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 179216 1 basuke basuke achristensen basuke bfulgham buildbot commit-queue don.olmstead glenn lforschler pvollan rniwa webkit-bug-importer oldest_to_newest 1370069 0 basuke 2017-11-09 15:17:07 -0800 Without Cygwin, it cannot find ImageDiff executable. 1370074 1 326495 basuke 2017-11-09 15:30:17 -0800 Created attachment 326495 patch 1370088 2 326495 pvollan 2017-11-09 15:56:59 -0800 Comment on attachment 326495 patch View in context: https://bugs.webkit.org/attachment.cgi?id=326495&action=review R=me. > Tools/Scripts/webkitpy/port/win.py:165 > + """Return current platform is Cygwin or not""" Perhaps change this to "Return whether current platform is Cygwin or not". 1370090 3 326501 basuke 2017-11-09 16:09:13 -0800 Created attachment 326501 fix 1370095 4 326504 basuke 2017-11-09 16:11:39 -0800 Created attachment 326504 fix reviewer 1370114 5 326504 commit-queue 2017-11-09 16:48:54 -0800 Comment on attachment 326504 fix reviewer Clearing flags on attachment: 326504 Committed r224656: <https://trac.webkit.org/changeset/224656> 1370115 6 commit-queue 2017-11-09 16:48:56 -0800 All reviewed patches have been landed. Closing bug. 1371982 7 webkit-bug-importer 2017-11-15 09:43:35 -0800 <rdar://problem/35562313> 326495 2017-11-09 15:30:17 -0800 2017-11-09 16:09:13 -0800 patch bug-179508.diff text/plain 2156 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYTIz N2VjMzNmZC4uMmRhYzc0NzE2ZDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0xMS0wOSAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBDYW5ub3Qg ZmluZCBJbWFnZURpZmYgZXhlY3V0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTc5NTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5OgorICAgICAg ICAoV2luUG9ydC5pc19jeWd3aW4pOgorICAgICAgICAoV2luUG9ydC5fcGF0aF90b19pbWFnZV9k aWZmKToKKyAgICAgICAgKFdpblBvcnQuZmluZF9zeXN0ZW1fcGlkKToKKwogMjAxNy0xMS0wNiAg Q2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29ueS5jb20+CiAKICAgICAgICAgVXNlIGVu dW0gY2xhc3NlcyB3aXRoaW4gRmlsZVN5c3RlbQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L3dpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkK aW5kZXggZGNlNzliNDcxMjYuLmFhNThiZTJhYzY4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvd2luLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93 aW4ucHkKQEAgLTE2MSw2ICsxNjEsMTAgQEAgY2xhc3MgV2luUG9ydChBcHBsZVBvcnQpOgogCiAg ICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lzdGVtLmpvaW4ocm9vdF9kaXJlY3RvcnksICpjb21w cykKIAorICAgIGRlZiBpc19jeWd3aW4oc2VsZik6CisgICAgICAgICIiIlJldHVybiBjdXJyZW50 IHBsYXRmb3JtIGlzIEN5Z3dpbiBvciBub3QiIiIKKyAgICAgICAgcmV0dXJuIHNlbGYuaG9zdC5w bGF0Zm9ybS5pc19jeWd3aW4oKQorCiAgICAgIyBOb3RlOiBUaGVzZSBhcmUgYmFzZWQgb24gdGhl IHN0b2NrIFhBTVBQIGxvY2F0aW9ucyBmb3IgdGhlc2UgZmlsZXMuCiAgICAgZGVmIF91c2VzX2Fw YWNoZShzZWxmKToKICAgICAgICAgcmV0dXJuIFRydWUKQEAgLTE4MSw2ICsxODUsMTIgQEAgY2xh c3MgV2luUG9ydChBcHBsZVBvcnQpOgogICAgIGRlZiBfcGF0aF90b19saWdodHRwZF9waHAoc2Vs Zik6CiAgICAgICAgIHJldHVybiAiL3Vzci9iaW4vcGhwLWNnaSIKIAorICAgIGRlZiBfcGF0aF90 b19pbWFnZV9kaWZmKHNlbGYpOgorICAgICAgICBpZiBzZWxmLmlzX2N5Z3dpbigpOgorICAgICAg ICAgICAgcmV0dXJuIHN1cGVyKFdpblBvcnQsIHNlbGYpLl9wYXRoX3RvX2ltYWdlX2RpZmYoKQor CisgICAgICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKCdJbWFnZURpZmYuZXhlJykKKwogICAg IGRlZiB0ZXN0X3NlYXJjaF9wYXRoKHNlbGYpOgogICAgICAgICB0ZXN0X2ZhbGxiYWNrX25hbWVz ID0gW3BhdGggZm9yIHBhdGggaW4gc2VsZi5iYXNlbGluZV9zZWFyY2hfcGF0aCgpIGlmIG5vdCBw YXRoLnN0YXJ0c3dpdGgoc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgoJ21hYycpKV0KICAgICAg ICAgcmV0dXJuIG1hcChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwgdGVzdF9mYWxsYmFja19u YW1lcykKQEAgLTQyNCw3ICs0MzQsNyBAQCBjbGFzcyBXaW5Qb3J0KEFwcGxlUG9ydCk6CiAgICAg ZGVmIGZpbmRfc3lzdGVtX3BpZChzZWxmLCBuYW1lLCBwaWQpOgogICAgICAgICBzeXN0ZW1fcGlk ID0gaW50KHBpZCkKIAotICAgICAgICBpZiBzeXMucGxhdGZvcm0gPT0gImN5Z3dpbiI6CisgICAg ICAgIGlmIHNlbGYuaXNfY3lnd2luKCk6CiAgICAgICAgICAgICAjIFdpbmRvd3MgYW5kIEN5Z3dp biBQSURzIGFyZSBub3QgdGhlIHNhbWUuICBXZSBuZWVkIHRvIGZpbmQgdGhlIFdpbmRvd3MKICAg ICAgICAgICAgICMgUElEIGZvciBvdXIgQ3lnd2luIHByb2Nlc3Mgc28gd2UgY2FuIG1hdGNoIGl0 IGxhdGVyIHRvIGFueSBjcmFzaAogICAgICAgICAgICAgIyBmaWxlcyB3ZSBlbmQgdXAgY3JlYXRp bmcgKHdoaWNoIHdpbGwgYmUgdGFnZ2VkIHdpdGggdGhlIFdpbmRvd3MgUElEKQo= 326501 2017-11-09 16:09:13 -0800 2017-11-09 16:11:39 -0800 fix bug-179508.diff text/plain 2164 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYTIz N2VjMzNmZC4uMmRhYzc0NzE2ZDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0xMS0wOSAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBDYW5ub3Qg ZmluZCBJbWFnZURpZmYgZXhlY3V0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTc5NTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5OgorICAgICAg ICAoV2luUG9ydC5pc19jeWd3aW4pOgorICAgICAgICAoV2luUG9ydC5fcGF0aF90b19pbWFnZV9k aWZmKToKKyAgICAgICAgKFdpblBvcnQuZmluZF9zeXN0ZW1fcGlkKToKKwogMjAxNy0xMS0wNiAg Q2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29ueS5jb20+CiAKICAgICAgICAgVXNlIGVu dW0gY2xhc3NlcyB3aXRoaW4gRmlsZVN5c3RlbQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L3dpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkK aW5kZXggZGNlNzliNDcxMjYuLmFhNThiZTJhYzY4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvd2luLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93 aW4ucHkKQEAgLTE2MSw2ICsxNjEsMTAgQEAgY2xhc3MgV2luUG9ydChBcHBsZVBvcnQpOgogCiAg ICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lzdGVtLmpvaW4ocm9vdF9kaXJlY3RvcnksICpjb21w cykKIAorICAgIGRlZiBpc19jeWd3aW4oc2VsZik6CisgICAgICAgICIiIlJldHVybiB3aGV0aGVy IGN1cnJlbnQgcGxhdGZvcm0gaXMgQ3lnd2luIG9yIG5vdCIiIgorICAgICAgICByZXR1cm4gc2Vs Zi5ob3N0LnBsYXRmb3JtLmlzX2N5Z3dpbigpCisKICAgICAjIE5vdGU6IFRoZXNlIGFyZSBiYXNl ZCBvbiB0aGUgc3RvY2sgWEFNUFAgbG9jYXRpb25zIGZvciB0aGVzZSBmaWxlcy4KICAgICBkZWYg X3VzZXNfYXBhY2hlKHNlbGYpOgogICAgICAgICByZXR1cm4gVHJ1ZQpAQCAtMTgxLDYgKzE4NSwx MiBAQCBjbGFzcyBXaW5Qb3J0KEFwcGxlUG9ydCk6CiAgICAgZGVmIF9wYXRoX3RvX2xpZ2h0dHBk X3BocChzZWxmKToKICAgICAgICAgcmV0dXJuICIvdXNyL2Jpbi9waHAtY2dpIgogCisgICAgZGVm IF9wYXRoX3RvX2ltYWdlX2RpZmYoc2VsZik6CisgICAgICAgIGlmIHNlbGYuaXNfY3lnd2luKCk6 CisgICAgICAgICAgICByZXR1cm4gc3VwZXIoV2luUG9ydCwgc2VsZikuX3BhdGhfdG9faW1hZ2Vf ZGlmZigpCisKKyAgICAgICAgcmV0dXJuIHNlbGYuX2J1aWxkX3BhdGgoJ0ltYWdlRGlmZi5leGUn KQorCiAgICAgZGVmIHRlc3Rfc2VhcmNoX3BhdGgoc2VsZik6CiAgICAgICAgIHRlc3RfZmFsbGJh Y2tfbmFtZXMgPSBbcGF0aCBmb3IgcGF0aCBpbiBzZWxmLmJhc2VsaW5lX3NlYXJjaF9wYXRoKCkg aWYgbm90IHBhdGguc3RhcnRzd2l0aChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCgnbWFjJykp XQogICAgICAgICByZXR1cm4gbWFwKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCB0ZXN0X2Zh bGxiYWNrX25hbWVzKQpAQCAtNDI0LDcgKzQzNCw3IEBAIGNsYXNzIFdpblBvcnQoQXBwbGVQb3J0 KToKICAgICBkZWYgZmluZF9zeXN0ZW1fcGlkKHNlbGYsIG5hbWUsIHBpZCk6CiAgICAgICAgIHN5 c3RlbV9waWQgPSBpbnQocGlkKQogCi0gICAgICAgIGlmIHN5cy5wbGF0Zm9ybSA9PSAiY3lnd2lu IjoKKyAgICAgICAgaWYgc2VsZi5pc19jeWd3aW4oKToKICAgICAgICAgICAgICMgV2luZG93cyBh bmQgQ3lnd2luIFBJRHMgYXJlIG5vdCB0aGUgc2FtZS4gIFdlIG5lZWQgdG8gZmluZCB0aGUgV2lu ZG93cwogICAgICAgICAgICAgIyBQSUQgZm9yIG91ciBDeWd3aW4gcHJvY2VzcyBzbyB3ZSBjYW4g bWF0Y2ggaXQgbGF0ZXIgdG8gYW55IGNyYXNoCiAgICAgICAgICAgICAjIGZpbGVzIHdlIGVuZCB1 cCBjcmVhdGluZyAod2hpY2ggd2lsbCBiZSB0YWdnZWQgd2l0aCB0aGUgV2luZG93cyBQSUQpCg== 326504 2017-11-09 16:11:39 -0800 2017-11-09 16:48:54 -0800 fix reviewer bug-179508.diff text/plain 2165 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYTIz N2VjMzNmZC4uMmRhYzc0NzE2ZDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0xMS0wOSAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBDYW5ub3Qg ZmluZCBJbWFnZURpZmYgZXhlY3V0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTc5NTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUGVyIEFybmUg Vm9sbGFuLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weToKKyAgICAg ICAgKFdpblBvcnQuaXNfY3lnd2luKToKKyAgICAgICAgKFdpblBvcnQuX3BhdGhfdG9faW1hZ2Vf ZGlmZik6CisgICAgICAgIChXaW5Qb3J0LmZpbmRfc3lzdGVtX3BpZCk6CisKIDIwMTctMTEtMDYg IENocmlzdG9waGVyIFJlaWQgIDxjaHJpcy5yZWlkQHNvbnkuY29tPgogCiAgICAgICAgIFVzZSBl bnVtIGNsYXNzZXMgd2l0aGluIEZpbGVTeXN0ZW0KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC93aW4ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5 CmluZGV4IGRjZTc5YjQ3MTI2Li5hYTU4YmUyYWM2OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L3dpbi5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv d2luLnB5CkBAIC0xNjEsNiArMTYxLDEwIEBAIGNsYXNzIFdpblBvcnQoQXBwbGVQb3J0KToKIAog ICAgICAgICByZXR1cm4gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHJvb3RfZGlyZWN0b3J5LCAqY29t cHMpCiAKKyAgICBkZWYgaXNfY3lnd2luKHNlbGYpOgorICAgICAgICAiIiJSZXR1cm4gd2hldGhl ciBjdXJyZW50IHBsYXRmb3JtIGlzIEN5Z3dpbiBvciBub3QiIiIKKyAgICAgICAgcmV0dXJuIHNl bGYuaG9zdC5wbGF0Zm9ybS5pc19jeWd3aW4oKQorCiAgICAgIyBOb3RlOiBUaGVzZSBhcmUgYmFz ZWQgb24gdGhlIHN0b2NrIFhBTVBQIGxvY2F0aW9ucyBmb3IgdGhlc2UgZmlsZXMuCiAgICAgZGVm IF91c2VzX2FwYWNoZShzZWxmKToKICAgICAgICAgcmV0dXJuIFRydWUKQEAgLTE4MSw2ICsxODUs MTIgQEAgY2xhc3MgV2luUG9ydChBcHBsZVBvcnQpOgogICAgIGRlZiBfcGF0aF90b19saWdodHRw ZF9waHAoc2VsZik6CiAgICAgICAgIHJldHVybiAiL3Vzci9iaW4vcGhwLWNnaSIKIAorICAgIGRl ZiBfcGF0aF90b19pbWFnZV9kaWZmKHNlbGYpOgorICAgICAgICBpZiBzZWxmLmlzX2N5Z3dpbigp OgorICAgICAgICAgICAgcmV0dXJuIHN1cGVyKFdpblBvcnQsIHNlbGYpLl9wYXRoX3RvX2ltYWdl X2RpZmYoKQorCisgICAgICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKCdJbWFnZURpZmYuZXhl JykKKwogICAgIGRlZiB0ZXN0X3NlYXJjaF9wYXRoKHNlbGYpOgogICAgICAgICB0ZXN0X2ZhbGxi YWNrX25hbWVzID0gW3BhdGggZm9yIHBhdGggaW4gc2VsZi5iYXNlbGluZV9zZWFyY2hfcGF0aCgp IGlmIG5vdCBwYXRoLnN0YXJ0c3dpdGgoc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgoJ21hYycp KV0KICAgICAgICAgcmV0dXJuIG1hcChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwgdGVzdF9m YWxsYmFja19uYW1lcykKQEAgLTQyNCw3ICs0MzQsNyBAQCBjbGFzcyBXaW5Qb3J0KEFwcGxlUG9y dCk6CiAgICAgZGVmIGZpbmRfc3lzdGVtX3BpZChzZWxmLCBuYW1lLCBwaWQpOgogICAgICAgICBz eXN0ZW1fcGlkID0gaW50KHBpZCkKIAotICAgICAgICBpZiBzeXMucGxhdGZvcm0gPT0gImN5Z3dp biI6CisgICAgICAgIGlmIHNlbGYuaXNfY3lnd2luKCk6CiAgICAgICAgICAgICAjIFdpbmRvd3Mg YW5kIEN5Z3dpbiBQSURzIGFyZSBub3QgdGhlIHNhbWUuICBXZSBuZWVkIHRvIGZpbmQgdGhlIFdp bmRvd3MKICAgICAgICAgICAgICMgUElEIGZvciBvdXIgQ3lnd2luIHByb2Nlc3Mgc28gd2UgY2Fu IG1hdGNoIGl0IGxhdGVyIHRvIGFueSBjcmFzaAogICAgICAgICAgICAgIyBmaWxlcyB3ZSBlbmQg dXAgY3JlYXRpbmcgKHdoaWNoIHdpbGwgYmUgdGFnZ2VkIHdpdGggdGhlIFdpbmRvd3MgUElEKQo=